[IAST] Add support for CallSites in functions with by ref value type arguments

daniel-romano-DD commented 3 months ago

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging[bot] commented 3 months ago

Datadog Report

Branch report: flavien/asm/iast/callsite-by-ref Commit report: 1194548 Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 58995 Passed, 168 Skipped, 49m 12.33s Total Time

andrewlock commented 3 months ago

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5745) - mean (75ms)  : 67, 83
     .   : milestone, 75,
    master - mean (73ms)  : 64, 81
     .   : milestone, 73,

    section CallTarget+Inlining+NGEN
    This PR (5745) - mean (901ms)  : 874, 928
     .   : milestone, 901,
    master - mean (896ms)  : 868, 924
     .   : milestone, 896,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5745) - mean (111ms)  : 108, 114
     .   : milestone, 111,
    master - mean (109ms)  : 106, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5745) - mean (637ms)  : 618, 656
     .   : milestone, 637,
    master - mean (632ms)  : 617, 648
     .   : milestone, 632,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5745) - mean (94ms)  : 90, 99
     .   : milestone, 94,
    master - mean (93ms)  : 89, 97
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5745) - mean (595ms)  : 579, 611
     .   : milestone, 595,
    master - mean (592ms)  : 578, 606
     .   : milestone, 592,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5745) - mean (190ms)  : 187, 193
     .   : milestone, 190,
    master - mean (191ms)  : 188, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (5745) - mean (1,002ms)  : 974, 1031
     .   : milestone, 1002,
    master - mean (1,006ms)  : 976, 1036
     .   : milestone, 1006,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5745) - mean (277ms)  : 273, 281
     .   : milestone, 277,
    master - mean (277ms)  : 272, 281
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (5745) - mean (820ms)  : 791, 849
     .   : milestone, 820,
    master - mean (817ms)  : 797, 836
     .   : milestone, 817,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5745) - mean (266ms)  : 261, 271
     .   : milestone, 266,
    master - mean (265ms)  : 261, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (5745) - mean (806ms)  : 779, 834
     .   : milestone, 806,
    master - mean (805ms)  : 778, 832
     .   : milestone, 805,

andrewlock commented 3 months ago

Benchmarks Report for appsec :snail:

Benchmarks for #5745 compared to master:

All benchmarks have the same speed
1 benchmarks have fewer allocations
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`AllCycleSimpleBody`|net6.0|72.8μs|87.1ns|337ns|0.0723| 0|0|6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`AllCycleSimpleBody`|netcoreapp3.1|62.1μs|83.6ns|313ns|0.0625| 0|0|6.95 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`AllCycleSimpleBody`|net472|47.3μs|56.9ns|221ns|1.31| 0|0|8.34 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`AllCycleMoreComplexBody`|net6.0|77.3μs|82.2ns|318ns|0.115| 0|0|9.51 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`AllCycleMoreComplexBody`|netcoreapp3.1|69.8μs|72.2ns|280ns|0.14| 0|0|10.37 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`AllCycleMoreComplexBody`|net472|53.9μs|69.3ns|259ns|1.87| 0.0271|0|11.85 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`ObjectExtractorSimpleBody`|net6.0|142ns|0.149ns|0.575ns|0.00395| 0|0|280 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`ObjectExtractorSimpleBody`|netcoreapp3.1|199ns|0.259ns|1ns|0.00371| 0|0|272 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`ObjectExtractorSimpleBody`|net472|171ns|0.143ns|0.552ns|0.0446| 0|0|281 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`ObjectExtractorMoreComplexBody`|net6.0|3.05μs|3.01ns|11.3ns|0.0532| 0|0|3.78 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`ObjectExtractorMoreComplexBody`|netcoreapp3.1|3.95μs|2.03ns|7.32ns|0.0512| 0|0|3.69 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`ObjectExtractorMoreComplexBody`|net472|3.79μs|1.69ns|6.55ns|0.603| 0.00572|0|3.8 KB| |#5745|`AllCycleSimpleBody`|net6.0|71.9μs|116ns|449ns|0.0716| 0|0|6 KB| |#5745|`AllCycleSimpleBody`|netcoreapp3.1|62.1μs|80.9ns|313ns|0.0953| 0|0|6.95 KB| |#5745|`AllCycleSimpleBody`|net472|47.2μs|45.2ns|169ns|1.31| 0|0|8.34 KB| |#5745|`AllCycleMoreComplexBody`|net6.0|76.9μs|117ns|453ns|0.116| 0|0|9.51 KB| |#5745|`AllCycleMoreComplexBody`|netcoreapp3.1|69.3μs|72.4ns|271ns|0.14| 0|0|10.37 KB| |#5745|`AllCycleMoreComplexBody`|net472|53.6μs|27.2ns|94.4ns|1.88| 0.0269|0|11.85 KB| |#5745|`ObjectExtractorSimpleBody`|net6.0|147ns|0.151ns|0.587ns|0.00396| 0|0|280 B| |#5745|`ObjectExtractorSimpleBody`|netcoreapp3.1|201ns|0.118ns|0.443ns|0.00367| 0|0|272 B| |#5745|`ObjectExtractorSimpleBody`|net472|182ns|0.181ns|0.7ns|0.0446| 0|0|281 B| |#5745|`ObjectExtractorMoreComplexBody`|net6.0|3.08μs|7.38ns|28.6ns|0.0535| 0|0|3.78 KB| |#5745|`ObjectExtractorMoreComplexBody`|netcoreapp3.1|3.88μs|1.74ns|6.49ns|0.0506| 0|0|3.69 KB| |#5745|`ObjectExtractorMoreComplexBody`|net472|3.85μs|3.46ns|13.4ns|0.602| 0.00575|0|3.8 KB|

Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`EncodeArgs`|net6.0|38.2μs|15.3ns|59.3ns|0.452| 0|0|32.4 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`EncodeArgs`|netcoreapp3.1|54.9μs|25.4ns|98.4ns|0.437| 0|0|32.4 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`EncodeArgs`|net472|67.2μs|41.5ns|155ns|5.16| 0.0679|0|32.5 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`EncodeLegacyArgs`|net6.0|72.3μs|24.5ns|95ns|0| 0|0|2.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`EncodeLegacyArgs`|netcoreapp3.1|105μs|82.6ns|320ns|0| 0|0|2.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`EncodeLegacyArgs`|net472|156μs|100ns|387ns|0.309| 0|0|2.15 KB| |#5745|`EncodeArgs`|net6.0|36.9μs|22.7ns|87.9ns|0.458| 0|0|32.4 KB| |#5745|`EncodeArgs`|netcoreapp3.1|55.2μs|22.9ns|85.5ns|0.439| 0|0|32.4 KB| |#5745|`EncodeArgs`|net472|66.8μs|37.9ns|147ns|5.16| 0.067|0|32.5 KB| |#5745|`EncodeLegacyArgs`|net6.0|74.5μs|90.2ns|325ns|0| 0|0|2.14 KB| |#5745|`EncodeLegacyArgs`|netcoreapp3.1|107μs|251ns|974ns|0| 0|0|2.14 KB| |#5745|`EncodeLegacyArgs`|net472|156μs|70.2ns|272ns|0.31| 0|0|2.15 KB|

Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`RunWafRealisticBenchmark`|net6.0|183μs|133ns|513ns|0| 0|0|2.42 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`RunWafRealisticBenchmark`|netcoreapp3.1|195μs|214ns|829ns|0| 0|0|2.37 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`RunWafRealisticBenchmark`|net472|209μs|186ns|694ns|0.313| 0|0|2.43 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`RunWafRealisticBenchmarkWithAttack`|net6.0|121μs|77.4ns|300ns|0| 0|0|1.46 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`RunWafRealisticBenchmarkWithAttack`|netcoreapp3.1|131μs|82.1ns|318ns|0| 0|0|1.45 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`RunWafRealisticBenchmarkWithAttack`|net472|140μs|24.1ns|90.2ns|0.209| 0|0|1.48 KB| |#5745|`RunWafRealisticBenchmark`|net6.0|185μs|272ns|1.05μs|0| 0|0|2.42 KB| |#5745|`RunWafRealisticBenchmark`|netcoreapp3.1|191μs|123ns|442ns|0| 0|0|2.37 KB| |#5745|`RunWafRealisticBenchmark`|net472|210μs|51.8ns|201ns|0.314| 0|0|2.43 KB| |#5745|`RunWafRealisticBenchmarkWithAttack`|net6.0|123μs|85.4ns|331ns|0| 0|0|1.46 KB| |#5745|`RunWafRealisticBenchmarkWithAttack`|netcoreapp3.1|129μs|71.6ns|277ns|0| 0|0|1.45 KB| |#5745|`RunWafRealisticBenchmarkWithAttack`|net472|142μs|33.7ns|121ns|0.213| 0|0|1.48 KB|

Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed :heavy_check_mark: More allocations :warning: #### More allocations :warning: in #5745 | Benchmark | Base Allocated | Diff Allocated | Change | Change % | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 | 253.27 KB | 255.02 KB | 1.75 KB | 0.69% #### Fewer allocations :tada: in #5745 | Benchmark | Base Allocated | Diff Allocated | Change | Change % | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 | 264.38 KB | 255.36 KB | -9.02 KB | -3.41%

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`StringConcatBenchmark`|net6.0|56.5μs|610ns|5.97μs|0| 0|0|43.44 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`StringConcatBenchmark`|netcoreapp3.1|62.3μs|810ns|8.02μs|0| 0|0|42.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`StringConcatBenchmark`|net472|37.9μs|81.2ns|293ns|0| 0|0|59.04 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`StringConcatAspectBenchmark`|net6.0|274μs|4.34μs|42.8μs|0| 0|0|253.27 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`StringConcatAspectBenchmark`|netcoreapp3.1|341μs|1.77μs|8.29μs|0| 0|0|264.38 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`StringConcatAspectBenchmark`|net472|321μs|7.57μs|74.1μs|0| 0|0|278.53 KB| |#5745|`StringConcatBenchmark`|net6.0|62μs|700ns|6.93μs|0| 0|0|43.44 KB| |#5745|`StringConcatBenchmark`|netcoreapp3.1|67.2μs|1.05μs|10.3μs|0| 0|0|42.64 KB| |#5745|`StringConcatBenchmark`|net472|38.5μs|113ns|409ns|0| 0|0|59.07 KB| |#5745|`StringConcatAspectBenchmark`|net6.0|306μs|1.66μs|12.2μs|0| 0|0|255.02 KB| |#5745|`StringConcatAspectBenchmark`|netcoreapp3.1|346μs|2.75μs|26.8μs|0| 0|0|255.36 KB| |#5745|`StringConcatAspectBenchmark`|net472|302μs|6.48μs|62.5μs|0| 0|0|277.81 KB|

andrewlock commented 3 months ago

Benchmarks Report for tracer :snail:

Benchmarks for #5745 compared to master:

2 benchmarks are faster, with geometric mean 1.140
1 benchmarks are slower, with geometric mean 1.123
1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`StartStopWithChild`|net6.0|7.63μs|41.4ns|248ns|0.0151| 0.00756|0|5.42 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`StartStopWithChild`|netcoreapp3.1|9.91μs|50.4ns|294ns|0.0247| 0.00988|0|5.62 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`StartStopWithChild`|net472|16.2μs|29.5ns|102ns|1.01| 0.301|0.0871|6.06 KB| |#5745|`StartStopWithChild`|net6.0|7.81μs|43.8ns|277ns|0.0158| 0.00394|0|5.42 KB| |#5745|`StartStopWithChild`|netcoreapp3.1|9.85μs|48.3ns|193ns|0.0152| 0.00505|0|5.62 KB| |#5745|`StartStopWithChild`|net472|16.2μs|56.1ns|217ns|1.03| 0.312|0.0961|6.06 KB|

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`WriteAndFlushEnrichedTraces`|net6.0|484μs|271ns|1.01μs|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|645μs|176ns|636ns|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`WriteAndFlushEnrichedTraces`|net472|827μs|234ns|905ns|0.411| 0|0|3.3 KB| |#5745|`WriteAndFlushEnrichedTraces`|net6.0|467μs|406ns|1.57μs|0| 0|0|2.7 KB| |#5745|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|651μs|311ns|1.21μs|0| 0|0|2.7 KB| |#5745|`WriteAndFlushEnrichedTraces`|net472|831μs|256ns|992ns|0.417| 0|0|3.3 KB|

Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`SendRequest`|net6.0|173μs|179ns|695ns|0.174| 0|0|18.44 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`SendRequest`|netcoreapp3.1|193μs|264ns|1.02μs|0.193| 0|0|20.6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`SendRequest`|net472|0.000558ns|0.000219ns|0.000819ns|0| 0|0|0 b| |#5745|`SendRequest`|net6.0|173μs|204ns|790ns|0.259| 0|0|18.44 KB| |#5745|`SendRequest`|netcoreapp3.1|191μs|336ns|1.3μs|0.191| 0|0|20.6 KB| |#5745|`SendRequest`|net472|0ns|0ns|0ns|0| 0|0|0 b|

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada: #### Fewer allocations :tada: in #5745 | Benchmark | Base Allocated | Diff Allocated | Change | Change % | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 | 41.76 KB | 41.5 KB | -257 B | -0.62%

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`WriteAndFlushEnrichedTraces`|net6.0|556μs|854ns|3.31μs|0.543| 0|0|41.76 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|657μs|650ns|2.34μs|0.324| 0|0|41.72 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`WriteAndFlushEnrichedTraces`|net472|862μs|4.41μs|20.7μs|8.39| 2.52|0.419|53.23 KB| |#5745|`WriteAndFlushEnrichedTraces`|net6.0|538μs|2.11μs|8.19μs|0.543| 0|0|41.5 KB| |#5745|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|662μs|1.18μs|4.57μs|0.329| 0|0|41.8 KB| |#5745|`WriteAndFlushEnrichedTraces`|net472|851μs|3.47μs|13.5μs|8.28| 2.48|0.414|53.25 KB|

Benchmarks.Trace.DbCommandBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #5745 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 | 1.123 | 987.85 | 1,109.51 |

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`ExecuteNonQuery`|net6.0|988ns|0.248ns|0.927ns|0.0114| 0|0|808 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`ExecuteNonQuery`|netcoreapp3.1|1.41μs|0.709ns|2.65ns|0.0106| 0|0|808 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`ExecuteNonQuery`|net472|1.78μs|3.02ns|11.7ns|0.122| 0|0|770 B| |#5745|`ExecuteNonQuery`|net6.0|1.11μs|0.233ns|0.84ns|0.0111| 0|0|808 B| |#5745|`ExecuteNonQuery`|netcoreapp3.1|1.44μs|0.732ns|2.74ns|0.0109| 0|0|808 B| |#5745|`ExecuteNonQuery`|net472|1.7μs|3.75ns|14.5ns|0.122| 0|0|770 B|

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`CallElasticsearch`|net6.0|1.19μs|1.05ns|4.06ns|0.0137| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`CallElasticsearch`|netcoreapp3.1|1.54μs|1.34ns|5.2ns|0.0133| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`CallElasticsearch`|net472|2.56μs|2.02ns|7.82ns|0.157| 0.00128|0|995 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`CallElasticsearchAsync`|net6.0|1.28μs|0.414ns|1.6ns|0.0135| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`CallElasticsearchAsync`|netcoreapp3.1|1.62μs|0.467ns|1.81ns|0.0138| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`CallElasticsearchAsync`|net472|2.63μs|1.83ns|6.83ns|0.167| 0.00132|0|1.05 KB| |#5745|`CallElasticsearch`|net6.0|1.27μs|0.485ns|1.81ns|0.0134| 0|0|976 B| |#5745|`CallElasticsearch`|netcoreapp3.1|1.51μs|0.479ns|1.79ns|0.0134| 0|0|976 B| |#5745|`CallElasticsearch`|net472|2.59μs|2.18ns|8.44ns|0.158| 0|0|995 B| |#5745|`CallElasticsearchAsync`|net6.0|1.3μs|0.385ns|1.44ns|0.0137| 0|0|952 B| |#5745|`CallElasticsearchAsync`|netcoreapp3.1|1.62μs|1.2ns|4.5ns|0.0138| 0|0|1.02 KB| |#5745|`CallElasticsearchAsync`|net472|2.66μs|1.36ns|5.26ns|0.167| 0.00131|0|1.05 KB|

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`ExecuteAsync`|net6.0|1.36μs|0.388ns|1.45ns|0.013| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`ExecuteAsync`|netcoreapp3.1|1.55μs|0.805ns|2.9ns|0.0124| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`ExecuteAsync`|net472|1.84μs|1.68ns|6.49ns|0.145| 0|0|915 B| |#5745|`ExecuteAsync`|net6.0|1.27μs|1.25ns|4.67ns|0.0134| 0|0|952 B| |#5745|`ExecuteAsync`|netcoreapp3.1|1.59μs|0.787ns|2.95ns|0.0128| 0|0|952 B| |#5745|`ExecuteAsync`|net472|1.71μs|0.853ns|3.3ns|0.145| 0|0|915 B|

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`SendAsync`|net6.0|4.35μs|1.45ns|5.43ns|0.0306| 0|0|2.22 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`SendAsync`|netcoreapp3.1|5.05μs|1.42ns|5.49ns|0.0354| 0|0|2.76 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`SendAsync`|net472|7.59μs|1.83ns|7.08ns|0.5| 0|0|3.15 KB| |#5745|`SendAsync`|net6.0|4.27μs|1.52ns|5.49ns|0.03| 0|0|2.22 KB| |#5745|`SendAsync`|netcoreapp3.1|5.19μs|2.35ns|9.12ns|0.0364| 0|0|2.76 KB| |#5745|`SendAsync`|net472|7.72μs|1.63ns|6.31ns|0.498| 0|0|3.15 KB|

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EnrichedLog`|net6.0|1.47μs|0.529ns|1.98ns|0.0226| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EnrichedLog`|netcoreapp3.1|2.18μs|1.63ns|6.3ns|0.0222| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EnrichedLog`|net472|2.57μs|1.55ns|6.02ns|0.249| 0|0|1.57 KB| |#5745|`EnrichedLog`|net6.0|1.59μs|0.629ns|2.35ns|0.023| 0|0|1.64 KB| |#5745|`EnrichedLog`|netcoreapp3.1|2.19μs|0.451ns|1.69ns|0.0219| 0|0|1.64 KB| |#5745|`EnrichedLog`|net472|2.47μs|1.48ns|5.74ns|0.249| 0|0|1.57 KB|

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EnrichedLog`|net6.0|113μs|64.3ns|232ns|0.0566| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EnrichedLog`|netcoreapp3.1|117μs|95.7ns|358ns|0| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EnrichedLog`|net472|146μs|51.1ns|184ns|0.657| 0.219|0|4.46 KB| |#5745|`EnrichedLog`|net6.0|116μs|188ns|727ns|0.0576| 0|0|4.28 KB| |#5745|`EnrichedLog`|netcoreapp3.1|118μs|89.2ns|309ns|0.0584| 0|0|4.28 KB| |#5745|`EnrichedLog`|net472|145μs|39ns|151ns|0.653| 0.218|0|4.46 KB|

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EnrichedLog`|net6.0|3.2μs|1.01ns|3.65ns|0.0306| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EnrichedLog`|netcoreapp3.1|4.11μs|1.4ns|5.23ns|0.0287| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EnrichedLog`|net472|4.88μs|2.21ns|8.54ns|0.32| 0|0|2.02 KB| |#5745|`EnrichedLog`|net6.0|3.2μs|1.03ns|3.99ns|0.0307| 0|0|2.2 KB| |#5745|`EnrichedLog`|netcoreapp3.1|4.22μs|1.74ns|6.74ns|0.0294| 0|0|2.2 KB| |#5745|`EnrichedLog`|net472|4.89μs|3.87ns|15ns|0.319| 0|0|2.02 KB|

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`SendReceive`|net6.0|1.32μs|0.769ns|2.88ns|0.0158| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`SendReceive`|netcoreapp3.1|1.8μs|1.22ns|4.73ns|0.0154| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`SendReceive`|net472|1.97μs|0.883ns|3.42ns|0.183| 0.000983|0|1.16 KB| |#5745|`SendReceive`|net6.0|1.41μs|0.52ns|1.94ns|0.0162| 0|0|1.14 KB| |#5745|`SendReceive`|netcoreapp3.1|1.79μs|2.38ns|8.92ns|0.0151| 0|0|1.14 KB| |#5745|`SendReceive`|net472|2.09μs|1.52ns|5.26ns|0.183| 0|0|1.16 KB|

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EnrichedLog`|net6.0|2.69μs|0.887ns|3.32ns|0.0215| 0|0|1.6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EnrichedLog`|netcoreapp3.1|4.07μs|1.86ns|6.96ns|0.0224| 0|0|1.65 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`EnrichedLog`|net472|4.45μs|2.99ns|11.2ns|0.324| 0|0|2.04 KB| |#5745|`EnrichedLog`|net6.0|2.89μs|1.06ns|4.11ns|0.0229| 0|0|1.6 KB| |#5745|`EnrichedLog`|netcoreapp3.1|3.86μs|3.54ns|13.7ns|0.0213| 0|0|1.65 KB| |#5745|`EnrichedLog`|net472|4.49μs|1.84ns|7.12ns|0.323| 0|0|2.04 KB|

Benchmarks.Trace.SpanBenchmark - Faster :tada: Same allocations :heavy_check_mark: #### Faster :tada: in #5745 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 | 1.162 | 550.31 | 473.52 | | Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 | 1.118 | 755.00 | 675.35 |

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`StartFinishSpan`|net6.0|397ns|0.541ns|2.1ns|0.00816| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`StartFinishSpan`|netcoreapp3.1|641ns|0.304ns|1.18ns|0.00771| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`StartFinishSpan`|net472|646ns|0.364ns|1.36ns|0.0918| 0|0|578 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`StartFinishScope`|net6.0|551ns|0.448ns|1.73ns|0.00968| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`StartFinishScope`|netcoreapp3.1|755ns|0.695ns|2.41ns|0.00932| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`StartFinishScope`|net472|797ns|0.682ns|2.64ns|0.105| 0|0|658 B| |#5745|`StartFinishSpan`|net6.0|396ns|0.124ns|0.482ns|0.00813| 0|0|576 B| |#5745|`StartFinishSpan`|netcoreapp3.1|580ns|0.574ns|2.22ns|0.00777| 0|0|576 B| |#5745|`StartFinishSpan`|net472|594ns|0.503ns|1.95ns|0.0916| 0|0|578 B| |#5745|`StartFinishScope`|net6.0|473ns|0.201ns|0.753ns|0.00984| 0|0|696 B| |#5745|`StartFinishScope`|netcoreapp3.1|675ns|0.232ns|0.899ns|0.00925| 0|0|696 B| |#5745|`StartFinishScope`|net472|810ns|0.387ns|1.45ns|0.104| 0|0|658 B|

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`RunOnMethodBegin`|net6.0|690ns|0.199ns|0.744ns|0.0097| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`RunOnMethodBegin`|netcoreapp3.1|946ns|0.382ns|1.48ns|0.00949| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5a26ca5fb95f34a9b66152633f667861a84a9be0)|`RunOnMethodBegin`|net472|1.09μs|0.668ns|2.59ns|0.104| 0|0|658 B| |#5745|`RunOnMethodBegin`|net6.0|632ns|0.152ns|0.591ns|0.00986| 0|0|696 B| |#5745|`RunOnMethodBegin`|netcoreapp3.1|887ns|1.16ns|4.5ns|0.00929| 0|0|696 B| |#5745|`RunOnMethodBegin`|net472|1.06μs|0.472ns|1.83ns|0.104| 0|0|658 B|

andrewlock commented 3 months ago

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5745) (11.861M)   : 0, 11861155
    master (11.677M)   : 0, 11677397
    benchmarks/2.9.0 (12.049M)   : 0, 12048905

    section Automatic
    This PR (5745) (8.045M)   : 0, 8045423
    master (8.003M)   : 0, 8002548
    benchmarks/2.9.0 (8.464M)   : 0, 8463997

    section Trace stats
    master (8.385M)   : 0, 8385236

    section Manual
    This PR (5745) (10.139M)   : 0, 10138831
    master (10.236M)   : 0, 10235956

    section Manual + Automatic
    This PR (5745) (7.582M)   : 0, 7581984
    master (7.643M)   : 0, 7642546

    section Version Conflict
    master (6.845M)   : 0, 6844774

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5745) (9.614M)   : 0, 9614052
    master (9.249M)   : 0, 9249240
    benchmarks/2.9.0 (9.590M)   : 0, 9590349

    section Automatic
    This PR (5745) (6.463M)   : 0, 6463252
    master (6.453M)   : 0, 6452929

    section Trace stats
    master (6.927M)   : 0, 6927474

    section Manual
    This PR (5745) (8.232M)   : 0, 8231693
    master (8.377M)   : 0, 8377082

    section Manual + Automatic
    This PR (5745) (6.123M)   : 0, 6122531
    master (6.153M)   : 0, 6152556

    section Version Conflict
    master (5.443M)   : 0, 5442500

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5745) (10.185M)   : 0, 10185352
    master (10.168M)   : 0, 10168297
    benchmarks/2.9.0 (10.465M)   : 0, 10465033

    section Automatic
    This PR (5745) (7.224M)   : 0, 7223980
    master (7.084M)   : 0, 7084082
    benchmarks/2.9.0 (7.635M)   : 0, 7635248

    section Trace stats
    master (7.631M)   : 0, 7631490

    section Manual
    This PR (5745) (8.982M)   : 0, 8981545
    master (8.759M)   : 0, 8759048

    section Manual + Automatic
    This PR (5745) (7.074M)   : 0, 7074074
    master (6.830M)   : 0, 6830341

    section Version Conflict
    master (6.324M)   : 0, 6324082

daniel-romano-DD commented 3 months ago

Superseeded by https://github.com/DataDog/dd-trace-dotnet/pull/5755

DataDog / dd-trace-dotnet