DataDog / dd-trace-dotnet

.NET Client Library for Datadog APM
https://docs.datadoghq.com/tracing/
Apache License 2.0
413 stars 132 forks source link

[Profiler] Fix profiler build warning #5751

Open gleocadie opened 4 days ago

gleocadie commented 4 days ago

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging[bot] commented 4 days ago

Datadog Report

Branch report: gleocadie/fix-linux-compilation-warning Commit report: 6e5399c Test service: dd-trace-dotnet

:x: 7 Failed (0 Known Flaky), 342385 Passed, 1890 Skipped, 15h 28m 44.61s Total Time

:x: Failed Tests (7)

This report shows up to 5 failed tests.

  • TestDirectoryListingLeak - Datadog.Trace.Security.IntegrationTests.Iast.AspNetCore5IastTestsRestartedSampleIastEnabled - Details
<details>
<summary>Expand for error</summary>

```
Unable to determine port application is listening on
```
</details>
andrewlock commented 4 days ago

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5751) - mean (74ms)  : 65, 83
     .   : milestone, 74,
    master - mean (73ms)  : 65, 82
     .   : milestone, 73,

    section CallTarget+Inlining+NGEN
    This PR (5751) - mean (897ms)  : 870, 924
     .   : milestone, 897,
    master - mean (992ms)  : 971, 1012
     .   : milestone, 992,
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5751) - mean (109ms)  : 106, 113
     .   : milestone, 109,
    master - mean (110ms)  : 106, 113
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (5751) - mean (634ms)  : 618, 650
     .   : milestone, 634,
    master - mean (706ms)  : 681, 731
     .   : milestone, 706,
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5751) - mean (93ms)  : 90, 95
     .   : milestone, 93,
    master - mean (93ms)  : 90, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5751) - mean (590ms)  : 575, 605
     .   : milestone, 590,
    master - mean (658ms)  : 634, 682
     .   : milestone, 658,
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5751) - mean (191ms)  : 188, 194
     .   : milestone, 191,
    master - mean (192ms)  : 187, 197
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (5751) - mean (1,000ms)  : 971, 1030
     .   : milestone, 1000,
    master - mean (1,090ms)  : 1061, 1118
     .   : milestone, 1090,
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5751) - mean (277ms)  : 272, 281
     .   : milestone, 277,
    master - mean (278ms)  : 273, 283
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (5751) - mean (823ms)  : 791, 856
     .   : milestone, 823,
    master - mean (878ms)  : 854, 901
     .   : milestone, 878,
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5751) - mean (266ms)  : 261, 270
     .   : milestone, 266,
    master - mean (266ms)  : 262, 270
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (5751) - mean (811ms)  : 784, 837
     .   : milestone, 811,
    master - mean (862ms)  : 838, 886
     .   : milestone, 862,
andrewlock commented 4 days ago

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5751) (11.250M)   : 0, 11250000
    master (11.521M)   : 0, 11521470
    benchmarks/2.9.0 (12.028M)   : 0, 12027804

    section Automatic
    This PR (5751) (7.812M)   : 0, 7812212
    master (7.634M)   : 0, 7633719
    benchmarks/2.9.0 (8.471M)   : 0, 8471115

    section Trace stats
    master (8.171M)   : 0, 8170678

    section Manual
    This PR (5751) (9.863M)   : 0, 9862764
    master (10.009M)   : 0, 10008600

    section Manual + Automatic
    This PR (5751) (7.506M)   : 0, 7505970
    master (7.285M)   : 0, 7285173

    section Version Conflict
    master (6.562M)   : 0, 6561604
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5751) (9.539M)   : 0, 9539257
    master (9.421M)   : 0, 9421362
    benchmarks/2.9.0 (9.556M)   : 0, 9555936

    section Automatic
    This PR (5751) (6.654M)   : 0, 6653530
    master (6.538M)   : 0, 6538499

    section Trace stats
    master (6.846M)   : 0, 6845967

    section Manual
    This PR (5751) (8.358M)   : 0, 8357605
    master (8.396M)   : 0, 8396114

    section Manual + Automatic
    This PR (5751) (6.188M)   : 0, 6188485
    master (6.262M)   : 0, 6262289

    section Version Conflict
    master (5.705M)   : 0, 5705337
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5751) (10.439M)   : 0, 10439300
    master (9.862M)   : 0, 9861889
    benchmarks/2.9.0 (9.885M)   : 0, 9885158

    section Automatic
    This PR (5751) (7.224M)   : 0, 7224322
    master (7.083M)   : 0, 7083189
    benchmarks/2.9.0 (6.977M)   : 0, 6977395

    section Trace stats
    master (7.352M)   : 0, 7351962

    section Manual
    This PR (5751) (9.136M)   : 0, 9136258
    master (8.799M)   : 0, 8799384

    section Manual + Automatic
    This PR (5751) (6.935M)   : 0, 6934878
    master (6.892M)   : 0, 6892212

    section Version Conflict
    master (6.119M)   : 0, 6118897
andrewlock commented 4 days ago

Benchmarks Report for tracer :snail:

Benchmarks for #5751 compared to master:

The following thresholds were used for comparing the benchmark speeds:

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`StartStopWithChild`|net6.0|7.71μs|43.2ns|300ns|0.0154| 0.0077|0|5.43 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`StartStopWithChild`|netcoreapp3.1|9.97μs|53.1ns|265ns|0.0145| 0.00969|0|5.62 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`StartStopWithChild`|net472|16.1μs|46.8ns|175ns|1.03| 0.325|0.0893|6.07 KB| |#5751|`StartStopWithChild`|net6.0|7.55μs|41.2ns|240ns|0.0157| 0.00783|0|5.43 KB| |#5751|`StartStopWithChild`|netcoreapp3.1|10.2μs|57.1ns|357ns|0.0196| 0.00982|0|5.62 KB| |#5751|`StartStopWithChild`|net472|16.3μs|48.1ns|180ns|1| 0.294|0.0817|6.06 KB|
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`WriteAndFlushEnrichedTraces`|net6.0|458μs|261ns|1.01μs|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|641μs|213ns|825ns|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`WriteAndFlushEnrichedTraces`|net472|818μs|164ns|590ns|0.408| 0|0|3.3 KB| |#5751|`WriteAndFlushEnrichedTraces`|net6.0|498μs|184ns|688ns|0| 0|0|2.7 KB| |#5751|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|636μs|323ns|1.25μs|0| 0|0|2.7 KB| |#5751|`WriteAndFlushEnrichedTraces`|net472|814μs|216ns|836ns|0.403| 0|0|3.3 KB|
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`SendRequest`|net6.0|172μs|167ns|646ns|0.171| 0|0|18.44 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`SendRequest`|netcoreapp3.1|194μs|258ns|967ns|0.194| 0|0|20.6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`SendRequest`|net472|3.76E‑05ns|3.76E‑05ns|0.000141ns|0| 0|0|0 b| |#5751|`SendRequest`|net6.0|170μs|262ns|1.01μs|0.171| 0|0|18.44 KB| |#5751|`SendRequest`|netcoreapp3.1|189μs|372ns|1.44μs|0.19| 0|0|20.6 KB| |#5751|`SendRequest`|net472|7.89E‑05ns|7.89E‑05ns|0.000306ns|0| 0|0|0 b|
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`WriteAndFlushEnrichedTraces`|net6.0|559μs|1.4μs|5.41μs|0.543| 0|0|41.71 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|692μs|1.48μs|5.73μs|0.34| 0|0|41.66 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`WriteAndFlushEnrichedTraces`|net472|882μs|2.21μs|8.58μs|8.17| 2.45|0.408|53.28 KB| |#5751|`WriteAndFlushEnrichedTraces`|net6.0|555μs|457ns|1.77μs|0.553| 0|0|41.8 KB| |#5751|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|654μs|1.18μs|4.59μs|0.332| 0|0|41.7 KB| |#5751|`WriteAndFlushEnrichedTraces`|net472|862μs|4.07μs|16.8μs|8.19| 2.59|0.431|53.22 KB|
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`ExecuteNonQuery`|net6.0|1.13μs|0.47ns|1.76ns|0.0113| 0|0|808 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`ExecuteNonQuery`|netcoreapp3.1|1.43μs|0.839ns|3.14ns|0.0108| 0|0|808 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`ExecuteNonQuery`|net472|1.75μs|2.38ns|9.2ns|0.122| 0|0|770 B| |#5751|`ExecuteNonQuery`|net6.0|1.04μs|0.748ns|2.9ns|0.0114| 0|0|808 B| |#5751|`ExecuteNonQuery`|netcoreapp3.1|1.51μs|1.08ns|4.19ns|0.0106| 0|0|808 B| |#5751|`ExecuteNonQuery`|net472|1.74μs|0.622ns|2.41ns|0.122| 0|0|770 B|
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`CallElasticsearch`|net6.0|1.27μs|0.91ns|3.4ns|0.0137| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`CallElasticsearch`|netcoreapp3.1|1.62μs|1.55ns|5.98ns|0.013| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`CallElasticsearch`|net472|2.68μs|2.12ns|8.2ns|0.157| 0|0|995 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`CallElasticsearchAsync`|net6.0|1.29μs|0.964ns|3.61ns|0.0129| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`CallElasticsearchAsync`|netcoreapp3.1|1.58μs|0.492ns|1.77ns|0.0141| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`CallElasticsearchAsync`|net472|2.64μs|1.33ns|5.13ns|0.166| 0|0|1.05 KB| |#5751|`CallElasticsearch`|net6.0|1.21μs|0.911ns|3.41ns|0.0133| 0|0|976 B| |#5751|`CallElasticsearch`|netcoreapp3.1|1.51μs|0.792ns|2.97ns|0.0127| 0|0|976 B| |#5751|`CallElasticsearch`|net472|2.59μs|2.06ns|7.97ns|0.157| 0|0|995 B| |#5751|`CallElasticsearchAsync`|net6.0|1.2μs|0.352ns|1.32ns|0.0132| 0|0|952 B| |#5751|`CallElasticsearchAsync`|netcoreapp3.1|1.66μs|1.28ns|4.77ns|0.0141| 0|0|1.02 KB| |#5751|`CallElasticsearchAsync`|net472|2.56μs|2.64ns|10.2ns|0.166| 0|0|1.05 KB|
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`ExecuteAsync`|net6.0|1.3μs|0.722ns|2.8ns|0.0132| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`ExecuteAsync`|netcoreapp3.1|1.66μs|1.03ns|3.86ns|0.0125| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`ExecuteAsync`|net472|1.8μs|1.34ns|5.18ns|0.145| 0|0|915 B| |#5751|`ExecuteAsync`|net6.0|1.18μs|0.303ns|1.13ns|0.0131| 0|0|952 B| |#5751|`ExecuteAsync`|netcoreapp3.1|1.59μs|2.24ns|8.66ns|0.0127| 0|0|952 B| |#5751|`ExecuteAsync`|net472|1.79μs|0.503ns|1.95ns|0.145| 0|0|915 B|
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`SendAsync`|net6.0|4.12μs|3.21ns|11.6ns|0.0308| 0|0|2.22 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`SendAsync`|netcoreapp3.1|5.17μs|2.56ns|9.92ns|0.0363| 0|0|2.76 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`SendAsync`|net472|7.69μs|2.5ns|9.03ns|0.497| 0|0|3.15 KB| |#5751|`SendAsync`|net6.0|4.31μs|1.25ns|4.68ns|0.03| 0|0|2.22 KB| |#5751|`SendAsync`|netcoreapp3.1|5.2μs|2.94ns|11.4ns|0.0364| 0|0|2.76 KB| |#5751|`SendAsync`|net472|7.67μs|1.85ns|7.18ns|0.498| 0|0|3.15 KB|
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`EnrichedLog`|net6.0|1.56μs|0.826ns|3.09ns|0.0233| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`EnrichedLog`|netcoreapp3.1|2.15μs|0.778ns|3.01ns|0.0216| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`EnrichedLog`|net472|2.44μs|1.4ns|5.44ns|0.249| 0|0|1.57 KB| |#5751|`EnrichedLog`|net6.0|1.48μs|0.604ns|2.18ns|0.023| 0|0|1.64 KB| |#5751|`EnrichedLog`|netcoreapp3.1|2.28μs|0.998ns|3.73ns|0.0228| 0|0|1.64 KB| |#5751|`EnrichedLog`|net472|2.55μs|0.92ns|3.56ns|0.249| 0|0|1.57 KB|
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`EnrichedLog`|net6.0|113μs|117ns|421ns|0.0565| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`EnrichedLog`|netcoreapp3.1|118μs|194ns|752ns|0.0585| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`EnrichedLog`|net472|147μs|116ns|420ns|0.656| 0.219|0|4.46 KB| |#5751|`EnrichedLog`|net6.0|115μs|140ns|522ns|0.0563| 0|0|4.28 KB| |#5751|`EnrichedLog`|netcoreapp3.1|120μs|105ns|406ns|0| 0|0|4.28 KB| |#5751|`EnrichedLog`|net472|146μs|84.9ns|318ns|0.656| 0.219|0|4.46 KB|
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`EnrichedLog`|net6.0|3.02μs|1.12ns|4.33ns|0.0302| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`EnrichedLog`|netcoreapp3.1|4.05μs|1.89ns|7.07ns|0.0284| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`EnrichedLog`|net472|4.85μs|2.65ns|10.3ns|0.318| 0|0|2.02 KB| |#5751|`EnrichedLog`|net6.0|3.06μs|1.36ns|5.25ns|0.03| 0|0|2.2 KB| |#5751|`EnrichedLog`|netcoreapp3.1|4.09μs|1.41ns|5.28ns|0.0286| 0|0|2.2 KB| |#5751|`EnrichedLog`|net472|4.96μs|1.71ns|6.62ns|0.321| 0|0|2.02 KB|
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`SendReceive`|net6.0|1.32μs|0.752ns|2.91ns|0.0159| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`SendReceive`|netcoreapp3.1|1.76μs|0.747ns|2.79ns|0.015| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`SendReceive`|net472|2.08μs|1.84ns|7.14ns|0.184| 0|0|1.16 KB| |#5751|`SendReceive`|net6.0|1.35μs|0.702ns|2.72ns|0.0161| 0|0|1.14 KB| |#5751|`SendReceive`|netcoreapp3.1|1.79μs|0.985ns|3.82ns|0.0148| 0|0|1.14 KB| |#5751|`SendReceive`|net472|2.07μs|0.865ns|3.12ns|0.183| 0|0|1.16 KB|
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`EnrichedLog`|net6.0|2.74μs|0.705ns|2.73ns|0.0219| 0|0|1.6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`EnrichedLog`|netcoreapp3.1|3.85μs|1.23ns|4.6ns|0.0211| 0|0|1.65 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`EnrichedLog`|net472|4.46μs|1.51ns|5.86ns|0.324| 0|0|2.04 KB| |#5751|`EnrichedLog`|net6.0|2.72μs|1.19ns|4.62ns|0.0215| 0|0|1.6 KB| |#5751|`EnrichedLog`|netcoreapp3.1|3.79μs|3.34ns|12.9ns|0.0207| 0|0|1.65 KB| |#5751|`EnrichedLog`|net472|4.47μs|1.34ns|5.03ns|0.323| 0|0|2.04 KB|
Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`StartFinishSpan`|net6.0|391ns|0.126ns|0.471ns|0.00806| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`StartFinishSpan`|netcoreapp3.1|534ns|0.393ns|1.47ns|0.0077| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`StartFinishSpan`|net472|672ns|0.528ns|1.97ns|0.0918| 0|0|578 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`StartFinishScope`|net6.0|564ns|0.314ns|1.22ns|0.00958| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`StartFinishScope`|netcoreapp3.1|687ns|3.38ns|14.7ns|0.00929| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`StartFinishScope`|net472|883ns|0.408ns|1.47ns|0.104| 0|0|658 B| |#5751|`StartFinishSpan`|net6.0|398ns|0.129ns|0.484ns|0.00801| 0|0|576 B| |#5751|`StartFinishSpan`|netcoreapp3.1|566ns|0.273ns|1.06ns|0.00791| 0|0|576 B| |#5751|`StartFinishSpan`|net472|717ns|0.474ns|1.77ns|0.0915| 0|0|578 B| |#5751|`StartFinishScope`|net6.0|547ns|0.147ns|0.57ns|0.00961| 0|0|696 B| |#5751|`StartFinishScope`|netcoreapp3.1|719ns|0.509ns|1.97ns|0.00938| 0|0|696 B| |#5751|`StartFinishScope`|net472|837ns|0.216ns|0.808ns|0.104| 0|0|658 B|
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`RunOnMethodBegin`|net6.0|619ns|2ns|7.76ns|0.00973| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`RunOnMethodBegin`|netcoreapp3.1|863ns|0.494ns|1.91ns|0.0092| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/4203f405576b5f7137c09d0add52f0d5d5c7239a)|`RunOnMethodBegin`|net472|1.08μs|0.931ns|3.36ns|0.104| 0|0|658 B| |#5751|`RunOnMethodBegin`|net6.0|592ns|0.201ns|0.753ns|0.00977| 0|0|696 B| |#5751|`RunOnMethodBegin`|netcoreapp3.1|890ns|0.255ns|0.988ns|0.00934| 0|0|696 B| |#5751|`RunOnMethodBegin`|net472|1.1μs|0.326ns|1.26ns|0.104| 0|0|658 B|