Skip flaky tests on .NET Core 2.1

andrewlock commented 2 days ago

Summary of changes

Skip flaky test on .NET Core 2.1 in more scenarios

Reason for change

The DirectoryInfo.GetDirectories() call in this CI Visibility test flakes due to a bug in the BCL on .NET Core 2.1. We already catch and ignore manifestation, this ignores another one.

Implementation details

Ignore IndexOutOfRangeException as well as NullReferenceException.

Stack trace showing the issue

``` System.IndexOutOfRangeException : Index was outside the bounds of the array. at System.IO.Enumeration.FileSystemEnumerator`1.MoveNext() at System.Collections.Generic.LargeArrayBuilder`1.AddRange(IEnumerable`1 items) at System.Collections.Generic.EnumerableHelpers.ToArray[T](IEnumerable`1 source) at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source) at System.IO.DirectoryInfo.GetDirectories(String searchPattern, EnumerationOptions enumerationOptions) at System.IO.DirectoryInfo.GetDirectories() at ICSharpCode.Decompiler.Metadata.DotNetCorePathFinder.GetClosestVersionFolder(String basePath, Version version) at ICSharpCode.Decompiler.Metadata.DotNetCorePathFinder.TryResolveDotNetCoreShared(IAssemblyReference name, String& runtimePack) at ICSharpCode.Decompiler.Metadata.DotNetCorePathFinder.TryResolveDotNetCore(IAssemblyReference name) at ICSharpCode.Decompiler.Metadata.UniversalAssemblyResolver.FindAssemblyFile(IAssemblyReference name) at ICSharpCode.Decompiler.Metadata.UniversalAssemblyResolver.Resolve(IAssemblyReference name) at System.Threading.Tasks.Task`1.InnerInvoke() at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) --- End of stack trace from previous location where exception was thrown --- at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot) --- End of stack trace from previous location where exception was thrown --- at ICSharpCode.Decompiler.TypeSystem.DecompilerTypeSystem..ctor(PEFile mainModule, IAssemblyResolver assemblyResolver, TypeSystemOptions typeSystemOptions) at ICSharpCode.Decompiler.CSharp.CSharpDecompiler.CreateTypeSystemFromFile(String fileName, DecompilerSettings settings) at Datadog.Trace.Tools.Runner.Tests.CoverageRewriteTests.NoFilter(String coverageMode) in D:\a\1\s\tracer\test\Datadog.Trace.Tools.Runner.Tests\CoverageRewriteTests.cs:line 140 ```

Test coverage

N/A

Other details

datadog-ddstaging[bot] commented 2 days ago

Datadog Report

Branch report: andrew/ci/fix-flaky-test Commit report: 118f832 Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 342872 Passed, 1630 Skipped, 15h 54m 8.49s Total Time :snowflake: 4 New Flaky :hourglass: 1 Performance Regression

New Flaky Tests (4)

NoExceptions - Datadog.Trace.ClrProfiler.IntegrationTests.SmokeTests.AssemblyResolveMscorlibResourcesInfiniteRecursionCrashSmokeTest - Last Failure

Expand for error
``` Expected no errors in smoke test: ptrace(ATTACH, 15284) FAILED No such process Expected: True Actual: False ```
TestSecurity - Datadog.Trace.Security.IntegrationTests.AspNetCore5ExternalRules - Last Failure

Expand for error
``` Unable to determine port application is listening on ```
TestCustomRules - Datadog.Trace.Security.IntegrationTests.Rcm.AspNetCore5AsmCustomRules - Last Failure

Expand for error
``` Unable to determine port application is listening on ```
RunTest - Datadog.Trace.Security.IntegrationTests.Rcm.AspNetCore5AsmDataSecurityEnabledBlockingRequestIp - Last Failure

Expand for error
``` Unable to determine port application is listening on ```

:hourglass: Performance Regressions vs Default Branch (1)

ExecuteNonQuery - Benchmarks.Trace.DbCommandBenchmark 1.73µs (+236ns, +16%) - Details

andrewlock commented 2 days ago

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5753) - mean (73ms)  : 63, 83
     .   : milestone, 73,
    master - mean (74ms)  : 63, 85
     .   : milestone, 74,

    section CallTarget+Inlining+NGEN
    This PR (5753) - mean (901ms)  : 877, 925
     .   : milestone, 901,
    master - mean (897ms)  : 875, 918
     .   : milestone, 897,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5753) - mean (109ms)  : 106, 112
     .   : milestone, 109,
    master - mean (109ms)  : 106, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5753) - mean (635ms)  : 619, 651
     .   : milestone, 635,
    master - mean (633ms)  : 618, 648
     .   : milestone, 633,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5753) - mean (92ms)  : 90, 95
     .   : milestone, 92,
    master - mean (93ms)  : 88, 98
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5753) - mean (594ms)  : 578, 610
     .   : milestone, 594,
    master - mean (590ms)  : 576, 604
     .   : milestone, 590,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5753) - mean (191ms)  : 188, 194
     .   : milestone, 191,
    master - mean (190ms)  : 188, 193
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (5753) - mean (1,011ms)  : 967, 1055
     .   : milestone, 1011,
    master - mean (999ms)  : 974, 1024
     .   : milestone, 999,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5753) - mean (277ms)  : 272, 282
     .   : milestone, 277,
    master - mean (275ms)  : 271, 279
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (5753) - mean (822ms)  : 796, 849
     .   : milestone, 822,
    master - mean (819ms)  : 788, 850
     .   : milestone, 819,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5753) - mean (265ms)  : 261, 269
     .   : milestone, 265,
    master - mean (264ms)  : 259, 270
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (5753) - mean (802ms)  : 773, 830
     .   : milestone, 802,
    master - mean (806ms)  : 771, 841
     .   : milestone, 806,

andrewlock commented 1 day ago

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5753) (11.919M)   : 0, 11918603
    master (11.677M)   : 0, 11677397
    benchmarks/2.9.0 (12.049M)   : 0, 12048905

    section Automatic
    This PR (5753) (8.049M)   : 0, 8048664
    master (8.003M)   : 0, 8002548
    benchmarks/2.9.0 (8.464M)   : 0, 8463997

    section Trace stats
    master (8.385M)   : 0, 8385236

    section Manual
    This PR (5753) (10.393M)   : 0, 10393378
    master (10.236M)   : 0, 10235956

    section Manual + Automatic
    This PR (5753) (7.567M)   : 0, 7567320
    master (7.643M)   : 0, 7642546

    section Version Conflict
    master (6.845M)   : 0, 6844774

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5753) (9.396M)   : 0, 9396084
    master (9.249M)   : 0, 9249240
    benchmarks/2.9.0 (9.590M)   : 0, 9590349

    section Automatic
    This PR (5753) (6.428M)   : 0, 6428102
    master (6.453M)   : 0, 6452929

    section Trace stats
    master (6.927M)   : 0, 6927474

    section Manual
    This PR (5753) (8.260M)   : 0, 8260425
    master (8.377M)   : 0, 8377082

    section Manual + Automatic
    This PR (5753) (6.174M)   : 0, 6173951
    master (6.153M)   : 0, 6152556

    section Version Conflict
    master (5.443M)   : 0, 5442500

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5753) (10.304M)   : 0, 10304264
    master (10.168M)   : 0, 10168297
    benchmarks/2.9.0 (10.465M)   : 0, 10465033

    section Automatic
    This PR (5753) (7.108M)   : 0, 7107961
    master (7.084M)   : 0, 7084082
    benchmarks/2.9.0 (7.635M)   : 0, 7635248

    section Trace stats
    master (7.631M)   : 0, 7631490

    section Manual
    This PR (5753) (8.781M)   : 0, 8781368
    master (8.759M)   : 0, 8759048

    section Manual + Automatic
    This PR (5753) (6.806M)   : 0, 6806166
    master (6.830M)   : 0, 6830341

    section Version Conflict
    master (6.324M)   : 0, 6324082

andrewlock commented 1 day ago

Benchmarks Report for tracer :snail:

Benchmarks for #5753 compared to master:

3 benchmarks are faster, with geometric mean 1.123
1 benchmarks are slower, with geometric mean 1.143
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`StartStopWithChild`|net6.0|7.74μs|44.7ns|352ns|0.0183| 0.00733|0|5.43 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`StartStopWithChild`|netcoreapp3.1|9.89μs|55.2ns|366ns|0.0189| 0.00944|0|5.62 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`StartStopWithChild`|net472|16μs|44.1ns|171ns|1.02| 0.297|0.102|6.07 KB| |#5753|`StartStopWithChild`|net6.0|7.7μs|44.3ns|331ns|0.0264| 0.0113|0|5.42 KB| |#5753|`StartStopWithChild`|netcoreapp3.1|9.95μs|52.8ns|284ns|0.0194| 0.00972|0|5.62 KB| |#5753|`StartStopWithChild`|net472|16.1μs|65.2ns|252ns|1.03| 0.319|0.104|6.08 KB|

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`WriteAndFlushEnrichedTraces`|net6.0|481μs|265ns|991ns|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|627μs|121ns|436ns|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`WriteAndFlushEnrichedTraces`|net472|822μs|321ns|1.24μs|0.411| 0|0|3.3 KB| |#5753|`WriteAndFlushEnrichedTraces`|net6.0|487μs|378ns|1.42μs|0| 0|0|2.7 KB| |#5753|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|629μs|126ns|456ns|0| 0|0|2.7 KB| |#5753|`WriteAndFlushEnrichedTraces`|net472|836μs|312ns|1.17μs|0.414| 0|0|3.3 KB|

Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`SendRequest`|net6.0|171μs|262ns|1.01μs|0.253| 0|0|18.45 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`SendRequest`|netcoreapp3.1|191μs|388ns|1.5μs|0.192| 0|0|20.61 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`SendRequest`|net472|4.1E‑05ns|4.1E‑05ns|0.000153ns|0| 0|0|0 b| |#5753|`SendRequest`|net6.0|173μs|313ns|1.17μs|0.257| 0|0|18.45 KB| |#5753|`SendRequest`|netcoreapp3.1|194μs|196ns|757ns|0.193| 0|0|20.61 KB| |#5753|`SendRequest`|net472|0ns|0ns|0ns|0| 0|0|0 b|

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`WriteAndFlushEnrichedTraces`|net6.0|562μs|639ns|2.48μs|0.548| 0|0|41.76 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|672μs|1.79μs|6.92μs|0.336| 0|0|41.59 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`WriteAndFlushEnrichedTraces`|net472|857μs|3.98μs|15.4μs|8.62| 2.59|0.431|53.23 KB| |#5753|`WriteAndFlushEnrichedTraces`|net6.0|559μs|575ns|2.23μs|0.551| 0|0|41.55 KB| |#5753|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|662μs|1.08μs|4.18μs|0.329| 0|0|41.74 KB| |#5753|`WriteAndFlushEnrichedTraces`|net472|854μs|3.77μs|14.6μs|8.33| 2.5|0.417|53.27 KB|

Benchmarks.Trace.DbCommandBenchmark - Faster :tada: Same allocations :heavy_check_mark: #### Faster :tada: in #5753 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 | 1.130 | 1,312.24 | 1,161.74 |

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`ExecuteNonQuery`|net6.0|1.31μs|0.84ns|3.25ns|0.0144| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`ExecuteNonQuery`|netcoreapp3.1|1.62μs|0.397ns|1.54ns|0.0139| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`ExecuteNonQuery`|net472|1.92μs|0.357ns|1.34ns|0.156| 0|0|987 B| |#5753|`ExecuteNonQuery`|net6.0|1.16μs|0.468ns|1.81ns|0.014| 0|0|1.02 KB| |#5753|`ExecuteNonQuery`|netcoreapp3.1|1.73μs|1.2ns|4.65ns|0.0138| 0|0|1.02 KB| |#5753|`ExecuteNonQuery`|net472|1.92μs|0.407ns|1.47ns|0.157| 0|0|987 B|

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`CallElasticsearch`|net6.0|1.18μs|0.736ns|2.75ns|0.0136| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`CallElasticsearch`|netcoreapp3.1|1.49μs|0.882ns|3.42ns|0.0127| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`CallElasticsearch`|net472|2.63μs|3.04ns|11.8ns|0.158| 0|0|995 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`CallElasticsearchAsync`|net6.0|1.24μs|1.22ns|4.23ns|0.013| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`CallElasticsearchAsync`|netcoreapp3.1|1.65μs|0.751ns|2.81ns|0.0138| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`CallElasticsearchAsync`|net472|2.71μs|1.05ns|4.06ns|0.167| 0|0|1.05 KB| |#5753|`CallElasticsearch`|net6.0|1.27μs|0.868ns|3.36ns|0.0134| 0|0|976 B| |#5753|`CallElasticsearch`|netcoreapp3.1|1.49μs|1.11ns|4.29ns|0.0133| 0|0|976 B| |#5753|`CallElasticsearch`|net472|2.64μs|1.5ns|5.82ns|0.158| 0|0|995 B| |#5753|`CallElasticsearchAsync`|net6.0|1.34μs|0.931ns|3.49ns|0.0133| 0|0|952 B| |#5753|`CallElasticsearchAsync`|netcoreapp3.1|1.7μs|0.688ns|2.58ns|0.0137| 0|0|1.02 KB| |#5753|`CallElasticsearchAsync`|net472|2.65μs|12.7ns|52.3ns|0.166| 0|0|1.05 KB|

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`ExecuteAsync`|net6.0|1.26μs|0.491ns|1.9ns|0.0134| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`ExecuteAsync`|netcoreapp3.1|1.64μs|0.391ns|1.46ns|0.0124| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`ExecuteAsync`|net472|1.75μs|0.977ns|3.78ns|0.145| 0|0|915 B| |#5753|`ExecuteAsync`|net6.0|1.33μs|0.514ns|1.99ns|0.0133| 0|0|952 B| |#5753|`ExecuteAsync`|netcoreapp3.1|1.61μs|1.13ns|4.21ns|0.0128| 0|0|952 B| |#5753|`ExecuteAsync`|net472|1.72μs|1.17ns|4.53ns|0.145| 0|0|915 B|

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`SendAsync`|net6.0|4.04μs|1.47ns|5.5ns|0.0322| 0|0|2.22 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`SendAsync`|netcoreapp3.1|4.99μs|1.32ns|4.94ns|0.0373| 0|0|2.76 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`SendAsync`|net472|7.71μs|7.16ns|27.7ns|0.498| 0|0|3.15 KB| |#5753|`SendAsync`|net6.0|4.22μs|2.54ns|9.51ns|0.0315| 0|0|2.22 KB| |#5753|`SendAsync`|netcoreapp3.1|5.17μs|1.92ns|7.19ns|0.0364| 0|0|2.76 KB| |#5753|`SendAsync`|net472|7.58μs|1.81ns|7.02ns|0.497| 0|0|3.15 KB|

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`EnrichedLog`|net6.0|1.51μs|0.575ns|2.15ns|0.0233| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`EnrichedLog`|netcoreapp3.1|2.14μs|3.49ns|13.5ns|0.0222| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`EnrichedLog`|net472|2.62μs|0.814ns|2.82ns|0.25| 0|0|1.57 KB| |#5753|`EnrichedLog`|net6.0|1.44μs|0.427ns|1.6ns|0.023| 0|0|1.64 KB| |#5753|`EnrichedLog`|netcoreapp3.1|2.14μs|1.36ns|5.26ns|0.0224| 0|0|1.64 KB| |#5753|`EnrichedLog`|net472|2.66μs|1.29ns|4.84ns|0.249| 0|0|1.57 KB|

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`EnrichedLog`|net6.0|114μs|105ns|408ns|0| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`EnrichedLog`|netcoreapp3.1|120μs|172ns|668ns|0| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`EnrichedLog`|net472|148μs|150ns|581ns|0.67| 0.223|0|4.46 KB| |#5753|`EnrichedLog`|net6.0|112μs|99.6ns|386ns|0.056| 0|0|4.28 KB| |#5753|`EnrichedLog`|netcoreapp3.1|119μs|220ns|853ns|0| 0|0|4.28 KB| |#5753|`EnrichedLog`|net472|146μs|45.2ns|157ns|0.662| 0.221|0|4.46 KB|

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`EnrichedLog`|net6.0|3.03μs|0.671ns|2.51ns|0.0302| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`EnrichedLog`|netcoreapp3.1|4.09μs|1.61ns|5.8ns|0.0286| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`EnrichedLog`|net472|4.94μs|2.15ns|8.34ns|0.319| 0|0|2.02 KB| |#5753|`EnrichedLog`|net6.0|3.09μs|0.904ns|3.38ns|0.0309| 0|0|2.2 KB| |#5753|`EnrichedLog`|netcoreapp3.1|4.37μs|1.86ns|7.2ns|0.0284| 0|0|2.2 KB| |#5753|`EnrichedLog`|net472|4.81μs|1.61ns|6.23ns|0.32| 0|0|2.02 KB|

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`SendReceive`|net6.0|1.36μs|0.85ns|3.29ns|0.0156| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`SendReceive`|netcoreapp3.1|1.69μs|1.18ns|4.58ns|0.0153| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`SendReceive`|net472|2.08μs|1.08ns|3.88ns|0.183| 0|0|1.16 KB| |#5753|`SendReceive`|net6.0|1.28μs|0.563ns|2.18ns|0.0159| 0|0|1.14 KB| |#5753|`SendReceive`|netcoreapp3.1|1.81μs|1.03ns|3.98ns|0.0155| 0|0|1.14 KB| |#5753|`SendReceive`|net472|2.01μs|1.36ns|5.08ns|0.183| 0|0|1.16 KB|

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`EnrichedLog`|net6.0|2.79μs|1.27ns|4.93ns|0.0222| 0|0|1.6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`EnrichedLog`|netcoreapp3.1|3.87μs|2.27ns|8.81ns|0.0211| 0|0|1.65 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`EnrichedLog`|net472|4.59μs|8.13ns|31.5ns|0.323| 0|0|2.04 KB| |#5753|`EnrichedLog`|net6.0|2.72μs|0.733ns|2.84ns|0.0217| 0|0|1.6 KB| |#5753|`EnrichedLog`|netcoreapp3.1|3.81μs|1.42ns|5.32ns|0.0212| 0|0|1.65 KB| |#5753|`EnrichedLog`|net472|4.39μs|2.18ns|8.44ns|0.322| 0|0|2.04 KB|

Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #5753 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 | 1.143 | 584.75 | 668.44 | #### Faster :tada: in #5753 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 | 1.120 | 623.28 | 556.35 |

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`StartFinishSpan`|net6.0|384ns|0.201ns|0.779ns|0.00815| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`StartFinishSpan`|netcoreapp3.1|623ns|0.27ns|1.05ns|0.00773| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`StartFinishSpan`|net472|585ns|0.591ns|2.29ns|0.0917| 0|0|578 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`StartFinishScope`|net6.0|605ns|0.246ns|0.952ns|0.00968| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`StartFinishScope`|netcoreapp3.1|760ns|0.383ns|1.48ns|0.0095| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`StartFinishScope`|net472|825ns|0.708ns|2.74ns|0.104| 0|0|658 B| |#5753|`StartFinishSpan`|net6.0|400ns|0.401ns|1.55ns|0.00804| 0|0|576 B| |#5753|`StartFinishSpan`|netcoreapp3.1|556ns|0.312ns|1.21ns|0.00777| 0|0|576 B| |#5753|`StartFinishSpan`|net472|669ns|1.25ns|4.85ns|0.0915| 0|0|578 B| |#5753|`StartFinishScope`|net6.0|558ns|0.204ns|0.789ns|0.00976| 0|0|696 B| |#5753|`StartFinishScope`|netcoreapp3.1|685ns|0.365ns|1.41ns|0.00936| 0|0|696 B| |#5753|`StartFinishScope`|net472|786ns|0.393ns|1.42ns|0.104| 0|0|658 B|

Benchmarks.Trace.TraceAnnotationsBenchmark - Faster :tada: Same allocations :heavy_check_mark: #### Faster :tada: in #5753 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.118 | 663.03 | 592.95 |

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`RunOnMethodBegin`|net6.0|663ns|0.352ns|1.36ns|0.00986| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`RunOnMethodBegin`|netcoreapp3.1|872ns|0.496ns|1.86ns|0.0096| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/3f330720d3dc3bec87156d0fcf12e8e1ca9b8652)|`RunOnMethodBegin`|net472|1.1μs|0.531ns|2.06ns|0.104| 0|0|658 B| |#5753|`RunOnMethodBegin`|net6.0|592ns|0.453ns|1.76ns|0.00983| 0|0|696 B| |#5753|`RunOnMethodBegin`|netcoreapp3.1|962ns|0.531ns|2.06ns|0.00915| 0|0|696 B| |#5753|`RunOnMethodBegin`|net472|1.06μs|0.726ns|2.81ns|0.104| 0|0|658 B|

DataDog / dd-trace-dotnet