Open andrewlock opened 3 months ago
Execution-time results for samples comparing the following branches/commits:
Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.
Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).
gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5754) - mean (70ms) : 68, 73
. : milestone, 70,
master - mean (70ms) : 67, 74
. : milestone, 70,
section CallTarget+Inlining+NGEN
This PR (5754) - mean (1,105ms) : 1085, 1125
. : milestone, 1105,
master - mean (1,107ms) : 1086, 1128
. : milestone, 1107,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5754) - mean (110ms) : 106, 114
. : milestone, 110,
master - mean (110ms) : 107, 113
. : milestone, 110,
section CallTarget+Inlining+NGEN
This PR (5754) - mean (774ms) : 754, 793
. : milestone, 774,
master - mean (774ms) : 759, 790
. : milestone, 774,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5754) - mean (94ms) : 90, 98
. : milestone, 94,
master - mean (93ms) : 89, 96
. : milestone, 93,
section CallTarget+Inlining+NGEN
This PR (5754) - mean (729ms) : 713, 745
. : milestone, 729,
master - mean (730ms) : 712, 747
. : milestone, 730,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5754) - mean (233ms) : 222, 245
. : milestone, 233,
master - mean (190ms) : 187, 193
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (5754) - mean (1,226ms) : 1176, 1276
. : milestone, 1226,
master - mean (1,198ms) : 1174, 1223
. : milestone, 1198,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5754) - mean (278ms) : 272, 284
. : milestone, 278,
master - mean (276ms) : 272, 280
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (5754) - mean (940ms) : 924, 957
. : milestone, 940,
master - mean (940ms) : 922, 958
. : milestone, 940,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5754) - mean (264ms) : 259, 269
. : milestone, 264,
master - mean (265ms) : 261, 269
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (5754) - mean (921ms) : 899, 943
. : milestone, 921,
master - mean (927ms) : 909, 944
. : milestone, 927,
Throughput results for AspNetCoreSimpleController comparing the following branches/commits:
Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.
Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!
gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5754) (11.079M) : 0, 11078502
master (11.214M) : 0, 11213559
benchmarks/2.9.0 (11.081M) : 0, 11080577
section Automatic
This PR (5754) (7.343M) : 0, 7343217
master (7.414M) : 0, 7414388
benchmarks/2.9.0 (7.732M) : 0, 7732233
section Trace stats
master (7.737M) : 0, 7737460
section Manual
master (11.115M) : 0, 11114877
section Manual + Automatic
This PR (5754) (6.867M) : 0, 6866852
master (6.964M) : 0, 6963791
section DD_TRACE_ENABLED=0
master (10.268M) : 0, 10267825
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5754) (9.495M) : 0, 9495139
master (9.609M) : 0, 9608747
benchmarks/2.9.0 (9.798M) : 0, 9798067
section Automatic
This PR (5754) (6.571M) : 0, 6570532
master (6.616M) : 0, 6616057
section Trace stats
master (6.832M) : 0, 6832011
section Manual
master (9.547M) : 0, 9547071
section Manual + Automatic
This PR (5754) (6.145M) : 0, 6144629
master (6.118M) : 0, 6117867
section DD_TRACE_ENABLED=0
master (9.018M) : 0, 9018069
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5754) (10.034M) : 0, 10034298
master (10.124M) : 0, 10123739
benchmarks/2.9.0 (10.067M) : 0, 10067315
section Automatic
This PR (5754) (6.756M) : 0, 6756003
master (6.654M) : 0, 6653810
benchmarks/2.9.0 (7.552M) : 0, 7552193
section Trace stats
master (7.417M) : 0, 7416762
section Manual
master (9.870M) : 0, 9869748
section Manual + Automatic
This PR (5754) (6.201M) : 0, 6200617
master (6.325M) : 0, 6325090
section DD_TRACE_ENABLED=0
master (9.274M) : 0, 9273906
Branch report: andrew/ci/run-calltarget-native-tests-on-windows
Commit report: 0bf98de
Test service: dd-trace-dotnet
:white_check_mark: 0 Failed, 362802 Passed, 2047 Skipped, 16h 1m 24.96s Total Time
Benchmarks for #5754 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored.
Summary of changes
Runs the
CallTargetNativeTests
on WindowsReason for change
We weren't running these on Windows, and we should be
Implementation details
Add the
RunOnWindows
trait. Longer term I want to reverse the role of this trait, i.e. we run on windows by default and you addRunOnWindows=False
to disable that.Test coverage
More now
Other details
I thought we had a bug related to ref structs here, but it appears to be a Schrödinger's bugOops, no, there it is!