search

DataDog / dd-trace-dotnet

.NET Client Library for Datadog APM
https://docs.datadoghq.com/tracing/
Apache License 2.0
456 stars 142 forks source link

Fix signature size check in ModifyLocalSig #5921

Closed kevingosse closed 2 months ago

kevingosse commented 3 months ago

Summary of changes

Fix signature size check in ModifyLocalSig.

Reason for change

Detected by static analysis.

Implementation details

Because originalSignatureSize and len are unsigned, their subtraction is unsigned and thus can't be negative.

datadog-ddstaging[bot] commented 3 months ago

Datadog Report

Branch report: kevin/unsigned Commit report: c662cc2 Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 356383 Passed, 2267 Skipped, 23h 16m 37.93s Total Time

andrewlock commented 3 months ago

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).