[serverless] No-op AWS Lambda integration on missing API Key (#5900 - v2)

andrewlock commented 1 month ago

Summary of changes

Verifies that an API key is set in order to call the Lambda Extension.

Reason for change

It would not crash the customers, but it logs errors that should be avoided and handled better by not doing the operation.

Implementation details

Just created an API key getter in order to then check if the API is missing.

Test coverage

Tested manually on AWS Lambda.

Other details

Backport of #5900

andrewlock commented 1 month ago

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5935) - mean (74ms)  : 64, 84
     .   : milestone, 74,

    section CallTarget+Inlining+NGEN
    This PR (5935) - mean (1,037ms)  : 1016, 1058
     .   : milestone, 1037,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5935) - mean (111ms)  : 107, 115
     .   : milestone, 111,

    section CallTarget+Inlining+NGEN
    This PR (5935) - mean (717ms)  : 699, 736
     .   : milestone, 717,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5935) - mean (94ms)  : 91, 97
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (5935) - mean (670ms)  : 653, 687
     .   : milestone, 670,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5935) - mean (191ms)  : 186, 197
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (5935) - mean (1,113ms)  : 1091, 1135
     .   : milestone, 1113,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5935) - mean (278ms)  : 271, 285
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (5935) - mean (881ms)  : 858, 905
     .   : milestone, 881,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5935) - mean (265ms)  : 260, 270
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (5935) - mean (859ms)  : 838, 880
     .   : milestone, 859,

datadog-ddstaging[bot] commented 1 month ago

Datadog Report

Branch report: jordan.gonzalez/SLES-1806/aws/no-op-on-missing-api-key-v2 Commit report: 4e664ab Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 14492 Passed, 47 Skipped, 49m 5.5s Total Time

duncanista commented 1 month ago

Closing due to #5941

andrewlock commented 1 month ago

Benchmarks Report for tracer :snail:

Benchmarks for #5935 compared to master:

2 benchmarks are faster, with geometric mean 1.160
1 benchmarks are slower, with geometric mean 1.171
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`StartStopWithChild`|net6.0|7.98μs|45ns|305ns|0.0188| 0.0075|0|5.43 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`StartStopWithChild`|netcoreapp3.1|9.93μs|56ns|376ns|0.0297| 0.0149|0|5.62 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`StartStopWithChild`|net472|15.8μs|55.7ns|216ns|1.02| 0.306|0.0943|6.06 KB| |#5935|`StartStopWithChild`|net6.0|7.79μs|44.1ns|318ns|0.0148| 0.00738|0|5.43 KB| |#5935|`StartStopWithChild`|netcoreapp3.1|9.93μs|53.4ns|312ns|0.0144| 0.00481|0|5.61 KB| |#5935|`StartStopWithChild`|net472|16μs|39.2ns|152ns|1.03| 0.31|0.103|6.07 KB|

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`WriteAndFlushEnrichedTraces`|net6.0|459μs|209ns|809ns|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|635μs|426ns|1.59μs|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`WriteAndFlushEnrichedTraces`|net472|845μs|532ns|1.99μs|0.422| 0|0|3.3 KB| |#5935|`WriteAndFlushEnrichedTraces`|net6.0|470μs|463ns|1.79μs|0| 0|0|2.7 KB| |#5935|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|635μs|212ns|792ns|0| 0|0|2.7 KB| |#5935|`WriteAndFlushEnrichedTraces`|net472|843μs|590ns|2.29μs|0.422| 0|0|3.29 KB|

Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`SendRequest`|net6.0|192μs|1.07μs|7.01μs|0.198| 0|0|18.45 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`SendRequest`|netcoreapp3.1|214μs|1.22μs|9.35μs|0.211| 0|0|20.61 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`SendRequest`|net472|0.000893ns|0.000468ns|0.00175ns|0| 0|0|0 b| |#5935|`SendRequest`|net6.0|190μs|1.08μs|7.97μs|0.196| 0|0|18.45 KB| |#5935|`SendRequest`|netcoreapp3.1|213μs|1.19μs|8.1μs|0.229| 0|0|20.61 KB| |#5935|`SendRequest`|net472|0.00101ns|0.00034ns|0.00127ns|0| 0|0|0 b|

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: More allocations :warning: #### More allocations :warning: in #5935 | Benchmark | Base Allocated | Diff Allocated | Change | Change % | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 | 41.42 KB | 41.73 KB | 303 B | 0.73%

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`WriteAndFlushEnrichedTraces`|net6.0|573μs|989ns|3.57μs|0.536| 0|0|41.76 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|731μs|3.79μs|19.3μs|0.368| 0|0|41.42 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`WriteAndFlushEnrichedTraces`|net472|880μs|3.72μs|14.4μs|8.8| 2.64|0.44|53.34 KB| |#5935|`WriteAndFlushEnrichedTraces`|net6.0|563μs|2.13μs|8.24μs|0.573| 0|0|41.6 KB| |#5935|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|672μs|3.18μs|15.6μs|0.338| 0|0|41.73 KB| |#5935|`WriteAndFlushEnrichedTraces`|net472|905μs|4.18μs|15.6μs|8.15| 2.26|0.453|53.29 KB|

Benchmarks.Trace.DbCommandBenchmark - Faster :tada: Same allocations :heavy_check_mark: #### Faster :tada: in #5935 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 | 1.171 | 1,393.67 | 1,190.63 |

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`ExecuteNonQuery`|net6.0|1.39μs|0.903ns|3.5ns|0.0139| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`ExecuteNonQuery`|netcoreapp3.1|1.74μs|1.3ns|5.03ns|0.014| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`ExecuteNonQuery`|net472|2.07μs|2.93ns|11.4ns|0.156| 0|0|987 B| |#5935|`ExecuteNonQuery`|net6.0|1.19μs|0.651ns|2.44ns|0.0144| 0|0|1.02 KB| |#5935|`ExecuteNonQuery`|netcoreapp3.1|1.72μs|1.05ns|3.92ns|0.0136| 0|0|1.02 KB| |#5935|`ExecuteNonQuery`|net472|2.04μs|2.23ns|8.34ns|0.157| 0|0|987 B|

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`CallElasticsearch`|net6.0|1.22μs|1.52ns|5.7ns|0.0138| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`CallElasticsearch`|netcoreapp3.1|1.61μs|3.11ns|12.1ns|0.0131| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`CallElasticsearch`|net472|2.4μs|1.63ns|6.32ns|0.158| 0|0|995 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`CallElasticsearchAsync`|net6.0|1.2μs|0.715ns|2.68ns|0.0132| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`CallElasticsearchAsync`|netcoreapp3.1|1.61μs|0.613ns|2.3ns|0.0137| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`CallElasticsearchAsync`|net472|2.57μs|1.35ns|5.24ns|0.167| 0|0|1.05 KB| |#5935|`CallElasticsearch`|net6.0|1.17μs|0.366ns|1.37ns|0.0135| 0|0|976 B| |#5935|`CallElasticsearch`|netcoreapp3.1|1.54μs|0.689ns|2.58ns|0.0129| 0|0|976 B| |#5935|`CallElasticsearch`|net472|2.43μs|2.09ns|8.08ns|0.158| 0.00121|0|995 B| |#5935|`CallElasticsearchAsync`|net6.0|1.25μs|0.836ns|3.13ns|0.0132| 0|0|952 B| |#5935|`CallElasticsearchAsync`|netcoreapp3.1|1.65μs|0.946ns|3.66ns|0.0142| 0|0|1.02 KB| |#5935|`CallElasticsearchAsync`|net472|2.67μs|1.73ns|6.23ns|0.167| 0|0|1.05 KB|

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`ExecuteAsync`|net6.0|1.27μs|1.09ns|4.08ns|0.0133| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`ExecuteAsync`|netcoreapp3.1|1.65μs|0.858ns|3.21ns|0.0125| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`ExecuteAsync`|net472|1.66μs|0.384ns|1.44ns|0.145| 0|0|915 B| |#5935|`ExecuteAsync`|net6.0|1.15μs|0.714ns|2.67ns|0.0132| 0|0|952 B| |#5935|`ExecuteAsync`|netcoreapp3.1|1.61μs|2.21ns|8.55ns|0.013| 0|0|952 B| |#5935|`ExecuteAsync`|net472|1.75μs|1.16ns|4.49ns|0.145| 0.000873|0|915 B|

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`SendAsync`|net6.0|4.34μs|2.08ns|7.8ns|0.0304| 0|0|2.22 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`SendAsync`|netcoreapp3.1|5.08μs|1.51ns|5.64ns|0.0357| 0|0|2.76 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`SendAsync`|net472|7.85μs|2.83ns|11ns|0.497| 0|0|3.15 KB| |#5935|`SendAsync`|net6.0|4.14μs|0.975ns|3.78ns|0.0312| 0|0|2.22 KB| |#5935|`SendAsync`|netcoreapp3.1|5.04μs|1.56ns|6.04ns|0.0352| 0|0|2.76 KB| |#5935|`SendAsync`|net472|7.86μs|3.27ns|12.6ns|0.499| 0|0|3.15 KB|

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`EnrichedLog`|net6.0|1.49μs|0.763ns|2.96ns|0.0232| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`EnrichedLog`|netcoreapp3.1|2.24μs|1.61ns|6.02ns|0.0223| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`EnrichedLog`|net472|2.65μs|1.83ns|6.59ns|0.249| 0|0|1.57 KB| |#5935|`EnrichedLog`|net6.0|1.46μs|1.33ns|4.98ns|0.0227| 0|0|1.64 KB| |#5935|`EnrichedLog`|netcoreapp3.1|2.36μs|0.785ns|2.83ns|0.0224| 0|0|1.64 KB| |#5935|`EnrichedLog`|net472|2.62μs|1.75ns|6.57ns|0.249| 0|0|1.57 KB|

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`EnrichedLog`|net6.0|116μs|200ns|774ns|0.0583| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`EnrichedLog`|netcoreapp3.1|120μs|265ns|1.02μs|0| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`EnrichedLog`|net472|151μs|201ns|778ns|0.674| 0.225|0|4.46 KB| |#5935|`EnrichedLog`|net6.0|117μs|240ns|931ns|0| 0|0|4.28 KB| |#5935|`EnrichedLog`|netcoreapp3.1|120μs|222ns|858ns|0| 0|0|4.28 KB| |#5935|`EnrichedLog`|net472|147μs|219ns|848ns|0.661| 0.22|0|4.46 KB|

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`EnrichedLog`|net6.0|3.01μs|0.751ns|2.91ns|0.0301| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`EnrichedLog`|netcoreapp3.1|4.3μs|1.37ns|5.32ns|0.0301| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`EnrichedLog`|net472|4.91μs|1.48ns|5.73ns|0.319| 0|0|2.02 KB| |#5935|`EnrichedLog`|net6.0|3.09μs|1.04ns|4.05ns|0.031| 0|0|2.2 KB| |#5935|`EnrichedLog`|netcoreapp3.1|4.34μs|1.35ns|5.24ns|0.0282| 0|0|2.2 KB| |#5935|`EnrichedLog`|net472|4.71μs|1.59ns|6.15ns|0.319| 0|0|2.02 KB|

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`SendReceive`|net6.0|1.33μs|0.667ns|2.58ns|0.016| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`SendReceive`|netcoreapp3.1|1.82μs|1.35ns|5.22ns|0.0154| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`SendReceive`|net472|2.21μs|2.01ns|7.77ns|0.183| 0.00111|0|1.16 KB| |#5935|`SendReceive`|net6.0|1.27μs|0.676ns|2.53ns|0.016| 0|0|1.14 KB| |#5935|`SendReceive`|netcoreapp3.1|1.78μs|2.46ns|9.51ns|0.0151| 0|0|1.14 KB| |#5935|`SendReceive`|net472|2.14μs|1.59ns|5.94ns|0.183| 0.00107|0|1.16 KB|

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`EnrichedLog`|net6.0|2.88μs|0.836ns|3.24ns|0.0216| 0|0|1.6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`EnrichedLog`|netcoreapp3.1|4μs|1.16ns|4.48ns|0.022| 0|0|1.65 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`EnrichedLog`|net472|4.32μs|2.36ns|9.14ns|0.323| 0|0|2.04 KB| |#5935|`EnrichedLog`|net6.0|2.65μs|0.786ns|2.94ns|0.0226| 0|0|1.6 KB| |#5935|`EnrichedLog`|netcoreapp3.1|3.88μs|1.53ns|5.51ns|0.0214| 0|0|1.65 KB| |#5935|`EnrichedLog`|net472|4.34μs|1.55ns|5.79ns|0.323| 0|0|2.04 KB|

Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #5935 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 | 1.171 | 794.61 | 930.16 |

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`StartFinishSpan`|net6.0|403ns|0.148ns|0.574ns|0.00813| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`StartFinishSpan`|netcoreapp3.1|623ns|0.358ns|1.34ns|0.00779| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`StartFinishSpan`|net472|666ns|0.202ns|0.783ns|0.0916| 0|0|578 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`StartFinishScope`|net6.0|535ns|0.185ns|0.715ns|0.00981| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`StartFinishScope`|netcoreapp3.1|737ns|0.29ns|1.12ns|0.00951| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`StartFinishScope`|net472|795ns|1.02ns|3.94ns|0.104| 0|0|658 B| |#5935|`StartFinishSpan`|net6.0|441ns|0.12ns|0.463ns|0.00811| 0|0|576 B| |#5935|`StartFinishSpan`|netcoreapp3.1|597ns|1.29ns|4.99ns|0.00761| 0|0|576 B| |#5935|`StartFinishSpan`|net472|681ns|0.428ns|1.66ns|0.0915| 0|0|578 B| |#5935|`StartFinishScope`|net6.0|494ns|0.124ns|0.463ns|0.00966| 0|0|696 B| |#5935|`StartFinishScope`|netcoreapp3.1|668ns|0.309ns|1.2ns|0.00939| 0|0|696 B| |#5935|`StartFinishScope`|net472|930ns|0.146ns|0.546ns|0.104| 0|0|658 B|

Benchmarks.Trace.TraceAnnotationsBenchmark - Faster :tada: Same allocations :heavy_check_mark: #### Faster :tada: in #5935 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.150 | 681.18 | 592.32 |

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`RunOnMethodBegin`|net6.0|681ns|0.43ns|1.67ns|0.00963| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`RunOnMethodBegin`|netcoreapp3.1|979ns|0.281ns|1.09ns|0.00936| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/e0d9add131aa15e77624aaf334f6c31c89892aab)|`RunOnMethodBegin`|net472|1.09μs|0.426ns|1.65ns|0.104| 0|0|658 B| |#5935|`RunOnMethodBegin`|net6.0|593ns|0.261ns|1.01ns|0.00978| 0|0|696 B| |#5935|`RunOnMethodBegin`|netcoreapp3.1|969ns|0.494ns|1.91ns|0.00956| 0|0|696 B| |#5935|`RunOnMethodBegin`|net472|1.11μs|0.721ns|2.79ns|0.104| 0|0|658 B|

DataDog / dd-trace-dotnet