Closed andrewlock closed 1 month ago
Branch report: dani/iast/hardcodedsecrets_init_fix-v2
Commit report: ace0982
Test service: dd-trace-dotnet
:white_check_mark: 0 Failed, 346055 Passed, 1775 Skipped, 15h 5m 2.16s Total Time
Execution-time results for samples comparing the following branches/commits:
Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.
Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).
gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5937) - mean (74ms) : 66, 83
. : milestone, 74,
section CallTarget+Inlining+NGEN
This PR (5937) - mean (1,032ms) : 996, 1068
. : milestone, 1032,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5937) - mean (110ms) : 107, 113
. : milestone, 110,
section CallTarget+Inlining+NGEN
This PR (5937) - mean (720ms) : 679, 762
. : milestone, 720,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5937) - mean (94ms) : 91, 97
. : milestone, 94,
section CallTarget+Inlining+NGEN
This PR (5937) - mean (675ms) : 635, 716
. : milestone, 675,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5937) - mean (190ms) : 186, 194
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (5937) - mean (1,112ms) : 1090, 1134
. : milestone, 1112,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5937) - mean (276ms) : 272, 280
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (5937) - mean (877ms) : 854, 899
. : milestone, 877,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5937) - mean (267ms) : 261, 273
. : milestone, 267,
section CallTarget+Inlining+NGEN
This PR (5937) - mean (865ms) : 850, 880
. : milestone, 865,
Benchmarks for #5937 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored.
Benchmarks for #5937 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored.
Throughput results for AspNetCoreSimpleController comparing the following branches/commits:
Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.
Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!
gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5937) (11.497M) : 0, 11497140
master (11.601M) : 0, 11600674
benchmarks/2.9.0 (11.883M) : 0, 11882814
section Automatic
This PR (5937) (7.748M) : 0, 7748289
master (7.683M) : 0, 7683307
benchmarks/2.9.0 (8.446M) : 0, 8445613
section Trace stats
master (8.064M) : 0, 8064161
section Manual
This PR (5937) (9.810M) : crit ,0, 9809785
master (11.471M) : 0, 11470876
section Manual + Automatic
This PR (5937) (7.334M) : 0, 7334306
master (7.151M) : 0, 7150588
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5937) (9.549M) : 0, 9548994
benchmarks/2.9.0 (9.760M) : 0, 9759697
section Automatic
This PR (5937) (6.578M) : 0, 6577879
section Manual
This PR (5937) (8.157M) : 0, 8157495
section Manual + Automatic
This PR (5937) (5.939M) : 0, 5939303
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5937) (10.087M) : 0, 10086814
section Automatic
This PR (5937) (6.881M) : 0, 6880780
section Manual
This PR (5937) (8.678M) : 0, 8678141
section Manual + Automatic
This PR (5937) (6.611M) : 0, 6611489
Summary of changes
Make IAST analyzers initialization explicit, and call it only in
Instrumentation.Initialize
to avoid multiple instances scenariosReason for change
A crash under these circumstances has been detected
Implementation details
Move IAST analyzers init inside
Instrumentation.Initialize
only to make sure they are initialized only onceTest coverage
Other details
Backport of https://github.com/DataDog/dd-trace-dotnet/pull/5920