search

DataDog / dd-trace-dotnet

.NET Client Library for Datadog APM
https://docs.datadoghq.com/tracing/
Apache License 2.0
437 stars 137 forks source link

Fix GRPC integration #5958

Open tonyredondo opened 1 month ago

tonyredondo commented 1 month ago

Summary of changes

This PR fixes the current GRPC integration.

Reason for change

The following error has been seen in the Error tracking product:

image

Implementation details

Instead of calling DuckCast directly that can throw, we use TryDuckCast to check if we can use the ducktype struct before.

datadog-ddstaging[bot] commented 1 month ago

Datadog Report

Branch report: tony/remove-grpc-unsupported-versions Commit report: 64b5673 Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 53 Passed, 0 Skipped, 32m 6.72s Total Time

andrewlock commented 1 month ago

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5958) - mean (71ms)  : 67, 75
     .   : milestone, 71,
    master - mean (70ms)  : 67, 74
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (5958) - mean (1,087ms)  : 1066, 1109
     .   : milestone, 1087,
    master - mean (1,083ms)  : 1051, 1116
     .   : milestone, 1083,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5958) - mean (111ms)  : 107, 115
     .   : milestone, 111,
    master - mean (109ms)  : 107, 111
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5958) - mean (762ms)  : 712, 811
     .   : milestone, 762,
    master - mean (750ms)  : 733, 766
     .   : milestone, 750,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5958) - mean (94ms)  : 90, 98
     .   : milestone, 94,
    master - mean (94ms)  : 90, 98
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (5958) - mean (710ms)  : 682, 738
     .   : milestone, 710,
    master - mean (699ms)  : 682, 716
     .   : milestone, 699,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5958) - mean (190ms)  : 187, 193
     .   : milestone, 190,
    master - mean (190ms)  : 186, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (5958) - mean (1,157ms)  : 1133, 1181
     .   : milestone, 1157,
    master - mean (1,159ms)  : 1134, 1184
     .   : milestone, 1159,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5958) - mean (275ms)  : 271, 280
     .   : milestone, 275,
    master - mean (276ms)  : 271, 282
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (5958) - mean (916ms)  : 895, 937
     .   : milestone, 916,
    master - mean (917ms)  : 899, 936
     .   : milestone, 917,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5958) - mean (265ms)  : 261, 270
     .   : milestone, 265,
    master - mean (264ms)  : 259, 269
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (5958) - mean (904ms)  : 889, 919
     .   : milestone, 904,
    master - mean (897ms)  : 879, 916
     .   : milestone, 897,
andrewlock commented 1 month ago

Benchmarks Report for tracer :snail:

Benchmarks for #5958 compared to master:

The following thresholds were used for comparing the benchmark speeds:

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`StartStopWithChild`|net6.0|7.67μs|38.8ns|182ns|0.0117| 0.00391|0|5.43 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`StartStopWithChild`|netcoreapp3.1|9.92μs|53.9ns|309ns|0.0153| 0.00511|0|5.62 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`StartStopWithChild`|net472|16μs|53.9ns|209ns|1.02| 0.313|0.0862|6.06 KB| |#5958|`StartStopWithChild`|net6.0|7.92μs|45.1ns|329ns|0.0159| 0.00797|0|5.42 KB| |#5958|`StartStopWithChild`|netcoreapp3.1|9.61μs|51.3ns|276ns|0.0189| 0.00472|0|5.62 KB| |#5958|`StartStopWithChild`|net472|16.1μs|44.9ns|174ns|1.01| 0.296|0.0961|6.07 KB|
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`WriteAndFlushEnrichedTraces`|net6.0|475μs|199ns|718ns|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|623μs|276ns|1.07μs|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`WriteAndFlushEnrichedTraces`|net472|839μs|319ns|1.15μs|0.417| 0|0|3.3 KB| |#5958|`WriteAndFlushEnrichedTraces`|net6.0|474μs|416ns|1.56μs|0| 0|0|2.7 KB| |#5958|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|632μs|388ns|1.5μs|0| 0|0|2.7 KB| |#5958|`WriteAndFlushEnrichedTraces`|net472|848μs|632ns|2.45μs|0.422| 0|0|3.3 KB|
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`SendRequest`|net6.0|197μs|1.19μs|11.7μs|0.147| 0|0|18.45 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`SendRequest`|netcoreapp3.1|211μs|991ns|3.84μs|0.218| 0|0|20.61 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`SendRequest`|net472|0.00204ns|0.000721ns|0.0027ns|0| 0|0|0 b| |#5958|`SendRequest`|net6.0|192μs|1.1μs|7.75μs|0.199| 0|0|18.45 KB| |#5958|`SendRequest`|netcoreapp3.1|215μs|1.22μs|9.11μs|0.217| 0|0|20.61 KB| |#5958|`SendRequest`|net472|0.00261ns|0.000789ns|0.00306ns|0| 0|0|0 b|
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`WriteAndFlushEnrichedTraces`|net6.0|550μs|2.66μs|10.7μs|0.556| 0|0|41.63 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|666μs|3.17μs|13.1μs|0.349| 0|0|41.57 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`WriteAndFlushEnrichedTraces`|net472|872μs|3.76μs|13.6μs|8.3| 2.62|0.437|53.3 KB| |#5958|`WriteAndFlushEnrichedTraces`|net6.0|613μs|3.5μs|26μs|0.595| 0|0|41.64 KB| |#5958|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|682μs|3.53μs|17.7μs|0.331| 0|0|41.72 KB| |#5958|`WriteAndFlushEnrichedTraces`|net472|879μs|4μs|15.5μs|8.3| 2.62|0.437|53.29 KB|
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`ExecuteNonQuery`|net6.0|1.28μs|1.2ns|4.64ns|0.0147| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`ExecuteNonQuery`|netcoreapp3.1|1.71μs|1.21ns|4.68ns|0.0137| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`ExecuteNonQuery`|net472|2.07μs|2.33ns|9.02ns|0.157| 0|0|987 B| |#5958|`ExecuteNonQuery`|net6.0|1.28μs|0.812ns|3.14ns|0.0146| 0|0|1.02 KB| |#5958|`ExecuteNonQuery`|netcoreapp3.1|1.61μs|1.63ns|6.32ns|0.0136| 0|0|1.02 KB| |#5958|`ExecuteNonQuery`|net472|1.94μs|1.66ns|6.43ns|0.157| 0|0|987 B|
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`CallElasticsearch`|net6.0|1.34μs|0.74ns|2.77ns|0.0134| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`CallElasticsearch`|netcoreapp3.1|1.54μs|0.485ns|1.81ns|0.0131| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`CallElasticsearch`|net472|2.5μs|2.03ns|7.85ns|0.158| 0|0|995 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`CallElasticsearchAsync`|net6.0|1.25μs|0.657ns|2.46ns|0.0132| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`CallElasticsearchAsync`|netcoreapp3.1|1.66μs|0.725ns|2.81ns|0.0142| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`CallElasticsearchAsync`|net472|2.66μs|2.69ns|10.4ns|0.167| 0|0|1.05 KB| |#5958|`CallElasticsearch`|net6.0|1.22μs|1.39ns|5.39ns|0.0135| 0|0|976 B| |#5958|`CallElasticsearch`|netcoreapp3.1|1.52μs|1.55ns|5.81ns|0.0137| 0|0|976 B| |#5958|`CallElasticsearch`|net472|2.5μs|1.91ns|7.39ns|0.157| 0|0|995 B| |#5958|`CallElasticsearchAsync`|net6.0|1.26μs|1.06ns|4.12ns|0.0133| 0|0|952 B| |#5958|`CallElasticsearchAsync`|netcoreapp3.1|1.59μs|0.859ns|3.33ns|0.0134| 0|0|1.02 KB| |#5958|`CallElasticsearchAsync`|net472|2.68μs|3.53ns|13.7ns|0.166| 0|0|1.05 KB|
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`ExecuteAsync`|net6.0|1.34μs|1.03ns|4.01ns|0.0134| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`ExecuteAsync`|netcoreapp3.1|1.68μs|0.653ns|2.36ns|0.0127| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`ExecuteAsync`|net472|1.78μs|1.28ns|4.97ns|0.145| 0|0|915 B| |#5958|`ExecuteAsync`|net6.0|1.23μs|0.748ns|2.9ns|0.0136| 0|0|952 B| |#5958|`ExecuteAsync`|netcoreapp3.1|1.63μs|1.29ns|4.98ns|0.013| 0|0|952 B| |#5958|`ExecuteAsync`|net472|1.8μs|1.63ns|6.32ns|0.145| 0|0|915 B|
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`SendAsync`|net6.0|4μs|2.09ns|7.55ns|0.0303| 0|0|2.22 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`SendAsync`|netcoreapp3.1|5.09μs|2.07ns|7.73ns|0.0357| 0|0|2.76 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`SendAsync`|net472|8.03μs|2.66ns|9.96ns|0.499| 0|0|3.15 KB| |#5958|`SendAsync`|net6.0|4.15μs|2.31ns|8.93ns|0.0312| 0|0|2.22 KB| |#5958|`SendAsync`|netcoreapp3.1|5.1μs|2.06ns|7.99ns|0.0356| 0|0|2.76 KB| |#5958|`SendAsync`|net472|7.8μs|2.84ns|11ns|0.496| 0|0|3.15 KB|
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`EnrichedLog`|net6.0|1.59μs|0.569ns|2.2ns|0.0232| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`EnrichedLog`|netcoreapp3.1|2.17μs|2.89ns|10.8ns|0.0217| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`EnrichedLog`|net472|2.82μs|1.52ns|5.89ns|0.249| 0|0|1.57 KB| |#5958|`EnrichedLog`|net6.0|1.53μs|1.49ns|5.56ns|0.0228| 0|0|1.64 KB| |#5958|`EnrichedLog`|netcoreapp3.1|2.26μs|1.03ns|3.86ns|0.0215| 0|0|1.64 KB| |#5958|`EnrichedLog`|net472|2.68μs|2.25ns|8.73ns|0.249| 0|0|1.57 KB|
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`EnrichedLog`|net6.0|117μs|173ns|669ns|0.0589| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`EnrichedLog`|netcoreapp3.1|120μs|297ns|1.11μs|0| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`EnrichedLog`|net472|151μs|384ns|1.44μs|0.67| 0.223|0|4.46 KB| |#5958|`EnrichedLog`|net6.0|115μs|187ns|700ns|0| 0|0|4.28 KB| |#5958|`EnrichedLog`|netcoreapp3.1|120μs|145ns|563ns|0| 0|0|4.28 KB| |#5958|`EnrichedLog`|net472|147μs|229ns|887ns|0.662| 0.221|0|4.46 KB|
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`EnrichedLog`|net6.0|2.89μs|1.4ns|5.41ns|0.0303| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`EnrichedLog`|netcoreapp3.1|4.1μs|2.82ns|10.6ns|0.0285| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`EnrichedLog`|net472|4.8μs|1.6ns|6.18ns|0.319| 0|0|2.02 KB| |#5958|`EnrichedLog`|net6.0|3.17μs|0.819ns|3.17ns|0.0302| 0|0|2.2 KB| |#5958|`EnrichedLog`|netcoreapp3.1|4.21μs|2.34ns|9.05ns|0.0295| 0|0|2.2 KB| |#5958|`EnrichedLog`|net472|4.92μs|1.04ns|3.9ns|0.319| 0|0|2.02 KB|
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`SendReceive`|net6.0|1.34μs|0.558ns|2.16ns|0.016| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`SendReceive`|netcoreapp3.1|1.72μs|0.999ns|3.6ns|0.0155| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`SendReceive`|net472|2.18μs|1.59ns|5.96ns|0.184| 0.00109|0|1.16 KB| |#5958|`SendReceive`|net6.0|1.33μs|1.56ns|6.05ns|0.016| 0|0|1.14 KB| |#5958|`SendReceive`|netcoreapp3.1|1.77μs|1.02ns|3.94ns|0.0151| 0|0|1.14 KB| |#5958|`SendReceive`|net472|2.11μs|2ns|7.76ns|0.183| 0|0|1.16 KB|
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`EnrichedLog`|net6.0|2.68μs|0.463ns|1.67ns|0.0228| 0|0|1.6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`EnrichedLog`|netcoreapp3.1|3.93μs|1.33ns|5.17ns|0.0216| 0|0|1.65 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`EnrichedLog`|net472|4.47μs|2.81ns|10.5ns|0.324| 0|0|2.04 KB| |#5958|`EnrichedLog`|net6.0|2.62μs|0.785ns|3.04ns|0.0223| 0|0|1.6 KB| |#5958|`EnrichedLog`|netcoreapp3.1|3.91μs|1.63ns|5.88ns|0.0213| 0|0|1.65 KB| |#5958|`EnrichedLog`|net472|4.45μs|2.96ns|11.5ns|0.323| 0|0|2.04 KB|
Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #5958 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 | 1.156 | 564.78 | 653.02 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`StartFinishSpan`|net6.0|392ns|0.125ns|0.469ns|0.00804| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`StartFinishSpan`|netcoreapp3.1|606ns|0.818ns|3.06ns|0.00793| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`StartFinishSpan`|net472|565ns|0.326ns|1.26ns|0.0917| 0|0|578 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`StartFinishScope`|net6.0|466ns|0.157ns|0.606ns|0.0098| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`StartFinishScope`|netcoreapp3.1|707ns|0.446ns|1.73ns|0.00912| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`StartFinishScope`|net472|846ns|0.509ns|1.97ns|0.104| 0|0|658 B| |#5958|`StartFinishSpan`|net6.0|405ns|0.284ns|1.1ns|0.00814| 0|0|576 B| |#5958|`StartFinishSpan`|netcoreapp3.1|603ns|0.289ns|1.12ns|0.00766| 0|0|576 B| |#5958|`StartFinishSpan`|net472|653ns|0.461ns|1.79ns|0.0917| 0|0|578 B| |#5958|`StartFinishScope`|net6.0|477ns|0.142ns|0.551ns|0.00963| 0|0|696 B| |#5958|`StartFinishScope`|netcoreapp3.1|696ns|0.346ns|1.34ns|0.00953| 0|0|696 B| |#5958|`StartFinishScope`|net472|910ns|0.891ns|3.45ns|0.104| 0|0|658 B|
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`RunOnMethodBegin`|net6.0|639ns|0.227ns|0.88ns|0.00964| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`RunOnMethodBegin`|netcoreapp3.1|989ns|3.24ns|12.5ns|0.00946| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/2482f58cee3e5ac4024fcbef77735923e7b75ca5)|`RunOnMethodBegin`|net472|1.04μs|0.471ns|1.82ns|0.104| 0|0|658 B| |#5958|`RunOnMethodBegin`|net6.0|621ns|0.217ns|0.839ns|0.0097| 0|0|696 B| |#5958|`RunOnMethodBegin`|netcoreapp3.1|1μs|0.777ns|3.01ns|0.00907| 0|0|696 B| |#5958|`RunOnMethodBegin`|net472|1.12μs|1.11ns|4.29ns|0.105| 0|0|658 B|
andrewlock commented 1 month ago

Throughput/Crank Report :zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5958) (11.235M)   : 0, 11234872
    master (11.287M)   : 0, 11287273
    benchmarks/2.9.0 (11.711M)   : 0, 11710619

    section Automatic
    This PR (5958) (7.451M)   : 0, 7450906
    master (7.387M)   : 0, 7386911
    benchmarks/2.9.0 (8.265M)   : 0, 8264630

    section Trace stats
    master (7.736M)   : 0, 7736052

    section Manual
    master (11.250M)   : 0, 11249712

    section Manual + Automatic
    This PR (5958) (6.840M)   : 0, 6839853
    master (6.869M)   : 0, 6868717

    section DD_TRACE_ENABLED=0
    master (10.392M)   : 0, 10391860

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5958) (9.672M)   : 0, 9672048
    master (9.673M)   : 0, 9673344
    benchmarks/2.9.0 (9.717M)   : 0, 9716586

    section Automatic
    This PR (5958) (6.727M)   : 0, 6726961
    master (6.647M)   : 0, 6646970

    section Trace stats
    master (6.918M)   : 0, 6917987

    section Manual
    master (9.474M)   : 0, 9473853

    section Manual + Automatic
    This PR (5958) (6.188M)   : 0, 6188094
    master (6.204M)   : 0, 6204168

    section DD_TRACE_ENABLED=0
    master (9.032M)   : 0, 9031783

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5958) (10.054M)   : 0, 10054265

    section Automatic
    This PR (5958) (6.450M)   : 0, 6449772

    section Manual + Automatic
    This PR (5958) (6.058M)   : 0, 6057690