search

DataDog / dd-trace-dotnet

.NET Client Library for Datadog APM
https://docs.datadoghq.com/tracing/
Apache License 2.0
437 stars 137 forks source link

Run installer tests with libgcc added to the alpine package #5967

Open andrewlock opened 1 month ago

andrewlock commented 1 month ago

Summary of changes

Runs additional installer tests for alpine where the glibc compatibility package is installed

Reason for change

It's possible to run glibc libraries on alpine if you use the compatibility layer. We don't need these and generally won't "notice" they're there, but we should check that it doesn't cause any issues for us

Implementation details

Add additional smokes tests that add the compatibility package to the alpine container

Test coverage

Just added a few smoke tests, to make sure we don't hit any obvious issues

Other details

Will also backport these to v2

datadog-ddstaging[bot] commented 1 month ago

Datadog Report

Branch report: andrew/ci/smoke-tests-for-glibc-alpine Commit report: 6963e0b Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 361563 Passed, 2058 Skipped, 14h 32m 38.54s Total Time

andrewlock commented 1 month ago

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

andrewlock commented 1 month ago

Throughput/Crank Report :zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5967) (11.078M)   : 0, 11077691
    master (11.247M)   : 0, 11246521
    benchmarks/2.9.0 (11.120M)   : 0, 11120231

    section Automatic
    This PR (5967) (7.414M)   : 0, 7413566
    master (7.508M)   : 0, 7508439
    benchmarks/2.9.0 (7.874M)   : 0, 7874046

    section Trace stats
    master (7.707M)   : 0, 7707332

    section Manual
    master (11.233M)   : 0, 11232811

    section Manual + Automatic
    This PR (5967) (6.894M)   : 0, 6894130
    master (6.892M)   : 0, 6891553

    section DD_TRACE_ENABLED=0
    master (10.225M)   : 0, 10225326

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5967) (9.396M)   : 0, 9395569
    benchmarks/2.9.0 (9.342M)   : 0, 9341974

    section Automatic
    This PR (5967) (6.675M)   : 0, 6675143

    section Manual + Automatic
    This PR (5967) (6.134M)   : 0, 6134399

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5967) (10.145M)   : 0, 10144886
    master (10.060M)   : 0, 10059520
    benchmarks/2.9.0 (10.105M)   : 0, 10105239

    section Automatic
    This PR (5967) (6.920M)   : 0, 6919964
    master (6.690M)   : 0, 6690107
    benchmarks/2.9.0 (7.518M)   : 0, 7517801

    section Trace stats
    master (7.324M)   : 0, 7324117

    section Manual
    master (10.131M)   : 0, 10131126

    section Manual + Automatic
    This PR (5967) (6.259M)   : 0, 6258969
    master (6.279M)   : 0, 6279338

    section DD_TRACE_ENABLED=0
    master (9.441M)   : 0, 9441325
andrewlock commented 1 month ago

Benchmarks Report for tracer :snail:

Benchmarks for #5967 compared to master:

The following thresholds were used for comparing the benchmark speeds:

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`StartStopWithChild`|net6.0|7.76μs|43.7ns|303ns|0.0148| 0.00738|0|5.43 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`StartStopWithChild`|netcoreapp3.1|9.78μs|55.1ns|389ns|0.0241| 0.00963|0|5.61 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`StartStopWithChild`|net472|15.8μs|46.9ns|175ns|1.02| 0.302|0.103|6.07 KB| |#5967|`StartStopWithChild`|net6.0|7.68μs|44.1ns|333ns|0.0154| 0.0077|0|5.43 KB| |#5967|`StartStopWithChild`|netcoreapp3.1|10.1μs|52ns|255ns|0.0197| 0.00984|0|5.62 KB| |#5967|`StartStopWithChild`|net472|15.9μs|39.1ns|152ns|1.05| 0.325|0.0951|6.06 KB|
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`WriteAndFlushEnrichedTraces`|net6.0|476μs|256ns|990ns|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|645μs|131ns|473ns|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`WriteAndFlushEnrichedTraces`|net472|839μs|659ns|2.55μs|0.417| 0|0|3.3 KB| |#5967|`WriteAndFlushEnrichedTraces`|net6.0|464μs|393ns|1.52μs|0| 0|0|2.7 KB| |#5967|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|639μs|421ns|1.63μs|0| 0|0|2.7 KB| |#5967|`WriteAndFlushEnrichedTraces`|net472|834μs|248ns|927ns|0.417| 0|0|3.3 KB|
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`SendRequest`|net6.0|187μs|884ns|3.54μs|0.183| 0|0|18.45 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`SendRequest`|netcoreapp3.1|207μs|1.1μs|5.91μs|0.209| 0|0|20.61 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`SendRequest`|net472|0.0059ns|0.00211ns|0.00818ns|0| 0|0|0 b| |#5967|`SendRequest`|net6.0|182μs|934ns|4.18μs|0.177| 0|0|18.45 KB| |#5967|`SendRequest`|netcoreapp3.1|200μs|944ns|3.78μs|0.197| 0|0|20.61 KB| |#5967|`SendRequest`|net472|3.71E‑05ns|3.71E‑05ns|0.000144ns|0| 0|0|0 b|
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`WriteAndFlushEnrichedTraces`|net6.0|543μs|1.82μs|6.83μs|0.546| 0|0|41.52 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|677μs|3.19μs|14.6μs|0.329| 0|0|41.73 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`WriteAndFlushEnrichedTraces`|net472|875μs|3.56μs|13.8μs|8.13| 2.57|0.428|53.27 KB| |#5967|`WriteAndFlushEnrichedTraces`|net6.0|547μs|1.31μs|5.09μs|0.556| 0|0|41.57 KB| |#5967|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|666μs|2.52μs|9.08μs|0.326| 0|0|41.74 KB| |#5967|`WriteAndFlushEnrichedTraces`|net472|862μs|4.1μs|16.9μs|8.33| 2.5|0.417|53.31 KB|
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`ExecuteNonQuery`|net6.0|1.35μs|1.31ns|5.06ns|0.0142| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`ExecuteNonQuery`|netcoreapp3.1|1.72μs|1.68ns|6.5ns|0.0138| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`ExecuteNonQuery`|net472|2.02μs|0.813ns|2.93ns|0.157| 0|0|987 B| |#5967|`ExecuteNonQuery`|net6.0|1.34μs|1.85ns|7.15ns|0.0142| 0|0|1.02 KB| |#5967|`ExecuteNonQuery`|netcoreapp3.1|1.7μs|0.952ns|3.56ns|0.0137| 0|0|1.02 KB| |#5967|`ExecuteNonQuery`|net472|1.99μs|0.776ns|2.9ns|0.156| 0|0|987 B|
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`CallElasticsearch`|net6.0|1.19μs|0.497ns|1.86ns|0.0137| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`CallElasticsearch`|netcoreapp3.1|1.46μs|0.583ns|2.1ns|0.0132| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`CallElasticsearch`|net472|2.47μs|1.59ns|5.97ns|0.158| 0|0|995 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`CallElasticsearchAsync`|net6.0|1.35μs|1.64ns|6.37ns|0.0135| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`CallElasticsearchAsync`|netcoreapp3.1|1.65μs|0.594ns|2.3ns|0.0142| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`CallElasticsearchAsync`|net472|2.51μs|1.25ns|4.67ns|0.166| 0|0|1.05 KB| |#5967|`CallElasticsearch`|net6.0|1.13μs|0.745ns|2.88ns|0.0137| 0|0|976 B| |#5967|`CallElasticsearch`|netcoreapp3.1|1.55μs|0.883ns|3.3ns|0.013| 0|0|976 B| |#5967|`CallElasticsearch`|net472|2.44μs|1.64ns|6.36ns|0.158| 0|0|995 B| |#5967|`CallElasticsearchAsync`|net6.0|1.33μs|0.51ns|1.97ns|0.0133| 0|0|952 B| |#5967|`CallElasticsearchAsync`|netcoreapp3.1|1.58μs|0.667ns|2.58ns|0.0134| 0|0|1.02 KB| |#5967|`CallElasticsearchAsync`|net472|2.65μs|1.91ns|7.39ns|0.166| 0|0|1.05 KB|
Benchmarks.Trace.GraphQLBenchmark - Faster :tada: Same allocations :heavy_check_mark: #### Faster :tada: in #5967 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 | 1.142 | 1,342.72 | 1,176.23 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`ExecuteAsync`|net6.0|1.34μs|0.561ns|2.1ns|0.013| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`ExecuteAsync`|netcoreapp3.1|1.57μs|0.783ns|2.82ns|0.0127| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`ExecuteAsync`|net472|1.73μs|0.546ns|2.04ns|0.145| 0|0|915 B| |#5967|`ExecuteAsync`|net6.0|1.18μs|0.668ns|2.5ns|0.0135| 0|0|952 B| |#5967|`ExecuteAsync`|netcoreapp3.1|1.69μs|1.03ns|3.86ns|0.0127| 0|0|952 B| |#5967|`ExecuteAsync`|net472|1.8μs|0.673ns|2.61ns|0.145| 0|0|915 B|
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`SendAsync`|net6.0|4.14μs|0.957ns|3.58ns|0.0311| 0|0|2.22 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`SendAsync`|netcoreapp3.1|5.1μs|2.15ns|8.05ns|0.0359| 0|0|2.76 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`SendAsync`|net472|7.75μs|2.41ns|9.35ns|0.496| 0|0|3.15 KB| |#5967|`SendAsync`|net6.0|4.29μs|9.11ns|35.3ns|0.0314| 0|0|2.22 KB| |#5967|`SendAsync`|netcoreapp3.1|5.06μs|2.05ns|7.93ns|0.0361| 0|0|2.76 KB| |#5967|`SendAsync`|net472|7.84μs|3.76ns|13.5ns|0.497| 0|0|3.15 KB|
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`EnrichedLog`|net6.0|1.47μs|0.435ns|1.68ns|0.0229| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`EnrichedLog`|netcoreapp3.1|2.38μs|0.732ns|2.74ns|0.0225| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`EnrichedLog`|net472|2.71μs|1.55ns|5.99ns|0.249| 0|0|1.57 KB| |#5967|`EnrichedLog`|net6.0|1.62μs|0.68ns|2.54ns|0.0235| 0|0|1.64 KB| |#5967|`EnrichedLog`|netcoreapp3.1|2.22μs|1.27ns|4.94ns|0.0223| 0|0|1.64 KB| |#5967|`EnrichedLog`|net472|2.64μs|1.05ns|4.08ns|0.249| 0|0|1.57 KB|
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`EnrichedLog`|net6.0|117μs|134ns|502ns|0.0589| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`EnrichedLog`|netcoreapp3.1|121μs|386ns|1.5μs|0| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`EnrichedLog`|net472|151μs|215ns|832ns|0.682| 0.227|0|4.46 KB| |#5967|`EnrichedLog`|net6.0|119μs|349ns|1.35μs|0| 0|0|4.28 KB| |#5967|`EnrichedLog`|netcoreapp3.1|120μs|160ns|620ns|0.0598| 0|0|4.28 KB| |#5967|`EnrichedLog`|net472|151μs|223ns|862ns|0.68| 0.227|0|4.46 KB|
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`EnrichedLog`|net6.0|3.07μs|0.986ns|3.69ns|0.0305| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`EnrichedLog`|netcoreapp3.1|4.39μs|0.973ns|3.77ns|0.0305| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`EnrichedLog`|net472|4.85μs|1.03ns|4.01ns|0.32| 0|0|2.02 KB| |#5967|`EnrichedLog`|net6.0|2.97μs|1.12ns|4.32ns|0.0309| 0|0|2.2 KB| |#5967|`EnrichedLog`|netcoreapp3.1|4.19μs|2.68ns|10ns|0.0294| 0|0|2.2 KB| |#5967|`EnrichedLog`|net472|4.95μs|1.79ns|6.95ns|0.321| 0|0|2.02 KB|
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`SendReceive`|net6.0|1.31μs|0.747ns|2.79ns|0.0164| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`SendReceive`|netcoreapp3.1|1.75μs|0.965ns|3.48ns|0.0158| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`SendReceive`|net472|2.14μs|1.44ns|5.38ns|0.183| 0|0|1.16 KB| |#5967|`SendReceive`|net6.0|1.37μs|1.04ns|4.02ns|0.0164| 0|0|1.14 KB| |#5967|`SendReceive`|netcoreapp3.1|1.82μs|0.526ns|1.97ns|0.0154| 0|0|1.14 KB| |#5967|`SendReceive`|net472|2.21μs|1.17ns|4.39ns|0.183| 0.0011|0|1.16 KB|
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`EnrichedLog`|net6.0|2.79μs|1.15ns|4.44ns|0.0224| 0|0|1.6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`EnrichedLog`|netcoreapp3.1|3.94μs|2.01ns|7.77ns|0.0218| 0|0|1.65 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`EnrichedLog`|net472|4.35μs|1.25ns|4.67ns|0.322| 0|0|2.04 KB| |#5967|`EnrichedLog`|net6.0|2.73μs|1.16ns|4.49ns|0.0219| 0|0|1.6 KB| |#5967|`EnrichedLog`|netcoreapp3.1|3.94μs|1.22ns|4.57ns|0.0217| 0|0|1.65 KB| |#5967|`EnrichedLog`|net472|4.38μs|5.69ns|21.3ns|0.323| 0|0|2.04 KB|
Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #5967 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 | 1.144 | 683.87 | 782.51 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`StartFinishSpan`|net6.0|400ns|0.257ns|0.993ns|0.00803| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`StartFinishSpan`|netcoreapp3.1|574ns|1.16ns|4.5ns|0.00761| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`StartFinishSpan`|net472|618ns|0.706ns|2.73ns|0.0916| 0|0|578 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`StartFinishScope`|net6.0|537ns|0.549ns|2.05ns|0.00971| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`StartFinishScope`|netcoreapp3.1|685ns|1.12ns|4.33ns|0.00929| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`StartFinishScope`|net472|809ns|0.641ns|2.48ns|0.104| 0|0|658 B| |#5967|`StartFinishSpan`|net6.0|391ns|0.258ns|1ns|0.00812| 0|0|576 B| |#5967|`StartFinishSpan`|netcoreapp3.1|554ns|0.47ns|1.82ns|0.00778| 0|0|576 B| |#5967|`StartFinishSpan`|net472|657ns|0.705ns|2.73ns|0.0916| 0|0|578 B| |#5967|`StartFinishScope`|net6.0|559ns|0.866ns|3.35ns|0.00977| 0|0|696 B| |#5967|`StartFinishScope`|netcoreapp3.1|782ns|0.594ns|2.3ns|0.0093| 0|0|696 B| |#5967|`StartFinishScope`|net472|836ns|0.852ns|3.19ns|0.104| 0|0|658 B|
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`RunOnMethodBegin`|net6.0|582ns|0.413ns|1.6ns|0.00987| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`RunOnMethodBegin`|netcoreapp3.1|899ns|1.01ns|3.77ns|0.00949| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/61563101dccc3f057ad98dcbe65a58558fada13b)|`RunOnMethodBegin`|net472|1.02μs|1.54ns|5.96ns|0.104| 0|0|658 B| |#5967|`RunOnMethodBegin`|net6.0|591ns|0.54ns|2.09ns|0.00974| 0|0|696 B| |#5967|`RunOnMethodBegin`|netcoreapp3.1|941ns|0.638ns|2.47ns|0.00928| 0|0|696 B| |#5967|`RunOnMethodBegin`|net472|1.05μs|0.841ns|3.26ns|0.105| 0|0|658 B|