andrewlock
commented
1 month ago Execution-Time Benchmarks Report :stopwatch:
Execution-time results for samples comparing the following branches/commits:
Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
- Welch test with statistical test for significance of 5%
- Only results indicating a difference greater than 5% and 5 ms are considered.
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.
Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).
gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5970) - mean (73ms) : 63, 83
. : milestone, 73,
section CallTarget+Inlining+NGEN
This PR (5970) - mean (1,034ms) : 1012, 1057
. : milestone, 1034,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5970) - mean (109ms) : 106, 113
. : milestone, 109,
section CallTarget+Inlining+NGEN
This PR (5970) - mean (722ms) : 695, 750
. : milestone, 722,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5970) - mean (96ms) : 89, 102
. : milestone, 96,
section CallTarget+Inlining+NGEN
This PR (5970) - mean (675ms) : 651, 700
. : milestone, 675,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5970) - mean (190ms) : 188, 192
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (5970) - mean (1,115ms) : 1095, 1136
. : milestone, 1115,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5970) - mean (276ms) : 271, 280
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (5970) - mean (875ms) : 853, 898
. : milestone, 875,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5970) - mean (265ms) : 259, 270
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (5970) - mean (872ms) : 853, 891
. : milestone, 872,
datadog-ddstaging[bot]
Added the infrastructure of integration testing for Exception Replay in ASP.NET Core.
To add a test, one needs to simply create a class that inherits from
IRun/IAsyncRunand decorated withExceptionReplayTestDataattribute, providing to the attribute the amount of snapshots anticipated both in default configuration and full stack trace capture configuration.This PR also introduces the renaming of the configs of Exception Replay from Exception Debugging. In the early days we used to call Exception Replay internally Exception Debugging, thus some of the configs held this name. This PR renamed those leftovers to Exception Replay, including the enablement config of
DD_EXCEPTION_REPLAY_ENABLED. Introduced a PR todd-gotoo where these configs were added to theconfig_norm_rules.jsonfile.Laying the groundwork for integration testing of Exception Replay.
The testing infra bootstraps the web app, queries via reflection all the tests (classes inheriting from
IRun/IAsyncRunand decorated withExceptionReplayTestDataattribute) and list them. Upon executing a test, a request will hit an endpoint ofRunTestwith the name of the test to run (FQN of the class name). The crafted test must throw an exception to be considered valid. For a more complex test scenarios, more endpoints could be introduced.Every test runs in 4 flavors:
This whole PR 🤓. I've added two tests that utilize the infra:
ExceptionWithNonSupportedFramesTestRecursiveExceptionTestFixes DEBUG-2681, DEBUG-2732, DEBUG-1642.
Backport of https://github.com/DataDog/dd-trace-dotnet/pull/5821