search

DataDog / dd-trace-dotnet

.NET Client Library for Datadog APM
https://docs.datadoghq.com/tracing/
Apache License 2.0
437 stars 137 forks source link

[Version Bump] 2.59.0 #5972

Closed github-actions[bot] closed 4 weeks ago

github-actions[bot] commented 4 weeks ago

The following files were found to be modified (as expected)

@DataDog/apm-dotnet

datadog-ddstaging[bot] commented 4 weeks ago

Datadog Report

Branch report: version-bump-2.59.0 Commit report: 03418b2 Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 352702 Passed, 2602 Skipped, 24h 35m 9.28s Total Time :hourglass: 18 Performance Regressions

:hourglass: Performance Regressions vs Default Branch (18)

This report shows up to 5 performance regressions.

  • Baseline - Samples.FakeDbCommand.windows.net462.json.scenarios 84.17ms (+10.84ms, +15%) - Details
  • Baseline - Samples.FakeDbCommand.windows.net60.json.scenarios 106.3ms (+13.7ms, +15%) - Details
  • Baseline - Samples.FakeDbCommand.windows.netcoreapp31.json.scenarios 125.55ms (+16.14ms, +15%) - Details
  • Profiler_cpu_walltime_old_stackwalk - scenarios 3.25s (+910.76ms, +39%) - Details
  • Profiler_cpu_walltime - scenarios 3.24s (+902.12ms, +39%) - Details
andrewlock commented 4 weeks ago

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5972) - mean (84ms)  : 72, 97
     .   : milestone, 84,

    section CallTarget+Inlining+NGEN
    This PR (5972) - mean (1,093ms)  : 1059, 1127
     .   : milestone, 1093,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5972) - mean (126ms)  : 114, 137
     .   : milestone, 126,

    section CallTarget+Inlining+NGEN
    This PR (5972) - mean (774ms)  : 748, 800
     .   : milestone, 774,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5972) - mean (106ms)  : 98, 115
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (5972) - mean (723ms)  : 698, 747
     .   : milestone, 723,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5972) - mean (191ms)  : 188, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (5972) - mean (1,116ms)  : 1097, 1134
     .   : milestone, 1116,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5972) - mean (276ms)  : 271, 281
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (5972) - mean (879ms)  : 861, 897
     .   : milestone, 879,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5972) - mean (265ms)  : 260, 270
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (5972) - mean (869ms)  : 844, 893
     .   : milestone, 869,
andrewlock commented 4 weeks ago

Benchmarks Report for tracer :snail:

Benchmarks for #5972 compared to master:

The following thresholds were used for comparing the benchmark speeds:

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`StartStopWithChild`|net6.0|7.46μs|41.8ns|268ns|0.0116| 0.00386|0|5.43 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`StartStopWithChild`|netcoreapp3.1|9.99μs|45.8ns|183ns|0.0145| 0.00483|0|5.62 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`StartStopWithChild`|net472|15.9μs|34.7ns|134ns|1.02| 0.313|0.0963|6.05 KB| |#5972|`StartStopWithChild`|net6.0|7.68μs|42.5ns|265ns|0.0189| 0.00758|0|5.43 KB| |#5972|`StartStopWithChild`|netcoreapp3.1|10μs|50.2ns|270ns|0.0144| 0.00481|0|5.62 KB| |#5972|`StartStopWithChild`|net472|16.2μs|21.9ns|79.1ns|1.01| 0.293|0.0949|6.05 KB|
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`WriteAndFlushEnrichedTraces`|net6.0|488μs|369ns|1.38μs|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|639μs|472ns|1.83μs|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`WriteAndFlushEnrichedTraces`|net472|846μs|553ns|1.99μs|0.422| 0|0|3.3 KB| |#5972|`WriteAndFlushEnrichedTraces`|net6.0|470μs|230ns|892ns|0| 0|0|2.7 KB| |#5972|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|648μs|1.31μs|4.91μs|0| 0|0|2.7 KB| |#5972|`WriteAndFlushEnrichedTraces`|net472|832μs|390ns|1.46μs|0.414| 0|0|3.3 KB|
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`SendRequest`|net6.0|183μs|1μs|5.59μs|0.182| 0|0|18.45 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`SendRequest`|netcoreapp3.1|209μs|1.2μs|9.23μs|0.213| 0|0|20.61 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`SendRequest`|net472|0.00263ns|0.000963ns|0.00373ns|0| 0|0|0 b| |#5972|`SendRequest`|net6.0|196μs|1.11μs|7.8μs|0.199| 0|0|18.45 KB| |#5972|`SendRequest`|netcoreapp3.1|216μs|1.24μs|9.34μs|0.203| 0|0|20.61 KB| |#5972|`SendRequest`|net472|0.0005ns|0.000317ns|0.00119ns|0| 0|0|0 b|
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada: #### Fewer allocations :tada: in #5972 | Benchmark | Base Allocated | Diff Allocated | Change | Change % | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 | 41.86 KB | 41.65 KB | -210 B | -0.50% ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`WriteAndFlushEnrichedTraces`|net6.0|557μs|1.46μs|5.64μs|0.534| 0|0|41.61 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|661μs|2.5μs|9.68μs|0.326| 0|0|41.86 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`WriteAndFlushEnrichedTraces`|net472|860μs|3.23μs|12.5μs|8.3| 2.62|0.437|53.23 KB| |#5972|`WriteAndFlushEnrichedTraces`|net6.0|567μs|2.73μs|10.6μs|0.553| 0|0|41.56 KB| |#5972|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|674μs|2.98μs|11.2μs|0.336| 0|0|41.65 KB| |#5972|`WriteAndFlushEnrichedTraces`|net472|877μs|4.14μs|17.1μs|8.56| 2.57|0.428|53.26 KB|
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`ExecuteNonQuery`|net6.0|1.26μs|1.36ns|5.27ns|0.0145| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`ExecuteNonQuery`|netcoreapp3.1|1.71μs|1.58ns|5.91ns|0.0129| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`ExecuteNonQuery`|net472|1.94μs|3.05ns|11.8ns|0.156| 0|0|987 B| |#5972|`ExecuteNonQuery`|net6.0|1.27μs|1.07ns|4.13ns|0.014| 0|0|1.02 KB| |#5972|`ExecuteNonQuery`|netcoreapp3.1|1.61μs|1.06ns|3.83ns|0.0135| 0|0|1.02 KB| |#5972|`ExecuteNonQuery`|net472|2.02μs|1.22ns|4.73ns|0.156| 0|0|987 B|
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`CallElasticsearch`|net6.0|1.25μs|0.672ns|2.6ns|0.0139| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`CallElasticsearch`|netcoreapp3.1|1.57μs|0.875ns|3.27ns|0.0125| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`CallElasticsearch`|net472|2.45μs|2.59ns|10ns|0.158| 0|0|995 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`CallElasticsearchAsync`|net6.0|1.22μs|0.494ns|1.85ns|0.0134| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`CallElasticsearchAsync`|netcoreapp3.1|1.61μs|0.607ns|2.27ns|0.0135| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`CallElasticsearchAsync`|net472|2.65μs|1.03ns|3.72ns|0.167| 0|0|1.05 KB| |#5972|`CallElasticsearch`|net6.0|1.29μs|1.34ns|5.19ns|0.0136| 0|0|976 B| |#5972|`CallElasticsearch`|netcoreapp3.1|1.51μs|0.706ns|2.64ns|0.0128| 0|0|976 B| |#5972|`CallElasticsearch`|net472|2.53μs|1.14ns|4.28ns|0.158| 0.00126|0|995 B| |#5972|`CallElasticsearchAsync`|net6.0|1.21μs|0.808ns|3.13ns|0.0133| 0|0|952 B| |#5972|`CallElasticsearchAsync`|netcoreapp3.1|1.62μs|0.649ns|2.34ns|0.014| 0|0|1.02 KB| |#5972|`CallElasticsearchAsync`|net472|2.53μs|1.19ns|4.46ns|0.167| 0|0|1.05 KB|
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`ExecuteAsync`|net6.0|1.25μs|0.983ns|3.68ns|0.0135| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`ExecuteAsync`|netcoreapp3.1|1.63μs|1.16ns|4.48ns|0.0129| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`ExecuteAsync`|net472|1.75μs|1.34ns|5.18ns|0.145| 0|0|915 B| |#5972|`ExecuteAsync`|net6.0|1.27μs|1.34ns|5.02ns|0.0133| 0|0|952 B| |#5972|`ExecuteAsync`|netcoreapp3.1|1.65μs|0.981ns|3.54ns|0.0124| 0|0|952 B| |#5972|`ExecuteAsync`|net472|1.74μs|1.48ns|5.72ns|0.145| 0.000869|0|915 B|
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`SendAsync`|net6.0|4.18μs|2.75ns|10.7ns|0.0312| 0|0|2.22 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`SendAsync`|netcoreapp3.1|5.11μs|1.72ns|6.19ns|0.0358| 0|0|2.76 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`SendAsync`|net472|7.69μs|1.37ns|5.12ns|0.5| 0|0|3.15 KB| |#5972|`SendAsync`|net6.0|4.29μs|3.39ns|13.1ns|0.03| 0|0|2.22 KB| |#5972|`SendAsync`|netcoreapp3.1|5.26μs|1.66ns|6.2ns|0.0363| 0|0|2.76 KB| |#5972|`SendAsync`|net472|7.8μs|1.51ns|5.83ns|0.499| 0|0|3.15 KB|
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`EnrichedLog`|net6.0|1.48μs|0.651ns|2.44ns|0.023| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`EnrichedLog`|netcoreapp3.1|2.27μs|1.16ns|4.48ns|0.0226| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`EnrichedLog`|net472|2.63μs|1.84ns|7.14ns|0.249| 0|0|1.57 KB| |#5972|`EnrichedLog`|net6.0|1.53μs|0.973ns|3.64ns|0.0229| 0|0|1.64 KB| |#5972|`EnrichedLog`|netcoreapp3.1|2.22μs|0.91ns|3.41ns|0.0218| 0|0|1.64 KB| |#5972|`EnrichedLog`|net472|2.66μs|2.01ns|7.77ns|0.249| 0|0|1.57 KB|
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`EnrichedLog`|net6.0|116μs|300ns|1.16μs|0| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`EnrichedLog`|netcoreapp3.1|119μs|189ns|708ns|0.0593| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`EnrichedLog`|net472|151μs|327ns|1.26μs|0.685| 0.228|0|4.46 KB| |#5972|`EnrichedLog`|net6.0|114μs|117ns|453ns|0.0568| 0|0|4.28 KB| |#5972|`EnrichedLog`|netcoreapp3.1|119μs|119ns|428ns|0.0595| 0|0|4.28 KB| |#5972|`EnrichedLog`|net472|149μs|210ns|814ns|0.676| 0.225|0|4.46 KB|
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`EnrichedLog`|net6.0|3.03μs|1.03ns|3.99ns|0.0302| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`EnrichedLog`|netcoreapp3.1|4.27μs|2.23ns|8.66ns|0.0303| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`EnrichedLog`|net472|5.06μs|1.35ns|5.24ns|0.321| 0|0|2.02 KB| |#5972|`EnrichedLog`|net6.0|3.05μs|1.53ns|5.91ns|0.0304| 0|0|2.2 KB| |#5972|`EnrichedLog`|netcoreapp3.1|4.04μs|1.62ns|6.27ns|0.0303| 0|0|2.2 KB| |#5972|`EnrichedLog`|net472|4.94μs|2.21ns|8.55ns|0.32| 0|0|2.02 KB|
Benchmarks.Trace.RedisBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #5972 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.RedisBenchmark.SendReceive‑netcoreapp3.1 | 1.127 | 1,695.96 | 1,911.60 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`SendReceive`|net6.0|1.43μs|1.25ns|4.85ns|0.0157| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`SendReceive`|netcoreapp3.1|1.7μs|0.98ns|3.67ns|0.0155| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`SendReceive`|net472|2.24μs|1.64ns|6.34ns|0.183| 0.0011|0|1.16 KB| |#5972|`SendReceive`|net6.0|1.4μs|0.776ns|3.01ns|0.0162| 0|0|1.14 KB| |#5972|`SendReceive`|netcoreapp3.1|1.91μs|1.14ns|4.42ns|0.0153| 0|0|1.14 KB| |#5972|`SendReceive`|net472|2.18μs|1.47ns|5.7ns|0.183| 0|0|1.16 KB|
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`EnrichedLog`|net6.0|2.68μs|0.594ns|2.14ns|0.0215| 0|0|1.6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`EnrichedLog`|netcoreapp3.1|3.84μs|1.24ns|4.65ns|0.0211| 0|0|1.65 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`EnrichedLog`|net472|4.42μs|2.44ns|9.47ns|0.323| 0|0|2.04 KB| |#5972|`EnrichedLog`|net6.0|2.65μs|0.878ns|3.4ns|0.0225| 0|0|1.6 KB| |#5972|`EnrichedLog`|netcoreapp3.1|3.91μs|4.06ns|14.6ns|0.0214| 0|0|1.65 KB| |#5972|`EnrichedLog`|net472|4.35μs|1.75ns|6.79ns|0.322| 0|0|2.04 KB|
Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`StartFinishSpan`|net6.0|394ns|0.368ns|1.43ns|0.00814| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`StartFinishSpan`|netcoreapp3.1|547ns|0.718ns|2.68ns|0.00782| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`StartFinishSpan`|net472|661ns|0.274ns|1.06ns|0.0918| 0|0|578 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`StartFinishScope`|net6.0|471ns|0.169ns|0.653ns|0.00989| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`StartFinishScope`|netcoreapp3.1|742ns|0.516ns|2ns|0.00932| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`StartFinishScope`|net472|854ns|1.11ns|4.31ns|0.104| 0|0|658 B| |#5972|`StartFinishSpan`|net6.0|399ns|0.269ns|1.04ns|0.00806| 0|0|576 B| |#5972|`StartFinishSpan`|netcoreapp3.1|588ns|0.367ns|1.42ns|0.00787| 0|0|576 B| |#5972|`StartFinishSpan`|net472|608ns|0.801ns|3.1ns|0.0917| 0|0|578 B| |#5972|`StartFinishScope`|net6.0|497ns|0.454ns|1.76ns|0.00969| 0|0|696 B| |#5972|`StartFinishScope`|netcoreapp3.1|779ns|0.813ns|3.15ns|0.00932| 0|0|696 B| |#5972|`StartFinishScope`|net472|897ns|0.87ns|3.37ns|0.104| 0|0|658 B|
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #5972 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 | 1.142 | 876.03 | 1,000.36 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`RunOnMethodBegin`|net6.0|665ns|0.486ns|1.88ns|0.00959| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`RunOnMethodBegin`|netcoreapp3.1|876ns|0.816ns|3.16ns|0.00929| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/01c50c300ba7919e6857655cb550bf486631507c)|`RunOnMethodBegin`|net472|1.12μs|1.26ns|4.86ns|0.104| 0|0|658 B| |#5972|`RunOnMethodBegin`|net6.0|686ns|0.927ns|3.59ns|0.00966| 0|0|696 B| |#5972|`RunOnMethodBegin`|netcoreapp3.1|1μs|1.35ns|5.05ns|0.00923| 0|0|696 B| |#5972|`RunOnMethodBegin`|net472|1.05μs|1.01ns|3.91ns|0.104| 0|0|658 B|