DataDog / dd-trace-dotnet

.NET Client Library for Datadog APM
https://docs.datadoghq.com/tracing/
Apache License 2.0
437 stars 137 forks source link

Add `linux-musl-arm64` standalone `dd-trace` to the v3 release artifacts #5974

Closed andrewlock closed 3 weeks ago

andrewlock commented 4 weeks ago

Summary of changes

Includes the alpine arm64 standalone runner in the release artifacts

Reason for change

We include standalone artifacts for dd-trace for win-x64, linux-x64, linux-arm64, linux-musl-x64. Now we have linux-musl-arm64 too, which is required for customers troubleshooting alpine arm64 issues.

Implementation details

Just include it in the release automatically, we already build it. I manually added it to the 3.2.0 release.

Test coverage

Nope, we'll just need to check the next release to make sure it's there

datadog-ddstaging[bot] commented 4 weeks ago

Datadog Report

Branch report: andrew/ci/update-release Commit report: 9f4b5b2 Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 360807 Passed, 2058 Skipped, 15h 10m 10.04s Total Time :snowflake: 1 New Flaky

New Flaky Tests (1)

andrewlock commented 4 weeks ago

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5974) - mean (70ms)  : 67, 74
     .   : milestone, 70,
    master - mean (78ms)  : 72, 84
     .   : milestone, 78,

    section CallTarget+Inlining+NGEN
    This PR (5974) - mean (1,079ms)  : 1060, 1099
     .   : milestone, 1079,
    master - mean (1,112ms)  : 1072, 1151
     .   : milestone, 1112,
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5974) - mean (109ms)  : 107, 111
     .   : milestone, 109,
    master - mean (122ms)  : 113, 131
     .   : milestone, 122,

    section CallTarget+Inlining+NGEN
    This PR (5974) - mean (751ms)  : 733, 768
     .   : milestone, 751,
    master - mean (797ms)  : 757, 838
     .   : milestone, 797,
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5974) - mean (93ms)  : 90, 96
     .   : milestone, 93,
    master - mean (103ms)  : 93, 113
     .   : milestone, 103,

    section CallTarget+Inlining+NGEN
    This PR (5974) - mean (704ms)  : 689, 719
     .   : milestone, 704,
    master - mean (749ms)  : 724, 773
     .   : milestone, 749,
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5974) - mean (190ms)  : 187, 193
     .   : milestone, 190,
    master - mean (191ms)  : 187, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (5974) - mean (1,159ms)  : 1139, 1179
     .   : milestone, 1159,
    master - mean (1,151ms)  : 1123, 1179
     .   : milestone, 1151,
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5974) - mean (276ms)  : 271, 280
     .   : milestone, 276,
    master - mean (275ms)  : 271, 279
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (5974) - mean (918ms)  : 899, 937
     .   : milestone, 918,
    master - mean (912ms)  : 895, 928
     .   : milestone, 912,
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5974) - mean (266ms)  : 261, 270
     .   : milestone, 266,
    master - mean (264ms)  : 261, 268
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (5974) - mean (901ms)  : 878, 924
     .   : milestone, 901,
    master - mean (898ms)  : 880, 916
     .   : milestone, 898,
andrewlock commented 4 weeks ago

Benchmarks Report for tracer :snail:

Benchmarks for #5974 compared to master:

The following thresholds were used for comparing the benchmark speeds:

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`StartStopWithChild`|net6.0|7.74μs|42.5ns|241ns|0.0156| 0.00779|0|5.43 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`StartStopWithChild`|netcoreapp3.1|10.1μs|54.4ns|313ns|0.0148| 0.00493|0|5.61 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`StartStopWithChild`|net472|15.8μs|36.5ns|141ns|1.02| 0.304|0.101|6.07 KB| |#5974|`StartStopWithChild`|net6.0|7.83μs|44.6ns|309ns|0.016| 0.00799|0|5.43 KB| |#5974|`StartStopWithChild`|netcoreapp3.1|9.76μs|48ns|225ns|0.0142| 0.00473|0|5.62 KB| |#5974|`StartStopWithChild`|net472|16.2μs|64.5ns|250ns|1.03| 0.315|0.089|6.06 KB|
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`WriteAndFlushEnrichedTraces`|net6.0|492μs|432ns|1.67μs|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|652μs|177ns|685ns|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`WriteAndFlushEnrichedTraces`|net472|840μs|450ns|1.74μs|0.419| 0|0|3.3 KB| |#5974|`WriteAndFlushEnrichedTraces`|net6.0|460μs|211ns|816ns|0| 0|0|2.7 KB| |#5974|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|644μs|348ns|1.3μs|0| 0|0|2.7 KB| |#5974|`WriteAndFlushEnrichedTraces`|net472|858μs|682ns|2.64μs|0.425| 0|0|3.3 KB|
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`SendRequest`|net6.0|189μs|1.07μs|9.39μs|0.268| 0|0|18.45 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`SendRequest`|netcoreapp3.1|216μs|1.22μs|8.95μs|0.204| 0|0|20.61 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`SendRequest`|net472|0.00102ns|0.00043ns|0.00161ns|0| 0|0|0 b| |#5974|`SendRequest`|net6.0|191μs|1.06μs|6.98μs|0.197| 0|0|18.45 KB| |#5974|`SendRequest`|netcoreapp3.1|218μs|1.18μs|8.75μs|0.196| 0|0|20.61 KB| |#5974|`SendRequest`|net472|0.00225ns|0.00079ns|0.00306ns|0| 0|0|0 b|
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`WriteAndFlushEnrichedTraces`|net6.0|568μs|2.84μs|13μs|0.546| 0|0|41.63 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|667μs|2.2μs|8.54μs|0.338| 0|0|41.85 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`WriteAndFlushEnrichedTraces`|net472|878μs|2.55μs|9.55μs|8.36| 2.64|0.44|53.35 KB| |#5974|`WriteAndFlushEnrichedTraces`|net6.0|555μs|3.03μs|16.9μs|0.534| 0|0|41.47 KB| |#5974|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|690μs|3.88μs|26μs|0.342| 0|0|41.84 KB| |#5974|`WriteAndFlushEnrichedTraces`|net472|869μs|3.13μs|11.7μs|8.19| 2.59|0.431|53.3 KB|
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`ExecuteNonQuery`|net6.0|1.28μs|1.1ns|4.25ns|0.0141| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`ExecuteNonQuery`|netcoreapp3.1|1.75μs|1.12ns|4.34ns|0.014| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`ExecuteNonQuery`|net472|2.05μs|3.73ns|14.5ns|0.156| 0|0|987 B| |#5974|`ExecuteNonQuery`|net6.0|1.21μs|0.83ns|3.22ns|0.0142| 0|0|1.02 KB| |#5974|`ExecuteNonQuery`|netcoreapp3.1|1.65μs|1.09ns|4.21ns|0.0133| 0|0|1.02 KB| |#5974|`ExecuteNonQuery`|net472|2.1μs|1.59ns|5.94ns|0.157| 0|0|987 B|
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`CallElasticsearch`|net6.0|1.29μs|0.412ns|1.6ns|0.0136| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`CallElasticsearch`|netcoreapp3.1|1.55μs|1.16ns|4.48ns|0.0132| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`CallElasticsearch`|net472|2.41μs|0.959ns|3.71ns|0.158| 0|0|995 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`CallElasticsearchAsync`|net6.0|1.27μs|0.626ns|2.34ns|0.0133| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`CallElasticsearchAsync`|netcoreapp3.1|1.69μs|1.71ns|6.39ns|0.0135| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`CallElasticsearchAsync`|net472|2.68μs|1.55ns|6.02ns|0.167| 0|0|1.05 KB| |#5974|`CallElasticsearch`|net6.0|1.25μs|1.91ns|7.15ns|0.0136| 0|0|976 B| |#5974|`CallElasticsearch`|netcoreapp3.1|1.55μs|0.954ns|3.57ns|0.0132| 0|0|976 B| |#5974|`CallElasticsearch`|net472|2.46μs|1.65ns|6.41ns|0.158| 0|0|995 B| |#5974|`CallElasticsearchAsync`|net6.0|1.23μs|0.95ns|3.68ns|0.0135| 0|0|952 B| |#5974|`CallElasticsearchAsync`|netcoreapp3.1|1.61μs|0.559ns|2.09ns|0.0137| 0|0|1.02 KB| |#5974|`CallElasticsearchAsync`|net472|2.71μs|2.22ns|8.58ns|0.167| 0|0|1.05 KB|
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`ExecuteAsync`|net6.0|1.21μs|0.968ns|3.62ns|0.0133| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`ExecuteAsync`|netcoreapp3.1|1.6μs|1.33ns|4.99ns|0.0128| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`ExecuteAsync`|net472|1.83μs|0.785ns|2.94ns|0.145| 0|0|915 B| |#5974|`ExecuteAsync`|net6.0|1.24μs|0.941ns|3.26ns|0.0131| 0|0|952 B| |#5974|`ExecuteAsync`|netcoreapp3.1|1.65μs|5.55ns|21.5ns|0.0124| 0|0|952 B| |#5974|`ExecuteAsync`|net472|1.73μs|1.11ns|4.3ns|0.145| 0|0|915 B|
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`SendAsync`|net6.0|4.12μs|0.763ns|2.75ns|0.031| 0|0|2.22 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`SendAsync`|netcoreapp3.1|4.95μs|1.79ns|6.93ns|0.0372| 0|0|2.76 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`SendAsync`|net472|7.9μs|1.67ns|6.27ns|0.5| 0|0|3.15 KB| |#5974|`SendAsync`|net6.0|4.12μs|0.912ns|3.41ns|0.0311| 0|0|2.22 KB| |#5974|`SendAsync`|netcoreapp3.1|5.1μs|1.88ns|7.05ns|0.0383| 0|0|2.76 KB| |#5974|`SendAsync`|net472|7.72μs|1.44ns|5.58ns|0.498| 0|0|3.15 KB|
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`EnrichedLog`|net6.0|1.46μs|0.487ns|1.89ns|0.0227| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`EnrichedLog`|netcoreapp3.1|2.27μs|1.28ns|4.95ns|0.0227| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`EnrichedLog`|net472|2.62μs|1.95ns|7.29ns|0.25| 0|0|1.57 KB| |#5974|`EnrichedLog`|net6.0|1.48μs|0.891ns|3.33ns|0.0229| 0|0|1.64 KB| |#5974|`EnrichedLog`|netcoreapp3.1|2.28μs|0.959ns|3.71ns|0.0218| 0|0|1.64 KB| |#5974|`EnrichedLog`|net472|2.9μs|2.13ns|7.97ns|0.249| 0|0|1.57 KB|
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`EnrichedLog`|net6.0|117μs|187ns|725ns|0| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`EnrichedLog`|netcoreapp3.1|121μs|276ns|1.07μs|0| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`EnrichedLog`|net472|150μs|349ns|1.35μs|0.673| 0.224|0|4.46 KB| |#5974|`EnrichedLog`|net6.0|118μs|230ns|892ns|0.0587| 0|0|4.28 KB| |#5974|`EnrichedLog`|netcoreapp3.1|118μs|113ns|423ns|0.0591| 0|0|4.28 KB| |#5974|`EnrichedLog`|net472|151μs|235ns|910ns|0.676| 0.225|0|4.46 KB|
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`EnrichedLog`|net6.0|3μs|0.446ns|1.67ns|0.0301| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`EnrichedLog`|netcoreapp3.1|4.18μs|1.52ns|5.88ns|0.0299| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`EnrichedLog`|net472|4.81μs|1.2ns|4.66ns|0.319| 0|0|2.02 KB| |#5974|`EnrichedLog`|net6.0|2.9μs|0.516ns|1.86ns|0.0306| 0|0|2.2 KB| |#5974|`EnrichedLog`|netcoreapp3.1|4.15μs|1.4ns|5.23ns|0.0291| 0|0|2.2 KB| |#5974|`EnrichedLog`|net472|4.84μs|1.23ns|4.62ns|0.319| 0|0|2.02 KB|
Benchmarks.Trace.RedisBenchmark - Faster :tada: Same allocations :heavy_check_mark: #### Faster :tada: in #5974 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0 | 1.130 | 1,451.85 | 1,285.19 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`SendReceive`|net6.0|1.45μs|0.682ns|2.55ns|0.016| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`SendReceive`|netcoreapp3.1|1.68μs|1.84ns|7.14ns|0.0152| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`SendReceive`|net472|2.27μs|2.17ns|8.39ns|0.183| 0.00113|0|1.16 KB| |#5974|`SendReceive`|net6.0|1.29μs|0.48ns|1.8ns|0.0161| 0|0|1.14 KB| |#5974|`SendReceive`|netcoreapp3.1|1.82μs|1.11ns|4.28ns|0.0155| 0|0|1.14 KB| |#5974|`SendReceive`|net472|2.1μs|1.58ns|5.92ns|0.183| 0|0|1.16 KB|
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`EnrichedLog`|net6.0|2.6μs|1.28ns|4.95ns|0.0218| 0|0|1.6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`EnrichedLog`|netcoreapp3.1|3.92μs|1.52ns|5.67ns|0.0216| 0|0|1.65 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`EnrichedLog`|net472|4.33μs|2.21ns|7.67ns|0.322| 0|0|2.04 KB| |#5974|`EnrichedLog`|net6.0|2.67μs|1.09ns|3.91ns|0.0214| 0|0|1.6 KB| |#5974|`EnrichedLog`|netcoreapp3.1|3.91μs|1.24ns|4.8ns|0.0215| 0|0|1.65 KB| |#5974|`EnrichedLog`|net472|4.44μs|1.73ns|6.7ns|0.323| 0|0|2.04 KB|
Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #5974 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 | 1.147 | 558.82 | 640.85 | | Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 | 1.116 | 672.77 | 750.58 | #### Faster :tada: in #5974 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 | 1.146 | 709.78 | 619.39 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`StartFinishSpan`|net6.0|395ns|0.292ns|1.13ns|0.00817| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`StartFinishSpan`|netcoreapp3.1|559ns|0.488ns|1.89ns|0.00775| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`StartFinishSpan`|net472|711ns|1.12ns|4.35ns|0.0915| 0|0|578 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`StartFinishScope`|net6.0|475ns|0.481ns|1.86ns|0.00985| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`StartFinishScope`|netcoreapp3.1|672ns|0.606ns|2.35ns|0.00922| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`StartFinishScope`|net472|854ns|0.9ns|3.49ns|0.105| 0|0|658 B| |#5974|`StartFinishSpan`|net6.0|392ns|0.265ns|1.03ns|0.00815| 0|0|576 B| |#5974|`StartFinishSpan`|netcoreapp3.1|641ns|0.579ns|2.17ns|0.0076| 0|0|576 B| |#5974|`StartFinishSpan`|net472|620ns|1.22ns|4.71ns|0.0916| 0|0|578 B| |#5974|`StartFinishScope`|net6.0|484ns|0.42ns|1.63ns|0.00965| 0|0|696 B| |#5974|`StartFinishScope`|netcoreapp3.1|750ns|0.903ns|3.5ns|0.00932| 0|0|696 B| |#5974|`StartFinishScope`|net472|891ns|0.908ns|3.52ns|0.104| 0|0|658 B|
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster :tada: Same allocations :heavy_check_mark: #### Faster :tada: in #5974 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.120 | 679.41 | 606.35 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`RunOnMethodBegin`|net6.0|680ns|0.458ns|1.71ns|0.00954| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`RunOnMethodBegin`|netcoreapp3.1|840ns|0.569ns|2.2ns|0.00964| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/263c9889144df0dc261b28fe950afd77dc5abdad)|`RunOnMethodBegin`|net472|1.11μs|1.13ns|4.38ns|0.104| 0|0|658 B| |#5974|`RunOnMethodBegin`|net6.0|606ns|0.555ns|2.15ns|0.00965| 0|0|696 B| |#5974|`RunOnMethodBegin`|netcoreapp3.1|893ns|0.751ns|2.91ns|0.00939| 0|0|696 B| |#5974|`RunOnMethodBegin`|net472|1.11μs|1.29ns|4.99ns|0.104| 0|0|658 B|