Closed gleocadie closed 2 months ago
Branch report: gleocadie/add-blocking-thread-name
Commit report: 0378b3b
Test service: dd-trace-dotnet
:white_check_mark: 0 Failed, 359081 Passed, 2324 Skipped, 16h 7m 43.16s Total Time
Execution-time results for samples comparing the following branches/commits:
Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.
Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).
gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5981) - mean (71ms) : 67, 75
. : milestone, 71,
master - mean (70ms) : 67, 74
. : milestone, 70,
section CallTarget+Inlining+NGEN
This PR (5981) - mean (1,080ms) : 1056, 1104
. : milestone, 1080,
master - mean (1,080ms) : 1058, 1103
. : milestone, 1080,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5981) - mean (110ms) : 105, 115
. : milestone, 110,
master - mean (110ms) : 106, 115
. : milestone, 110,
section CallTarget+Inlining+NGEN
This PR (5981) - mean (755ms) : 739, 771
. : milestone, 755,
master - mean (762ms) : 735, 790
. : milestone, 762,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5981) - mean (94ms) : 89, 98
. : milestone, 94,
master - mean (93ms) : 90, 95
. : milestone, 93,
section CallTarget+Inlining+NGEN
This PR (5981) - mean (710ms) : 693, 727
. : milestone, 710,
master - mean (708ms) : 685, 731
. : milestone, 708,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5981) - mean (191ms) : 187, 194
. : milestone, 191,
master - mean (190ms) : 187, 193
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (5981) - mean (1,163ms) : 1139, 1188
. : milestone, 1163,
master - mean (1,162ms) : 1131, 1193
. : milestone, 1162,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5981) - mean (275ms) : 272, 279
. : milestone, 275,
master - mean (276ms) : 271, 281
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (5981) - mean (923ms) : 893, 953
. : milestone, 923,
master - mean (916ms) : 899, 932
. : milestone, 916,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5981) - mean (265ms) : 260, 270
. : milestone, 265,
master - mean (265ms) : 261, 269
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (5981) - mean (907ms) : 885, 929
. : milestone, 907,
master - mean (904ms) : 885, 922
. : milestone, 904,
Benchmarks for #5981 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored.
Summary of changes
Add the
blocking thread name
as tag on sample.Reason for change
In a previous PR, we provide the
blocking thread id
only. The backend would need the name to display something useful.Implementation details
Add and propagate the blocking thread name.
Test coverage
Update the current test.
Other details