search

DataDog / dd-trace-dotnet

.NET Client Library for Datadog APM
https://docs.datadoghq.com/tracing/
Apache License 2.0
437 stars 137 forks source link

Version Bump to 2.58.1 #5983

Closed andrewlock closed 3 weeks ago

andrewlock commented 3 weeks ago

Summary of changes

Bump the version to 2.58.1

Reason for change

We just released 2.58.0, but there was an issue with the SSI artifacts, so doing a patch release so we can update them (we can't release new artifacts for old code)

Implementation details

# reset 2.59.0 to 2.58.0
.\tracer\build.ps1 UpdateVersion -NewVersion 2.58.0 -NewIsPrerelease false
# update 2.58.0 to 2.58.1
.\tracer\build.ps1 UpdateVersion -NewVersion 2.58.1 -NewIsPrerelease false

Test coverage

Meh

Other details

We could/should do a hotfix, but as there's nothing else in this branch yet, this seems simpler to reason about

datadog-ddstaging[bot] commented 3 weeks ago

Datadog Report

Branch report: andrew/bump-version-to-2-58-1 Commit report: ebc8961 Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 356977 Passed, 2587 Skipped, 24h 13m 1.73s Total Time

andrewlock commented 3 weeks ago

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5983) - mean (76ms)  : 68, 83
     .   : milestone, 76,
    master - mean (70ms)  : 66, 73
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (5983) - mean (1,038ms)  : 1005, 1072
     .   : milestone, 1038,
    master - mean (1,073ms)  : 1048, 1097
     .   : milestone, 1073,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5983) - mean (112ms)  : 106, 118
     .   : milestone, 112,
    master - mean (109ms)  : 105, 113
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5983) - mean (731ms)  : 703, 759
     .   : milestone, 731,
    master - mean (753ms)  : 728, 777
     .   : milestone, 753,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5983) - mean (94ms)  : 91, 97
     .   : milestone, 94,
    master - mean (92ms)  : 89, 95
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (5983) - mean (678ms)  : 651, 706
     .   : milestone, 678,
    master - mean (701ms)  : 684, 718
     .   : milestone, 701,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5983) - mean (190ms)  : 187, 194
     .   : milestone, 190,
    master - mean (191ms)  : 188, 194
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (5983) - mean (1,111ms)  : 1085, 1137
     .   : milestone, 1111,
    master - mean (1,158ms)  : 1137, 1178
     .   : milestone, 1158,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5983) - mean (276ms)  : 270, 282
     .   : milestone, 276,
    master - mean (275ms)  : 271, 279
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (5983) - mean (881ms)  : 862, 901
     .   : milestone, 881,
    master - mean (919ms)  : 903, 936
     .   : milestone, 919,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5983) - mean (265ms)  : 260, 270
     .   : milestone, 265,
    master - mean (264ms)  : 260, 267
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (5983) - mean (873ms)  : 846, 899
     .   : milestone, 873,
    master - mean (904ms)  : 875, 932
     .   : milestone, 904,
andrewlock commented 3 weeks ago

Benchmarks Report for tracer :snail:

Benchmarks for #5983 compared to master:

The following thresholds were used for comparing the benchmark speeds:

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`StartStopWithChild`|net6.0|7.51μs|42.9ns|330ns|0.0179| 0.00717|0|5.42 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`StartStopWithChild`|netcoreapp3.1|9.8μs|53.6ns|308ns|0.0184| 0.00921|0|5.61 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`StartStopWithChild`|net472|16μs|50.7ns|196ns|1.03| 0.305|0.0939|6.07 KB| |#5983|`StartStopWithChild`|net6.0|7.69μs|42.7ns|302ns|0.0151| 0.00753|0|5.43 KB| |#5983|`StartStopWithChild`|netcoreapp3.1|9.75μs|49ns|219ns|0.0147| 0.0049|0|5.62 KB| |#5983|`StartStopWithChild`|net472|15.9μs|45.7ns|177ns|1.02| 0.312|0.0935|6.07 KB|
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`WriteAndFlushEnrichedTraces`|net6.0|471μs|463ns|1.79μs|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|643μs|318ns|1.23μs|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`WriteAndFlushEnrichedTraces`|net472|839μs|739ns|2.86μs|0.419| 0|0|3.3 KB| |#5983|`WriteAndFlushEnrichedTraces`|net6.0|477μs|186ns|671ns|0| 0|0|2.7 KB| |#5983|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|644μs|312ns|1.17μs|0| 0|0|2.7 KB| |#5983|`WriteAndFlushEnrichedTraces`|net472|833μs|549ns|2.13μs|0.417| 0|0|3.3 KB|
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`SendRequest`|net6.0|200μs|1.12μs|7.46μs|0.204| 0|0|18.45 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`SendRequest`|netcoreapp3.1|230μs|1.35μs|13.3μs|0.209| 0|0|20.61 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`SendRequest`|net472|0ns|0ns|0ns|0| 0|0|0 b| |#5983|`SendRequest`|net6.0|203μs|1.21μs|11.9μs|0.193| 0|0|18.45 KB| |#5983|`SendRequest`|netcoreapp3.1|224μs|1.22μs|7.1μs|0.222| 0|0|20.61 KB| |#5983|`SendRequest`|net472|0.00337ns|0.0012ns|0.00464ns|0| 0|0|0 b|
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`WriteAndFlushEnrichedTraces`|net6.0|579μs|3.26μs|21.1μs|0.571| 0|0|41.66 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|695μs|3.74μs|20.8μs|0.342| 0|0|41.76 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`WriteAndFlushEnrichedTraces`|net472|860μs|3.85μs|14.9μs|8.39| 2.52|0.419|53.3 KB| |#5983|`WriteAndFlushEnrichedTraces`|net6.0|574μs|2.7μs|15.1μs|0.581| 0|0|41.56 KB| |#5983|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|707μs|3.84μs|22.4μs|0.357| 0|0|41.78 KB| |#5983|`WriteAndFlushEnrichedTraces`|net472|881μs|2.97μs|11.5μs|8.3| 2.62|0.437|53.34 KB|
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`ExecuteNonQuery`|net6.0|1.29μs|1.42ns|5.51ns|0.0142| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`ExecuteNonQuery`|netcoreapp3.1|1.76μs|1.51ns|5.87ns|0.0141| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`ExecuteNonQuery`|net472|1.98μs|1.54ns|5.97ns|0.157| 0|0|987 B| |#5983|`ExecuteNonQuery`|net6.0|1.27μs|1.92ns|7.43ns|0.0139| 0|0|1.02 KB| |#5983|`ExecuteNonQuery`|netcoreapp3.1|1.68μs|4.19ns|16.2ns|0.0134| 0|0|1.02 KB| |#5983|`ExecuteNonQuery`|net472|2.03μs|1.47ns|5.7ns|0.156| 0|0|987 B|
Benchmarks.Trace.ElasticsearchBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #5983 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 | 1.192 | 1,184.50 | 1,412.40 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`CallElasticsearch`|net6.0|1.18μs|0.484ns|1.81ns|0.0136| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`CallElasticsearch`|netcoreapp3.1|1.47μs|1.14ns|4.13ns|0.0136| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`CallElasticsearch`|net472|2.45μs|2.17ns|8.41ns|0.158| 0|0|995 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`CallElasticsearchAsync`|net6.0|1.3μs|0.457ns|1.71ns|0.0137| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`CallElasticsearchAsync`|netcoreapp3.1|1.68μs|0.739ns|2.86ns|0.0135| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`CallElasticsearchAsync`|net472|2.53μs|1.96ns|7.59ns|0.167| 0|0|1.05 KB| |#5983|`CallElasticsearch`|net6.0|1.41μs|0.691ns|2.58ns|0.0135| 0|0|976 B| |#5983|`CallElasticsearch`|netcoreapp3.1|1.48μs|0.566ns|2.19ns|0.0134| 0|0|976 B| |#5983|`CallElasticsearch`|net472|2.49μs|2.51ns|9.71ns|0.158| 0|0|995 B| |#5983|`CallElasticsearchAsync`|net6.0|1.29μs|0.457ns|1.71ns|0.0136| 0|0|952 B| |#5983|`CallElasticsearchAsync`|netcoreapp3.1|1.6μs|1.13ns|4.36ns|0.0139| 0|0|1.02 KB| |#5983|`CallElasticsearchAsync`|net472|2.71μs|1.84ns|6.9ns|0.166| 0|0|1.05 KB|
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`ExecuteAsync`|net6.0|1.22μs|0.964ns|3.61ns|0.013| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`ExecuteAsync`|netcoreapp3.1|1.66μs|0.872ns|3.26ns|0.0125| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`ExecuteAsync`|net472|1.72μs|0.52ns|1.95ns|0.145| 0|0|915 B| |#5983|`ExecuteAsync`|net6.0|1.18μs|0.417ns|1.61ns|0.0137| 0|0|952 B| |#5983|`ExecuteAsync`|netcoreapp3.1|1.65μs|1.36ns|5.27ns|0.0132| 0|0|952 B| |#5983|`ExecuteAsync`|net472|1.78μs|1.38ns|5.35ns|0.145| 0|0|915 B|
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`SendAsync`|net6.0|4.24μs|3.77ns|14.1ns|0.0299| 0|0|2.22 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`SendAsync`|netcoreapp3.1|5.09μs|1.99ns|7.71ns|0.0378| 0|0|2.76 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`SendAsync`|net472|7.9μs|2.09ns|8.1ns|0.498| 0|0|3.15 KB| |#5983|`SendAsync`|net6.0|4.12μs|1.76ns|6.58ns|0.0309| 0|0|2.22 KB| |#5983|`SendAsync`|netcoreapp3.1|5.18μs|2.24ns|8.39ns|0.0361| 0|0|2.76 KB| |#5983|`SendAsync`|net472|7.76μs|3.73ns|14.4ns|0.499| 0|0|3.15 KB|
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`EnrichedLog`|net6.0|1.54μs|0.988ns|3.7ns|0.0231| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`EnrichedLog`|netcoreapp3.1|2.39μs|0.726ns|2.62ns|0.0212| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`EnrichedLog`|net472|2.74μs|1.18ns|4.4ns|0.249| 0|0|1.57 KB| |#5983|`EnrichedLog`|net6.0|1.49μs|0.936ns|3.63ns|0.0231| 0|0|1.64 KB| |#5983|`EnrichedLog`|netcoreapp3.1|2.36μs|1ns|3.75ns|0.0212| 0|0|1.64 KB| |#5983|`EnrichedLog`|net472|2.61μs|2.66ns|10.3ns|0.249| 0|0|1.57 KB|
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`EnrichedLog`|net6.0|116μs|286ns|1.11μs|0.0576| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`EnrichedLog`|netcoreapp3.1|121μs|223ns|864ns|0| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`EnrichedLog`|net472|149μs|210ns|815ns|0.673| 0.224|0|4.46 KB| |#5983|`EnrichedLog`|net6.0|115μs|201ns|778ns|0.0573| 0|0|4.28 KB| |#5983|`EnrichedLog`|netcoreapp3.1|121μs|129ns|498ns|0| 0|0|4.28 KB| |#5983|`EnrichedLog`|net472|148μs|274ns|1.06μs|0.665| 0.222|0|4.46 KB|
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`EnrichedLog`|net6.0|2.98μs|1.38ns|5.15ns|0.0314| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`EnrichedLog`|netcoreapp3.1|4.19μs|1.51ns|5.86ns|0.0295| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`EnrichedLog`|net472|4.87μs|0.997ns|3.86ns|0.321| 0|0|2.02 KB| |#5983|`EnrichedLog`|net6.0|3.08μs|9.79ns|37.9ns|0.0304| 0|0|2.2 KB| |#5983|`EnrichedLog`|netcoreapp3.1|4.32μs|1.51ns|5.85ns|0.0303| 0|0|2.2 KB| |#5983|`EnrichedLog`|net472|4.81μs|1.16ns|4.48ns|0.319| 0|0|2.02 KB|
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`SendReceive`|net6.0|1.43μs|0.792ns|3.07ns|0.0157| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`SendReceive`|netcoreapp3.1|1.73μs|0.846ns|3.28ns|0.0155| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`SendReceive`|net472|2.14μs|1.57ns|6.07ns|0.183| 0|0|1.16 KB| |#5983|`SendReceive`|net6.0|1.35μs|0.861ns|3.33ns|0.0163| 0|0|1.14 KB| |#5983|`SendReceive`|netcoreapp3.1|1.78μs|0.861ns|3.34ns|0.0151| 0|0|1.14 KB| |#5983|`SendReceive`|net472|2.08μs|1.97ns|7.64ns|0.183| 0.00103|0|1.16 KB|
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`EnrichedLog`|net6.0|2.65μs|1.02ns|3.82ns|0.0219| 0|0|1.6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`EnrichedLog`|netcoreapp3.1|4.08μs|2.46ns|9.52ns|0.0222| 0|0|1.65 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`EnrichedLog`|net472|4.47μs|3.97ns|15.4ns|0.323| 0|0|2.04 KB| |#5983|`EnrichedLog`|net6.0|2.77μs|0.954ns|3.57ns|0.0222| 0|0|1.6 KB| |#5983|`EnrichedLog`|netcoreapp3.1|3.92μs|2.9ns|11.2ns|0.0216| 0|0|1.65 KB| |#5983|`EnrichedLog`|net472|4.43μs|3.94ns|15.3ns|0.324| 0|0|2.04 KB|
Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #5983 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 | 1.180 | 468.56 | 553.01 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`StartFinishSpan`|net6.0|402ns|0.365ns|1.41ns|0.00811| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`StartFinishSpan`|netcoreapp3.1|590ns|0.261ns|1.01ns|0.00783| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`StartFinishSpan`|net472|631ns|0.639ns|2.48ns|0.0915| 0|0|578 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`StartFinishScope`|net6.0|469ns|0.244ns|0.943ns|0.0098| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`StartFinishScope`|netcoreapp3.1|701ns|0.53ns|2.05ns|0.0094| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`StartFinishScope`|net472|851ns|1.09ns|4.24ns|0.104| 0|0|658 B| |#5983|`StartFinishSpan`|net6.0|417ns|0.308ns|1.19ns|0.00811| 0|0|576 B| |#5983|`StartFinishSpan`|netcoreapp3.1|583ns|0.704ns|2.73ns|0.00776| 0|0|576 B| |#5983|`StartFinishSpan`|net472|578ns|0.614ns|2.38ns|0.0917| 0|0|578 B| |#5983|`StartFinishScope`|net6.0|554ns|0.686ns|2.66ns|0.00971| 0|0|696 B| |#5983|`StartFinishScope`|netcoreapp3.1|728ns|0.779ns|2.91ns|0.00943| 0|0|696 B| |#5983|`StartFinishScope`|net472|781ns|0.83ns|3.1ns|0.104| 0|0|658 B|
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`RunOnMethodBegin`|net6.0|637ns|0.692ns|2.68ns|0.00984| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`RunOnMethodBegin`|netcoreapp3.1|952ns|0.343ns|1.28ns|0.00931| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/d1e7fc37a5c0dce194cb362d5c92501ba31403d6)|`RunOnMethodBegin`|net472|1.08μs|1.67ns|6.46ns|0.104| 0|0|658 B| |#5983|`RunOnMethodBegin`|net6.0|596ns|0.48ns|1.86ns|0.00964| 0|0|696 B| |#5983|`RunOnMethodBegin`|netcoreapp3.1|918ns|0.402ns|1.56ns|0.00907| 0|0|696 B| |#5983|`RunOnMethodBegin`|net472|1.11μs|0.998ns|3.6ns|0.104| 0|0|658 B|