andrewlock
commented
3 weeks ago Execution-Time Benchmarks Report :stopwatch:
Execution-time results for samples comparing the following branches/commits:
Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
- Welch test with statistical test for significance of 5%
- Only results indicating a difference greater than 5% and 5 ms are considered.
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.
Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).
gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5985) - mean (70ms) : 67, 73
. : milestone, 70,
master - mean (69ms) : 67, 71
. : milestone, 69,
section CallTarget+Inlining+NGEN
This PR (5985) - mean (1,085ms) : 1055, 1114
. : milestone, 1085,
master - mean (1,077ms) : 1053, 1101
. : milestone, 1077,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5985) - mean (109ms) : 104, 115
. : milestone, 109,
master - mean (109ms) : 105, 112
. : milestone, 109,
section CallTarget+Inlining+NGEN
This PR (5985) - mean (762ms) : 746, 778
. : milestone, 762,
master - mean (758ms) : 739, 778
. : milestone, 758,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5985) - mean (93ms) : 89, 96
. : milestone, 93,
master - mean (92ms) : 90, 95
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (5985) - mean (712ms) : 690, 733
. : milestone, 712,
master - mean (710ms) : 697, 724
. : milestone, 710,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5985) - mean (190ms) : 187, 193
. : milestone, 190,
master - mean (190ms) : 187, 192
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (5985) - mean (1,159ms) : 1126, 1192
. : milestone, 1159,
master - mean (1,160ms) : 1137, 1184
. : milestone, 1160,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5985) - mean (275ms) : 269, 281
. : milestone, 275,
master - mean (274ms) : 270, 279
. : milestone, 274,
section CallTarget+Inlining+NGEN
This PR (5985) - mean (920ms) : 903, 938
. : milestone, 920,
master - mean (922ms) : 902, 942
. : milestone, 922,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5985) - mean (263ms) : 259, 268
. : milestone, 263,
master - mean (264ms) : 259, 268
. : milestone, 264,
section CallTarget+Inlining+NGEN
This PR (5985) - mean (906ms) : 885, 928
. : milestone, 906,
master - mean (902ms) : 883, 922
. : milestone, 902,
datadog-ddstaging[bot]
Summary of changes
Explicitly check for
S_OKwhen callingGetModuleMetadata.Reason for change
GetModuleMetadatacan returnS_FALSE(one known case is if the module is a resource, but there might be other). We've been using theSUCCEEDED/FAILEDmacros to check the error code, butS_FALSEis not considered as an error so we would mistakenly assume that the call succeeded.Implementation details
Note that I only updated the error checks. There are a couple of places where we call
GetModuleMetadatawithout checking the error code, I haven't touched those.For
GetModuleInterfacesin IAST, I also moved the call toReleaseto only do it if the call succeeded.