[Profiler/CI] Disable Profiler Windows ASAN job

gleocadie commented 3 weeks ago

Summary of changes

Disable Windows ASAN job.

Reason for change

After investigating, it seems that the current version of VS on the runner has a bug in the linker for ASAN. This has been fixed in recent updates but it's a PITA. Since we do not have windows specific code for now, we can just disable and come back to it later if it's needed.

The common code (windows/linux) will be exercised by ASAN Linux.

Implementation details

add condition: false on the job

Test coverage

Other details

datadog-ddstaging[bot] commented 3 weeks ago

Datadog Report

Branch report: gleocadie/disable-windows-asan-tests Commit report: 9803227 Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 361704 Passed, 2046 Skipped, 14h 32m 32.05s Total Time

gleocadie commented 3 weeks ago

What exactly do we need to update, and to what version? I will likely need to update in the next month or so anyway, so could fix this at the same time 🙂

thanks, I'll give you the info :)

andrewlock commented 3 weeks ago

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5987) - mean (70ms)  : 67, 72
     .   : milestone, 70,
    master - mean (69ms)  : 67, 71
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (5987) - mean (1,081ms)  : 1054, 1109
     .   : milestone, 1081,
    master - mean (1,077ms)  : 1053, 1101
     .   : milestone, 1077,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5987) - mean (109ms)  : 106, 111
     .   : milestone, 109,
    master - mean (109ms)  : 105, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5987) - mean (760ms)  : 743, 778
     .   : milestone, 760,
    master - mean (758ms)  : 739, 778
     .   : milestone, 758,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5987) - mean (93ms)  : 89, 96
     .   : milestone, 93,
    master - mean (92ms)  : 90, 95
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (5987) - mean (712ms)  : 694, 730
     .   : milestone, 712,
    master - mean (710ms)  : 697, 724
     .   : milestone, 710,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5987) - mean (191ms)  : 187, 194
     .   : milestone, 191,
    master - mean (190ms)  : 187, 192
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (5987) - mean (1,166ms)  : 1138, 1194
     .   : milestone, 1166,
    master - mean (1,160ms)  : 1137, 1184
     .   : milestone, 1160,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5987) - mean (275ms)  : 270, 281
     .   : milestone, 275,
    master - mean (274ms)  : 270, 279
     .   : milestone, 274,

    section CallTarget+Inlining+NGEN
    This PR (5987) - mean (922ms)  : 905, 939
     .   : milestone, 922,
    master - mean (922ms)  : 902, 942
     .   : milestone, 922,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5987) - mean (265ms)  : 260, 269
     .   : milestone, 265,
    master - mean (264ms)  : 259, 268
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (5987) - mean (906ms)  : 879, 932
     .   : milestone, 906,
    master - mean (902ms)  : 883, 922
     .   : milestone, 902,

DataDog / dd-trace-dotnet