[ASM] RASP: add telemetry tag for shell injection

NachoEchevarria commented 3 weeks ago

Summary of changes

The RASP shell injection telemetry tag was not defined, so telemetry was not being sent.

Reason for change

Fix the RASP telemetry for shell injection.

Implementation details

Test coverage

Other details

datadog-ddstaging[bot] commented 3 weeks ago

Datadog Report

Branch report: nacho/TelemetryRaspShellInjection Commit report: 5193daf Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 365109 Passed, 2055 Skipped, 16h 14m 58.9s Total Time

andrewlock commented 3 weeks ago

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5993) - mean (70ms)  : 66, 75
     .   : milestone, 70,
    master - mean (69ms)  : 67, 71
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (5993) - mean (1,089ms)  : 1056, 1121
     .   : milestone, 1089,
    master - mean (1,077ms)  : 1053, 1101
     .   : milestone, 1077,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5993) - mean (110ms)  : 106, 115
     .   : milestone, 110,
    master - mean (109ms)  : 105, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5993) - mean (763ms)  : 737, 790
     .   : milestone, 763,
    master - mean (758ms)  : 739, 778
     .   : milestone, 758,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5993) - mean (93ms)  : 89, 98
     .   : milestone, 93,
    master - mean (92ms)  : 90, 95
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (5993) - mean (715ms)  : 695, 735
     .   : milestone, 715,
    master - mean (710ms)  : 697, 724
     .   : milestone, 710,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5993) - mean (191ms)  : 186, 197
     .   : milestone, 191,
    master - mean (190ms)  : 187, 192
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (5993) - mean (1,159ms)  : 1133, 1185
     .   : milestone, 1159,
    master - mean (1,160ms)  : 1137, 1184
     .   : milestone, 1160,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5993) - mean (275ms)  : 271, 279
     .   : milestone, 275,
    master - mean (274ms)  : 270, 279
     .   : milestone, 274,

    section CallTarget+Inlining+NGEN
    This PR (5993) - mean (919ms)  : 895, 942
     .   : milestone, 919,
    master - mean (922ms)  : 902, 942
     .   : milestone, 922,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5993) - mean (264ms)  : 260, 268
     .   : milestone, 264,
    master - mean (264ms)  : 259, 268
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (5993) - mean (903ms)  : 882, 925
     .   : milestone, 903,
    master - mean (902ms)  : 883, 922
     .   : milestone, 902,

andrewlock commented 3 weeks ago

Benchmarks Report for appsec :snail:

Benchmarks for #5993 compared to master:

1 benchmarks are slower, with geometric mean 1.233
2 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #5993 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑netcoreapp3.1 | 1.233 | 198.55 | 244.87 |

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`AllCycleSimpleBody`|net6.0|72.4μs|81.3ns|304ns|0.0723| 0|0|6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`AllCycleSimpleBody`|netcoreapp3.1|62.9μs|113ns|438ns|0.094| 0|0|6.95 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`AllCycleSimpleBody`|net472|49.6μs|30.6ns|115ns|1.31| 0|0|8.34 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`AllCycleMoreComplexBody`|net6.0|78.5μs|50.2ns|188ns|0.118| 0|0|9.51 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`AllCycleMoreComplexBody`|netcoreapp3.1|69μs|86.1ns|322ns|0.138| 0|0|10.37 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`AllCycleMoreComplexBody`|net472|55.4μs|41ns|159ns|1.88| 0.0277|0|11.85 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`ObjectExtractorSimpleBody`|net6.0|140ns|0.125ns|0.435ns|0.00397| 0|0|280 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`ObjectExtractorSimpleBody`|netcoreapp3.1|199ns|0.131ns|0.473ns|0.00371| 0|0|272 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`ObjectExtractorSimpleBody`|net472|171ns|0.158ns|0.59ns|0.0446| 0|0|281 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`ObjectExtractorMoreComplexBody`|net6.0|3.04μs|3.38ns|12.6ns|0.0533| 0|0|3.78 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`ObjectExtractorMoreComplexBody`|netcoreapp3.1|3.96μs|3.18ns|11.9ns|0.0494| 0|0|3.69 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`ObjectExtractorMoreComplexBody`|net472|3.81μs|1.98ns|7.67ns|0.603| 0.00572|0|3.8 KB| |#5993|`AllCycleSimpleBody`|net6.0|73.1μs|106ns|412ns|0.0749| 0|0|6.01 KB| |#5993|`AllCycleSimpleBody`|netcoreapp3.1|62.1μs|68.6ns|257ns|0.0619| 0|0|6.95 KB| |#5993|`AllCycleSimpleBody`|net472|49.4μs|21.9ns|81.8ns|1.3| 0|0|8.33 KB| |#5993|`AllCycleMoreComplexBody`|net6.0|78.3μs|98.2ns|380ns|0.117| 0|0|9.51 KB| |#5993|`AllCycleMoreComplexBody`|netcoreapp3.1|68.7μs|75.5ns|292ns|0.137| 0|0|10.37 KB| |#5993|`AllCycleMoreComplexBody`|net472|56.9μs|22.3ns|83.5ns|1.88| 0.0285|0|11.85 KB| |#5993|`ObjectExtractorSimpleBody`|net6.0|145ns|0.654ns|2.53ns|0.00397| 0|0|280 B| |#5993|`ObjectExtractorSimpleBody`|netcoreapp3.1|245ns|0.626ns|2.42ns|0.00367| 0|0|272 B| |#5993|`ObjectExtractorSimpleBody`|net472|176ns|0.358ns|1.39ns|0.0446| 0|0|281 B| |#5993|`ObjectExtractorMoreComplexBody`|net6.0|3.2μs|12ns|46.4ns|0.0523| 0|0|3.78 KB| |#5993|`ObjectExtractorMoreComplexBody`|netcoreapp3.1|3.92μs|11.2ns|43.4ns|0.0503| 0|0|3.69 KB| |#5993|`ObjectExtractorMoreComplexBody`|net472|3.86μs|2.76ns|10.3ns|0.602| 0.00577|0|3.8 KB|

Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`EncodeArgs`|net6.0|36.7μs|17ns|65.9ns|0.446| 0|0|32.4 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`EncodeArgs`|netcoreapp3.1|54.1μs|27ns|101ns|0.433| 0|0|32.4 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`EncodeArgs`|net472|66μs|26.8ns|104ns|5.15| 0.0661|0|32.5 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`EncodeLegacyArgs`|net6.0|72.8μs|106ns|412ns|0| 0|0|2.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`EncodeLegacyArgs`|netcoreapp3.1|106μs|383ns|1.48μs|0| 0|0|2.15 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`EncodeLegacyArgs`|net472|151μs|128ns|495ns|0.304| 0|0|2.15 KB| |#5993|`EncodeArgs`|net6.0|38.6μs|112ns|418ns|0.448| 0|0|32.4 KB| |#5993|`EncodeArgs`|netcoreapp3.1|54.2μs|56.1ns|210ns|0.431| 0|0|32.4 KB| |#5993|`EncodeArgs`|net472|65.9μs|35.4ns|132ns|5.14| 0.0659|0|32.5 KB| |#5993|`EncodeLegacyArgs`|net6.0|73.4μs|101ns|377ns|0| 0|0|2.14 KB| |#5993|`EncodeLegacyArgs`|netcoreapp3.1|104μs|94.3ns|365ns|0| 0|0|2.14 KB| |#5993|`EncodeLegacyArgs`|net472|153μs|165ns|641ns|0.303| 0|0|2.15 KB|

Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`RunWafRealisticBenchmark`|net6.0|184μs|63.1ns|244ns|0| 0|0|2.42 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`RunWafRealisticBenchmark`|netcoreapp3.1|194μs|255ns|986ns|0| 0|0|2.37 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`RunWafRealisticBenchmark`|net472|209μs|137ns|532ns|0.314| 0|0|2.43 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`RunWafRealisticBenchmarkWithAttack`|net6.0|122μs|74.3ns|288ns|0| 0|0|1.46 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`RunWafRealisticBenchmarkWithAttack`|netcoreapp3.1|130μs|193ns|747ns|0| 0|0|1.45 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`RunWafRealisticBenchmarkWithAttack`|net472|139μs|209ns|783ns|0.208| 0|0|1.48 KB| |#5993|`RunWafRealisticBenchmark`|net6.0|185μs|73.1ns|264ns|0| 0|0|2.42 KB| |#5993|`RunWafRealisticBenchmark`|netcoreapp3.1|198μs|486ns|1.88μs|0| 0|0|2.37 KB| |#5993|`RunWafRealisticBenchmark`|net472|209μs|110ns|426ns|0.315| 0|0|2.43 KB| |#5993|`RunWafRealisticBenchmarkWithAttack`|net6.0|122μs|56.1ns|217ns|0| 0|0|1.46 KB| |#5993|`RunWafRealisticBenchmarkWithAttack`|netcoreapp3.1|129μs|140ns|523ns|0| 0|0|1.45 KB| |#5993|`RunWafRealisticBenchmarkWithAttack`|net472|138μs|79.3ns|286ns|0.207| 0|0|1.48 KB|

Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada: #### Fewer allocations :tada: in #5993 | Benchmark | Base Allocated | Diff Allocated | Change | Change % | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 | 255.52 KB | 253.77 KB | -1.75 KB | -0.69% | Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 | 62.13 KB | 58.84 KB | -3.29 KB | -5.29%

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`StringConcatBenchmark`|net6.0|60.8μs|838ns|8.29μs|0| 0|0|43.44 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`StringConcatBenchmark`|netcoreapp3.1|53.1μs|219ns|930ns|0| 0|0|42.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`StringConcatBenchmark`|net472|37.3μs|96.2ns|360ns|0| 0|0|62.13 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`StringConcatAspectBenchmark`|net6.0|323μs|1.83μs|12.5μs|0| 0|0|255.88 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`StringConcatAspectBenchmark`|netcoreapp3.1|345μs|2μs|16.5μs|0| 0|0|255.52 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`StringConcatAspectBenchmark`|net472|266μs|4.34μs|42.3μs|0| 0|0|278.53 KB| |#5993|`StringConcatBenchmark`|net6.0|59.9μs|838ns|8.3μs|0| 0|0|43.44 KB| |#5993|`StringConcatBenchmark`|netcoreapp3.1|54.2μs|307ns|2.26μs|0| 0|0|42.64 KB| |#5993|`StringConcatBenchmark`|net472|37μs|132ns|477ns|0| 0|0|58.84 KB| |#5993|`StringConcatAspectBenchmark`|net6.0|315μs|1.76μs|12μs|0| 0|0|255.37 KB| |#5993|`StringConcatAspectBenchmark`|netcoreapp3.1|298μs|5.24μs|49.5μs|0| 0|0|253.77 KB| |#5993|`StringConcatAspectBenchmark`|net472|291μs|6.46μs|63.3μs|0| 0|0|278.53 KB|

andrewlock commented 3 weeks ago

Benchmarks Report for tracer :snail:

Benchmarks for #5993 compared to master:

3 benchmarks are faster, with geometric mean 1.118
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`StartStopWithChild`|net6.0|7.84μs|44.3ns|319ns|0.0149| 0.00747|0|5.43 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`StartStopWithChild`|netcoreapp3.1|10μs|55.7ns|348ns|0.0145| 0.00482|0|5.62 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`StartStopWithChild`|net472|16μs|51.7ns|200ns|1.01| 0.288|0.0881|6.06 KB| |#5993|`StartStopWithChild`|net6.0|7.69μs|43.7ns|306ns|0.0161| 0.00805|0|5.43 KB| |#5993|`StartStopWithChild`|netcoreapp3.1|9.79μs|53.3ns|388ns|0.0188| 0.00938|0|5.61 KB| |#5993|`StartStopWithChild`|net472|16.4μs|70ns|280ns|1.02| 0.308|0.108|6.07 KB|

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`WriteAndFlushEnrichedTraces`|net6.0|499μs|261ns|1.01μs|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|638μs|270ns|1.05μs|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`WriteAndFlushEnrichedTraces`|net472|850μs|595ns|2.31μs|0.422| 0|0|3.3 KB| |#5993|`WriteAndFlushEnrichedTraces`|net6.0|476μs|321ns|1.2μs|0| 0|0|2.7 KB| |#5993|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|635μs|329ns|1.27μs|0| 0|0|2.7 KB| |#5993|`WriteAndFlushEnrichedTraces`|net472|831μs|765ns|2.96μs|0.414| 0|0|3.3 KB|

Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`SendRequest`|net6.0|224μs|2.24μs|22.2μs|0.205| 0|0|18.45 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`SendRequest`|netcoreapp3.1|235μs|1.43μs|14.1μs|0.254| 0|0|20.61 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`SendRequest`|net472|0.00254ns|0.00105ns|0.00408ns|0| 0|0|0 b| |#5993|`SendRequest`|net6.0|201μs|993ns|7.5μs|0.204| 0|0|18.45 KB| |#5993|`SendRequest`|netcoreapp3.1|233μs|1.41μs|13.9μs|0.215| 0|0|20.61 KB| |#5993|`SendRequest`|net472|0.0039ns|0.00145ns|0.00561ns|0| 0|0|0 b|

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`WriteAndFlushEnrichedTraces`|net6.0|584μs|2.42μs|9.05μs|0.571| 0|0|41.69 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|686μs|3.82μs|24.2μs|0.342| 0|0|41.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`WriteAndFlushEnrichedTraces`|net472|877μs|4.1μs|15.9μs|8.19| 2.59|0.431|53.32 KB| |#5993|`WriteAndFlushEnrichedTraces`|net6.0|622μs|3.62μs|32μs|0.573| 0|0|41.59 KB| |#5993|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|723μs|4.01μs|26μs|0.355| 0|0|41.75 KB| |#5993|`WriteAndFlushEnrichedTraces`|net472|885μs|3.38μs|12.7μs|8.25| 2.6|0.434|53.3 KB|

Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`ExecuteNonQuery`|net6.0|1.25μs|1.4ns|5.41ns|0.0143| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`ExecuteNonQuery`|netcoreapp3.1|1.69μs|1.94ns|7.27ns|0.0135| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`ExecuteNonQuery`|net472|2.01μs|1.21ns|4.53ns|0.156| 0|0|987 B| |#5993|`ExecuteNonQuery`|net6.0|1.25μs|0.864ns|2.99ns|0.0145| 0|0|1.02 KB| |#5993|`ExecuteNonQuery`|netcoreapp3.1|1.84μs|1.88ns|7.05ns|0.0137| 0|0|1.02 KB| |#5993|`ExecuteNonQuery`|net472|2.12μs|3.03ns|11.3ns|0.157| 0|0|987 B|

Benchmarks.Trace.ElasticsearchBenchmark - Faster :tada: Same allocations :heavy_check_mark: #### Faster :tada: in #5993 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 | 1.116 | 1,187.68 | 1,064.01 |

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`CallElasticsearch`|net6.0|1.19μs|0.623ns|2.16ns|0.0137| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`CallElasticsearch`|netcoreapp3.1|1.59μs|0.569ns|2.13ns|0.0127| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`CallElasticsearch`|net472|2.41μs|1.37ns|5.31ns|0.158| 0|0|995 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`CallElasticsearchAsync`|net6.0|1.16μs|0.644ns|2.49ns|0.0134| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`CallElasticsearchAsync`|netcoreapp3.1|1.6μs|0.79ns|2.95ns|0.0136| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`CallElasticsearchAsync`|net472|2.61μs|1.44ns|5.57ns|0.166| 0|0|1.05 KB| |#5993|`CallElasticsearch`|net6.0|1.06μs|0.56ns|2.17ns|0.0139| 0|0|976 B| |#5993|`CallElasticsearch`|netcoreapp3.1|1.61μs|0.513ns|1.99ns|0.0129| 0|0|976 B| |#5993|`CallElasticsearch`|net472|2.46μs|2.21ns|8.55ns|0.158| 0|0|995 B| |#5993|`CallElasticsearchAsync`|net6.0|1.24μs|1.2ns|4.48ns|0.0131| 0|0|952 B| |#5993|`CallElasticsearchAsync`|netcoreapp3.1|1.64μs|0.474ns|1.77ns|0.014| 0|0|1.02 KB| |#5993|`CallElasticsearchAsync`|net472|2.55μs|1.84ns|7.12ns|0.167| 0|0|1.05 KB|

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`ExecuteAsync`|net6.0|1.2μs|0.951ns|3.68ns|0.0132| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`ExecuteAsync`|netcoreapp3.1|1.59μs|0.906ns|3.51ns|0.0128| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`ExecuteAsync`|net472|1.76μs|0.73ns|2.83ns|0.145| 0|0|915 B| |#5993|`ExecuteAsync`|net6.0|1.24μs|0.835ns|3.12ns|0.0131| 0|0|952 B| |#5993|`ExecuteAsync`|netcoreapp3.1|1.64μs|0.75ns|2.91ns|0.0131| 0|0|952 B| |#5993|`ExecuteAsync`|net472|1.77μs|1.27ns|4.75ns|0.145| 0|0|915 B|

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`SendAsync`|net6.0|4.18μs|3ns|10.8ns|0.0313| 0|0|2.22 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`SendAsync`|netcoreapp3.1|5.06μs|2.06ns|7.96ns|0.0355| 0|0|2.76 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`SendAsync`|net472|7.88μs|2.89ns|10.8ns|0.497| 0|0|3.15 KB| |#5993|`SendAsync`|net6.0|4.16μs|1.77ns|6.4ns|0.0315| 0|0|2.22 KB| |#5993|`SendAsync`|netcoreapp3.1|5μs|1.74ns|6.74ns|0.0377| 0|0|2.76 KB| |#5993|`SendAsync`|net472|7.76μs|2.78ns|10.8ns|0.497| 0|0|3.15 KB|

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`EnrichedLog`|net6.0|1.48μs|0.457ns|1.65ns|0.0231| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`EnrichedLog`|netcoreapp3.1|2.2μs|5.09ns|18.4ns|0.0217| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`EnrichedLog`|net472|2.62μs|1.34ns|5.02ns|0.249| 0|0|1.57 KB| |#5993|`EnrichedLog`|net6.0|1.58μs|0.403ns|1.51ns|0.023| 0|0|1.64 KB| |#5993|`EnrichedLog`|netcoreapp3.1|2.21μs|1.23ns|4.59ns|0.0219| 0|0|1.64 KB| |#5993|`EnrichedLog`|net472|2.68μs|1.54ns|5.75ns|0.249| 0|0|1.57 KB|

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`EnrichedLog`|net6.0|116μs|188ns|730ns|0| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`EnrichedLog`|netcoreapp3.1|120μs|168ns|649ns|0.06| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`EnrichedLog`|net472|149μs|153ns|594ns|0.668| 0.223|0|4.46 KB| |#5993|`EnrichedLog`|net6.0|116μs|323ns|1.21μs|0.057| 0|0|4.28 KB| |#5993|`EnrichedLog`|netcoreapp3.1|121μs|262ns|1.02μs|0.0607| 0|0|4.28 KB| |#5993|`EnrichedLog`|net472|147μs|197ns|761ns|0.657| 0.219|0|4.46 KB|

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`EnrichedLog`|net6.0|3.01μs|2.55ns|9.88ns|0.0315| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`EnrichedLog`|netcoreapp3.1|4.09μs|1.11ns|4.28ns|0.0287| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`EnrichedLog`|net472|4.85μs|1.88ns|7.27ns|0.319| 0|0|2.02 KB| |#5993|`EnrichedLog`|net6.0|3.02μs|0.909ns|3.52ns|0.0303| 0|0|2.2 KB| |#5993|`EnrichedLog`|netcoreapp3.1|4.13μs|2.07ns|8.01ns|0.029| 0|0|2.2 KB| |#5993|`EnrichedLog`|net472|4.83μs|1.27ns|4.92ns|0.319| 0|0|2.02 KB|

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`SendReceive`|net6.0|1.39μs|0.591ns|2.29ns|0.0159| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`SendReceive`|netcoreapp3.1|1.7μs|1.25ns|4.82ns|0.0153| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`SendReceive`|net472|2.16μs|1.48ns|5.74ns|0.183| 0.00107|0|1.16 KB| |#5993|`SendReceive`|net6.0|1.37μs|0.916ns|3.55ns|0.0158| 0|0|1.14 KB| |#5993|`SendReceive`|netcoreapp3.1|1.81μs|2.1ns|8.14ns|0.0154| 0|0|1.14 KB| |#5993|`SendReceive`|net472|2.21μs|2.56ns|9.91ns|0.183| 0.00111|0|1.16 KB|

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`EnrichedLog`|net6.0|2.91μs|0.892ns|3.46ns|0.0219| 0|0|1.6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`EnrichedLog`|netcoreapp3.1|3.94μs|2.89ns|11.2ns|0.0216| 0|0|1.65 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`EnrichedLog`|net472|4.43μs|0.962ns|3.33ns|0.323| 0|0|2.04 KB| |#5993|`EnrichedLog`|net6.0|2.76μs|0.515ns|1.86ns|0.0221| 0|0|1.6 KB| |#5993|`EnrichedLog`|netcoreapp3.1|3.8μs|1.71ns|6.15ns|0.0211| 0|0|1.65 KB| |#5993|`EnrichedLog`|net472|4.32μs|2.04ns|7.92ns|0.324| 0|0|2.04 KB|

Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`StartFinishSpan`|net6.0|400ns|0.142ns|0.532ns|0.00805| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`StartFinishSpan`|netcoreapp3.1|588ns|0.562ns|2.18ns|0.00787| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`StartFinishSpan`|net472|623ns|1.11ns|4.31ns|0.0916| 0|0|578 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`StartFinishScope`|net6.0|497ns|0.419ns|1.62ns|0.00967| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`StartFinishScope`|netcoreapp3.1|731ns|1.96ns|7.61ns|0.00952| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`StartFinishScope`|net472|884ns|0.993ns|3.84ns|0.104| 0|0|658 B| |#5993|`StartFinishSpan`|net6.0|406ns|0.235ns|0.909ns|0.00815| 0|0|576 B| |#5993|`StartFinishSpan`|netcoreapp3.1|569ns|0.224ns|0.839ns|0.00788| 0|0|576 B| |#5993|`StartFinishSpan`|net472|637ns|0.296ns|1.11ns|0.0915| 0|0|578 B| |#5993|`StartFinishScope`|net6.0|499ns|0.95ns|3.29ns|0.0097| 0|0|696 B| |#5993|`StartFinishScope`|netcoreapp3.1|667ns|0.401ns|1.55ns|0.00934| 0|0|696 B| |#5993|`StartFinishScope`|net472|825ns|0.765ns|2.96ns|0.104| 0|0|658 B|

Benchmarks.Trace.TraceAnnotationsBenchmark - Faster :tada: Same allocations :heavy_check_mark: #### Faster :tada: in #5993 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.121 | 748.23 | 667.71 | | Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 | 1.116 | 998.86 | 894.76 |

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`RunOnMethodBegin`|net6.0|748ns|0.702ns|2.72ns|0.00971| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`RunOnMethodBegin`|netcoreapp3.1|1E+03ns|1.28ns|4.97ns|0.00912| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f5634df36ee6ff72b776034afc51e6ea2f4a6451)|`RunOnMethodBegin`|net472|1.11μs|1.33ns|5.14ns|0.104| 0|0|658 B| |#5993|`RunOnMethodBegin`|net6.0|667ns|0.633ns|2.45ns|0.00973| 0|0|696 B| |#5993|`RunOnMethodBegin`|netcoreapp3.1|895ns|0.593ns|2.3ns|0.00959| 0|0|696 B| |#5993|`RunOnMethodBegin`|net472|1.09μs|2.1ns|8.12ns|0.104| 0|0|658 B|

andrewlock commented 3 weeks ago

Throughput/Crank Report :zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5993) (11.092M)   : 0, 11092063
    master (11.153M)   : 0, 11153369

    section Automatic
    This PR (5993) (7.436M)   : 0, 7435521
    master (7.524M)   : 0, 7524241

    section Trace stats
    master (7.700M)   : 0, 7700114

    section Manual
    master (11.283M)   : 0, 11283128

    section Manual + Automatic
    This PR (5993) (6.829M)   : 0, 6828679
    master (6.832M)   : 0, 6831619

    section DD_TRACE_ENABLED=0
    master (10.376M)   : 0, 10376490

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5993) (9.590M)   : 0, 9590149
    benchmarks/2.9.0 (9.645M)   : 0, 9644839

    section Automatic
    This PR (5993) (6.706M)   : 0, 6705591

    section Manual + Automatic
    This PR (5993) (6.253M)   : 0, 6252835

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5993) (10.081M)   : 0, 10080584
    benchmarks/2.9.0 (10.408M)   : 0, 10408319

    section Automatic
    This PR (5993) (6.941M)   : 0, 6940751
    benchmarks/2.9.0 (7.412M)   : 0, 7412035

    section Manual + Automatic
    This PR (5993) (6.405M)   : 0, 6404552

NachoEchevarria commented 3 weeks ago

Thanks for your reviews!

DataDog / dd-trace-dotnet