DataDog / dd-trace-dotnet

.NET Client Library for Datadog APM
https://docs.datadoghq.com/tracing/
Apache License 2.0
437 stars 137 forks source link

[Test Package Versions Bump] Updating package versions #5995

Closed github-actions[bot] closed 6 days ago

github-actions[bot] commented 3 weeks ago

Updates the package versions for integration tests.

bouwkast commented 3 weeks ago

I ran this to see if it worked with the new permissions as the same permissions are failing on other repositories

andrewlock commented 3 weeks ago

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5995) - mean (70ms)  : 68, 72
     .   : milestone, 70,
    master - mean (70ms)  : 67, 73
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (5995) - mean (1,103ms)  : 1081, 1126
     .   : milestone, 1103,
    master - mean (1,105ms)  : 1067, 1143
     .   : milestone, 1105,
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5995) - mean (109ms)  : 107, 111
     .   : milestone, 109,
    master - mean (109ms)  : 105, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5995) - mean (769ms)  : 752, 785
     .   : milestone, 769,
    master - mean (766ms)  : 751, 782
     .   : milestone, 766,
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5995) - mean (92ms)  : 90, 95
     .   : milestone, 92,
    master - mean (92ms)  : 90, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (5995) - mean (726ms)  : 705, 747
     .   : milestone, 726,
    master - mean (727ms)  : 707, 747
     .   : milestone, 727,
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5995) - mean (191ms)  : 187, 194
     .   : milestone, 191,
    master - mean (191ms)  : 187, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (5995) - mean (1,192ms)  : 1174, 1210
     .   : milestone, 1192,
    master - mean (1,202ms)  : 1165, 1240
     .   : milestone, 1202,
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5995) - mean (276ms)  : 271, 282
     .   : milestone, 276,
    master - mean (276ms)  : 270, 281
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (5995) - mean (941ms)  : 927, 955
     .   : milestone, 941,
    master - mean (938ms)  : 918, 958
     .   : milestone, 938,
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5995) - mean (266ms)  : 262, 269
     .   : milestone, 266,
    master - mean (265ms)  : 261, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (5995) - mean (924ms)  : 906, 941
     .   : milestone, 924,
    master - mean (922ms)  : 906, 939
     .   : milestone, 922,
datadog-ddstaging[bot] commented 3 weeks ago

Datadog Report

Branch report: bot/test-package-versions-bump Commit report: f694ba4 Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 368165 Passed, 2064 Skipped, 15h 32m 25.35s Total Time

andrewlock commented 3 weeks ago

Benchmarks Report for tracer :snail:

Benchmarks for #5995 compared to master:

The following thresholds were used for comparing the benchmark speeds:

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`StartStopWithChild`|net6.0|7.87μs|44.8ns|329ns|0.0151| 0.00754|0|5.42 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`StartStopWithChild`|netcoreapp3.1|10.1μs|55.6ns|347ns|0.0245| 0.00979|0|5.61 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`StartStopWithChild`|net472|16.4μs|61.8ns|239ns|1.02| 0.3|0.0947|6.06 KB| |#5995|`StartStopWithChild`|net6.0|7.85μs|42.6ns|289ns|0.0118| 0.00393|0|5.43 KB| |#5995|`StartStopWithChild`|netcoreapp3.1|9.93μs|54ns|310ns|0.0193| 0.00966|0|5.62 KB| |#5995|`StartStopWithChild`|net472|16.2μs|43ns|167ns|1.01| 0.292|0.0893|6.06 KB|
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`WriteAndFlushEnrichedTraces`|net6.0|451μs|381ns|1.48μs|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|640μs|370ns|1.43μs|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`WriteAndFlushEnrichedTraces`|net472|831μs|358ns|1.39μs|0.414| 0|0|3.3 KB| |#5995|`WriteAndFlushEnrichedTraces`|net6.0|484μs|1.02μs|3.94μs|0| 0|0|2.7 KB| |#5995|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|632μs|445ns|1.67μs|0| 0|0|2.7 KB| |#5995|`WriteAndFlushEnrichedTraces`|net472|831μs|393ns|1.52μs|0.414| 0|0|3.3 KB|
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`SendRequest`|net6.0|205μs|1.16μs|8.38μs|0.2| 0|0|18.45 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`SendRequest`|netcoreapp3.1|231μs|1.32μs|9.55μs|0.219| 0|0|20.61 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`SendRequest`|net472|0.00105ns|0.000482ns|0.00187ns|0| 0|0|0 b| |#5995|`SendRequest`|net6.0|208μs|1.17μs|7.37μs|0.198| 0|0|18.45 KB| |#5995|`SendRequest`|netcoreapp3.1|238μs|1.54μs|15.3μs|0.22| 0|0|20.61 KB| |#5995|`SendRequest`|net472|0.000377ns|0.000259ns|0.001ns|0| 0|0|0 b|
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`WriteAndFlushEnrichedTraces`|net6.0|562μs|2.54μs|9.83μs|0.558| 0|0|41.66 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|683μs|3.67μs|21.4μs|0.347| 0|0|41.73 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`WriteAndFlushEnrichedTraces`|net472|849μs|3.95μs|15.3μs|8.45| 2.53|0.422|53.3 KB| |#5995|`WriteAndFlushEnrichedTraces`|net6.0|583μs|2.99μs|13.4μs|0.558| 0|0|41.65 KB| |#5995|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|692μs|3.79μs|23μs|0.336| 0|0|41.75 KB| |#5995|`WriteAndFlushEnrichedTraces`|net472|878μs|3.48μs|13.5μs|8.3| 2.62|0.437|53.32 KB|
Benchmarks.Trace.DbCommandBenchmark - Faster :tada: Same allocations :heavy_check_mark: #### Faster :tada: in #5995 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 | 1.134 | 1,331.72 | 1,173.84 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`ExecuteNonQuery`|net6.0|1.33μs|1.77ns|6.85ns|0.0145| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`ExecuteNonQuery`|netcoreapp3.1|1.77μs|1.64ns|6.35ns|0.0131| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`ExecuteNonQuery`|net472|2.11μs|3.79ns|14.7ns|0.156| 0|0|987 B| |#5995|`ExecuteNonQuery`|net6.0|1.17μs|0.75ns|2.9ns|0.0142| 0|0|1.02 KB| |#5995|`ExecuteNonQuery`|netcoreapp3.1|1.76μs|2.22ns|8.61ns|0.0133| 0|0|1.02 KB| |#5995|`ExecuteNonQuery`|net472|2.08μs|1.21ns|4.69ns|0.157| 0|0|987 B|
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`CallElasticsearch`|net6.0|1.16μs|1.43ns|5.55ns|0.0139| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`CallElasticsearch`|netcoreapp3.1|1.54μs|1.35ns|5.06ns|0.0131| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`CallElasticsearch`|net472|2.32μs|2.44ns|9.47ns|0.157| 0|0|995 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`CallElasticsearchAsync`|net6.0|1.37μs|1.26ns|4.87ns|0.0133| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`CallElasticsearchAsync`|netcoreapp3.1|1.61μs|0.997ns|3.59ns|0.0138| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`CallElasticsearchAsync`|net472|2.64μs|1.8ns|6.99ns|0.167| 0|0|1.05 KB| |#5995|`CallElasticsearch`|net6.0|1.24μs|0.481ns|1.8ns|0.0136| 0|0|976 B| |#5995|`CallElasticsearch`|netcoreapp3.1|1.57μs|0.755ns|2.92ns|0.0133| 0|0|976 B| |#5995|`CallElasticsearch`|net472|2.43μs|1.2ns|4.5ns|0.157| 0|0|995 B| |#5995|`CallElasticsearchAsync`|net6.0|1.32μs|3.21ns|12ns|0.0132| 0|0|952 B| |#5995|`CallElasticsearchAsync`|netcoreapp3.1|1.63μs|2.41ns|9.32ns|0.0138| 0|0|1.02 KB| |#5995|`CallElasticsearchAsync`|net472|2.67μs|1.51ns|5.44ns|0.167| 0|0|1.05 KB|
Benchmarks.Trace.GraphQLBenchmark - Faster :tada: Same allocations :heavy_check_mark: #### Faster :tada: in #5995 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 | 1.190 | 1,349.45 | 1,134.26 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`ExecuteAsync`|net6.0|1.35μs|1.85ns|7.18ns|0.0131| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`ExecuteAsync`|netcoreapp3.1|1.72μs|0.535ns|2ns|0.0127| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`ExecuteAsync`|net472|1.81μs|1.38ns|5.34ns|0.145| 0|0|915 B| |#5995|`ExecuteAsync`|net6.0|1.13μs|0.614ns|2.38ns|0.0136| 0|0|952 B| |#5995|`ExecuteAsync`|netcoreapp3.1|1.58μs|0.645ns|2.5ns|0.0126| 0|0|952 B| |#5995|`ExecuteAsync`|net472|1.85μs|1.39ns|5.2ns|0.145| 0|0|915 B|
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`SendAsync`|net6.0|4.23μs|1.81ns|6.76ns|0.0295| 0|0|2.22 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`SendAsync`|netcoreapp3.1|5.17μs|2.8ns|10.1ns|0.0361| 0|0|2.76 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`SendAsync`|net472|7.81μs|1.46ns|5.65ns|0.497| 0|0|3.15 KB| |#5995|`SendAsync`|net6.0|4.21μs|1.24ns|4.46ns|0.0316| 0|0|2.22 KB| |#5995|`SendAsync`|netcoreapp3.1|5.18μs|1.51ns|5.84ns|0.0362| 0|0|2.76 KB| |#5995|`SendAsync`|net472|7.73μs|2.77ns|10.7ns|0.496| 0|0|3.15 KB|
Benchmarks.Trace.ILoggerBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #5995 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 | 1.117 | 1,490.55 | 1,664.61 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`EnrichedLog`|net6.0|1.49μs|0.775ns|2.9ns|0.023| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`EnrichedLog`|netcoreapp3.1|2.33μs|1.44ns|5.38ns|0.022| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`EnrichedLog`|net472|2.61μs|1.33ns|5.15ns|0.249| 0|0|1.57 KB| |#5995|`EnrichedLog`|net6.0|1.66μs|0.716ns|2.77ns|0.0233| 0|0|1.64 KB| |#5995|`EnrichedLog`|netcoreapp3.1|2.3μs|1.58ns|5.89ns|0.0218| 0|0|1.64 KB| |#5995|`EnrichedLog`|net472|2.68μs|1.49ns|5.76ns|0.249| 0|0|1.57 KB|
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`EnrichedLog`|net6.0|117μs|222ns|859ns|0.0576| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`EnrichedLog`|netcoreapp3.1|121μs|210ns|815ns|0.0602| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`EnrichedLog`|net472|151μs|128ns|495ns|0.672| 0.224|0|4.46 KB| |#5995|`EnrichedLog`|net6.0|119μs|258ns|1μs|0.0593| 0|0|4.28 KB| |#5995|`EnrichedLog`|netcoreapp3.1|122μs|147ns|568ns|0.0606| 0|0|4.28 KB| |#5995|`EnrichedLog`|net472|150μs|155ns|600ns|0.673| 0.224|0|4.46 KB|
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`EnrichedLog`|net6.0|2.9μs|0.868ns|3.36ns|0.031| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`EnrichedLog`|netcoreapp3.1|4.38μs|0.999ns|3.87ns|0.0284| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`EnrichedLog`|net472|5.02μs|1.26ns|4.89ns|0.32| 0|0|2.02 KB| |#5995|`EnrichedLog`|net6.0|2.91μs|2.3ns|8.91ns|0.0306| 0|0|2.2 KB| |#5995|`EnrichedLog`|netcoreapp3.1|4.13μs|1.41ns|5.28ns|0.0296| 0|0|2.2 KB| |#5995|`EnrichedLog`|net472|4.79μs|1.19ns|4.59ns|0.32| 0|0|2.02 KB|
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`SendReceive`|net6.0|1.38μs|0.536ns|2.07ns|0.016| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`SendReceive`|netcoreapp3.1|1.73μs|0.849ns|3.29ns|0.0156| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`SendReceive`|net472|2.1μs|1.16ns|4.51ns|0.183| 0.00104|0|1.16 KB| |#5995|`SendReceive`|net6.0|1.41μs|0.554ns|2.14ns|0.0163| 0|0|1.14 KB| |#5995|`SendReceive`|netcoreapp3.1|1.83μs|1.07ns|4.16ns|0.0156| 0|0|1.14 KB| |#5995|`SendReceive`|net472|2.13μs|2.27ns|8.8ns|0.183| 0|0|1.16 KB|
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`EnrichedLog`|net6.0|2.76μs|0.98ns|3.8ns|0.0221| 0|0|1.6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`EnrichedLog`|netcoreapp3.1|3.65μs|1.38ns|5.35ns|0.0221| 0|0|1.65 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`EnrichedLog`|net472|4.43μs|1.46ns|5.48ns|0.323| 0|0|2.04 KB| |#5995|`EnrichedLog`|net6.0|2.64μs|0.86ns|3.33ns|0.0224| 0|0|1.6 KB| |#5995|`EnrichedLog`|netcoreapp3.1|4μs|3.48ns|13.5ns|0.0215| 0|0|1.65 KB| |#5995|`EnrichedLog`|net472|4.48μs|3.42ns|13.3ns|0.323| 0|0|2.04 KB|
Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #5995 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 | 1.138 | 710.64 | 808.54 | #### Faster :tada: in #5995 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 | 1.136 | 684.40 | 602.68 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`StartFinishSpan`|net6.0|400ns|0.141ns|0.548ns|0.00803| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`StartFinishSpan`|netcoreapp3.1|597ns|0.312ns|1.21ns|0.00794| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`StartFinishSpan`|net472|684ns|0.501ns|1.87ns|0.0918| 0|0|578 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`StartFinishScope`|net6.0|505ns|0.216ns|0.836ns|0.00966| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`StartFinishScope`|netcoreapp3.1|711ns|0.58ns|2.24ns|0.0095| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`StartFinishScope`|net472|808ns|2.52ns|9.75ns|0.104| 0|0|658 B| |#5995|`StartFinishSpan`|net6.0|403ns|0.158ns|0.612ns|0.0081| 0|0|576 B| |#5995|`StartFinishSpan`|netcoreapp3.1|556ns|0.217ns|0.813ns|0.00784| 0|0|576 B| |#5995|`StartFinishSpan`|net472|602ns|0.25ns|0.967ns|0.0917| 0|0|578 B| |#5995|`StartFinishScope`|net6.0|535ns|2.99ns|19.2ns|0.00984| 0|0|696 B| |#5995|`StartFinishScope`|netcoreapp3.1|807ns|0.751ns|2.91ns|0.00926| 0|0|696 B| |#5995|`StartFinishScope`|net472|885ns|0.463ns|1.79ns|0.104| 0|0|658 B|
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster :tada: Same allocations :heavy_check_mark: #### Faster :tada: in #5995 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 | 1.120 | 1,020.27 | 910.75 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`RunOnMethodBegin`|net6.0|656ns|1.06ns|3.83ns|0.00984| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`RunOnMethodBegin`|netcoreapp3.1|1.02μs|0.923ns|3.57ns|0.00926| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/03b9ea77b098ad4bf37ffa439c3331d4ba7fcd88)|`RunOnMethodBegin`|net472|1.1μs|1.57ns|6.07ns|0.104| 0|0|658 B| |#5995|`RunOnMethodBegin`|net6.0|675ns|0.151ns|0.564ns|0.0098| 0|0|696 B| |#5995|`RunOnMethodBegin`|netcoreapp3.1|911ns|0.331ns|1.24ns|0.00966| 0|0|696 B| |#5995|`RunOnMethodBegin`|net472|1.12μs|0.38ns|1.47ns|0.105| 0|0|658 B|
andrewlock commented 3 weeks ago

Throughput/Crank Report :zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5995) (10.867M)   : 0, 10867106
    master (11.098M)   : 0, 11098480
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (5995) (7.252M)   : 0, 7252323
    master (7.197M)   : 0, 7196894
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.633M)   : 0, 7632576

    section Manual
    master (11.005M)   : 0, 11005247

    section Manual + Automatic
    This PR (5995) (6.783M)   : 0, 6782613
    master (6.782M)   : 0, 6781842

    section DD_TRACE_ENABLED=0
    master (10.205M)   : 0, 10205469
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5995) (9.428M)   : 0, 9428337
    master (9.594M)   : 0, 9594252
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (5995) (6.525M)   : 0, 6524757
    master (6.687M)   : 0, 6686910

    section Trace stats
    master (6.937M)   : 0, 6937224

    section Manual
    master (9.495M)   : 0, 9495445

    section Manual + Automatic
    This PR (5995) (5.918M)   : 0, 5917708
    master (6.109M)   : 0, 6108826

    section DD_TRACE_ENABLED=0
    master (8.886M)   : 0, 8886342
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5995) (9.974M)   : 0, 9974455
    master (10.010M)   : 0, 10009662
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (5995) (6.577M)   : 0, 6576656
    master (6.610M)   : 0, 6610335
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.259M)   : 0, 7258665

    section Manual
    master (10.026M)   : 0, 10025796

    section Manual + Automatic
    This PR (5995) (6.092M)   : 0, 6092124
    master (6.249M)   : 0, 6248937

    section DD_TRACE_ENABLED=0
    master (9.319M)   : 0, 9319267