Closed daniel-romano-DD closed 2 months ago
Execution-time results for samples comparing the following branches/commits:
Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.
Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).
gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5997) - mean (70ms) : 67, 72
. : milestone, 70,
master - mean (69ms) : 67, 71
. : milestone, 69,
section CallTarget+Inlining+NGEN
This PR (5997) - mean (1,111ms) : 1090, 1132
. : milestone, 1111,
master - mean (1,118ms) : 1090, 1147
. : milestone, 1118,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5997) - mean (109ms) : 104, 113
. : milestone, 109,
master - mean (109ms) : 105, 112
. : milestone, 109,
section CallTarget+Inlining+NGEN
This PR (5997) - mean (812ms) : 794, 830
. : milestone, 812,
master - mean (809ms) : 789, 829
. : milestone, 809,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5997) - mean (92ms) : 89, 95
. : milestone, 92,
master - mean (92ms) : 89, 95
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (5997) - mean (771ms) : 749, 793
. : milestone, 771,
master - mean (768ms) : 748, 788
. : milestone, 768,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5997) - mean (192ms) : 187, 198
. : milestone, 192,
master - mean (190ms) : 187, 193
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (5997) - mean (1,195ms) : 1168, 1222
. : milestone, 1195,
master - mean (1,197ms) : 1169, 1224
. : milestone, 1197,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5997) - mean (277ms) : 272, 281
. : milestone, 277,
master - mean (276ms) : 272, 281
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (5997) - mean (973ms) : 953, 993
. : milestone, 973,
master - mean (971ms) : 951, 992
. : milestone, 971,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5997) - mean (264ms) : 261, 268
. : milestone, 264,
master - mean (265ms) : 261, 270
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (5997) - mean (951ms) : 921, 981
. : milestone, 951,
master - mean (952ms) : 931, 973
. : milestone, 952,
Branch report: dani/iast/stack_traces_location
Commit report: 120d53b
Test service: dd-trace-dotnet
:white_check_mark: 0 Failed, 471080 Passed, 3258 Skipped, 31h 42m 13.18s Total Time :snowflake: 1 New Flaky
SnapshotBiggerThanMaxSize_TwoLevel_OneSliced
- Datadog.Trace.Tests.Debugger.SnapshotSlicerTests
- Last Failure
Benchmarks for #5997 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored.
Benchmarks for #5997 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored.
The following differences have been observed in committed snapshots. It is meant to help the reviewer. The diff is simplistic, so please check some files anyway while we improve it.
1 occurrences of :
+ _dd.iast.json:
[...]
+ "vulnerabilities": [
+ {
+ "type": "STACKTRACE_LEAK",
+ "hash": 1099366274,
+ "location": {
+ "spanId": XXX,
+ "path": "Samples.Security.AspNetCore5.Controllers.IastController",
+ "method": "StackTraceLeak"
+ },
+ "evidence": {
+ "value": "Samples.Security.AspNetCore5,SystemException"
+ }
+ }
+ ]
[...]
+ _dd.iast.telemetry.executed.sink.header_injection: 1.0,
+ _dd.iast.telemetry.executed.sink.hsts_header_missing: 1.0,
+ _dd.iast.telemetry.executed.sink.stacktrace_leak: 1.0,
+ _dd.iast.telemetry.executed.sink.unvalidated_redirect: 1.0,
+ _dd.iast.telemetry.executed.sink.xcontenttype_header_missing: 1.0,
1 occurrences of :
- _sampling_priority_v1: 1.0
+ _sampling_priority_v1: 2.0
26 occurrences of :
+ appsec: ,
311 occurrences of :
+ },
+ MetaStruct: {
+ appsec:
23 occurrences of :
+ "stackId": "1"
5 occurrences of :
+ },
+ MetaStruct: {
+ _dd.stack:
6 occurrences of :
+ },
+ MetaStruct: {
+ appsec: ,
+ _dd.stack:
3 occurrences of :
+ "stackId": "2"
Throughput results for AspNetCoreSimpleController comparing the following branches/commits:
Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.
Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!
gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5997) (11.207M) : 0, 11207456
master (11.191M) : 0, 11191009
benchmarks/2.9.0 (11.235M) : 0, 11234930
section Automatic
This PR (5997) (7.446M) : 0, 7445598
master (7.480M) : 0, 7479864
benchmarks/2.9.0 (7.902M) : 0, 7901974
section Trace stats
master (7.854M) : 0, 7854112
section Manual
master (11.251M) : 0, 11250786
section Manual + Automatic
This PR (5997) (6.886M) : 0, 6886230
master (6.974M) : 0, 6974322
section DD_TRACE_ENABLED=0
master (10.260M) : 0, 10260342
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5997) (9.633M) : 0, 9632921
master (9.407M) : 0, 9407221
benchmarks/2.9.0 (9.468M) : 0, 9467847
section Automatic
This PR (5997) (6.581M) : 0, 6580748
master (6.409M) : 0, 6408651
section Trace stats
master (6.945M) : 0, 6945033
section Manual
master (9.485M) : 0, 9484960
section Manual + Automatic
This PR (5997) (6.082M) : 0, 6082118
master (6.153M) : 0, 6152889
section DD_TRACE_ENABLED=0
master (8.880M) : 0, 8879609
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5997) (10.246M) : 0, 10245694
master (10.042M) : 0, 10041833
benchmarks/2.9.0 (10.191M) : 0, 10191280
section Automatic
This PR (5997) (6.743M) : 0, 6742808
master (6.584M) : 0, 6583747
benchmarks/2.9.0 (7.389M) : 0, 7388665
section Trace stats
master (7.349M) : 0, 7348894
section Manual
master (10.065M) : 0, 10064803
section Manual + Automatic
This PR (5997) (6.280M) : 0, 6280349
master (6.022M) : 0, 6022361
section DD_TRACE_ENABLED=0
master (9.438M) : 0, 9437949
Summary of changes
Add full stack trace to vulnerability location following this RFC
Reason for change
A stack trace of where the vulnerability is located can help the client to locate it in order to fix it.
Implementation details
The stacks are added in the MetaStruct
_dd.stack
tag under thevulnerability
section. A stack Id has been added to the vulnerability location. This Id matches the stack Id on the MetaStruct dictionary.Test coverage
Added integration tests
Other details