Closed andrewlock closed 2 weeks ago
datadog-ddstaging[bot]
commented
3 weeks ago Branch report: andrew/ci/fix-installer-tests-2-upport
Commit report: 328df82
Test service: dd-trace-dotnet
:white_check_mark: 0 Failed, 369119 Passed, 2102 Skipped, 15h 16m 48.88s Total Time
andrewlock
commented
3 weeks ago Execution-time results for samples comparing the following branches/commits:
Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.
Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).
gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6004) - mean (70ms) : 67, 73
. : milestone, 70,
master - mean (71ms) : 67, 75
. : milestone, 71,
section CallTarget+Inlining+NGEN
This PR (6004) - mean (1,082ms) : 1060, 1103
. : milestone, 1082,
master - mean (1,085ms) : 1060, 1110
. : milestone, 1085,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6004) - mean (111ms) : 107, 114
. : milestone, 111,
master - mean (110ms) : 106, 114
. : milestone, 110,
section CallTarget+Inlining+NGEN
This PR (6004) - mean (780ms) : 740, 820
. : milestone, 780,
master - mean (759ms) : 741, 778
. : milestone, 759,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6004) - mean (94ms) : 91, 97
. : milestone, 94,
master - mean (93ms) : 89, 97
. : milestone, 93,
section CallTarget+Inlining+NGEN
This PR (6004) - mean (715ms) : 700, 731
. : milestone, 715,
master - mean (712ms) : 692, 732
. : milestone, 712,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6004) - mean (191ms) : 187, 194
. : milestone, 191,
master - mean (190ms) : 186, 194
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (6004) - mean (1,166ms) : 1126, 1207
. : milestone, 1166,
master - mean (1,165ms) : 1135, 1194
. : milestone, 1165,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6004) - mean (276ms) : 272, 280
. : milestone, 276,
master - mean (276ms) : 272, 280
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (6004) - mean (923ms) : 897, 949
. : milestone, 923,
master - mean (927ms) : 906, 947
. : milestone, 927,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6004) - mean (265ms) : 261, 268
. : milestone, 265,
master - mean (265ms) : 261, 268
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (6004) - mean (915ms) : 889, 941
. : milestone, 915,
master - mean (905ms) : 876, 934
. : milestone, 905,
Throughput results for AspNetCoreSimpleController comparing the following branches/commits:
Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.
Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!
gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6004) (11.182M) : 0, 11182465
master (11.202M) : 0, 11202155
benchmarks/2.9.0 (11.142M) : 0, 11142344
section Automatic
This PR (6004) (7.452M) : 0, 7451842
master (7.437M) : 0, 7437019
benchmarks/2.9.0 (7.893M) : 0, 7893301
section Trace stats
master (7.824M) : 0, 7824309
section Manual
master (11.306M) : 0, 11305639
section Manual + Automatic
This PR (6004) (6.956M) : 0, 6956259
master (6.918M) : 0, 6917708
section DD_TRACE_ENABLED=0
master (10.325M) : 0, 10325290
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6004) (9.627M) : 0, 9627173
master (9.731M) : 0, 9730961
benchmarks/2.9.0 (9.585M) : 0, 9584514
section Automatic
This PR (6004) (6.617M) : 0, 6617147
master (6.575M) : 0, 6574988
section Trace stats
master (7.001M) : 0, 7000523
section Manual
master (9.504M) : 0, 9504255
section Manual + Automatic
This PR (6004) (6.190M) : 0, 6190225
master (6.217M) : 0, 6216600
section DD_TRACE_ENABLED=0
master (9.049M) : 0, 9048961
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6004) (10.038M) : 0, 10038178
master (10.040M) : 0, 10040090
benchmarks/2.9.0 (10.094M) : 0, 10093850
section Automatic
This PR (6004) (6.699M) : 0, 6699496
master (6.783M) : 0, 6782944
benchmarks/2.9.0 (7.257M) : 0, 7257483
section Trace stats
master (7.323M) : 0, 7323194
section Manual
master (10.061M) : 0, 10060796
section Manual + Automatic
This PR (6004) (6.104M) : 0, 6104176
master (6.342M) : 0, 6342001
section DD_TRACE_ENABLED=0
master (9.357M) : 0, 9357055
Benchmarks for #6004 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored.
Summary of changes
Reason for change
The code we were using to install the "local" builds of the NuGet packages added the local source. However the dotnet restore was looking in both the local and nuget.org sources, and installing the highest version it found. That worked fine until we released 3.2.0 publicly and expect to install 2.59.0 of the local build.
Implementation details
Install an explicit version of the tracer. As this version is never in the public nuget.org source but is in the local source, it uses that.
Having to thread the version through everywhere is kinda horrible, but is the only thing I could find that works.
Test coverage
Will run a full installer test
Other details
The whole approach should be rewritten to be managed by Nuke tbh, if we ever find time
This PR is a "forward port" of
(the issue was exhibited on the 2.x branch, so this is preemptive for the future)