Fix the trace pipeline stage

andrewlock commented 3 weeks ago

Summary of changes

Fixes the trace-pipeline stage

Reason for change

We broke it in v3 because it uses manual-only instrumentation 🙈

Implementation details

Install and use the latest dd-trace tool from nuget.org. The trace pipeline installs the latest Datadog.Trace NuGet package, so by installing the latest dd-trace we're matching package versions correctly here too, so no need to thread the version through explicitly I think.

Test coverage

Before 🙁

After 😃

Other details

The release/2.x branch pipeline isn't broken, so this doesn't need backporting

datadog-ddstaging[bot] commented 3 weeks ago

Datadog Report

Branch report: andrew/ci/fix-pipeline Commit report: 92cd498 Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 364381 Passed, 2073 Skipped, 15h 10m 12.22s Total Time

andrewlock commented 3 weeks ago

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6007) - mean (70ms)  : 67, 72
     .   : milestone, 70,
    master - mean (69ms)  : 67, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6007) - mean (1,084ms)  : 1059, 1109
     .   : milestone, 1084,
    master - mean (1,077ms)  : 1052, 1103
     .   : milestone, 1077,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6007) - mean (110ms)  : 106, 114
     .   : milestone, 110,
    master - mean (108ms)  : 105, 111
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6007) - mean (759ms)  : 742, 776
     .   : milestone, 759,
    master - mean (757ms)  : 739, 775
     .   : milestone, 757,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6007) - mean (92ms)  : 89, 95
     .   : milestone, 92,
    master - mean (91ms)  : 89, 94
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6007) - mean (715ms)  : 694, 736
     .   : milestone, 715,
    master - mean (711ms)  : 687, 735
     .   : milestone, 711,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6007) - mean (189ms)  : 186, 193
     .   : milestone, 189,
    master - mean (192ms)  : 187, 197
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (6007) - mean (1,168ms)  : 1138, 1197
     .   : milestone, 1168,
    master - mean (1,167ms)  : 1137, 1197
     .   : milestone, 1167,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6007) - mean (275ms)  : 270, 280
     .   : milestone, 275,
    master - mean (274ms)  : 270, 279
     .   : milestone, 274,

    section CallTarget+Inlining+NGEN
    This PR (6007) - mean (923ms)  : 904, 942
     .   : milestone, 923,
    master - mean (921ms)  : 900, 942
     .   : milestone, 921,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6007) - mean (264ms)  : 260, 268
     .   : milestone, 264,
    master - mean (264ms)  : 260, 267
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (6007) - mean (901ms)  : 879, 923
     .   : milestone, 901,
    master - mean (904ms)  : 884, 923
     .   : milestone, 904,

andrewlock commented 3 weeks ago

Benchmarks Report for tracer :snail:

Benchmarks for #6007 compared to master:

1 benchmarks are faster, with geometric mean 1.120
1 benchmarks are slower, with geometric mean 1.167
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`StartStopWithChild`|net6.0|7.75μs|44.4ns|347ns|0.0149| 0.00745|0|5.43 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`StartStopWithChild`|netcoreapp3.1|9.9μs|54.4ns|326ns|0.0196| 0.0098|0|5.62 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`StartStopWithChild`|net472|15.9μs|41.5ns|155ns|1.02| 0.308|0.103|6.07 KB| |#6007|`StartStopWithChild`|net6.0|7.73μs|44ns|327ns|0.0145| 0.00727|0|5.43 KB| |#6007|`StartStopWithChild`|netcoreapp3.1|9.94μs|55.4ns|368ns|0.0147| 0.00489|0|5.62 KB| |#6007|`StartStopWithChild`|net472|16.2μs|63.7ns|247ns|1.02| 0.308|0.0891|6.06 KB|

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`WriteAndFlushEnrichedTraces`|net6.0|483μs|226ns|846ns|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|633μs|274ns|1.03μs|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`WriteAndFlushEnrichedTraces`|net472|830μs|725ns|2.81μs|0.414| 0|0|3.3 KB| |#6007|`WriteAndFlushEnrichedTraces`|net6.0|460μs|229ns|857ns|0| 0|0|2.7 KB| |#6007|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|633μs|200ns|747ns|0| 0|0|2.7 KB| |#6007|`WriteAndFlushEnrichedTraces`|net472|843μs|555ns|2.15μs|0.422| 0|0|3.3 KB|

Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`SendRequest`|net6.0|200μs|1.1μs|7.49μs|0.198| 0|0|18.45 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`SendRequest`|netcoreapp3.1|217μs|1.26μs|11.8μs|0.224| 0|0|20.61 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`SendRequest`|net472|0.00995ns|0.00278ns|0.01ns|0| 0|0|0 b| |#6007|`SendRequest`|net6.0|199μs|1.16μs|10.3μs|0.184| 0|0|18.45 KB| |#6007|`SendRequest`|netcoreapp3.1|223μs|1.3μs|12.3μs|0.226| 0|0|20.61 KB| |#6007|`SendRequest`|net472|0.00103ns|0.000468ns|0.00181ns|0| 0|0|0 b|

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`WriteAndFlushEnrichedTraces`|net6.0|559μs|1.85μs|6.92μs|0.576| 0|0|41.66 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|686μs|3.74μs|22.7μs|0.336| 0|0|41.66 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`WriteAndFlushEnrichedTraces`|net472|889μs|4.39μs|18.1μs|8.13| 2.57|0.428|53.32 KB| |#6007|`WriteAndFlushEnrichedTraces`|net6.0|555μs|2.59μs|9.69μs|0.556| 0|0|41.47 KB| |#6007|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|706μs|3.57μs|16μs|0.327| 0|0|41.55 KB| |#6007|`WriteAndFlushEnrichedTraces`|net472|865μs|4.37μs|20μs|8.74| 2.62|0.437|53.27 KB|

Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`ExecuteNonQuery`|net6.0|1.4μs|1.87ns|7.23ns|0.0139| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`ExecuteNonQuery`|netcoreapp3.1|1.82μs|1.94ns|7.51ns|0.0136| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`ExecuteNonQuery`|net472|2.09μs|1.66ns|6.42ns|0.156| 0|0|987 B| |#6007|`ExecuteNonQuery`|net6.0|1.46μs|1.7ns|6.6ns|0.0145| 0|0|1.02 KB| |#6007|`ExecuteNonQuery`|netcoreapp3.1|1.75μs|1.94ns|7.24ns|0.0138| 0|0|1.02 KB| |#6007|`ExecuteNonQuery`|net472|2.09μs|2.19ns|8.21ns|0.156| 0|0|987 B|

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`CallElasticsearch`|net6.0|1.23μs|0.729ns|2.82ns|0.0137| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`CallElasticsearch`|netcoreapp3.1|1.51μs|0.702ns|2.63ns|0.0129| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`CallElasticsearch`|net472|2.5μs|0.92ns|3.44ns|0.157| 0|0|995 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`CallElasticsearchAsync`|net6.0|1.33μs|0.822ns|3.18ns|0.0132| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`CallElasticsearchAsync`|netcoreapp3.1|1.61μs|0.903ns|3.5ns|0.0137| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`CallElasticsearchAsync`|net472|2.58μs|1.03ns|3.85ns|0.166| 0|0|1.05 KB| |#6007|`CallElasticsearch`|net6.0|1.16μs|0.438ns|1.58ns|0.0135| 0|0|976 B| |#6007|`CallElasticsearch`|netcoreapp3.1|1.56μs|0.56ns|2.09ns|0.0133| 0|0|976 B| |#6007|`CallElasticsearch`|net472|2.52μs|1.84ns|7.14ns|0.158| 0.00125|0|995 B| |#6007|`CallElasticsearchAsync`|net6.0|1.28μs|1.08ns|4.16ns|0.0134| 0|0|952 B| |#6007|`CallElasticsearchAsync`|netcoreapp3.1|1.65μs|0.894ns|3.46ns|0.0132| 0|0|1.02 KB| |#6007|`CallElasticsearchAsync`|net472|2.69μs|2.48ns|9.59ns|0.167| 0.00134|0|1.05 KB|

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`ExecuteAsync`|net6.0|1.2μs|0.568ns|2.2ns|0.0132| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`ExecuteAsync`|netcoreapp3.1|1.58μs|1.74ns|6.74ns|0.0126| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`ExecuteAsync`|net472|1.64μs|0.956ns|3.7ns|0.145| 0|0|915 B| |#6007|`ExecuteAsync`|net6.0|1.31μs|0.916ns|3.55ns|0.0137| 0|0|952 B| |#6007|`ExecuteAsync`|netcoreapp3.1|1.75μs|0.944ns|3.53ns|0.0131| 0|0|952 B| |#6007|`ExecuteAsync`|net472|1.8μs|1.32ns|5.13ns|0.145| 0|0|915 B|

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`SendAsync`|net6.0|4.26μs|1.41ns|5.07ns|0.0301| 0|0|2.22 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`SendAsync`|netcoreapp3.1|5.09μs|2.47ns|9.56ns|0.0356| 0|0|2.76 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`SendAsync`|net472|7.81μs|1.96ns|7.59ns|0.497| 0|0|3.15 KB| |#6007|`SendAsync`|net6.0|4.38μs|0.701ns|2.43ns|0.0303| 0|0|2.22 KB| |#6007|`SendAsync`|netcoreapp3.1|5.1μs|1.74ns|6.76ns|0.0357| 0|0|2.76 KB| |#6007|`SendAsync`|net472|7.96μs|2.05ns|7.67ns|0.497| 0|0|3.15 KB|

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`EnrichedLog`|net6.0|1.57μs|0.934ns|3.62ns|0.0227| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`EnrichedLog`|netcoreapp3.1|2.3μs|1.36ns|5.1ns|0.0218| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`EnrichedLog`|net472|2.72μs|2.26ns|8.75ns|0.249| 0|0|1.57 KB| |#6007|`EnrichedLog`|net6.0|1.48μs|0.919ns|3.44ns|0.0229| 0|0|1.64 KB| |#6007|`EnrichedLog`|netcoreapp3.1|2.25μs|1.01ns|3.63ns|0.0213| 0|0|1.64 KB| |#6007|`EnrichedLog`|net472|2.69μs|6.24ns|24.2ns|0.249| 0|0|1.57 KB|

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`EnrichedLog`|net6.0|116μs|189ns|732ns|0| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`EnrichedLog`|netcoreapp3.1|118μs|122ns|471ns|0| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`EnrichedLog`|net472|150μs|137ns|530ns|0.67| 0.223|0|4.46 KB| |#6007|`EnrichedLog`|net6.0|117μs|188ns|728ns|0.0582| 0|0|4.28 KB| |#6007|`EnrichedLog`|netcoreapp3.1|120μs|229ns|857ns|0.0604| 0|0|4.28 KB| |#6007|`EnrichedLog`|net472|149μs|400ns|1.55μs|0.666| 0.222|0|4.46 KB|

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`EnrichedLog`|net6.0|2.92μs|0.955ns|3.7ns|0.0307| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`EnrichedLog`|netcoreapp3.1|4.26μs|4.03ns|15.6ns|0.028| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`EnrichedLog`|net472|4.84μs|1.26ns|4.71ns|0.32| 0|0|2.02 KB| |#6007|`EnrichedLog`|net6.0|3.08μs|0.799ns|2.99ns|0.0312| 0|0|2.2 KB| |#6007|`EnrichedLog`|netcoreapp3.1|4.26μs|2.23ns|8.63ns|0.0297| 0|0|2.2 KB| |#6007|`EnrichedLog`|net472|4.8μs|0.874ns|3.38ns|0.32| 0|0|2.02 KB|

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`SendReceive`|net6.0|1.37μs|0.743ns|2.88ns|0.0157| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`SendReceive`|netcoreapp3.1|1.71μs|1.21ns|4.7ns|0.0155| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`SendReceive`|net472|2.16μs|1.58ns|6.11ns|0.183| 0.00108|0|1.16 KB| |#6007|`SendReceive`|net6.0|1.4μs|0.521ns|1.95ns|0.0162| 0|0|1.14 KB| |#6007|`SendReceive`|netcoreapp3.1|1.8μs|1.15ns|4.46ns|0.0153| 0|0|1.14 KB| |#6007|`SendReceive`|net472|2.12μs|1.25ns|4.33ns|0.183| 0.00106|0|1.16 KB|

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`EnrichedLog`|net6.0|2.89μs|1.19ns|4.61ns|0.0218| 0|0|1.6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`EnrichedLog`|netcoreapp3.1|3.92μs|1.67ns|6.49ns|0.0215| 0|0|1.65 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`EnrichedLog`|net472|4.47μs|2.18ns|8.44ns|0.323| 0|0|2.04 KB| |#6007|`EnrichedLog`|net6.0|2.83μs|1.17ns|4.4ns|0.0227| 0|0|1.6 KB| |#6007|`EnrichedLog`|netcoreapp3.1|3.83μs|2.23ns|8.63ns|0.0209| 0|0|1.65 KB| |#6007|`EnrichedLog`|net472|4.35μs|3.12ns|12.1ns|0.323| 0|0|2.04 KB|

Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #6007 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 | 1.167 | 396.13 | 462.44 | #### Faster :tada: in #6007 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 | 1.120 | 787.65 | 703.32 |

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`StartFinishSpan`|net6.0|396ns|0.365ns|1.41ns|0.00809| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`StartFinishSpan`|netcoreapp3.1|559ns|0.538ns|2.09ns|0.00772| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`StartFinishSpan`|net472|643ns|0.836ns|3.24ns|0.0916| 0|0|578 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`StartFinishScope`|net6.0|526ns|0.344ns|1.33ns|0.00966| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`StartFinishScope`|netcoreapp3.1|787ns|0.849ns|3.29ns|0.00937| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`StartFinishScope`|net472|892ns|0.932ns|3.61ns|0.105| 0|0|658 B| |#6007|`StartFinishSpan`|net6.0|462ns|0.242ns|0.937ns|0.00808| 0|0|576 B| |#6007|`StartFinishSpan`|netcoreapp3.1|605ns|0.476ns|1.84ns|0.00772| 0|0|576 B| |#6007|`StartFinishSpan`|net472|675ns|0.894ns|3.35ns|0.0916| 0|0|578 B| |#6007|`StartFinishScope`|net6.0|573ns|0.436ns|1.69ns|0.00978| 0|0|696 B| |#6007|`StartFinishScope`|netcoreapp3.1|703ns|0.51ns|1.97ns|0.00958| 0|0|696 B| |#6007|`StartFinishScope`|net472|860ns|0.702ns|2.63ns|0.104| 0|0|658 B|

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`RunOnMethodBegin`|net6.0|651ns|0.591ns|2.29ns|0.00973| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`RunOnMethodBegin`|netcoreapp3.1|951ns|0.678ns|2.54ns|0.00922| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/5c5bec1b893b52c2364a2bf2b66c58a92e6d7d83)|`RunOnMethodBegin`|net472|1.07μs|1.19ns|4.61ns|0.105| 0|0|658 B| |#6007|`RunOnMethodBegin`|net6.0|587ns|0.351ns|1.31ns|0.00986| 0|0|696 B| |#6007|`RunOnMethodBegin`|netcoreapp3.1|938ns|1.16ns|4.5ns|0.00933| 0|0|696 B| |#6007|`RunOnMethodBegin`|net472|1.1μs|0.889ns|3.44ns|0.104| 0|0|658 B|

andrewlock commented 3 weeks ago

Throughput/Crank Report :zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6007) (11.115M)   : 0, 11114650
    master (11.143M)   : 0, 11143432
    benchmarks/2.9.0 (11.151M)   : 0, 11151473

    section Automatic
    This PR (6007) (7.368M)   : 0, 7368046
    master (7.488M)   : 0, 7488306
    benchmarks/2.9.0 (7.902M)   : 0, 7902288

    section Trace stats
    master (7.688M)   : 0, 7688184

    section Manual
    master (11.009M)   : 0, 11009071

    section Manual + Automatic
    This PR (6007) (6.725M)   : 0, 6724827
    master (6.881M)   : 0, 6881454

    section DD_TRACE_ENABLED=0
    master (10.219M)   : 0, 10219353

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6007) (9.619M)   : 0, 9618538
    master (9.535M)   : 0, 9535092
    benchmarks/2.9.0 (9.808M)   : 0, 9808052

    section Automatic
    This PR (6007) (6.717M)   : 0, 6716892
    master (6.544M)   : 0, 6544374

    section Trace stats
    master (6.842M)   : 0, 6841532

    section Manual
    master (9.490M)   : 0, 9490033

    section Manual + Automatic
    This PR (6007) (6.078M)   : 0, 6078262
    master (6.233M)   : 0, 6232529

    section DD_TRACE_ENABLED=0
    master (8.978M)   : 0, 8977612

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6007) (9.982M)   : 0, 9981572
    master (10.020M)   : 0, 10020240
    benchmarks/2.9.0 (10.095M)   : 0, 10094883

    section Automatic
    This PR (6007) (6.631M)   : 0, 6631450
    master (6.634M)   : 0, 6634309
    benchmarks/2.9.0 (7.494M)   : 0, 7494302

    section Trace stats
    master (7.438M)   : 0, 7437728

    section Manual
    master (9.979M)   : 0, 9978938

    section Manual + Automatic
    This PR (6007) (6.220M)   : 0, 6219943
    master (6.374M)   : 0, 6373571

    section DD_TRACE_ENABLED=0
    master (9.455M)   : 0, 9455249

DataDog / dd-trace-dotnet