DataDog / dd-trace-dotnet

.NET Client Library for Datadog APM
https://docs.datadoghq.com/tracing/
Apache License 2.0
456 stars 142 forks source link

Set "component" tag for ASP.NET #6010

Open bouwkast opened 2 months ago

bouwkast commented 2 months ago

Summary of changes

Sets component tag for ASP.NET to aspnet

Reason for change

component tag was missing.

Implementation details

Add missing tag.

Test coverage

Lots of snapshots

Other details

andrewlock commented 2 months ago

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6010) - mean (71ms)  : 68, 73
     .   : milestone, 71,
    master - mean (71ms)  : 68, 73
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (6010) - mean (1,122ms)  : 1097, 1146
     .   : milestone, 1122,
    master - mean (1,117ms)  : 1096, 1138
     .   : milestone, 1117,
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6010) - mean (110ms)  : 107, 113
     .   : milestone, 110,
    master - mean (110ms)  : 107, 114
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (6010) - mean (780ms)  : 761, 799
     .   : milestone, 780,
    master - mean (778ms)  : 763, 793
     .   : milestone, 778,
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6010) - mean (94ms)  : 90, 97
     .   : milestone, 94,
    master - mean (93ms)  : 90, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6010) - mean (730ms)  : 714, 746
     .   : milestone, 730,
    master - mean (735ms)  : 716, 753
     .   : milestone, 735,
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6010) - mean (191ms)  : 187, 195
     .   : milestone, 191,
    master - mean (191ms)  : 188, 193
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6010) - mean (1,202ms)  : 1181, 1223
     .   : milestone, 1202,
    master - mean (1,201ms)  : 1177, 1225
     .   : milestone, 1201,
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6010) - mean (276ms)  : 271, 281
     .   : milestone, 276,
    master - mean (275ms)  : 271, 280
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (6010) - mean (942ms)  : 924, 959
     .   : milestone, 942,
    master - mean (943ms)  : 923, 964
     .   : milestone, 943,
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6010) - mean (265ms)  : 261, 269
     .   : milestone, 265,
    master - mean (264ms)  : 260, 269
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (6010) - mean (927ms)  : 909, 944
     .   : milestone, 927,
    master - mean (927ms)  : 909, 946
     .   : milestone, 927,
datadog-ddstaging[bot] commented 2 months ago

Datadog Report

Branch report: steven/AIDM-312 Commit report: 4540146 Test service: dd-trace-dotnet

:x: 6 Failed (1 Known Flaky), 468894 Passed, 3265 Skipped, 28h 55m 43.35s Total Time

:x: Failed Tests (6)

This report shows up to 5 failed tests.

  • WriteAndFlushEnrichedTraces - Benchmarks.Trace.AgentWriterBenchmark - Details
andrewlock commented 2 months ago

Throughput/Crank Report :zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6010) (11.204M)   : 0, 11204202
    master (11.115M)   : 0, 11115307
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6010) (7.293M)   : 0, 7293026
    master (7.335M)   : 0, 7334625
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.700M)   : 0, 7700429

    section Manual
    master (10.990M)   : 0, 10989510

    section Manual + Automatic
    This PR (6010) (6.869M)   : 0, 6869215
    master (6.780M)   : 0, 6780487

    section DD_TRACE_ENABLED=0
    master (10.305M)   : 0, 10305060
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6010) (9.531M)   : 0, 9530910
    master (9.774M)   : 0, 9773727
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6010) (6.474M)   : 0, 6474248
    master (6.463M)   : 0, 6462618

    section Trace stats
    master (6.907M)   : 0, 6906626

    section Manual
    master (9.697M)   : 0, 9697280

    section Manual + Automatic
    This PR (6010) (6.172M)   : 0, 6172072
    master (6.155M)   : 0, 6155472

    section DD_TRACE_ENABLED=0
    master (8.868M)   : 0, 8867528
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6010) (9.775M)   : 0, 9775351
    master (10.077M)   : 0, 10076675
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6010) (6.472M)   : 0, 6472450
    master (6.567M)   : 0, 6566975
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.314M)   : 0, 7314135

    section Manual
    master (10.073M)   : 0, 10073436

    section Manual + Automatic
    This PR (6010) (6.103M)   : 0, 6103152
    master (6.134M)   : 0, 6134127

    section DD_TRACE_ENABLED=0
    master (9.536M)   : 0, 9535909
andrewlock commented 2 months ago

Benchmarks Report for tracer :snail:

Benchmarks for #6010 compared to master:

The following thresholds were used for comparing the benchmark speeds:

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`StartStopWithChild`|net6.0|7.66μs|41ns|232ns|0.0204| 0.00816|0|5.43 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`StartStopWithChild`|netcoreapp3.1|10.1μs|55.3ns|336ns|0.0146| 0.00486|0|5.62 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`StartStopWithChild`|net472|16.3μs|71.4ns|277ns|1.02| 0.302|0.0953|6.07 KB| |#6010|`StartStopWithChild`|net6.0|7.85μs|42.5ns|300ns|0.0154| 0.0077|0|5.43 KB| |#6010|`StartStopWithChild`|netcoreapp3.1|10.2μs|55.7ns|305ns|0.0197| 0.00987|0|5.62 KB| |#6010|`StartStopWithChild`|net472|16μs|38.5ns|149ns|1.03| 0.325|0.0951|6.07 KB|
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`WriteAndFlushEnrichedTraces`|net6.0|459μs|467ns|1.75μs|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|632μs|410ns|1.59μs|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`WriteAndFlushEnrichedTraces`|net472|816μs|590ns|2.28μs|0.408| 0|0|3.3 KB| |#6010|`WriteAndFlushEnrichedTraces`|net6.0|468μs|208ns|779ns|0| 0|0|2.7 KB| |#6010|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|632μs|174ns|628ns|0| 0|0|2.7 KB| |#6010|`WriteAndFlushEnrichedTraces`|net472|830μs|352ns|1.32μs|0.414| 0|0|3.3 KB|
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`SendRequest`|net6.0|195μs|1.07μs|7.85μs|0.188| 0|0|18.45 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`SendRequest`|netcoreapp3.1|219μs|1.26μs|9.24μs|0.204| 0|0|20.61 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`SendRequest`|net472|0.00322ns|0.00106ns|0.00409ns|0| 0|0|0 b| |#6010|`SendRequest`|net6.0|192μs|1.04μs|6μs|0.192| 0|0|18.45 KB| |#6010|`SendRequest`|netcoreapp3.1|223μs|1.25μs|8.87μs|0.215| 0|0|20.61 KB| |#6010|`SendRequest`|net472|0.000622ns|0.000338ns|0.00127ns|0| 0|0|0 b|
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`WriteAndFlushEnrichedTraces`|net6.0|567μs|2.59μs|9.7μs|0.561| 0|0|41.58 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|694μs|3.74μs|19.8μs|0.331| 0|0|41.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`WriteAndFlushEnrichedTraces`|net472|860μs|3.08μs|11.5μs|8.5| 2.55|0.425|53.31 KB| |#6010|`WriteAndFlushEnrichedTraces`|net6.0|565μs|2.04μs|7.63μs|0.566| 0|0|41.67 KB| |#6010|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|680μs|3.04μs|11μs|0.345| 0|0|41.86 KB| |#6010|`WriteAndFlushEnrichedTraces`|net472|883μs|3.31μs|12.8μs|8.74| 2.62|0.437|53.32 KB|
Benchmarks.Trace.DbCommandBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #6010 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 | 1.145 | 1,253.16 | 1,435.12 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`ExecuteNonQuery`|net6.0|1.25μs|1.32ns|5.13ns|0.0145| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`ExecuteNonQuery`|netcoreapp3.1|1.74μs|0.908ns|3.4ns|0.0132| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`ExecuteNonQuery`|net472|2.1μs|1.63ns|6.3ns|0.156| 0|0|987 B| |#6010|`ExecuteNonQuery`|net6.0|1.44μs|1.6ns|6.21ns|0.0144| 0|0|1.02 KB| |#6010|`ExecuteNonQuery`|netcoreapp3.1|1.77μs|1.22ns|4.41ns|0.0133| 0|0|1.02 KB| |#6010|`ExecuteNonQuery`|net472|2.1μs|1.1ns|3.96ns|0.156| 0|0|987 B|
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`CallElasticsearch`|net6.0|1.19μs|2.72ns|10.5ns|0.0138| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`CallElasticsearch`|netcoreapp3.1|1.51μs|0.484ns|1.81ns|0.0128| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`CallElasticsearch`|net472|2.55μs|2.83ns|11ns|0.158| 0|0|995 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`CallElasticsearchAsync`|net6.0|1.2μs|0.846ns|3.28ns|0.0131| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`CallElasticsearchAsync`|netcoreapp3.1|1.7μs|0.992ns|3.71ns|0.0135| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`CallElasticsearchAsync`|net472|2.62μs|2.56ns|9.9ns|0.166| 0|0|1.05 KB| |#6010|`CallElasticsearch`|net6.0|1.18μs|0.588ns|2.28ns|0.0135| 0|0|976 B| |#6010|`CallElasticsearch`|netcoreapp3.1|1.58μs|0.83ns|3.11ns|0.0135| 0|0|976 B| |#6010|`CallElasticsearch`|net472|2.46μs|1.98ns|7.65ns|0.157| 0|0|995 B| |#6010|`CallElasticsearchAsync`|net6.0|1.25μs|0.314ns|1.17ns|0.013| 0|0|952 B| |#6010|`CallElasticsearchAsync`|netcoreapp3.1|1.68μs|0.825ns|2.98ns|0.0134| 0|0|1.02 KB| |#6010|`CallElasticsearchAsync`|net472|2.57μs|1.64ns|6.34ns|0.167| 0|0|1.05 KB|
Benchmarks.Trace.GraphQLBenchmark - Faster :tada: Same allocations :heavy_check_mark: #### Faster :tada: in #6010 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 | 1.120 | 1,384.54 | 1,236.21 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`ExecuteAsync`|net6.0|1.38μs|0.977ns|3.65ns|0.0131| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`ExecuteAsync`|netcoreapp3.1|1.62μs|0.528ns|1.9ns|0.013| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`ExecuteAsync`|net472|1.76μs|0.534ns|2.07ns|0.145| 0|0|915 B| |#6010|`ExecuteAsync`|net6.0|1.24μs|1.16ns|4.49ns|0.0136| 0|0|952 B| |#6010|`ExecuteAsync`|netcoreapp3.1|1.69μs|2.08ns|7.78ns|0.0126| 0|0|952 B| |#6010|`ExecuteAsync`|net472|1.76μs|0.399ns|1.55ns|0.145| 0|0|915 B|
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`SendAsync`|net6.0|4.23μs|10.6ns|41.1ns|0.0317| 0|0|2.22 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`SendAsync`|netcoreapp3.1|4.96μs|1.93ns|7.24ns|0.0372| 0|0|2.76 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`SendAsync`|net472|7.66μs|2.95ns|11.4ns|0.499| 0|0|3.15 KB| |#6010|`SendAsync`|net6.0|4.2μs|2.27ns|8.2ns|0.0312| 0|0|2.22 KB| |#6010|`SendAsync`|netcoreapp3.1|5.01μs|2.08ns|8.05ns|0.0375| 0|0|2.76 KB| |#6010|`SendAsync`|net472|7.85μs|1.33ns|5.17ns|0.498| 0|0|3.15 KB|
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`EnrichedLog`|net6.0|1.53μs|0.952ns|3.69ns|0.0229| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`EnrichedLog`|netcoreapp3.1|2.33μs|2.57ns|9.63ns|0.022| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`EnrichedLog`|net472|2.61μs|1.14ns|4.26ns|0.25| 0|0|1.57 KB| |#6010|`EnrichedLog`|net6.0|1.46μs|0.83ns|3.11ns|0.0234| 0|0|1.64 KB| |#6010|`EnrichedLog`|netcoreapp3.1|2.11μs|0.853ns|3.31ns|0.0221| 0|0|1.64 KB| |#6010|`EnrichedLog`|net472|2.76μs|1.07ns|4.14ns|0.249| 0|0|1.57 KB|
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`EnrichedLog`|net6.0|114μs|147ns|550ns|0.0571| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`EnrichedLog`|netcoreapp3.1|118μs|240ns|928ns|0.0597| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`EnrichedLog`|net472|147μs|156ns|603ns|0.662| 0.221|0|4.46 KB| |#6010|`EnrichedLog`|net6.0|114μs|140ns|544ns|0| 0|0|4.28 KB| |#6010|`EnrichedLog`|netcoreapp3.1|119μs|156ns|605ns|0| 0|0|4.28 KB| |#6010|`EnrichedLog`|net472|146μs|103ns|385ns|0.655| 0.218|0|4.46 KB|
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`EnrichedLog`|net6.0|3.22μs|1.67ns|6.46ns|0.0306| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`EnrichedLog`|netcoreapp3.1|4.12μs|5.94ns|23ns|0.0286| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`EnrichedLog`|net472|4.75μs|2.03ns|7.86ns|0.32| 0|0|2.02 KB| |#6010|`EnrichedLog`|net6.0|3.18μs|1.05ns|4.06ns|0.0303| 0|0|2.2 KB| |#6010|`EnrichedLog`|netcoreapp3.1|4.24μs|5.05ns|19.5ns|0.0296| 0|0|2.2 KB| |#6010|`EnrichedLog`|net472|5μs|2.88ns|10.8ns|0.32| 0|0|2.02 KB|
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`SendReceive`|net6.0|1.27μs|0.633ns|2.37ns|0.0159| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`SendReceive`|netcoreapp3.1|1.76μs|0.651ns|2.52ns|0.015| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`SendReceive`|net472|2.07μs|0.948ns|3.55ns|0.183| 0|0|1.16 KB| |#6010|`SendReceive`|net6.0|1.35μs|0.677ns|2.62ns|0.0161| 0|0|1.14 KB| |#6010|`SendReceive`|netcoreapp3.1|1.71μs|1.57ns|6.07ns|0.0161| 0|0|1.14 KB| |#6010|`SendReceive`|net472|2.15μs|0.82ns|2.96ns|0.183| 0.00107|0|1.16 KB|
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`EnrichedLog`|net6.0|2.81μs|0.942ns|3.65ns|0.0224| 0|0|1.6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`EnrichedLog`|netcoreapp3.1|3.88μs|2.39ns|9.27ns|0.0215| 0|0|1.65 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`EnrichedLog`|net472|4.31μs|2.81ns|10.9ns|0.323| 0|0|2.04 KB| |#6010|`EnrichedLog`|net6.0|2.81μs|0.901ns|3.37ns|0.0225| 0|0|1.6 KB| |#6010|`EnrichedLog`|netcoreapp3.1|3.81μs|1.35ns|5.24ns|0.021| 0|0|1.65 KB| |#6010|`EnrichedLog`|net472|4.32μs|2.99ns|11.6ns|0.322| 0|0|2.04 KB|
Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #6010 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 | 1.220 | 470.33 | 573.98 | | Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 | 1.200 | 542.02 | 650.35 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`StartFinishSpan`|net6.0|399ns|0.421ns|1.63ns|0.00818| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`StartFinishSpan`|netcoreapp3.1|541ns|0.532ns|2.06ns|0.00794| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`StartFinishSpan`|net472|735ns|0.366ns|1.42ns|0.0916| 0|0|578 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`StartFinishScope`|net6.0|471ns|0.411ns|1.59ns|0.00971| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`StartFinishScope`|netcoreapp3.1|729ns|0.285ns|1.1ns|0.00918| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`StartFinishScope`|net472|894ns|1.61ns|6.23ns|0.104| 0|0|658 B| |#6010|`StartFinishSpan`|net6.0|401ns|0.328ns|1.27ns|0.00807| 0|0|576 B| |#6010|`StartFinishSpan`|netcoreapp3.1|650ns|0.571ns|2.13ns|0.00781| 0|0|576 B| |#6010|`StartFinishSpan`|net472|714ns|0.669ns|2.59ns|0.0918| 0|0|578 B| |#6010|`StartFinishScope`|net6.0|574ns|0.312ns|1.21ns|0.00988| 0|0|696 B| |#6010|`StartFinishScope`|netcoreapp3.1|775ns|0.788ns|2.95ns|0.00932| 0|0|696 B| |#6010|`StartFinishScope`|net472|925ns|0.83ns|3.21ns|0.104| 0|0|658 B|
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #6010 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 | 1.155 | 847.61 | 978.71 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`RunOnMethodBegin`|net6.0|606ns|0.269ns|1.01ns|0.00975| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`RunOnMethodBegin`|netcoreapp3.1|848ns|0.522ns|1.81ns|0.00937| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f64cde135aa18dbe20677918f02c97de96145949)|`RunOnMethodBegin`|net472|1.02μs|0.635ns|2.46ns|0.104| 0|0|658 B| |#6010|`RunOnMethodBegin`|net6.0|665ns|0.4ns|1.55ns|0.00965| 0|0|696 B| |#6010|`RunOnMethodBegin`|netcoreapp3.1|979ns|0.793ns|3.07ns|0.00966| 0|0|696 B| |#6010|`RunOnMethodBegin`|net472|1.12μs|1.18ns|4.56ns|0.104| 0|0|658 B|
github-actions[bot] commented 2 months ago

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer. The diff is simplistic, so please check some files anyway while we improve it.

2141 occurrences of :

+      component: aspnet,