DataDog / dd-trace-dotnet

.NET Client Library for Datadog APM
https://docs.datadoghq.com/tracing/
Apache License 2.0
437 stars 137 forks source link

[ASM] Change stack trim proportion #6011

Closed daniel-romano-DD closed 2 weeks ago

daniel-romano-DD commented 3 weeks ago

Summary of changes

Right now, when reporting a stack, we trim the stack, providing 25% of the max count from the upper frames and 75% from the bottom. As discussed with other library teams, this has proven to add poor information, being much more valuable the upper frames then the lower ones. Make this proportion configurable by an envvar

Reason for change

Trimmed stacks submitted to backend with IAST vulnerabilities or RASP blocking events, when trimmed, add poor information to the client

Implementation details

Added an env var to tell how many top frames will be retrieved in proportion.

Test coverage

Unit tests.

Other details

dd-go PR

datadog-ddstaging[bot] commented 3 weeks ago

Datadog Report

Branch report: dani/asm/improve_stack_trimming Commit report: 72c3458 Test service: dd-trace-dotnet

:x: 1 Failed (1 Known Flaky), 366417 Passed, 2082 Skipped, 15h 44m 0.83s Total Time

:x: Failed Tests (1)

andrewlock commented 3 weeks ago

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6011) - mean (70ms)  : 66, 73
     .   : milestone, 70,
    master - mean (69ms)  : 67, 71
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6011) - mean (1,114ms)  : 1096, 1133
     .   : milestone, 1114,
    master - mean (1,118ms)  : 1090, 1147
     .   : milestone, 1118,
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6011) - mean (108ms)  : 105, 110
     .   : milestone, 108,
    master - mean (109ms)  : 105, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6011) - mean (811ms)  : 792, 830
     .   : milestone, 811,
    master - mean (809ms)  : 789, 829
     .   : milestone, 809,
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6011) - mean (92ms)  : 89, 95
     .   : milestone, 92,
    master - mean (92ms)  : 89, 95
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6011) - mean (770ms)  : 752, 788
     .   : milestone, 770,
    master - mean (768ms)  : 748, 788
     .   : milestone, 768,
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6011) - mean (190ms)  : 188, 193
     .   : milestone, 190,
    master - mean (190ms)  : 187, 193
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6011) - mean (1,201ms)  : 1171, 1231
     .   : milestone, 1201,
    master - mean (1,197ms)  : 1169, 1224
     .   : milestone, 1197,
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6011) - mean (276ms)  : 271, 282
     .   : milestone, 276,
    master - mean (276ms)  : 272, 281
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6011) - mean (973ms)  : 956, 990
     .   : milestone, 973,
    master - mean (971ms)  : 951, 992
     .   : milestone, 971,
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6011) - mean (265ms)  : 261, 268
     .   : milestone, 265,
    master - mean (265ms)  : 261, 270
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6011) - mean (947ms)  : 924, 969
     .   : milestone, 947,
    master - mean (952ms)  : 931, 973
     .   : milestone, 952,
andrewlock commented 3 weeks ago

Benchmarks Report for appsec :snail:

Benchmarks for #6011 compared to master:

The following thresholds were used for comparing the benchmark speeds:

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #6011 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑netcoreapp3.1 | 1.168 | 197.03 | 230.19 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`AllCycleSimpleBody`|net6.0|70.4μs|109ns|422ns|0.0703| 0|0|6.01 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`AllCycleSimpleBody`|netcoreapp3.1|62.7μs|96.8ns|349ns|0.0943| 0|0|6.95 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`AllCycleSimpleBody`|net472|48.9μs|39.4ns|148ns|1.31| 0|0|8.34 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`AllCycleMoreComplexBody`|net6.0|76.8μs|111ns|429ns|0.115| 0|0|9.51 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`AllCycleMoreComplexBody`|netcoreapp3.1|69.4μs|90.4ns|338ns|0.139| 0|0|10.37 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`AllCycleMoreComplexBody`|net472|56.3μs|58.9ns|228ns|1.88| 0.028|0|11.85 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`ObjectExtractorSimpleBody`|net6.0|141ns|0.322ns|1.25ns|0.00396| 0|0|280 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`ObjectExtractorSimpleBody`|netcoreapp3.1|197ns|0.326ns|1.26ns|0.00367| 0|0|272 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`ObjectExtractorSimpleBody`|net472|171ns|0.25ns|0.902ns|0.0446| 0|0|281 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`ObjectExtractorMoreComplexBody`|net6.0|3.01μs|2.3ns|8.9ns|0.0533| 0|0|3.78 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`ObjectExtractorMoreComplexBody`|netcoreapp3.1|3.97μs|5.43ns|21ns|0.0497| 0|0|3.69 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`ObjectExtractorMoreComplexBody`|net472|3.87μs|3.85ns|13.9ns|0.602| 0.00584|0|3.8 KB| |#6011|`AllCycleSimpleBody`|net6.0|73.4μs|86.5ns|324ns|0.0742| 0|0|6 KB| |#6011|`AllCycleSimpleBody`|netcoreapp3.1|62.8μs|79.5ns|298ns|0.0941| 0|0|6.95 KB| |#6011|`AllCycleSimpleBody`|net472|48μs|50ns|194ns|1.32| 0|0|8.34 KB| |#6011|`AllCycleMoreComplexBody`|net6.0|79.5μs|78.1ns|302ns|0.119| 0|0|9.51 KB| |#6011|`AllCycleMoreComplexBody`|netcoreapp3.1|70μs|78.4ns|283ns|0.142| 0|0|10.36 KB| |#6011|`AllCycleMoreComplexBody`|net472|54.9μs|57.2ns|214ns|1.88| 0.0273|0|11.85 KB| |#6011|`ObjectExtractorSimpleBody`|net6.0|147ns|0.209ns|0.783ns|0.00394| 0|0|280 B| |#6011|`ObjectExtractorSimpleBody`|netcoreapp3.1|230ns|0.223ns|0.834ns|0.00371| 0|0|272 B| |#6011|`ObjectExtractorSimpleBody`|net472|176ns|0.148ns|0.573ns|0.0446| 0|0|281 B| |#6011|`ObjectExtractorMoreComplexBody`|net6.0|3.11μs|2.04ns|7.63ns|0.0529| 0|0|3.78 KB| |#6011|`ObjectExtractorMoreComplexBody`|netcoreapp3.1|3.92μs|2.66ns|10.3ns|0.0508| 0|0|3.69 KB| |#6011|`ObjectExtractorMoreComplexBody`|net472|3.8μs|2.68ns|10.4ns|0.603| 0.00574|0|3.8 KB|
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`EncodeArgs`|net6.0|37.4μs|15.2ns|54.9ns|0.445| 0|0|32.4 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`EncodeArgs`|netcoreapp3.1|54.3μs|18.3ns|70.8ns|0.433| 0|0|32.4 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`EncodeArgs`|net472|68μs|85.9ns|333ns|5.14| 0.0676|0|32.5 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`EncodeLegacyArgs`|net6.0|72μs|27.2ns|105ns|0| 0|0|2.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`EncodeLegacyArgs`|netcoreapp3.1|105μs|265ns|1.03μs|0| 0|0|2.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`EncodeLegacyArgs`|net472|155μs|129ns|498ns|0.309| 0|0|2.15 KB| |#6011|`EncodeArgs`|net6.0|39.3μs|25.7ns|99.5ns|0.453| 0|0|32.4 KB| |#6011|`EncodeArgs`|netcoreapp3.1|54.8μs|47.2ns|183ns|0.435| 0|0|32.4 KB| |#6011|`EncodeArgs`|net472|67.2μs|26ns|93.9ns|5.14| 0.0667|0|32.5 KB| |#6011|`EncodeLegacyArgs`|net6.0|75.2μs|413ns|2.44μs|0.0365| 0|0|2.14 KB| |#6011|`EncodeLegacyArgs`|netcoreapp3.1|106μs|84ns|325ns|0| 0|0|2.14 KB| |#6011|`EncodeLegacyArgs`|net472|151μs|92.2ns|345ns|0.301| 0|0|2.15 KB|
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`RunWafRealisticBenchmark`|net6.0|186μs|188ns|729ns|0| 0|0|2.42 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`RunWafRealisticBenchmark`|netcoreapp3.1|199μs|236ns|913ns|0| 0|0|2.37 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`RunWafRealisticBenchmark`|net472|210μs|195ns|728ns|0.315| 0|0|2.43 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`RunWafRealisticBenchmarkWithAttack`|net6.0|123μs|104ns|403ns|0| 0|0|1.46 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`RunWafRealisticBenchmarkWithAttack`|netcoreapp3.1|129μs|69.4ns|269ns|0| 0|0|1.45 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`RunWafRealisticBenchmarkWithAttack`|net472|140μs|101ns|378ns|0.21| 0|0|1.48 KB| |#6011|`RunWafRealisticBenchmark`|net6.0|185μs|86.8ns|336ns|0| 0|0|2.42 KB| |#6011|`RunWafRealisticBenchmark`|netcoreapp3.1|196μs|109ns|409ns|0| 0|0|2.37 KB| |#6011|`RunWafRealisticBenchmark`|net472|211μs|433ns|1.68μs|0.317| 0|0|2.43 KB| |#6011|`RunWafRealisticBenchmarkWithAttack`|net6.0|122μs|47.5ns|184ns|0| 0|0|1.46 KB| |#6011|`RunWafRealisticBenchmarkWithAttack`|netcoreapp3.1|131μs|75.6ns|273ns|0| 0|0|1.45 KB| |#6011|`RunWafRealisticBenchmarkWithAttack`|net472|140μs|46.6ns|180ns|0.209| 0|0|1.48 KB|
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed :heavy_check_mark: More allocations :warning: #### More allocations :warning: in #6011 | Benchmark | Base Allocated | Diff Allocated | Change | Change % | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 | 254.74 KB | 270.88 KB | 16.14 KB | 6.33% | Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 | 255.86 KB | 265.22 KB | 9.36 KB | 3.66% ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`StringConcatBenchmark`|net6.0|64μs|776ns|7.68μs|0| 0|0|43.44 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`StringConcatBenchmark`|netcoreapp3.1|53.3μs|290ns|1.64μs|0| 0|0|42.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`StringConcatBenchmark`|net472|40μs|118ns|427ns|0| 0|0|59.09 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`StringConcatAspectBenchmark`|net6.0|327μs|1.85μs|12μs|0| 0|0|255.86 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`StringConcatAspectBenchmark`|netcoreapp3.1|360μs|1.93μs|10.9μs|0| 0|0|254.74 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`StringConcatAspectBenchmark`|net472|288μs|5.7μs|54.4μs|0| 0|0|278.53 KB| |#6011|`StringConcatBenchmark`|net6.0|62.1μs|751ns|7.44μs|0| 0|0|43.44 KB| |#6011|`StringConcatBenchmark`|netcoreapp3.1|55μs|272ns|1.15μs|0| 0|0|42.64 KB| |#6011|`StringConcatBenchmark`|net472|38μs|53.6ns|193ns|0| 0|0|59.07 KB| |#6011|`StringConcatAspectBenchmark`|net6.0|311μs|1.79μs|13.5μs|0| 0|0|265.22 KB| |#6011|`StringConcatAspectBenchmark`|netcoreapp3.1|336μs|4.68μs|43.1μs|0| 0|0|270.88 KB| |#6011|`StringConcatAspectBenchmark`|net472|280μs|6.07μs|59.5μs|0| 0|0|278.53 KB|
andrewlock commented 3 weeks ago

Throughput/Crank Report :zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6011) (10.868M)   : 0, 10867894
    master (11.191M)   : 0, 11191009
    benchmarks/2.9.0 (11.235M)   : 0, 11234930

    section Automatic
    This PR (6011) (7.278M)   : 0, 7278041
    master (7.480M)   : 0, 7479864
    benchmarks/2.9.0 (7.902M)   : 0, 7901974

    section Trace stats
    master (7.854M)   : 0, 7854112

    section Manual
    master (11.251M)   : 0, 11250786

    section Manual + Automatic
    This PR (6011) (6.840M)   : 0, 6839913
    master (6.974M)   : 0, 6974322

    section DD_TRACE_ENABLED=0
    master (10.260M)   : 0, 10260342
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6011) (9.666M)   : 0, 9666471
    master (9.407M)   : 0, 9407221
    benchmarks/2.9.0 (9.468M)   : 0, 9467847

    section Automatic
    This PR (6011) (6.654M)   : 0, 6653540
    master (6.409M)   : 0, 6408651

    section Trace stats
    master (6.945M)   : 0, 6945033

    section Manual
    master (9.485M)   : 0, 9484960

    section Manual + Automatic
    This PR (6011) (6.207M)   : 0, 6206674
    master (6.153M)   : 0, 6152889

    section DD_TRACE_ENABLED=0
    master (8.880M)   : 0, 8879609
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6011) (9.866M)   : 0, 9865904
    master (10.042M)   : 0, 10041833
    benchmarks/2.9.0 (10.191M)   : 0, 10191280

    section Automatic
    This PR (6011) (6.574M)   : 0, 6573623
    master (6.584M)   : 0, 6583747
    benchmarks/2.9.0 (7.389M)   : 0, 7388665

    section Trace stats
    master (7.349M)   : 0, 7348894

    section Manual
    master (10.065M)   : 0, 10064803

    section Manual + Automatic
    This PR (6011) (6.109M)   : 0, 6108823
    master (6.022M)   : 0, 6022361

    section DD_TRACE_ENABLED=0
    master (9.438M)   : 0, 9437949
andrewlock commented 3 weeks ago

Benchmarks Report for tracer :snail:

Benchmarks for #6011 compared to master:

The following thresholds were used for comparing the benchmark speeds:

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`StartStopWithChild`|net6.0|7.78μs|44.5ns|321ns|0.0155| 0.00776|0|5.43 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`StartStopWithChild`|netcoreapp3.1|9.61μs|51.4ns|272ns|0.0194| 0.0097|0|5.62 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`StartStopWithChild`|net472|16μs|47.3ns|183ns|1.01| 0.29|0.102|6.06 KB| |#6011|`StartStopWithChild`|net6.0|7.54μs|37.9ns|178ns|0.0152| 0.00761|0|5.42 KB| |#6011|`StartStopWithChild`|netcoreapp3.1|9.79μs|52.1ns|313ns|0.0235| 0.00941|0|5.62 KB| |#6011|`StartStopWithChild`|net472|16.3μs|63.7ns|247ns|1.01| 0.304|0.0881|6.06 KB|
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`WriteAndFlushEnrichedTraces`|net6.0|468μs|172ns|644ns|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|629μs|237ns|854ns|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`WriteAndFlushEnrichedTraces`|net472|824μs|253ns|979ns|0.417| 0|0|3.3 KB| |#6011|`WriteAndFlushEnrichedTraces`|net6.0|478μs|204ns|788ns|0| 0|0|2.7 KB| |#6011|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|629μs|279ns|1.04μs|0| 0|0|2.7 KB| |#6011|`WriteAndFlushEnrichedTraces`|net472|834μs|571ns|2.21μs|0.414| 0|0|3.3 KB|
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`SendRequest`|net6.0|197μs|1.13μs|8.27μs|0.211| 0|0|18.45 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`SendRequest`|netcoreapp3.1|218μs|1.21μs|7.35μs|0.212| 0|0|20.61 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`SendRequest`|net472|0ns|0ns|0ns|0| 0|0|0 b| |#6011|`SendRequest`|net6.0|197μs|1.13μs|9.01μs|0.189| 0|0|18.45 KB| |#6011|`SendRequest`|netcoreapp3.1|221μs|1.22μs|7.92μs|0.235| 0|0|20.61 KB| |#6011|`SendRequest`|net472|0.000866ns|0.000475ns|0.00178ns|0| 0|0|0 b|
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`WriteAndFlushEnrichedTraces`|net6.0|588μs|3.27μs|19.3μs|0.571| 0|0|41.75 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|699μs|3.56μs|15.9μs|0.342| 0|0|41.87 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`WriteAndFlushEnrichedTraces`|net472|885μs|4.34μs|17.4μs|8.3| 2.62|0.437|53.32 KB| |#6011|`WriteAndFlushEnrichedTraces`|net6.0|551μs|1.51μs|5.22μs|0.551| 0|0|41.58 KB| |#6011|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|674μs|2.81μs|10.9μs|0.343| 0|0|41.79 KB| |#6011|`WriteAndFlushEnrichedTraces`|net472|872μs|4.1μs|16.9μs|8.08| 2.55|0.425|53.31 KB|
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`ExecuteNonQuery`|net6.0|1.23μs|1.54ns|5.95ns|0.0141| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`ExecuteNonQuery`|netcoreapp3.1|1.8μs|3.03ns|11.7ns|0.0142| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`ExecuteNonQuery`|net472|2.09μs|1.77ns|6.86ns|0.156| 0|0|987 B| |#6011|`ExecuteNonQuery`|net6.0|1.28μs|0.95ns|3.68ns|0.0141| 0|0|1.02 KB| |#6011|`ExecuteNonQuery`|netcoreapp3.1|1.8μs|1.05ns|4.08ns|0.0135| 0|0|1.02 KB| |#6011|`ExecuteNonQuery`|net472|2μs|2.14ns|7.99ns|0.157| 0|0|987 B|
Benchmarks.Trace.ElasticsearchBenchmark - Faster :tada: Same allocations :heavy_check_mark: #### Faster :tada: in #6011 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 | 1.178 | 1,317.91 | 1,118.57 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`CallElasticsearch`|net6.0|1.32μs|0.602ns|2.33ns|0.0138| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`CallElasticsearch`|netcoreapp3.1|1.55μs|1.31ns|5.09ns|0.0133| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`CallElasticsearch`|net472|2.48μs|2.74ns|10.6ns|0.157| 0|0|995 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`CallElasticsearchAsync`|net6.0|1.32μs|0.579ns|2.24ns|0.0131| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`CallElasticsearchAsync`|netcoreapp3.1|1.62μs|1.77ns|6.64ns|0.0139| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`CallElasticsearchAsync`|net472|2.51μs|1.22ns|4.74ns|0.166| 0|0|1.05 KB| |#6011|`CallElasticsearch`|net6.0|1.12μs|0.567ns|2.2ns|0.0134| 0|0|976 B| |#6011|`CallElasticsearch`|netcoreapp3.1|1.56μs|0.867ns|3.24ns|0.0132| 0|0|976 B| |#6011|`CallElasticsearch`|net472|2.49μs|1.74ns|6.75ns|0.157| 0|0|995 B| |#6011|`CallElasticsearchAsync`|net6.0|1.21μs|0.387ns|1.5ns|0.0133| 0|0|952 B| |#6011|`CallElasticsearchAsync`|netcoreapp3.1|1.56μs|0.779ns|2.91ns|0.014| 0|0|1.02 KB| |#6011|`CallElasticsearchAsync`|net472|2.62μs|1.15ns|4.45ns|0.167| 0|0|1.05 KB|
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`ExecuteAsync`|net6.0|1.26μs|0.998ns|3.86ns|0.0133| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`ExecuteAsync`|netcoreapp3.1|1.64μs|0.701ns|2.62ns|0.0124| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`ExecuteAsync`|net472|1.79μs|0.83ns|3.1ns|0.145| 0|0|915 B| |#6011|`ExecuteAsync`|net6.0|1.26μs|0.863ns|3.34ns|0.0133| 0|0|952 B| |#6011|`ExecuteAsync`|netcoreapp3.1|1.63μs|1.58ns|6.11ns|0.0129| 0|0|952 B| |#6011|`ExecuteAsync`|net472|1.79μs|0.716ns|2.77ns|0.145| 0|0|915 B|
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`SendAsync`|net6.0|4.26μs|2ns|7.47ns|0.0299| 0|0|2.22 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`SendAsync`|netcoreapp3.1|4.97μs|1.76ns|6.82ns|0.0348| 0|0|2.76 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`SendAsync`|net472|7.67μs|2.62ns|10.2ns|0.499| 0|0|3.15 KB| |#6011|`SendAsync`|net6.0|4.26μs|1.31ns|4.9ns|0.032| 0|0|2.22 KB| |#6011|`SendAsync`|netcoreapp3.1|5.08μs|7.44ns|28.8ns|0.0352| 0|0|2.76 KB| |#6011|`SendAsync`|net472|7.86μs|2.31ns|8.93ns|0.499| 0|0|3.15 KB|
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`EnrichedLog`|net6.0|1.55μs|0.622ns|2.33ns|0.0233| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`EnrichedLog`|netcoreapp3.1|2.2μs|0.491ns|1.7ns|0.022| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`EnrichedLog`|net472|2.44μs|0.935ns|3.5ns|0.249| 0|0|1.57 KB| |#6011|`EnrichedLog`|net6.0|1.45μs|0.604ns|2.18ns|0.0234| 0|0|1.64 KB| |#6011|`EnrichedLog`|netcoreapp3.1|2.33μs|11.4ns|45.6ns|0.0231| 0|0|1.64 KB| |#6011|`EnrichedLog`|net472|2.52μs|1.54ns|5.95ns|0.249| 0|0|1.57 KB|
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`EnrichedLog`|net6.0|114μs|195ns|755ns|0.057| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`EnrichedLog`|netcoreapp3.1|119μs|211ns|816ns|0.0589| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`EnrichedLog`|net472|146μs|164ns|635ns|0.655| 0.218|0|4.46 KB| |#6011|`EnrichedLog`|net6.0|114μs|187ns|725ns|0.057| 0|0|4.28 KB| |#6011|`EnrichedLog`|netcoreapp3.1|117μs|139ns|538ns|0.0584| 0|0|4.28 KB| |#6011|`EnrichedLog`|net472|146μs|61.4ns|238ns|0.656| 0.219|0|4.46 KB|
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`EnrichedLog`|net6.0|3.18μs|1.06ns|4.11ns|0.0303| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`EnrichedLog`|netcoreapp3.1|4.25μs|6.55ns|25.4ns|0.0282| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`EnrichedLog`|net472|4.86μs|5.54ns|21.5ns|0.32| 0|0|2.02 KB| |#6011|`EnrichedLog`|net6.0|3.04μs|1.31ns|4.9ns|0.0303| 0|0|2.2 KB| |#6011|`EnrichedLog`|netcoreapp3.1|4.12μs|2.38ns|9.21ns|0.0289| 0|0|2.2 KB| |#6011|`EnrichedLog`|net472|4.96μs|1.31ns|4.91ns|0.319| 0|0|2.02 KB|
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`SendReceive`|net6.0|1.4μs|1.52ns|5.87ns|0.0159| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`SendReceive`|netcoreapp3.1|1.71μs|1.48ns|5.71ns|0.0152| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`SendReceive`|net472|2.04μs|0.914ns|3.54ns|0.183| 0.00102|0|1.16 KB| |#6011|`SendReceive`|net6.0|1.32μs|0.631ns|2.44ns|0.0158| 0|0|1.14 KB| |#6011|`SendReceive`|netcoreapp3.1|1.7μs|1.05ns|4.05ns|0.0155| 0|0|1.14 KB| |#6011|`SendReceive`|net472|2.08μs|1.09ns|4.22ns|0.183| 0|0|1.16 KB|
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`EnrichedLog`|net6.0|2.71μs|1.08ns|4.2ns|0.0217| 0|0|1.6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`EnrichedLog`|netcoreapp3.1|3.92μs|1.49ns|5.16ns|0.0215| 0|0|1.65 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`EnrichedLog`|net472|4.36μs|1.68ns|6.3ns|0.322| 0|0|2.04 KB| |#6011|`EnrichedLog`|net6.0|2.64μs|1.3ns|5.05ns|0.0225| 0|0|1.6 KB| |#6011|`EnrichedLog`|netcoreapp3.1|3.73μs|2.38ns|9.21ns|0.0205| 0|0|1.65 KB| |#6011|`EnrichedLog`|net472|4.24μs|1.09ns|4.09ns|0.322| 0|0|2.04 KB|
Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #6011 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 | 1.160 | 663.95 | 769.93 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`StartFinishSpan`|net6.0|392ns|0.281ns|1.09ns|0.00807| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`StartFinishSpan`|netcoreapp3.1|605ns|3.16ns|14.8ns|0.00796| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`StartFinishSpan`|net472|640ns|0.631ns|2.44ns|0.0918| 0|0|578 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`StartFinishScope`|net6.0|504ns|0.414ns|1.6ns|0.00987| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`StartFinishScope`|netcoreapp3.1|664ns|0.564ns|2.18ns|0.00962| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`StartFinishScope`|net472|840ns|0.7ns|2.71ns|0.105| 0|0|658 B| |#6011|`StartFinishSpan`|net6.0|398ns|0.109ns|0.422ns|0.00819| 0|0|576 B| |#6011|`StartFinishSpan`|netcoreapp3.1|616ns|0.763ns|2.95ns|0.00795| 0|0|576 B| |#6011|`StartFinishSpan`|net472|681ns|0.833ns|3.23ns|0.0916| 0|0|578 B| |#6011|`StartFinishScope`|net6.0|546ns|0.542ns|2.1ns|0.00994| 0|0|696 B| |#6011|`StartFinishScope`|netcoreapp3.1|770ns|0.404ns|1.4ns|0.00918| 0|0|696 B| |#6011|`StartFinishScope`|net472|910ns|0.814ns|3.15ns|0.105| 0|0|658 B|
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster :tada: Same allocations :heavy_check_mark: #### Faster :tada: in #6011 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472 | 1.118 | 1,150.18 | 1,028.65 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`RunOnMethodBegin`|net6.0|593ns|0.231ns|0.893ns|0.00983| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`RunOnMethodBegin`|netcoreapp3.1|886ns|0.639ns|2.39ns|0.00942| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/f48b7a31cd53f51fcd60dcb68435156224c53828)|`RunOnMethodBegin`|net472|1.15μs|1.02ns|3.93ns|0.104| 0|0|658 B| |#6011|`RunOnMethodBegin`|net6.0|649ns|0.62ns|2.4ns|0.00992| 0|0|696 B| |#6011|`RunOnMethodBegin`|netcoreapp3.1|973ns|1.08ns|4.02ns|0.00936| 0|0|696 B| |#6011|`RunOnMethodBegin`|net472|1.03μs|1.22ns|4.71ns|0.104| 0|0|658 B|