Closed daniel-romano-DD closed 2 weeks ago
Branch report: dani/asm/improve_stack_trimming
Commit report: 72c3458
Test service: dd-trace-dotnet
:x: 1 Failed (1 Known Flaky), 366417 Passed, 2082 Skipped, 15h 44m 0.83s Total Time
Profiler_liveheap
- scenarios
- :snowflake: Known flaky - Details
Execution-time results for samples comparing the following branches/commits:
Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.
Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).
gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6011) - mean (70ms) : 66, 73
. : milestone, 70,
master - mean (69ms) : 67, 71
. : milestone, 69,
section CallTarget+Inlining+NGEN
This PR (6011) - mean (1,114ms) : 1096, 1133
. : milestone, 1114,
master - mean (1,118ms) : 1090, 1147
. : milestone, 1118,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6011) - mean (108ms) : 105, 110
. : milestone, 108,
master - mean (109ms) : 105, 112
. : milestone, 109,
section CallTarget+Inlining+NGEN
This PR (6011) - mean (811ms) : 792, 830
. : milestone, 811,
master - mean (809ms) : 789, 829
. : milestone, 809,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6011) - mean (92ms) : 89, 95
. : milestone, 92,
master - mean (92ms) : 89, 95
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (6011) - mean (770ms) : 752, 788
. : milestone, 770,
master - mean (768ms) : 748, 788
. : milestone, 768,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6011) - mean (190ms) : 188, 193
. : milestone, 190,
master - mean (190ms) : 187, 193
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (6011) - mean (1,201ms) : 1171, 1231
. : milestone, 1201,
master - mean (1,197ms) : 1169, 1224
. : milestone, 1197,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6011) - mean (276ms) : 271, 282
. : milestone, 276,
master - mean (276ms) : 272, 281
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (6011) - mean (973ms) : 956, 990
. : milestone, 973,
master - mean (971ms) : 951, 992
. : milestone, 971,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6011) - mean (265ms) : 261, 268
. : milestone, 265,
master - mean (265ms) : 261, 270
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (6011) - mean (947ms) : 924, 969
. : milestone, 947,
master - mean (952ms) : 931, 973
. : milestone, 952,
Benchmarks for #6011 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored.
Throughput results for AspNetCoreSimpleController comparing the following branches/commits:
Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.
Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!
gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6011) (10.868M) : 0, 10867894
master (11.191M) : 0, 11191009
benchmarks/2.9.0 (11.235M) : 0, 11234930
section Automatic
This PR (6011) (7.278M) : 0, 7278041
master (7.480M) : 0, 7479864
benchmarks/2.9.0 (7.902M) : 0, 7901974
section Trace stats
master (7.854M) : 0, 7854112
section Manual
master (11.251M) : 0, 11250786
section Manual + Automatic
This PR (6011) (6.840M) : 0, 6839913
master (6.974M) : 0, 6974322
section DD_TRACE_ENABLED=0
master (10.260M) : 0, 10260342
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6011) (9.666M) : 0, 9666471
master (9.407M) : 0, 9407221
benchmarks/2.9.0 (9.468M) : 0, 9467847
section Automatic
This PR (6011) (6.654M) : 0, 6653540
master (6.409M) : 0, 6408651
section Trace stats
master (6.945M) : 0, 6945033
section Manual
master (9.485M) : 0, 9484960
section Manual + Automatic
This PR (6011) (6.207M) : 0, 6206674
master (6.153M) : 0, 6152889
section DD_TRACE_ENABLED=0
master (8.880M) : 0, 8879609
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6011) (9.866M) : 0, 9865904
master (10.042M) : 0, 10041833
benchmarks/2.9.0 (10.191M) : 0, 10191280
section Automatic
This PR (6011) (6.574M) : 0, 6573623
master (6.584M) : 0, 6583747
benchmarks/2.9.0 (7.389M) : 0, 7388665
section Trace stats
master (7.349M) : 0, 7348894
section Manual
master (10.065M) : 0, 10064803
section Manual + Automatic
This PR (6011) (6.109M) : 0, 6108823
master (6.022M) : 0, 6022361
section DD_TRACE_ENABLED=0
master (9.438M) : 0, 9437949
Benchmarks for #6011 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored.
Summary of changes
Right now, when reporting a stack, we trim the stack, providing 25% of the max count from the upper frames and 75% from the bottom. As discussed with other library teams, this has proven to add poor information, being much more valuable the upper frames then the lower ones. Make this proportion configurable by an envvar
Reason for change
Trimmed stacks submitted to backend with IAST vulnerabilities or RASP blocking events, when trimmed, add poor information to the client
Implementation details
Added an env var to tell how many top frames will be retrieved in proportion.
Test coverage
Unit tests.
Other details
dd-go PR