search

DataDog / dd-trace-dotnet

.NET Client Library for Datadog APM
https://docs.datadoghq.com/tracing/
Apache License 2.0
437 stars 137 forks source link

Fix SSI tests for profiler integration tests #6016

Closed andrewlock closed 2 weeks ago

andrewlock commented 3 weeks ago

Summary of changes

Fix profiler integration tests in the SSI run

Reason for change

5240 changed the behaviour of the profiler in the presence of SSI variables. We have a scheduled run on master that specifically sets the variables. This breaks the profiler integration tests that depend on those variables.

Implementation details

Add an "environment restorer" attribute, which mirrors the one we use in the tracing integration tests. Ensures that the SSI tests are working in their expected environment

Test coverage

This is the test, but did a dedicated run too, and it works

Other details

Related to #6014

datadog-ddstaging[bot] commented 3 weeks ago

Datadog Report

Branch report: andrew/profiling/fix-ssi-tests Commit report: e45d4da Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 363427 Passed, 2362 Skipped, 18h 19m 28.43s Total Time

andrewlock commented 3 weeks ago

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6016) - mean (70ms)  : 67, 73
     .   : milestone, 70,
    master - mean (71ms)  : 67, 75
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (6016) - mean (1,083ms)  : 1063, 1103
     .   : milestone, 1083,
    master - mean (1,085ms)  : 1060, 1110
     .   : milestone, 1085,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6016) - mean (109ms)  : 106, 112
     .   : milestone, 109,
    master - mean (110ms)  : 106, 114
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (6016) - mean (760ms)  : 741, 779
     .   : milestone, 760,
    master - mean (759ms)  : 741, 778
     .   : milestone, 759,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6016) - mean (93ms)  : 90, 96
     .   : milestone, 93,
    master - mean (93ms)  : 89, 97
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6016) - mean (708ms)  : 686, 731
     .   : milestone, 708,
    master - mean (712ms)  : 692, 732
     .   : milestone, 712,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6016) - mean (190ms)  : 187, 193
     .   : milestone, 190,
    master - mean (190ms)  : 186, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6016) - mean (1,161ms)  : 1136, 1185
     .   : milestone, 1161,
    master - mean (1,165ms)  : 1135, 1194
     .   : milestone, 1165,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6016) - mean (276ms)  : 272, 281
     .   : milestone, 276,
    master - mean (276ms)  : 272, 280
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6016) - mean (924ms)  : 906, 942
     .   : milestone, 924,
    master - mean (927ms)  : 906, 947
     .   : milestone, 927,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6016) - mean (264ms)  : 260, 269
     .   : milestone, 264,
    master - mean (265ms)  : 261, 268
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6016) - mean (907ms)  : 880, 934
     .   : milestone, 907,
    master - mean (905ms)  : 876, 934
     .   : milestone, 905,
andrewlock commented 3 weeks ago

Throughput/Crank Report :zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6016) (11.099M)   : 0, 11098553
    master (11.202M)   : 0, 11202155
    benchmarks/2.9.0 (11.142M)   : 0, 11142344

    section Automatic
    This PR (6016) (7.301M)   : 0, 7301012
    master (7.437M)   : 0, 7437019
    benchmarks/2.9.0 (7.893M)   : 0, 7893301

    section Trace stats
    master (7.824M)   : 0, 7824309

    section Manual
    master (11.306M)   : 0, 11305639

    section Manual + Automatic
    This PR (6016) (6.814M)   : 0, 6814443
    master (6.918M)   : 0, 6917708

    section DD_TRACE_ENABLED=0
    master (10.325M)   : 0, 10325290

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6016) (9.445M)   : 0, 9445306
    master (9.731M)   : 0, 9730961
    benchmarks/2.9.0 (9.585M)   : 0, 9584514

    section Automatic
    This PR (6016) (6.656M)   : 0, 6655520
    master (6.575M)   : 0, 6574988

    section Trace stats
    master (7.001M)   : 0, 7000523

    section Manual
    master (9.504M)   : 0, 9504255

    section Manual + Automatic
    This PR (6016) (6.214M)   : 0, 6213539
    master (6.217M)   : 0, 6216600

    section DD_TRACE_ENABLED=0
    master (9.049M)   : 0, 9048961

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6016) (10.173M)   : 0, 10173472
    master (10.040M)   : 0, 10040090
    benchmarks/2.9.0 (10.094M)   : 0, 10093850

    section Automatic
    This PR (6016) (6.751M)   : 0, 6751294
    master (6.783M)   : 0, 6782944
    benchmarks/2.9.0 (7.257M)   : 0, 7257483

    section Trace stats
    master (7.323M)   : 0, 7323194

    section Manual
    master (10.061M)   : 0, 10060796

    section Manual + Automatic
    This PR (6016) (6.105M)   : 0, 6104785
    master (6.342M)   : 0, 6342001

    section DD_TRACE_ENABLED=0
    master (9.357M)   : 0, 9357055
andrewlock commented 3 weeks ago

Benchmarks Report for tracer :snail:

Benchmarks for #6016 compared to master:

The following thresholds were used for comparing the benchmark speeds:

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`StartStopWithChild`|net6.0|7.7μs|42.1ns|252ns|0.015| 0.00375|0|5.43 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`StartStopWithChild`|netcoreapp3.1|10.1μs|56.8ns|398ns|0.0155| 0.00516|0|5.62 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`StartStopWithChild`|net472|15.9μs|49.6ns|192ns|1.01| 0.3|0.0947|6.06 KB| |#6016|`StartStopWithChild`|net6.0|7.55μs|39ns|199ns|0.0153| 0.00382|0|5.43 KB| |#6016|`StartStopWithChild`|netcoreapp3.1|9.77μs|52.2ns|281ns|0.0227| 0.00906|0|5.62 KB| |#6016|`StartStopWithChild`|net472|15.8μs|51.6ns|200ns|1.02| 0.309|0.0951|6.06 KB|
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`WriteAndFlushEnrichedTraces`|net6.0|485μs|347ns|1.34μs|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|630μs|2.07μs|7.47μs|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`WriteAndFlushEnrichedTraces`|net472|833μs|503ns|1.95μs|0.417| 0|0|3.3 KB| |#6016|`WriteAndFlushEnrichedTraces`|net6.0|481μs|497ns|1.92μs|0| 0|0|2.7 KB| |#6016|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|637μs|459ns|1.78μs|0| 0|0|2.7 KB| |#6016|`WriteAndFlushEnrichedTraces`|net472|842μs|292ns|1.13μs|0.419| 0|0|3.3 KB|
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`SendRequest`|net6.0|199μs|1.16μs|10.1μs|0.194| 0|0|18.45 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`SendRequest`|netcoreapp3.1|220μs|1.2μs|7.31μs|0.212| 0|0|20.61 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`SendRequest`|net472|0.000867ns|0.000421ns|0.00163ns|0| 0|0|0 b| |#6016|`SendRequest`|net6.0|200μs|1.12μs|9.66μs|0.196| 0|0|18.45 KB| |#6016|`SendRequest`|netcoreapp3.1|225μs|1.31μs|11.7μs|0.206| 0|0|20.61 KB| |#6016|`SendRequest`|net472|0.00159ns|0.000707ns|0.00274ns|0| 0|0|0 b|
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: More allocations :warning: #### More allocations :warning: in #6016 | Benchmark | Base Allocated | Diff Allocated | Change | Change % | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 | 41.45 KB | 41.82 KB | 372 B | 0.90% | Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 | 41.45 KB | 41.67 KB | 227 B | 0.55% ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`WriteAndFlushEnrichedTraces`|net6.0|601μs|3.09μs|15.5μs|0.584| 0|0|41.45 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|739μs|4.09μs|26.8μs|0.349| 0|0|41.45 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`WriteAndFlushEnrichedTraces`|net472|874μs|2.78μs|10.8μs|8.08| 2.55|0.425|53.27 KB| |#6016|`WriteAndFlushEnrichedTraces`|net6.0|567μs|2.26μs|8.75μs|0.573| 0|0|41.67 KB| |#6016|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|690μs|3.71μs|20.3μs|0.331| 0|0|41.82 KB| |#6016|`WriteAndFlushEnrichedTraces`|net472|865μs|3.02μs|11.3μs|8.13| 2.57|0.428|53.31 KB|
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`ExecuteNonQuery`|net6.0|1.33μs|0.844ns|3.16ns|0.0147| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`ExecuteNonQuery`|netcoreapp3.1|1.7μs|1.17ns|4.53ns|0.0138| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`ExecuteNonQuery`|net472|2.03μs|2.82ns|10.9ns|0.156| 0|0|987 B| |#6016|`ExecuteNonQuery`|net6.0|1.38μs|0.839ns|3.14ns|0.0138| 0|0|1.02 KB| |#6016|`ExecuteNonQuery`|netcoreapp3.1|1.75μs|1.07ns|4.14ns|0.0134| 0|0|1.02 KB| |#6016|`ExecuteNonQuery`|net472|2.04μs|1.18ns|4.58ns|0.156| 0|0|987 B|
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`CallElasticsearch`|net6.0|1.21μs|1.28ns|4.78ns|0.0133| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`CallElasticsearch`|netcoreapp3.1|1.56μs|2.34ns|8.76ns|0.0131| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`CallElasticsearch`|net472|2.42μs|1.59ns|6.17ns|0.157| 0|0|995 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`CallElasticsearchAsync`|net6.0|1.22μs|1.01ns|3.77ns|0.0133| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`CallElasticsearchAsync`|netcoreapp3.1|1.61μs|0.81ns|3.03ns|0.0138| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`CallElasticsearchAsync`|net472|2.5μs|1.69ns|6.32ns|0.166| 0|0|1.05 KB| |#6016|`CallElasticsearch`|net6.0|1.26μs|0.573ns|2.15ns|0.0133| 0|0|976 B| |#6016|`CallElasticsearch`|netcoreapp3.1|1.54μs|3.33ns|12.9ns|0.0131| 0|0|976 B| |#6016|`CallElasticsearch`|net472|2.32μs|1.91ns|7.39ns|0.158| 0|0|995 B| |#6016|`CallElasticsearchAsync`|net6.0|1.26μs|0.803ns|3.11ns|0.0132| 0|0|952 B| |#6016|`CallElasticsearchAsync`|netcoreapp3.1|1.62μs|0.704ns|2.64ns|0.0138| 0|0|1.02 KB| |#6016|`CallElasticsearchAsync`|net472|2.57μs|2.21ns|8.55ns|0.166| 0|0|1.05 KB|
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`ExecuteAsync`|net6.0|1.19μs|0.58ns|2.17ns|0.0133| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`ExecuteAsync`|netcoreapp3.1|1.62μs|0.391ns|1.41ns|0.0122| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`ExecuteAsync`|net472|1.76μs|1.63ns|6.3ns|0.145| 0|0|915 B| |#6016|`ExecuteAsync`|net6.0|1.32μs|3.09ns|12ns|0.0132| 0|0|952 B| |#6016|`ExecuteAsync`|netcoreapp3.1|1.66μs|0.675ns|2.43ns|0.0126| 0|0|952 B| |#6016|`ExecuteAsync`|net472|1.72μs|3.11ns|12ns|0.145| 0|0|915 B|
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`SendAsync`|net6.0|4.15μs|1.68ns|6.29ns|0.031| 0|0|2.22 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`SendAsync`|netcoreapp3.1|4.98μs|1.25ns|4.52ns|0.0374| 0|0|2.76 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`SendAsync`|net472|7.9μs|1.89ns|7.31ns|0.498| 0|0|3.15 KB| |#6016|`SendAsync`|net6.0|3.99μs|1.7ns|6.59ns|0.0301| 0|0|2.22 KB| |#6016|`SendAsync`|netcoreapp3.1|5.08μs|1.01ns|3.78ns|0.0357| 0|0|2.76 KB| |#6016|`SendAsync`|net472|7.77μs|1.93ns|7.49ns|0.497| 0|0|3.15 KB|
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`EnrichedLog`|net6.0|1.62μs|0.937ns|3.51ns|0.0226| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`EnrichedLog`|netcoreapp3.1|2.4μs|8.57ns|33.2ns|0.0226| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`EnrichedLog`|net472|2.63μs|1.88ns|7.3ns|0.249| 0|0|1.57 KB| |#6016|`EnrichedLog`|net6.0|1.54μs|0.699ns|2.52ns|0.0231| 0|0|1.64 KB| |#6016|`EnrichedLog`|netcoreapp3.1|2.23μs|1.2ns|4.64ns|0.0222| 0|0|1.64 KB| |#6016|`EnrichedLog`|net472|2.78μs|2.56ns|9.91ns|0.249| 0|0|1.57 KB|
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`EnrichedLog`|net6.0|117μs|149ns|576ns|0.0581| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`EnrichedLog`|netcoreapp3.1|120μs|225ns|871ns|0| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`EnrichedLog`|net472|146μs|255ns|988ns|0.662| 0.221|0|4.46 KB| |#6016|`EnrichedLog`|net6.0|113μs|243ns|939ns|0| 0|0|4.28 KB| |#6016|`EnrichedLog`|netcoreapp3.1|119μs|206ns|771ns|0| 0|0|4.28 KB| |#6016|`EnrichedLog`|net472|148μs|285ns|1.1μs|0.652| 0.217|0|4.46 KB|
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`EnrichedLog`|net6.0|2.93μs|4.77ns|18.5ns|0.0303| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`EnrichedLog`|netcoreapp3.1|4.2μs|4.49ns|17.4ns|0.0301| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`EnrichedLog`|net472|4.89μs|1.07ns|4.01ns|0.32| 0|0|2.02 KB| |#6016|`EnrichedLog`|net6.0|3.04μs|0.638ns|2.47ns|0.0304| 0|0|2.2 KB| |#6016|`EnrichedLog`|netcoreapp3.1|4.13μs|2.04ns|7.92ns|0.029| 0|0|2.2 KB| |#6016|`EnrichedLog`|net472|4.85μs|1.85ns|7.15ns|0.319| 0|0|2.02 KB|
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`SendReceive`|net6.0|1.3μs|1.29ns|4.84ns|0.0157| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`SendReceive`|netcoreapp3.1|1.76μs|0.255ns|0.883ns|0.016| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`SendReceive`|net472|2.12μs|1.47ns|5.51ns|0.183| 0.00106|0|1.16 KB| |#6016|`SendReceive`|net6.0|1.36μs|0.514ns|1.99ns|0.0163| 0|0|1.14 KB| |#6016|`SendReceive`|netcoreapp3.1|1.84μs|1.67ns|6.48ns|0.0159| 0|0|1.14 KB| |#6016|`SendReceive`|net472|2.18μs|1.8ns|6.49ns|0.183| 0|0|1.16 KB|
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`EnrichedLog`|net6.0|2.74μs|0.831ns|3.11ns|0.022| 0|0|1.6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`EnrichedLog`|netcoreapp3.1|3.84μs|2.02ns|7.57ns|0.0218| 0|0|1.65 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`EnrichedLog`|net472|4.41μs|3.55ns|13.3ns|0.323| 0|0|2.04 KB| |#6016|`EnrichedLog`|net6.0|2.89μs|4.75ns|17.8ns|0.0226| 0|0|1.6 KB| |#6016|`EnrichedLog`|netcoreapp3.1|3.96μs|2.48ns|9.61ns|0.0217| 0|0|1.65 KB| |#6016|`EnrichedLog`|net472|4.39μs|2.58ns|10ns|0.323| 0|0|2.04 KB|
Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #6016 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 | 1.140 | 578.00 | 658.67 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`StartFinishSpan`|net6.0|394ns|0.342ns|1.32ns|0.00817| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`StartFinishSpan`|netcoreapp3.1|549ns|0.374ns|1.4ns|0.00767| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`StartFinishSpan`|net472|578ns|1.02ns|3.94ns|0.0917| 0|0|578 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`StartFinishScope`|net6.0|546ns|0.315ns|1.22ns|0.00966| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`StartFinishScope`|netcoreapp3.1|773ns|0.679ns|2.63ns|0.00927| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`StartFinishScope`|net472|802ns|0.592ns|2.21ns|0.104| 0|0|658 B| |#6016|`StartFinishSpan`|net6.0|391ns|0.194ns|0.75ns|0.00806| 0|0|576 B| |#6016|`StartFinishSpan`|netcoreapp3.1|549ns|0.728ns|2.82ns|0.00795| 0|0|576 B| |#6016|`StartFinishSpan`|net472|659ns|0.472ns|1.83ns|0.0915| 0|0|578 B| |#6016|`StartFinishScope`|net6.0|548ns|0.473ns|1.83ns|0.00987| 0|0|696 B| |#6016|`StartFinishScope`|netcoreapp3.1|829ns|1.05ns|4.06ns|0.00944| 0|0|696 B| |#6016|`StartFinishScope`|net472|837ns|0.936ns|3.62ns|0.104| 0|0|658 B|
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`RunOnMethodBegin`|net6.0|655ns|0.405ns|1.57ns|0.00955| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`RunOnMethodBegin`|netcoreapp3.1|876ns|0.696ns|2.69ns|0.00938| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/cfbbeb2608dc08045d9b4f20ad545c381ec1a0b9)|`RunOnMethodBegin`|net472|1.09μs|1.23ns|4.76ns|0.105| 0|0|658 B| |#6016|`RunOnMethodBegin`|net6.0|675ns|0.536ns|2.08ns|0.0099| 0|0|696 B| |#6016|`RunOnMethodBegin`|netcoreapp3.1|885ns|0.781ns|3.02ns|0.00943| 0|0|696 B| |#6016|`RunOnMethodBegin`|net472|1.17μs|1.07ns|4.14ns|0.105| 0|0|658 B|