[Profiler] Disable SSI telemetry by default

chrisnas commented 2 weeks ago

Summary of changes

Enable SSI telemetry only by env var

Reason for change

Avoid conflicts with Tracer telemetry

Implementation details

Enable SSI telemetry only when DD_INTERNAL_PROFILING_SSI_TELEMETRY_ENABLED is set AND deployed via SSI

Test coverage

Corresponding tests have been updated and incremented to cover the new scenarios

Other details

andrewlock commented 2 weeks ago

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6020) - mean (70ms)  : 66, 73
     .   : milestone, 70,
    master - mean (75ms)  : 66, 84
     .   : milestone, 75,

    section CallTarget+Inlining+NGEN
    This PR (6020) - mean (1,105ms)  : 1085, 1125
     .   : milestone, 1105,
    master - mean (1,135ms)  : 1097, 1172
     .   : milestone, 1135,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6020) - mean (108ms)  : 106, 111
     .   : milestone, 108,
    master - mean (117ms)  : 108, 127
     .   : milestone, 117,

    section CallTarget+Inlining+NGEN
    This PR (6020) - mean (814ms)  : 796, 832
     .   : milestone, 814,
    master - mean (837ms)  : 811, 863
     .   : milestone, 837,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6020) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (97ms)  : 89, 104
     .   : milestone, 97,

    section CallTarget+Inlining+NGEN
    This PR (6020) - mean (768ms)  : 752, 784
     .   : milestone, 768,
    master - mean (792ms)  : 764, 819
     .   : milestone, 792,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6020) - mean (190ms)  : 187, 194
     .   : milestone, 190,
    master - mean (190ms)  : 187, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6020) - mean (1,195ms)  : 1168, 1222
     .   : milestone, 1195,
    master - mean (1,195ms)  : 1170, 1220
     .   : milestone, 1195,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6020) - mean (278ms)  : 274, 282
     .   : milestone, 278,
    master - mean (278ms)  : 272, 284
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (6020) - mean (978ms)  : 957, 998
     .   : milestone, 978,
    master - mean (973ms)  : 950, 996
     .   : milestone, 973,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6020) - mean (265ms)  : 259, 271
     .   : milestone, 265,
    master - mean (265ms)  : 261, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6020) - mean (951ms)  : 925, 977
     .   : milestone, 951,
    master - mean (949ms)  : 931, 967
     .   : milestone, 949,

datadog-ddstaging[bot] commented 2 weeks ago

Datadog Report

Branch report: chrisnas/disable_telemetry Commit report: 25ed42e Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 366114 Passed, 2346 Skipped, 16h 26m 8.76s Total Time

andrewlock commented 2 weeks ago

Benchmarks Report for tracer :snail:

Benchmarks for #6020 compared to master:

1 benchmarks are faster, with geometric mean 1.121
2 benchmarks are slower, with geometric mean 1.120
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`StartStopWithChild`|net6.0|7.56μs|41.9ns|251ns|0.011| 0.00366|0|5.43 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`StartStopWithChild`|netcoreapp3.1|9.85μs|55.2ns|358ns|0.0146| 0.00485|0|5.62 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`StartStopWithChild`|net472|16.1μs|63.2ns|245ns|1.01| 0.286|0.0874|6.07 KB| |#6020|`StartStopWithChild`|net6.0|7.59μs|42ns|278ns|0.0112| 0.00373|0|5.43 KB| |#6020|`StartStopWithChild`|netcoreapp3.1|9.7μs|50.8ns|259ns|0.019| 0.00948|0|5.62 KB| |#6020|`StartStopWithChild`|net472|16μs|50.1ns|194ns|1.01| 0.284|0.0812|6.07 KB|

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`WriteAndFlushEnrichedTraces`|net6.0|488μs|278ns|1.08μs|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|631μs|296ns|1.14μs|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`WriteAndFlushEnrichedTraces`|net472|826μs|384ns|1.39μs|0.411| 0|0|3.3 KB| |#6020|`WriteAndFlushEnrichedTraces`|net6.0|482μs|286ns|1.11μs|0| 0|0|2.7 KB| |#6020|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|669μs|226ns|846ns|0| 0|0|2.7 KB| |#6020|`WriteAndFlushEnrichedTraces`|net472|848μs|641ns|2.48μs|0.419| 0|0|3.3 KB|

Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`SendRequest`|net6.0|199μs|1.14μs|8.59μs|0.197| 0|0|18.45 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`SendRequest`|netcoreapp3.1|224μs|1.29μs|10.2μs|0.212| 0|0|20.61 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`SendRequest`|net472|0.00084ns|0.000368ns|0.00143ns|0| 0|0|0 b| |#6020|`SendRequest`|net6.0|199μs|1.13μs|8.03μs|0.204| 0|0|18.45 KB| |#6020|`SendRequest`|netcoreapp3.1|218μs|1.21μs|7.77μs|0.213| 0|0|20.61 KB| |#6020|`SendRequest`|net472|0.000996ns|0.000867ns|0.00313ns|0| 0|0|0 b|

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`WriteAndFlushEnrichedTraces`|net6.0|572μs|2.58μs|10μs|0.571| 0|0|41.58 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|675μs|3.4μs|16.6μs|0.336| 0|0|41.68 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`WriteAndFlushEnrichedTraces`|net472|862μs|4.22μs|17.9μs|8.28| 2.48|0.414|53.32 KB| |#6020|`WriteAndFlushEnrichedTraces`|net6.0|574μs|3.09μs|17.5μs|0.592| 0|0|41.67 KB| |#6020|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|658μs|3.24μs|13.4μs|0.34| 0|0|41.71 KB| |#6020|`WriteAndFlushEnrichedTraces`|net472|865μs|4.27μs|17.6μs|8.04| 2.23|0.446|53.32 KB|

Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`ExecuteNonQuery`|net6.0|1.32μs|0.848ns|3.29ns|0.0145| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`ExecuteNonQuery`|netcoreapp3.1|1.77μs|1.7ns|6.57ns|0.0134| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`ExecuteNonQuery`|net472|2.1μs|1.53ns|5.92ns|0.156| 0|0|987 B| |#6020|`ExecuteNonQuery`|net6.0|1.35μs|1.4ns|5.44ns|0.014| 0|0|1.02 KB| |#6020|`ExecuteNonQuery`|netcoreapp3.1|1.89μs|1.3ns|4.88ns|0.014| 0|0|1.02 KB| |#6020|`ExecuteNonQuery`|net472|2.1μs|1.68ns|6.28ns|0.156| 0|0|987 B|

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`CallElasticsearch`|net6.0|1.21μs|0.919ns|3.44ns|0.0134| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`CallElasticsearch`|netcoreapp3.1|1.51μs|1.19ns|4.28ns|0.013| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`CallElasticsearch`|net472|2.49μs|1.7ns|6.35ns|0.158| 0|0|995 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`CallElasticsearchAsync`|net6.0|1.28μs|0.942ns|3.65ns|0.0135| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`CallElasticsearchAsync`|netcoreapp3.1|1.62μs|0.97ns|3.5ns|0.014| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`CallElasticsearchAsync`|net472|2.53μs|2.21ns|8.58ns|0.167| 0|0|1.05 KB| |#6020|`CallElasticsearch`|net6.0|1.11μs|0.659ns|2.55ns|0.0133| 0|0|976 B| |#6020|`CallElasticsearch`|netcoreapp3.1|1.58μs|0.621ns|2.24ns|0.0134| 0|0|976 B| |#6020|`CallElasticsearch`|net472|2.56μs|1.38ns|5.17ns|0.157| 0|0|995 B| |#6020|`CallElasticsearchAsync`|net6.0|1.18μs|1.23ns|4.75ns|0.0129| 0|0|952 B| |#6020|`CallElasticsearchAsync`|netcoreapp3.1|1.66μs|1.02ns|3.82ns|0.0141| 0|0|1.02 KB| |#6020|`CallElasticsearchAsync`|net472|2.57μs|3.15ns|11.8ns|0.167| 0|0|1.05 KB|

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`ExecuteAsync`|net6.0|1.21μs|0.469ns|1.76ns|0.0133| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`ExecuteAsync`|netcoreapp3.1|1.63μs|0.767ns|2.97ns|0.0123| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`ExecuteAsync`|net472|1.69μs|0.492ns|1.91ns|0.145| 0|0|915 B| |#6020|`ExecuteAsync`|net6.0|1.33μs|0.706ns|2.64ns|0.0135| 0|0|952 B| |#6020|`ExecuteAsync`|netcoreapp3.1|1.64μs|0.517ns|1.87ns|0.0131| 0|0|952 B| |#6020|`ExecuteAsync`|net472|1.75μs|0.905ns|3.5ns|0.145| 0|0|915 B|

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`SendAsync`|net6.0|4.1μs|1.85ns|6.92ns|0.0306| 0|0|2.22 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`SendAsync`|netcoreapp3.1|5.07μs|3.27ns|12.7ns|0.038| 0|0|2.76 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`SendAsync`|net472|7.76μs|1.8ns|6.99ns|0.497| 0|0|3.15 KB| |#6020|`SendAsync`|net6.0|4.1μs|1.31ns|4.91ns|0.0307| 0|0|2.22 KB| |#6020|`SendAsync`|netcoreapp3.1|5.08μs|1.18ns|4.59ns|0.0355| 0|0|2.76 KB| |#6020|`SendAsync`|net472|7.76μs|1.7ns|6.59ns|0.5| 0|0|3.15 KB|

Benchmarks.Trace.ILoggerBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #6020 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 | 1.126 | 1,473.46 | 1,659.07 |

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`EnrichedLog`|net6.0|1.47μs|0.631ns|2.36ns|0.0229| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`EnrichedLog`|netcoreapp3.1|2.24μs|1.15ns|4.44ns|0.0223| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`EnrichedLog`|net472|2.61μs|3.14ns|12.2ns|0.249| 0|0|1.57 KB| |#6020|`EnrichedLog`|net6.0|1.66μs|0.459ns|1.66ns|0.0232| 0|0|1.64 KB| |#6020|`EnrichedLog`|netcoreapp3.1|2.22μs|0.947ns|3.54ns|0.0221| 0|0|1.64 KB| |#6020|`EnrichedLog`|net472|2.75μs|3.36ns|13ns|0.25| 0|0|1.57 KB|

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`EnrichedLog`|net6.0|114μs|227ns|881ns|0.0571| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`EnrichedLog`|netcoreapp3.1|119μs|201ns|777ns|0.0599| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`EnrichedLog`|net472|146μs|207ns|802ns|0.656| 0.219|0|4.46 KB| |#6020|`EnrichedLog`|net6.0|119μs|192ns|743ns|0.0591| 0|0|4.28 KB| |#6020|`EnrichedLog`|netcoreapp3.1|120μs|381ns|1.47μs|0| 0|0|4.28 KB| |#6020|`EnrichedLog`|net472|149μs|226ns|876ns|0.678| 0.226|0|4.46 KB|

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`EnrichedLog`|net6.0|3.12μs|4.19ns|16.2ns|0.03| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`EnrichedLog`|netcoreapp3.1|4.08μs|3.24ns|12.5ns|0.0285| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`EnrichedLog`|net472|4.84μs|0.827ns|2.98ns|0.32| 0|0|2.02 KB| |#6020|`EnrichedLog`|net6.0|2.97μs|1.07ns|4.15ns|0.0297| 0|0|2.2 KB| |#6020|`EnrichedLog`|netcoreapp3.1|4.12μs|1.1ns|4.25ns|0.0288| 0|0|2.2 KB| |#6020|`EnrichedLog`|net472|4.94μs|3.27ns|12.7ns|0.321| 0|0|2.02 KB|

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`SendReceive`|net6.0|1.33μs|0.571ns|2.14ns|0.0159| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`SendReceive`|netcoreapp3.1|1.78μs|0.79ns|3.06ns|0.0151| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`SendReceive`|net472|2.15μs|1.44ns|5.39ns|0.183| 0.00107|0|1.16 KB| |#6020|`SendReceive`|net6.0|1.28μs|0.578ns|2.08ns|0.016| 0|0|1.14 KB| |#6020|`SendReceive`|netcoreapp3.1|1.84μs|1.36ns|5.27ns|0.0156| 0|0|1.14 KB| |#6020|`SendReceive`|net472|2.21μs|1.08ns|4.03ns|0.183| 0.00112|0|1.16 KB|

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`EnrichedLog`|net6.0|2.7μs|1.52ns|5.88ns|0.0216| 0|0|1.6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`EnrichedLog`|netcoreapp3.1|3.83μs|1.55ns|6ns|0.0209| 0|0|1.65 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`EnrichedLog`|net472|4.33μs|3.68ns|14.2ns|0.322| 0|0|2.04 KB| |#6020|`EnrichedLog`|net6.0|2.67μs|0.694ns|2.6ns|0.0213| 0|0|1.6 KB| |#6020|`EnrichedLog`|netcoreapp3.1|3.97μs|2.19ns|8.5ns|0.0217| 0|0|1.65 KB| |#6020|`EnrichedLog`|net472|4.33μs|2.88ns|10.8ns|0.324| 0|0|2.04 KB|

Benchmarks.Trace.SpanBenchmark - Faster :tada: Same allocations :heavy_check_mark: #### Faster :tada: in #6020 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 | 1.121 | 528.19 | 471.08 |

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`StartFinishSpan`|net6.0|420ns|0.305ns|1.18ns|0.00797| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`StartFinishSpan`|netcoreapp3.1|575ns|0.509ns|1.97ns|0.00766| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`StartFinishSpan`|net472|579ns|0.815ns|3.05ns|0.0917| 0|0|578 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`StartFinishScope`|net6.0|529ns|0.967ns|3.75ns|0.00984| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`StartFinishScope`|netcoreapp3.1|770ns|0.987ns|3.82ns|0.00931| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`StartFinishScope`|net472|834ns|0.786ns|3.05ns|0.105| 0|0|658 B| |#6020|`StartFinishSpan`|net6.0|401ns|0.318ns|1.23ns|0.00807| 0|0|576 B| |#6020|`StartFinishSpan`|netcoreapp3.1|545ns|0.222ns|0.831ns|0.00793| 0|0|576 B| |#6020|`StartFinishSpan`|net472|565ns|0.477ns|1.85ns|0.0917| 0|0|578 B| |#6020|`StartFinishScope`|net6.0|471ns|0.261ns|1.01ns|0.00983| 0|0|696 B| |#6020|`StartFinishScope`|netcoreapp3.1|695ns|0.291ns|1.13ns|0.00971| 0|0|696 B| |#6020|`StartFinishScope`|net472|858ns|1.01ns|3.91ns|0.104| 0|0|658 B|

Benchmarks.Trace.TraceAnnotationsBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #6020 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.115 | 589.80 | 657.44 |

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`RunOnMethodBegin`|net6.0|590ns|0.453ns|1.75ns|0.00974| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`RunOnMethodBegin`|netcoreapp3.1|934ns|0.69ns|2.67ns|0.00935| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/66707046397580253ded828257a7cb63caa71035)|`RunOnMethodBegin`|net472|1.14μs|0.843ns|3.26ns|0.104| 0|0|658 B| |#6020|`RunOnMethodBegin`|net6.0|657ns|0.6ns|2.32ns|0.00965| 0|0|696 B| |#6020|`RunOnMethodBegin`|netcoreapp3.1|880ns|0.669ns|2.59ns|0.00928| 0|0|696 B| |#6020|`RunOnMethodBegin`|net472|1.1μs|1.83ns|7.1ns|0.104| 0|0|658 B|

andrewlock commented 2 weeks ago

Throughput/Crank Report :zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6020) (11.376M)   : 0, 11376374
    master (11.231M)   : 0, 11231191
    benchmarks/2.9.0 (11.382M)   : 0, 11382231

    section Automatic
    This PR (6020) (7.443M)   : 0, 7442962
    master (7.515M)   : 0, 7514608
    benchmarks/2.9.0 (7.834M)   : 0, 7834075

    section Trace stats
    master (7.733M)   : 0, 7732900

    section Manual
    master (11.202M)   : 0, 11202296

    section Manual + Automatic
    This PR (6020) (6.789M)   : 0, 6788547
    master (6.988M)   : 0, 6987518

    section DD_TRACE_ENABLED=0
    master (10.466M)   : 0, 10466013

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6020) (9.531M)   : 0, 9530905
    master (9.544M)   : 0, 9544174
    benchmarks/2.9.0 (9.745M)   : 0, 9744903

    section Automatic
    This PR (6020) (6.585M)   : 0, 6584595
    master (6.633M)   : 0, 6633210

    section Trace stats
    master (6.699M)   : 0, 6699486

    section Manual
    master (9.456M)   : 0, 9455551

    section Manual + Automatic
    This PR (6020) (6.162M)   : 0, 6161853
    master (6.210M)   : 0, 6209519

    section DD_TRACE_ENABLED=0
    master (9.025M)   : 0, 9024862

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6020) (10.166M)   : 0, 10166189
    master (10.276M)   : 0, 10276111
    benchmarks/2.9.0 (10.073M)   : 0, 10073079

    section Automatic
    This PR (6020) (6.857M)   : 0, 6857373
    master (6.636M)   : 0, 6635574
    benchmarks/2.9.0 (7.410M)   : 0, 7409502

    section Trace stats
    master (7.388M)   : 0, 7387724

    section Manual
    master (9.906M)   : 0, 9906408

    section Manual + Automatic
    This PR (6020) (6.383M)   : 0, 6383450
    master (6.175M)   : 0, 6174678

    section DD_TRACE_ENABLED=0
    master (9.259M)   : 0, 9258887

DataDog / dd-trace-dotnet