Closed andrewlock closed 2 weeks ago
datadog-ddstaging[bot]
commented
2 weeks ago Branch report: andrew/fix-version-bump
Commit report: 67d6fd6
Test service: dd-trace-dotnet
:white_check_mark: 0 Failed, 365336 Passed, 2059 Skipped, 15h 12m 32.98s Total Time :hourglass: 1 Performance Regression
EnrichedLog - Benchmarks.Trace.ILoggerBenchmark 1.98µs (+452ns, +30%) - Details
andrewlock
commented
2 weeks ago Execution-time results for samples comparing the following branches/commits:
Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.
Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).
gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6022) - mean (70ms) : 67, 72
. : milestone, 70,
master - mean (70ms) : 66, 73
. : milestone, 70,
section CallTarget+Inlining+NGEN
This PR (6022) - mean (1,110ms) : 1097, 1124
. : milestone, 1110,
master - mean (1,115ms) : 1101, 1128
. : milestone, 1115,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6022) - mean (109ms) : 105, 112
. : milestone, 109,
master - mean (108ms) : 105, 111
. : milestone, 108,
section CallTarget+Inlining+NGEN
This PR (6022) - mean (818ms) : 802, 833
. : milestone, 818,
master - mean (815ms) : 801, 829
. : milestone, 815,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6022) - mean (92ms) : 90, 94
. : milestone, 92,
master - mean (93ms) : 89, 97
. : milestone, 93,
section CallTarget+Inlining+NGEN
This PR (6022) - mean (771ms) : 753, 789
. : milestone, 771,
master - mean (767ms) : 750, 783
. : milestone, 767,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6022) - mean (192ms) : 187, 196
. : milestone, 192,
master - mean (192ms) : 188, 196
. : milestone, 192,
section CallTarget+Inlining+NGEN
This PR (6022) - mean (1,195ms) : 1166, 1224
. : milestone, 1195,
master - mean (1,195ms) : 1169, 1220
. : milestone, 1195,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6022) - mean (276ms) : 273, 279
. : milestone, 276,
master - mean (277ms) : 272, 282
. : milestone, 277,
section CallTarget+Inlining+NGEN
This PR (6022) - mean (972ms) : 952, 991
. : milestone, 972,
master - mean (975ms) : 952, 998
. : milestone, 975,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6022) - mean (265ms) : 261, 268
. : milestone, 265,
master - mean (265ms) : 261, 268
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (6022) - mean (954ms) : 934, 974
. : milestone, 954,
master - mean (961ms) : 937, 985
. : milestone, 961,
Throughput results for AspNetCoreSimpleController comparing the following branches/commits:
Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.
Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!
gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6022) (10.993M) : 0, 10993285
master (11.058M) : 0, 11058270
benchmarks/2.9.0 (11.185M) : 0, 11185492
section Automatic
This PR (6022) (7.450M) : 0, 7449595
master (7.433M) : 0, 7433068
benchmarks/2.9.0 (7.935M) : 0, 7934520
section Trace stats
master (7.639M) : 0, 7639043
section Manual
master (11.001M) : 0, 11001149
section Manual + Automatic
This PR (6022) (6.833M) : 0, 6833121
master (6.890M) : 0, 6889686
section DD_TRACE_ENABLED=0
master (10.219M) : 0, 10219072
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6022) (9.493M) : 0, 9493379
master (9.512M) : 0, 9512187
benchmarks/2.9.0 (9.560M) : 0, 9559569
section Automatic
This PR (6022) (6.716M) : 0, 6716443
master (6.599M) : 0, 6598948
section Trace stats
master (6.877M) : 0, 6877069
section Manual
master (9.582M) : 0, 9582301
section Manual + Automatic
This PR (6022) (5.945M) : 0, 5945393
master (6.227M) : 0, 6227256
section DD_TRACE_ENABLED=0
master (8.944M) : 0, 8943787
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6022) (10.392M) : 0, 10391676
master (9.874M) : 0, 9873927
benchmarks/2.9.0 (10.118M) : 0, 10117626
section Automatic
This PR (6022) (6.776M) : 0, 6775815
master (6.609M) : 0, 6609340
benchmarks/2.9.0 (7.416M) : 0, 7415715
section Trace stats
master (7.330M) : 0, 7329885
section Manual
master (10.106M) : 0, 10106430
section Manual + Automatic
This PR (6022) (6.372M) : 0, 6371832
master (6.122M) : 0, 6122215
section DD_TRACE_ENABLED=0
master (9.295M) : 0, 9294721
Summary of changes
Fixes a bug in the version-bump path
Reason for change
The path needs to be relative to the tracer folder (:wat:)
Implementation details
Fix the path
Test coverage
Yup, tested the version bump task works as expected
Other details
Fixed or release/2.x branch in