Closed daniel-romano-DD closed 2 weeks ago
The following differences have been observed in committed snapshots. It is meant to help the reviewer. The diff is simplistic, so please check some files anyway while we improve it.
Branch report: dani/asm/shorten_snapshots
Commit report: fdb3e9c
Test service: dd-trace-dotnet
:white_check_mark: 0 Failed, 364642 Passed, 2058 Skipped, 15h 45m 25.7s Total Time
Execution-time results for samples comparing the following branches/commits:
Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.
Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).
gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6024) - mean (70ms) : 66, 74
. : milestone, 70,
master - mean (69ms) : 67, 71
. : milestone, 69,
section CallTarget+Inlining+NGEN
This PR (6024) - mean (1,114ms) : 1094, 1133
. : milestone, 1114,
master - mean (1,107ms) : 1093, 1121
. : milestone, 1107,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6024) - mean (108ms) : 105, 112
. : milestone, 108,
master - mean (108ms) : 105, 111
. : milestone, 108,
section CallTarget+Inlining+NGEN
This PR (6024) - mean (815ms) : 796, 834
. : milestone, 815,
master - mean (819ms) : 799, 839
. : milestone, 819,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6024) - mean (92ms) : 90, 95
. : milestone, 92,
master - mean (91ms) : 88, 95
. : milestone, 91,
section CallTarget+Inlining+NGEN
This PR (6024) - mean (768ms) : 746, 789
. : milestone, 768,
master - mean (772ms) : 753, 790
. : milestone, 772,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6024) - mean (191ms) : 187, 194
. : milestone, 191,
master - mean (191ms) : 187, 194
. : milestone, 191,
section CallTarget+Inlining+NGEN
This PR (6024) - mean (1,191ms) : 1167, 1214
. : milestone, 1191,
master - mean (1,192ms) : 1162, 1221
. : milestone, 1192,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6024) - mean (277ms) : 273, 281
. : milestone, 277,
master - mean (276ms) : 271, 281
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (6024) - mean (977ms) : 955, 1000
. : milestone, 977,
master - mean (972ms) : 950, 994
. : milestone, 972,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6024) - mean (264ms) : 261, 268
. : milestone, 264,
master - mean (264ms) : 261, 268
. : milestone, 264,
section CallTarget+Inlining+NGEN
This PR (6024) - mean (951ms) : 922, 980
. : milestone, 951,
master - mean (951ms) : 928, 974
. : milestone, 951,
Benchmarks for #6024 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored.
Benchmarks for #6024 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored.
Throughput results for AspNetCoreSimpleController comparing the following branches/commits:
Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.
Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!
gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6024) (11.243M) : 0, 11242699
master (11.231M) : 0, 11231191
benchmarks/2.9.0 (11.382M) : 0, 11382231
section Automatic
This PR (6024) (7.472M) : 0, 7471660
master (7.515M) : 0, 7514608
benchmarks/2.9.0 (7.834M) : 0, 7834075
section Trace stats
master (7.733M) : 0, 7732900
section Manual
master (11.202M) : 0, 11202296
section Manual + Automatic
This PR (6024) (6.899M) : 0, 6899112
master (6.988M) : 0, 6987518
section DD_TRACE_ENABLED=0
master (10.466M) : 0, 10466013
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6024) (9.591M) : 0, 9590588
master (9.544M) : 0, 9544174
benchmarks/2.9.0 (9.745M) : 0, 9744903
section Automatic
This PR (6024) (6.632M) : 0, 6632434
master (6.633M) : 0, 6633210
section Trace stats
master (6.699M) : 0, 6699486
section Manual
master (9.456M) : 0, 9455551
section Manual + Automatic
This PR (6024) (6.261M) : 0, 6260766
master (6.210M) : 0, 6209519
section DD_TRACE_ENABLED=0
master (9.025M) : 0, 9024862
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6024) (10.080M) : 0, 10080171
master (10.276M) : 0, 10276111
benchmarks/2.9.0 (10.073M) : 0, 10073079
section Automatic
This PR (6024) (6.732M) : 0, 6731762
master (6.636M) : 0, 6635574
benchmarks/2.9.0 (7.410M) : 0, 7409502
section Trace stats
master (7.388M) : 0, 7387724
section Manual
master (9.906M) : 0, 9906408
section Manual + Automatic
This PR (6024) (6.078M) : 0, 6077631
master (6.175M) : 0, 6174678
section DD_TRACE_ENABLED=0
master (9.259M) : 0, 9258887
Summary of changes
Allows for verify test to override the snapshot file name
Reason for change
Some snapshots file names were too long and difficult to understand
Implementation details
Test coverage
Other details