[Profiler] Send ssi info with profiles

chrisnas commented 2 weeks ago

Summary of changes

Add SSI details when sending profiles

Reason for change

Allow the BE to emit telemetry metrics for SSI deployment

Implementation details

Test coverage

Other details

andrewlock commented 2 weeks ago

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6026) - mean (70ms)  : 67, 73
     .   : milestone, 70,
    master - mean (70ms)  : 67, 73
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6026) - mean (1,115ms)  : 1094, 1137
     .   : milestone, 1115,
    master - mean (1,111ms)  : 1088, 1133
     .   : milestone, 1111,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6026) - mean (109ms)  : 106, 111
     .   : milestone, 109,
    master - mean (108ms)  : 105, 112
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6026) - mean (819ms)  : 801, 837
     .   : milestone, 819,
    master - mean (814ms)  : 799, 830
     .   : milestone, 814,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6026) - mean (94ms)  : 90, 97
     .   : milestone, 94,
    master - mean (92ms)  : 89, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6026) - mean (774ms)  : 756, 791
     .   : milestone, 774,
    master - mean (770ms)  : 748, 793
     .   : milestone, 770,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6026) - mean (196ms)  : 176, 216
     .   : milestone, 196,
    master - mean (190ms)  : 187, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6026) - mean (1,197ms)  : 1175, 1218
     .   : milestone, 1197,
    master - mean (1,192ms)  : 1168, 1215
     .   : milestone, 1192,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6026) - mean (277ms)  : 272, 283
     .   : milestone, 277,
    master - mean (277ms)  : 272, 281
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6026) - mean (976ms)  : 953, 999
     .   : milestone, 976,
    master - mean (975ms)  : 953, 997
     .   : milestone, 975,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6026) - mean (265ms)  : 260, 270
     .   : milestone, 265,
    master - mean (266ms)  : 263, 268
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6026) - mean (950ms)  : 931, 969
     .   : milestone, 950,
    master - mean (946ms)  : 922, 970
     .   : milestone, 946,

datadog-ddstaging[bot] commented 2 weeks ago

Datadog Report

Branch report: chrisnas/send_ssi_info Commit report: 0de785d Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 370500 Passed, 2348 Skipped, 17h 6m 59.34s Total Time

andrewlock commented 2 weeks ago

Benchmarks Report for tracer :snail:

Benchmarks for #6026 compared to master:

1 benchmarks are faster, with geometric mean 1.143
1 benchmarks are slower, with geometric mean 1.169
1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`StartStopWithChild`|net6.0|7.68μs|44.1ns|330ns|0.0148| 0.0074|0|5.43 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`StartStopWithChild`|netcoreapp3.1|9.78μs|54.6ns|358ns|0.0195| 0.00976|0|5.62 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`StartStopWithChild`|net472|16.2μs|60.8ns|236ns|1.02| 0.314|0.102|6.06 KB| |#6026|`StartStopWithChild`|net6.0|7.75μs|44.2ns|345ns|0.0146| 0.00728|0|5.43 KB| |#6026|`StartStopWithChild`|netcoreapp3.1|9.75μs|53.1ns|301ns|0.0199| 0.00994|0|5.61 KB| |#6026|`StartStopWithChild`|net472|16.2μs|46.1ns|178ns|1.02| 0.304|0.088|6.06 KB|

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`WriteAndFlushEnrichedTraces`|net6.0|486μs|207ns|801ns|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|625μs|337ns|1.22μs|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`WriteAndFlushEnrichedTraces`|net472|892μs|722ns|2.8μs|0.431| 0|0|3.3 KB| |#6026|`WriteAndFlushEnrichedTraces`|net6.0|470μs|382ns|1.48μs|0| 0|0|2.7 KB| |#6026|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|636μs|161ns|559ns|0| 0|0|2.7 KB| |#6026|`WriteAndFlushEnrichedTraces`|net472|827μs|937ns|3.63μs|0.414| 0|0|3.3 KB|

Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`SendRequest`|net6.0|197μs|1.1μs|7.55μs|0.19| 0|0|18.45 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`SendRequest`|netcoreapp3.1|225μs|1.31μs|11.9μs|0.208| 0|0|20.61 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`SendRequest`|net472|0.000548ns|0.000228ns|0.000855ns|0| 0|0|0 b| |#6026|`SendRequest`|net6.0|193μs|1.08μs|7.24μs|0.189| 0|0|18.45 KB| |#6026|`SendRequest`|netcoreapp3.1|222μs|1.1μs|4.93μs|0.217| 0|0|20.61 KB| |#6026|`SendRequest`|net472|0.00112ns|0.000394ns|0.00153ns|0| 0|0|0 b|

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada: #### Fewer allocations :tada: in #6026 | Benchmark | Base Allocated | Diff Allocated | Change | Change % | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 | 41.8 KB | 41.58 KB | -220 B | -0.53%

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`WriteAndFlushEnrichedTraces`|net6.0|556μs|1.31μs|4.71μs|0.548| 0|0|41.53 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|681μs|3.3μs|16.9μs|0.347| 0|0|41.8 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`WriteAndFlushEnrichedTraces`|net472|874μs|3.47μs|13.4μs|8.19| 2.59|0.431|53.3 KB| |#6026|`WriteAndFlushEnrichedTraces`|net6.0|551μs|2.26μs|8.73μs|0.539| 0|0|41.68 KB| |#6026|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|691μs|3.27μs|12.2μs|0.34| 0|0|41.58 KB| |#6026|`WriteAndFlushEnrichedTraces`|net472|856μs|3.22μs|12μs|8.36| 2.64|0.44|53.37 KB|

Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`ExecuteNonQuery`|net6.0|1.4μs|1.57ns|6.07ns|0.014| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`ExecuteNonQuery`|netcoreapp3.1|1.73μs|1.31ns|5.08ns|0.0131| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`ExecuteNonQuery`|net472|2.08μs|1.6ns|5.99ns|0.157| 0|0|987 B| |#6026|`ExecuteNonQuery`|net6.0|1.31μs|1.09ns|4.09ns|0.0142| 0|0|1.02 KB| |#6026|`ExecuteNonQuery`|netcoreapp3.1|1.75μs|1.26ns|4.86ns|0.0139| 0|0|1.02 KB| |#6026|`ExecuteNonQuery`|net472|2.1μs|3.32ns|12.9ns|0.156| 0|0|987 B|

Benchmarks.Trace.ElasticsearchBenchmark - Faster :tada: Same allocations :heavy_check_mark: #### Faster :tada: in #6026 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 | 1.143 | 1,347.14 | 1,178.23 |

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`CallElasticsearch`|net6.0|1.23μs|1.1ns|4.11ns|0.0136| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`CallElasticsearch`|netcoreapp3.1|1.63μs|1.17ns|4.38ns|0.013| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`CallElasticsearch`|net472|2.51μs|1.33ns|5.16ns|0.158| 0|0|995 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`CallElasticsearchAsync`|net6.0|1.35μs|1.19ns|4.46ns|0.0135| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`CallElasticsearchAsync`|netcoreapp3.1|1.67μs|0.484ns|1.74ns|0.0134| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`CallElasticsearchAsync`|net472|2.62μs|1.9ns|7.35ns|0.167| 0|0|1.05 KB| |#6026|`CallElasticsearch`|net6.0|1.19μs|1.52ns|5.87ns|0.0137| 0|0|976 B| |#6026|`CallElasticsearch`|netcoreapp3.1|1.55μs|0.756ns|2.83ns|0.0131| 0|0|976 B| |#6026|`CallElasticsearch`|net472|2.47μs|1.84ns|6.87ns|0.158| 0|0|995 B| |#6026|`CallElasticsearchAsync`|net6.0|1.18μs|5.14ns|19.9ns|0.0133| 0|0|952 B| |#6026|`CallElasticsearchAsync`|netcoreapp3.1|1.6μs|0.861ns|3.22ns|0.0138| 0|0|1.02 KB| |#6026|`CallElasticsearchAsync`|net472|2.59μs|1.99ns|7.72ns|0.166| 0|0|1.05 KB|

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`ExecuteAsync`|net6.0|1.26μs|1.82ns|7.05ns|0.0132| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`ExecuteAsync`|netcoreapp3.1|1.71μs|0.645ns|2.5ns|0.0121| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`ExecuteAsync`|net472|1.86μs|0.667ns|2.5ns|0.145| 0|0|915 B| |#6026|`ExecuteAsync`|net6.0|1.31μs|1.33ns|5.15ns|0.0131| 0|0|952 B| |#6026|`ExecuteAsync`|netcoreapp3.1|1.6μs|1.01ns|3.77ns|0.0127| 0|0|952 B| |#6026|`ExecuteAsync`|net472|1.81μs|0.901ns|3.49ns|0.145| 0|0|915 B|

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`SendAsync`|net6.0|4.05μs|1.5ns|5.42ns|0.0303| 0|0|2.22 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`SendAsync`|netcoreapp3.1|5μs|1.73ns|6.72ns|0.0375| 0|0|2.76 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`SendAsync`|net472|7.68μs|3.48ns|13ns|0.497| 0|0|3.15 KB| |#6026|`SendAsync`|net6.0|4.15μs|2.07ns|7.47ns|0.0314| 0|0|2.22 KB| |#6026|`SendAsync`|netcoreapp3.1|5.07μs|3.02ns|11.3ns|0.0382| 0|0|2.76 KB| |#6026|`SendAsync`|net472|7.79μs|1.47ns|5.49ns|0.496| 0|0|3.15 KB|

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`EnrichedLog`|net6.0|1.52μs|0.568ns|2.13ns|0.023| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`EnrichedLog`|netcoreapp3.1|2.22μs|1.18ns|4.42ns|0.0221| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`EnrichedLog`|net472|2.55μs|1.91ns|7.15ns|0.249| 0|0|1.57 KB| |#6026|`EnrichedLog`|net6.0|1.45μs|0.495ns|1.72ns|0.0229| 0|0|1.64 KB| |#6026|`EnrichedLog`|netcoreapp3.1|2.39μs|1.07ns|4.13ns|0.0224| 0|0|1.64 KB| |#6026|`EnrichedLog`|net472|2.62μs|1.63ns|6.31ns|0.249| 0|0|1.57 KB|

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`EnrichedLog`|net6.0|114μs|290ns|1.12μs|0.0577| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`EnrichedLog`|netcoreapp3.1|120μs|263ns|1.02μs|0.0609| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`EnrichedLog`|net472|147μs|161ns|623ns|0.662| 0.221|0|4.46 KB| |#6026|`EnrichedLog`|net6.0|115μs|256ns|992ns|0| 0|0|4.28 KB| |#6026|`EnrichedLog`|netcoreapp3.1|120μs|192ns|743ns|0.0597| 0|0|4.28 KB| |#6026|`EnrichedLog`|net472|147μs|148ns|575ns|0.659| 0.22|0|4.46 KB|

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`EnrichedLog`|net6.0|2.93μs|0.737ns|2.85ns|0.0307| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`EnrichedLog`|netcoreapp3.1|4.25μs|3.55ns|13.8ns|0.0297| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`EnrichedLog`|net472|4.77μs|1.59ns|6.16ns|0.319| 0|0|2.02 KB| |#6026|`EnrichedLog`|net6.0|3.02μs|0.962ns|3.72ns|0.0301| 0|0|2.2 KB| |#6026|`EnrichedLog`|netcoreapp3.1|4.28μs|1.43ns|5.34ns|0.03| 0|0|2.2 KB| |#6026|`EnrichedLog`|net472|4.92μs|1.26ns|4.73ns|0.32| 0|0|2.02 KB|

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`SendReceive`|net6.0|1.32μs|0.929ns|3.6ns|0.0159| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`SendReceive`|netcoreapp3.1|1.81μs|0.996ns|3.73ns|0.0154| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`SendReceive`|net472|2.1μs|1.72ns|6.67ns|0.183| 0.00105|0|1.16 KB| |#6026|`SendReceive`|net6.0|1.4μs|1.59ns|6.15ns|0.0162| 0|0|1.14 KB| |#6026|`SendReceive`|netcoreapp3.1|1.68μs|0.679ns|2.63ns|0.0154| 0|0|1.14 KB| |#6026|`SendReceive`|net472|2.1μs|1.02ns|3.96ns|0.183| 0.00104|0|1.16 KB|

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`EnrichedLog`|net6.0|2.79μs|3.56ns|13.8ns|0.0223| 0|0|1.6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`EnrichedLog`|netcoreapp3.1|3.97μs|4.89ns|18.9ns|0.0217| 0|0|1.65 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`EnrichedLog`|net472|4.29μs|2.16ns|8.36ns|0.322| 0|0|2.04 KB| |#6026|`EnrichedLog`|net6.0|2.87μs|0.762ns|2.95ns|0.023| 0|0|1.6 KB| |#6026|`EnrichedLog`|netcoreapp3.1|3.82μs|1.71ns|6.61ns|0.0212| 0|0|1.65 KB| |#6026|`EnrichedLog`|net472|4.37μs|1.4ns|5.41ns|0.322| 0|0|2.04 KB|

Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #6026 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 | 1.169 | 786.22 | 919.07 |

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`StartFinishSpan`|net6.0|393ns|0.52ns|2.01ns|0.00812| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`StartFinishSpan`|netcoreapp3.1|587ns|0.83ns|3.21ns|0.0076| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`StartFinishSpan`|net472|695ns|0.76ns|2.94ns|0.0918| 0|0|578 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`StartFinishScope`|net6.0|491ns|0.14ns|0.525ns|0.00978| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`StartFinishScope`|netcoreapp3.1|739ns|0.429ns|1.66ns|0.00934| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`StartFinishScope`|net472|787ns|0.52ns|2.01ns|0.104| 0|0|658 B| |#6026|`StartFinishSpan`|net6.0|399ns|0.12ns|0.466ns|0.00822| 0|0|576 B| |#6026|`StartFinishSpan`|netcoreapp3.1|548ns|0.375ns|1.45ns|0.00801| 0|0|576 B| |#6026|`StartFinishSpan`|net472|657ns|0.205ns|0.794ns|0.0915| 0|0|578 B| |#6026|`StartFinishScope`|net6.0|494ns|0.219ns|0.849ns|0.00967| 0|0|696 B| |#6026|`StartFinishScope`|netcoreapp3.1|687ns|0.328ns|1.27ns|0.00951| 0|0|696 B| |#6026|`StartFinishScope`|net472|919ns|0.548ns|2.12ns|0.104| 0|0|658 B|

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`RunOnMethodBegin`|net6.0|689ns|3.61ns|18.1ns|0.00965| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`RunOnMethodBegin`|netcoreapp3.1|915ns|2.61ns|10.1ns|0.00912| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/336f69287ce7bcebcf81922b7ac37cf684362acb)|`RunOnMethodBegin`|net472|1.13μs|1.33ns|5.15ns|0.104| 0|0|658 B| |#6026|`RunOnMethodBegin`|net6.0|655ns|0.53ns|2.05ns|0.0098| 0|0|696 B| |#6026|`RunOnMethodBegin`|netcoreapp3.1|896ns|0.464ns|1.67ns|0.00946| 0|0|696 B| |#6026|`RunOnMethodBegin`|net472|1.11μs|0.357ns|1.38ns|0.104| 0|0|658 B|

andrewlock commented 2 weeks ago

Throughput/Crank Report :zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6026) (11.302M)   : 0, 11302493
    master (11.236M)   : 0, 11236275
    benchmarks/2.9.0 (11.382M)   : 0, 11382231

    section Automatic
    This PR (6026) (7.462M)   : 0, 7462360
    master (7.509M)   : 0, 7508701
    benchmarks/2.9.0 (7.834M)   : 0, 7834075

    section Trace stats
    master (7.758M)   : 0, 7757993

    section Manual
    master (11.290M)   : 0, 11289628

    section Manual + Automatic
    This PR (6026) (6.855M)   : 0, 6855394
    master (6.967M)   : 0, 6966886

    section DD_TRACE_ENABLED=0
    master (10.335M)   : 0, 10334708

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6026) (9.474M)   : 0, 9473792
    master (9.497M)   : 0, 9497111
    benchmarks/2.9.0 (9.745M)   : 0, 9744903

    section Automatic
    This PR (6026) (6.511M)   : 0, 6511032
    master (6.501M)   : 0, 6500519

    section Trace stats
    master (6.934M)   : 0, 6934203

    section Manual
    master (9.547M)   : 0, 9547317

    section Manual + Automatic
    This PR (6026) (6.015M)   : 0, 6014759
    master (6.184M)   : 0, 6184128

    section DD_TRACE_ENABLED=0
    master (8.719M)   : 0, 8718912

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6026) (10.461M)   : 0, 10460721
    master (10.175M)   : 0, 10175017
    benchmarks/2.9.0 (10.073M)   : 0, 10073079

    section Automatic
    This PR (6026) (6.779M)   : 0, 6779371
    master (6.867M)   : 0, 6866796
    benchmarks/2.9.0 (7.410M)   : 0, 7409502

    section Trace stats
    master (7.506M)   : 0, 7506009

    section Manual
    master (10.477M)   : 0, 10476947

    section Manual + Automatic
    This PR (6026) (6.279M)   : 0, 6278623
    master (6.195M)   : 0, 6194935

    section DD_TRACE_ENABLED=0
    master (9.561M)   : 0, 9561119

DataDog / dd-trace-dotnet