search

DataDog / dd-trace-dotnet

.NET Client Library for Datadog APM
https://docs.datadoghq.com/tracing/
Apache License 2.0
437 stars 137 forks source link

[ASM] Capabilities reporting against WAF versions. #6028

Closed NachoEchevarria closed 2 weeks ago

NachoEchevarria commented 2 weeks ago

Summary of changes

The capability reporter was comparing WAF versions against tracer versions. This should be fixed.

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging[bot] commented 2 weeks ago

Datadog Report

Branch report: nacho/RCMCapabilitiesReporting Commit report: 3bfe650 Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 365141 Passed, 2073 Skipped, 15h 52m 45.57s Total Time

andrewlock commented 2 weeks ago

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6028) - mean (70ms)  : 66, 73
     .   : milestone, 70,
    master - mean (70ms)  : 67, 73
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6028) - mean (1,122ms)  : 1102, 1141
     .   : milestone, 1122,
    master - mean (1,111ms)  : 1088, 1133
     .   : milestone, 1111,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6028) - mean (108ms)  : 106, 110
     .   : milestone, 108,
    master - mean (108ms)  : 105, 112
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6028) - mean (820ms)  : 799, 842
     .   : milestone, 820,
    master - mean (814ms)  : 799, 830
     .   : milestone, 814,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6028) - mean (92ms)  : 90, 95
     .   : milestone, 92,
    master - mean (92ms)  : 89, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6028) - mean (770ms)  : 748, 792
     .   : milestone, 770,
    master - mean (770ms)  : 748, 793
     .   : milestone, 770,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6028) - mean (191ms)  : 188, 194
     .   : milestone, 191,
    master - mean (190ms)  : 187, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6028) - mean (1,200ms)  : 1169, 1232
     .   : milestone, 1200,
    master - mean (1,192ms)  : 1168, 1215
     .   : milestone, 1192,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6028) - mean (277ms)  : 273, 282
     .   : milestone, 277,
    master - mean (277ms)  : 272, 281
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6028) - mean (975ms)  : 960, 990
     .   : milestone, 975,
    master - mean (975ms)  : 953, 997
     .   : milestone, 975,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6028) - mean (265ms)  : 261, 269
     .   : milestone, 265,
    master - mean (266ms)  : 263, 268
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6028) - mean (952ms)  : 927, 977
     .   : milestone, 952,
    master - mean (946ms)  : 922, 970
     .   : milestone, 946,
andrewlock commented 2 weeks ago

Benchmarks Report for appsec :snail:

Benchmarks for #6028 compared to master:

The following thresholds were used for comparing the benchmark speeds:

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Faster :tada: Same allocations :heavy_check_mark: #### Faster :tada: in #6028 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑net6.0 | 1.130 | 159.84 | 141.42 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`AllCycleSimpleBody`|net6.0|73.1μs|130ns|486ns|0.0735| 0|0|6.01 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`AllCycleSimpleBody`|netcoreapp3.1|62.6μs|59ns|229ns|0.0945| 0|0|6.95 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`AllCycleSimpleBody`|net472|47.9μs|56.7ns|220ns|1.32| 0|0|8.34 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`AllCycleMoreComplexBody`|net6.0|79.7μs|236ns|883ns|0.117| 0|0|9.51 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`AllCycleMoreComplexBody`|netcoreapp3.1|69.5μs|108ns|403ns|0.138| 0|0|10.36 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`AllCycleMoreComplexBody`|net472|55.4μs|64.2ns|249ns|1.86| 0.0278|0|11.85 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`ObjectExtractorSimpleBody`|net6.0|160ns|0.102ns|0.383ns|0.00396| 0|0|280 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`ObjectExtractorSimpleBody`|netcoreapp3.1|193ns|0.181ns|0.677ns|0.00368| 0|0|272 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`ObjectExtractorSimpleBody`|net472|163ns|0.248ns|0.961ns|0.0446| 0|0|281 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`ObjectExtractorMoreComplexBody`|net6.0|3.09μs|1.14ns|4.26ns|0.053| 0|0|3.78 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`ObjectExtractorMoreComplexBody`|netcoreapp3.1|3.9μs|2.62ns|10.1ns|0.0489| 0|0|3.69 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`ObjectExtractorMoreComplexBody`|net472|3.84μs|1.51ns|5.45ns|0.601| 0.00578|0|3.8 KB| |#6028|`AllCycleSimpleBody`|net6.0|73.6μs|153ns|592ns|0.0745| 0|0|6.01 KB| |#6028|`AllCycleSimpleBody`|netcoreapp3.1|61.7μs|164ns|634ns|0.0923| 0|0|6.95 KB| |#6028|`AllCycleSimpleBody`|net472|48.9μs|189ns|734ns|1.31| 0|0|8.34 KB| |#6028|`AllCycleMoreComplexBody`|net6.0|78.9μs|218ns|844ns|0.118| 0|0|9.51 KB| |#6028|`AllCycleMoreComplexBody`|netcoreapp3.1|69.3μs|272ns|1.05μs|0.139| 0|0|10.36 KB| |#6028|`AllCycleMoreComplexBody`|net472|56.5μs|280ns|1.15μs|1.86| 0.0286|0|11.85 KB| |#6028|`ObjectExtractorSimpleBody`|net6.0|142ns|0.672ns|2.6ns|0.00392| 0|0|280 B| |#6028|`ObjectExtractorSimpleBody`|netcoreapp3.1|207ns|0.556ns|2.16ns|0.00367| 0|0|272 B| |#6028|`ObjectExtractorSimpleBody`|net472|176ns|0.955ns|5.49ns|0.0446| 0|0|281 B| |#6028|`ObjectExtractorMoreComplexBody`|net6.0|3.09μs|12.9ns|49.9ns|0.0532| 0|0|3.78 KB| |#6028|`ObjectExtractorMoreComplexBody`|netcoreapp3.1|3.98μs|5.76ns|21.6ns|0.0484| 0|0|3.69 KB| |#6028|`ObjectExtractorMoreComplexBody`|net472|3.89μs|18.1ns|72.4ns|0.603| 0.00609|0|3.8 KB|
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`EncodeArgs`|net6.0|37.7μs|20.3ns|78.8ns|0.453| 0|0|32.4 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`EncodeArgs`|netcoreapp3.1|53.9μs|33.3ns|129ns|0.429| 0|0|32.4 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`EncodeArgs`|net472|66.4μs|25.1ns|93.8ns|5.14| 0.0664|0|32.5 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`EncodeLegacyArgs`|net6.0|71.5μs|86.1ns|334ns|0| 0|0|2.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`EncodeLegacyArgs`|netcoreapp3.1|107μs|315ns|1.22μs|0| 0|0|2.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`EncodeLegacyArgs`|net472|150μs|85.7ns|320ns|0.303| 0|0|2.15 KB| |#6028|`EncodeArgs`|net6.0|38.2μs|97.7ns|378ns|0.462| 0|0|32.4 KB| |#6028|`EncodeArgs`|netcoreapp3.1|54μs|102ns|397ns|0.433| 0|0|32.4 KB| |#6028|`EncodeArgs`|net472|65.1μs|122ns|440ns|5.16| 0.0658|0|32.5 KB| |#6028|`EncodeLegacyArgs`|net6.0|75.2μs|61.7ns|214ns|0| 0|0|2.14 KB| |#6028|`EncodeLegacyArgs`|netcoreapp3.1|106μs|195ns|753ns|0| 0|0|2.14 KB| |#6028|`EncodeLegacyArgs`|net472|151μs|102ns|395ns|0.306| 0|0|2.15 KB|
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`RunWafRealisticBenchmark`|net6.0|183μs|61.3ns|237ns|0| 0|0|2.42 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`RunWafRealisticBenchmark`|netcoreapp3.1|198μs|201ns|778ns|0| 0|0|2.37 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`RunWafRealisticBenchmark`|net472|206μs|62ns|240ns|0.309| 0|0|2.43 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`RunWafRealisticBenchmarkWithAttack`|net6.0|122μs|43.9ns|170ns|0| 0|0|1.46 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`RunWafRealisticBenchmarkWithAttack`|netcoreapp3.1|131μs|110ns|425ns|0| 0|0|1.45 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`RunWafRealisticBenchmarkWithAttack`|net472|139μs|55.2ns|214ns|0.208| 0|0|1.48 KB| |#6028|`RunWafRealisticBenchmark`|net6.0|186μs|284ns|1.1μs|0| 0|0|2.42 KB| |#6028|`RunWafRealisticBenchmark`|netcoreapp3.1|198μs|370ns|1.43μs|0| 0|0|2.37 KB| |#6028|`RunWafRealisticBenchmark`|net472|208μs|138ns|518ns|0.311| 0|0|2.43 KB| |#6028|`RunWafRealisticBenchmarkWithAttack`|net6.0|123μs|150ns|582ns|0| 0|0|1.46 KB| |#6028|`RunWafRealisticBenchmarkWithAttack`|netcoreapp3.1|130μs|111ns|430ns|0| 0|0|1.45 KB| |#6028|`RunWafRealisticBenchmarkWithAttack`|net472|139μs|184ns|711ns|0.209| 0|0|1.48 KB|
Benchmarks.Trace.Iast.StringAspectsBenchmark - Faster :tada: More allocations :warning: #### Faster :tada: in #6028 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 | 1.219 | 64,200.00 | 52,650.00 | multimodal #### More allocations :warning: in #6028 | Benchmark | Base Allocated | Diff Allocated | Change | Change % | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 | 255.48 KB | 311.34 KB | 55.86 KB | 21.87% | Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 | 278.53 KB | 286.72 KB | 8.19 KB | 2.94% #### Fewer allocations :tada: in #6028 | Benchmark | Base Allocated | Diff Allocated | Change | Change % | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 | 59.07 KB | 58.14 KB | -928 B | -1.57% | Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 | 265.04 KB | 254.26 KB | -10.78 KB | -4.07% ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`StringConcatBenchmark`|net6.0|61.3μs|942ns|9.33μs|0| 0|0|43.44 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`StringConcatBenchmark`|netcoreapp3.1|65.2μs|1.03μs|10.2μs|0| 0|0|42.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`StringConcatBenchmark`|net472|37.1μs|52.9ns|183ns|0| 0|0|59.07 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`StringConcatAspectBenchmark`|net6.0|280μs|5.26μs|52.1μs|0| 0|0|255.48 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`StringConcatAspectBenchmark`|netcoreapp3.1|344μs|1.79μs|12.1μs|0| 0|0|265.04 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`StringConcatAspectBenchmark`|net472|272μs|5.76μs|56.4μs|0| 0|0|278.53 KB| |#6028|`StringConcatBenchmark`|net6.0|60.2μs|740ns|7.33μs|0| 0|0|43.44 KB| |#6028|`StringConcatBenchmark`|netcoreapp3.1|52.5μs|99.5ns|345ns|0| 0|0|42.64 KB| |#6028|`StringConcatBenchmark`|net472|39.1μs|211ns|1.12μs|0| 0|0|58.14 KB| |#6028|`StringConcatAspectBenchmark`|net6.0|259μs|4.69μs|45μs|0| 0|0|311.34 KB| |#6028|`StringConcatAspectBenchmark`|netcoreapp3.1|341μs|1.97μs|15μs|0| 0|0|254.26 KB| |#6028|`StringConcatAspectBenchmark`|net472|287μs|5.54μs|54μs|0| 0|0|286.72 KB|
andrewlock commented 2 weeks ago

Benchmarks Report for tracer :snail:

Benchmarks for #6028 compared to master:

The following thresholds were used for comparing the benchmark speeds:

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`StartStopWithChild`|net6.0|7.63μs|42.6ns|276ns|0.0152| 0.0038|0|5.43 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`StartStopWithChild`|netcoreapp3.1|9.94μs|53.5ns|283ns|0.0201| 0.01|0|5.62 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`StartStopWithChild`|net472|15.8μs|39.5ns|148ns|1.01| 0.304|0.0936|6.06 KB| |#6028|`StartStopWithChild`|net6.0|8.01μs|46.2ns|364ns|0.0158| 0.00788|0|5.42 KB| |#6028|`StartStopWithChild`|netcoreapp3.1|9.64μs|52ns|294ns|0.0197| 0.00984|0|5.62 KB| |#6028|`StartStopWithChild`|net472|15.9μs|33.1ns|124ns|1.02| 0.302|0.0955|6.07 KB|
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`WriteAndFlushEnrichedTraces`|net6.0|470μs|287ns|1.11μs|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|645μs|160ns|555ns|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`WriteAndFlushEnrichedTraces`|net472|835μs|568ns|2.2μs|0.417| 0|0|3.3 KB| |#6028|`WriteAndFlushEnrichedTraces`|net6.0|501μs|233ns|870ns|0| 0|0|2.7 KB| |#6028|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|660μs|458ns|1.77μs|0| 0|0|2.7 KB| |#6028|`WriteAndFlushEnrichedTraces`|net472|829μs|427ns|1.54μs|0.414| 0|0|3.3 KB|
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`SendRequest`|net6.0|202μs|1.13μs|10.3μs|0.188| 0|0|18.45 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`SendRequest`|netcoreapp3.1|216μs|1.18μs|7.28μs|0.213| 0|0|20.61 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`SendRequest`|net472|0.000362ns|0.000193ns|0.000749ns|0| 0|0|0 b| |#6028|`SendRequest`|net6.0|197μs|1.13μs|8.55μs|0.197| 0|0|18.45 KB| |#6028|`SendRequest`|netcoreapp3.1|221μs|1.23μs|9.34μs|0.214| 0|0|20.61 KB| |#6028|`SendRequest`|net472|0.00423ns|0.001ns|0.00388ns|0| 0|0|0 b|
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`WriteAndFlushEnrichedTraces`|net6.0|589μs|2.79μs|11.5μs|0.566| 0|0|41.74 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|689μs|3.5μs|20.1μs|0.324| 0|0|41.77 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`WriteAndFlushEnrichedTraces`|net472|860μs|4.33μs|20.3μs|8.47| 2.42|0.403|53.32 KB| |#6028|`WriteAndFlushEnrichedTraces`|net6.0|563μs|2.64μs|12.1μs|0.573| 0|0|41.64 KB| |#6028|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|675μs|3.32μs|14.8μs|0.336| 0|0|41.79 KB| |#6028|`WriteAndFlushEnrichedTraces`|net472|828μs|2.8μs|10.8μs|8.13| 2.57|0.428|53.29 KB|
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`ExecuteNonQuery`|net6.0|1.31μs|1.62ns|6.28ns|0.0145| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`ExecuteNonQuery`|netcoreapp3.1|1.8μs|0.896ns|3.35ns|0.0135| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`ExecuteNonQuery`|net472|2.19μs|2.38ns|8.92ns|0.156| 0|0|987 B| |#6028|`ExecuteNonQuery`|net6.0|1.35μs|1.45ns|5.63ns|0.0144| 0|0|1.02 KB| |#6028|`ExecuteNonQuery`|netcoreapp3.1|1.75μs|1.82ns|7.04ns|0.014| 0|0|1.02 KB| |#6028|`ExecuteNonQuery`|net472|2.07μs|1.21ns|4.52ns|0.157| 0|0|987 B|
Benchmarks.Trace.ElasticsearchBenchmark - Faster :tada: Same allocations :heavy_check_mark: #### Faster :tada: in #6028 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 | 1.121 | 1,351.31 | 1,205.65 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`CallElasticsearch`|net6.0|1.14μs|0.99ns|3.7ns|0.0138| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`CallElasticsearch`|netcoreapp3.1|1.55μs|1.21ns|4.68ns|0.0132| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`CallElasticsearch`|net472|2.53μs|1.54ns|5.98ns|0.158| 0|0|995 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`CallElasticsearchAsync`|net6.0|1.35μs|0.457ns|1.71ns|0.0129| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`CallElasticsearchAsync`|netcoreapp3.1|1.57μs|0.782ns|3.03ns|0.0134| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`CallElasticsearchAsync`|net472|2.74μs|1.84ns|7.12ns|0.167| 0|0|1.05 KB| |#6028|`CallElasticsearch`|net6.0|1.23μs|1.11ns|4.29ns|0.0135| 0|0|976 B| |#6028|`CallElasticsearch`|netcoreapp3.1|1.59μs|1.55ns|5.81ns|0.0126| 0|0|976 B| |#6028|`CallElasticsearch`|net472|2.47μs|1.62ns|6.26ns|0.158| 0|0|995 B| |#6028|`CallElasticsearchAsync`|net6.0|1.21μs|0.417ns|1.61ns|0.0133| 0|0|952 B| |#6028|`CallElasticsearchAsync`|netcoreapp3.1|1.57μs|0.642ns|2.49ns|0.0135| 0|0|1.02 KB| |#6028|`CallElasticsearchAsync`|net472|2.58μs|1.62ns|6.07ns|0.167| 0|0|1.05 KB|
Benchmarks.Trace.GraphQLBenchmark - Faster :tada: Same allocations :heavy_check_mark: #### Faster :tada: in #6028 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 | 1.127 | 1,324.19 | 1,174.65 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`ExecuteAsync`|net6.0|1.32μs|0.901ns|3.49ns|0.0132| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`ExecuteAsync`|netcoreapp3.1|1.52μs|1.58ns|5.71ns|0.0124| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`ExecuteAsync`|net472|1.77μs|1.93ns|7.46ns|0.145| 0|0|915 B| |#6028|`ExecuteAsync`|net6.0|1.17μs|0.742ns|2.87ns|0.0129| 0|0|952 B| |#6028|`ExecuteAsync`|netcoreapp3.1|1.57μs|0.853ns|3.31ns|0.0124| 0|0|952 B| |#6028|`ExecuteAsync`|net472|1.74μs|4.22ns|16.3ns|0.145| 0|0|915 B|
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`SendAsync`|net6.0|4.17μs|1.11ns|4.31ns|0.0313| 0|0|2.22 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`SendAsync`|netcoreapp3.1|5.07μs|5.07ns|19.6ns|0.0378| 0|0|2.76 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`SendAsync`|net472|7.84μs|4.46ns|17.3ns|0.499| 0|0|3.15 KB| |#6028|`SendAsync`|net6.0|4.23μs|1.8ns|6.73ns|0.0295| 0|0|2.22 KB| |#6028|`SendAsync`|netcoreapp3.1|5.1μs|1.5ns|5.8ns|0.0357| 0|0|2.76 KB| |#6028|`SendAsync`|net472|7.79μs|1.64ns|6.12ns|0.499| 0|0|3.15 KB|
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`EnrichedLog`|net6.0|1.58μs|0.4ns|1.44ns|0.0229| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`EnrichedLog`|netcoreapp3.1|2.2μs|0.929ns|3.6ns|0.0225| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`EnrichedLog`|net472|2.58μs|1.54ns|5.56ns|0.249| 0|0|1.57 KB| |#6028|`EnrichedLog`|net6.0|1.49μs|1.21ns|4.37ns|0.0226| 0|0|1.64 KB| |#6028|`EnrichedLog`|netcoreapp3.1|2.28μs|1.06ns|3.97ns|0.0219| 0|0|1.64 KB| |#6028|`EnrichedLog`|net472|2.72μs|1.94ns|7.5ns|0.249| 0|0|1.57 KB|
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`EnrichedLog`|net6.0|114μs|103ns|386ns|0.0571| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`EnrichedLog`|netcoreapp3.1|119μs|204ns|763ns|0| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`EnrichedLog`|net472|148μs|164ns|634ns|0.663| 0.221|0|4.46 KB| |#6028|`EnrichedLog`|net6.0|116μs|141ns|546ns|0.0589| 0|0|4.28 KB| |#6028|`EnrichedLog`|netcoreapp3.1|121μs|182ns|682ns|0| 0|0|4.28 KB| |#6028|`EnrichedLog`|net472|149μs|273ns|1.06μs|0.675| 0.225|0|4.46 KB|
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`EnrichedLog`|net6.0|3.08μs|1.5ns|5.43ns|0.0296| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`EnrichedLog`|netcoreapp3.1|4.25μs|2.26ns|8.74ns|0.0296| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`EnrichedLog`|net472|4.85μs|2.46ns|9.52ns|0.319| 0|0|2.02 KB| |#6028|`EnrichedLog`|net6.0|2.99μs|0.637ns|2.3ns|0.0312| 0|0|2.2 KB| |#6028|`EnrichedLog`|netcoreapp3.1|4.09μs|3.33ns|12.9ns|0.0287| 0|0|2.2 KB| |#6028|`EnrichedLog`|net472|4.89μs|1.24ns|4.82ns|0.32| 0|0|2.02 KB|
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`SendReceive`|net6.0|1.31μs|0.621ns|2.41ns|0.0157| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`SendReceive`|netcoreapp3.1|1.7μs|1.44ns|5.58ns|0.0152| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`SendReceive`|net472|2.14μs|4.38ns|17ns|0.184| 0.00104|0|1.16 KB| |#6028|`SendReceive`|net6.0|1.38μs|0.944ns|3.66ns|0.016| 0|0|1.14 KB| |#6028|`SendReceive`|netcoreapp3.1|1.8μs|1.15ns|4.44ns|0.0153| 0|0|1.14 KB| |#6028|`SendReceive`|net472|1.94μs|1.37ns|5.31ns|0.184| 0|0|1.16 KB|
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark: ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`EnrichedLog`|net6.0|2.75μs|1.02ns|3.96ns|0.0219| 0|0|1.6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`EnrichedLog`|netcoreapp3.1|3.79μs|1.56ns|6.03ns|0.0228| 0|0|1.65 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`EnrichedLog`|net472|4.38μs|2.32ns|8.66ns|0.323| 0|0|2.04 KB| |#6028|`EnrichedLog`|net6.0|2.63μs|0.614ns|2.21ns|0.0224| 0|0|1.6 KB| |#6028|`EnrichedLog`|netcoreapp3.1|3.91μs|1.15ns|4.44ns|0.0216| 0|0|1.65 KB| |#6028|`EnrichedLog`|net472|4.29μs|1.71ns|6.41ns|0.322| 0|0|2.04 KB|
Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #6028 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 | 1.118 | 400.57 | 447.81 | #### Faster :tada: in #6028 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 | 1.225 | 664.90 | 542.78 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`StartFinishSpan`|net6.0|401ns|0.265ns|1.02ns|0.00806| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`StartFinishSpan`|netcoreapp3.1|665ns|0.604ns|2.34ns|0.00793| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`StartFinishSpan`|net472|667ns|1.16ns|4.47ns|0.0918| 0|0|578 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`StartFinishScope`|net6.0|489ns|0.171ns|0.641ns|0.00972| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`StartFinishScope`|netcoreapp3.1|694ns|0.497ns|1.93ns|0.00965| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`StartFinishScope`|net472|765ns|0.891ns|3.45ns|0.104| 0|0|658 B| |#6028|`StartFinishSpan`|net6.0|447ns|0.407ns|1.58ns|0.00796| 0|0|576 B| |#6028|`StartFinishSpan`|netcoreapp3.1|543ns|0.365ns|1.37ns|0.00787| 0|0|576 B| |#6028|`StartFinishSpan`|net472|662ns|0.533ns|1.92ns|0.0917| 0|0|578 B| |#6028|`StartFinishScope`|net6.0|488ns|0.365ns|1.41ns|0.0097| 0|0|696 B| |#6028|`StartFinishScope`|netcoreapp3.1|676ns|0.484ns|1.87ns|0.00948| 0|0|696 B| |#6028|`StartFinishScope`|net472|839ns|0.955ns|3.7ns|0.104| 0|0|658 B|
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower :warning: Same allocations :heavy_check_mark: #### Slower :warning: in #6028 | Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.146 | 643.80 | 737.67 | ### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`RunOnMethodBegin`|net6.0|643ns|0.35ns|1.35ns|0.00967| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`RunOnMethodBegin`|netcoreapp3.1|898ns|0.924ns|3.58ns|0.00941| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/8f54f5ba0cd6c3c60a29f70b1f9d4261d7b1c213)|`RunOnMethodBegin`|net472|1.11μs|1.49ns|5.77ns|0.104| 0|0|658 B| |#6028|`RunOnMethodBegin`|net6.0|738ns|0.869ns|3.37ns|0.00966| 0|0|696 B| |#6028|`RunOnMethodBegin`|netcoreapp3.1|912ns|1.54ns|5.97ns|0.00937| 0|0|696 B| |#6028|`RunOnMethodBegin`|net472|1.13μs|0.758ns|2.94ns|0.104| 0|0|658 B|