[Version Bump] 2.60.0 - Githubissues

github-actions[bot] commented 2 months ago

The following files were found to be modified (as expected)

[x] docs/CHANGELOG.md
[x] .azure-pipelines/ultimate-pipeline.yml
[x] profiler/src/ProfilerEngine/Datadog.Profiler.Native.Linux/CMakeLists.txt
[x] profiler/src/ProfilerEngine/Datadog.Profiler.Native.Windows/Resource.rc
[x] profiler/src/ProfilerEngine/Datadog.Profiler.Native/dd_profiler_version.h
[x] profiler/src/ProfilerEngine/Datadog.Linux.ApiWrapper/CMakeLists.txt
[x] profiler/src/ProfilerEngine/ProductVersion.props
[x] shared/src/Datadog.Trace.ClrProfiler.Native/CMakeLists.txt
[x] shared/src/Datadog.Trace.ClrProfiler.Native/Resource.rc
[x] shared/src/msi-installer/WindowsInstaller.wixproj
[x] shared/src/native-src/version.h
[x] tracer/build/artifacts/dd-dotnet.sh
[x] tracer/build/_build/Build.cs
[x] tracer/samples/AutomaticTraceIdInjection/MicrosoftExtensionsExample/MicrosoftExtensionsExample.csproj
[x] tracer/samples/AutomaticTraceIdInjection/Log4NetExample/Log4NetExample.csproj
[x] tracer/samples/AutomaticTraceIdInjection/NLog40Example/NLog40Example.csproj
[x] tracer/samples/AutomaticTraceIdInjection/NLog45Example/NLog45Example.csproj
[x] tracer/samples/AutomaticTraceIdInjection/NLog46Example/NLog46Example.csproj
[x] tracer/samples/AutomaticTraceIdInjection/SerilogExample/SerilogExample.csproj
[x] tracer/samples/ConsoleApp/Alpine3.10.dockerfile
[x] tracer/samples/ConsoleApp/Alpine3.9.dockerfile
[x] tracer/samples/ConsoleApp/Debian.dockerfile
[x] tracer/samples/OpenTelemetry/Debian.dockerfile
[x] tracer/samples/WindowsContainer/Dockerfile
[x] tracer/src/Datadog.Trace.Bundle/Datadog.Trace.Bundle.csproj
[x] tracer/src/Datadog.Trace.AspNet/Datadog.Trace.AspNet.csproj
[x] tracer/src/Datadog.Trace.ClrProfiler.Managed.Loader/Datadog.Trace.ClrProfiler.Managed.Loader.csproj
[x] tracer/src/Datadog.Trace.ClrProfiler.Managed.Loader/Startup.cs
[x] tracer/src/Datadog.Tracer.Native/CMakeLists.txt
[x] tracer/src/Datadog.Tracer.Native/dd_profiler_constants.h
[x] tracer/src/Datadog.Tracer.Native/Resource.rc
[x] tracer/src/Datadog.Trace.MSBuild/Datadog.Trace.MSBuild.csproj
[x] tracer/src/Datadog.Trace.BenchmarkDotNet/Datadog.Trace.BenchmarkDotNet.csproj
[x] tracer/src/Datadog.Trace.OpenTracing/Datadog.Trace.OpenTracing.csproj
[x] tracer/src/Datadog.Trace.Tools.dd_dotnet/Datadog.Trace.Tools.dd_dotnet.csproj
[x] tracer/src/Datadog.Trace.Tools.Runner/Datadog.Trace.Tools.Runner.csproj
[x] tracer/src/Datadog.Trace/Datadog.Trace.csproj
[x] tracer/src/Datadog.Trace/TracerConstants.cs
[x] tracer/src/Datadog.Trace.Trimming/Datadog.Trace.Trimming.csproj
[x] tracer/tools/PipelineMonitor/PipelineMonitor.csproj

@DataDog/apm-dotnet

datadog-ddstaging[bot] commented 2 months ago

Datadog Report

Branch report: version-bump-2.60.0 Commit report: 896d328 Test service: dd-trace-dotnet

:x: 2 Failed (1 Known Flaky), 350217 Passed, 2587 Skipped, 24h 46m 53.27s Total Time :snowflake: 2 New Flaky :hourglass: 15 Performance Regressions

:x: Failed Tests (2)

GenerateDumpIfDbgRequested - Datadog.Profiler.IntegrationTests.LinuxOnly.WrapperLibraryTest - :snowflake: Known flaky - Details

Expand for error
``` Expected runner.WaitForExitOrCaptureDump(processHelper.Process, milliseconds: 30_000) to be true, but found False. ```
GenerateDumpIfDbgRequested - Datadog.Profiler.IntegrationTests.LinuxOnly.WrapperLibraryTest - Details

Expand for error
``` Expected runner.WaitForExitOrCaptureDump(processHelper.Process, milliseconds: 30_000) to be true, but found False. ```

New Flaky Tests (2)

OnSupportedFrameworkInSsi_CallsForwarderWithExpectedTelemetry - Datadog.Trace.ClrProfiler.IntegrationTests.InstrumentationTests - Last Failure

Expand for error
``` Expected boolean to be true, but found False. ```
OnSupportedFrameworkInSsi_CallsForwarderWithExpectedTelemetry - Datadog.Trace.ClrProfiler.IntegrationTests.InstrumentationTests - Last Failure

Expand for error
``` Expected boolean to be true, but found False. ```

:hourglass: Performance Regressions vs Default Branch (15)

This report shows up to 5 performance regressions.

Baseline_cpu - scenarios 2.41s (+66.68ms, +3%) - Details

Profiler_cpu_walltime_old_stackwalk - scenarios 3.23s (+886.65ms, +38%) - Details

Profiler_cpu_walltime - scenarios 3.23s (+890.89ms, +38%) - Details

Profiler_walltime - scenarios 3.24s (+898.82ms, +38%) - Details

Profiler_cpu_walltime_timer_create - scenarios 3.24s (+898.45ms, +38%) - Details

andrewlock commented 2 months ago

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6036) - mean (75ms)  : 68, 81
     .   : milestone, 75,
    master - mean (69ms)  : 67, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6036) - mean (1,061ms)  : 1036, 1085
     .   : milestone, 1061,
    master - mean (1,117ms)  : 1090, 1144
     .   : milestone, 1117,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6036) - mean (108ms)  : 106, 111
     .   : milestone, 108,
    master - mean (109ms)  : 105, 114
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6036) - mean (774ms)  : 753, 794
     .   : milestone, 774,
    master - mean (812ms)  : 784, 840
     .   : milestone, 812,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6036) - mean (93ms)  : 89, 97
     .   : milestone, 93,
    master - mean (93ms)  : 88, 99
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6036) - mean (722ms)  : 701, 742
     .   : milestone, 722,
    master - mean (764ms)  : 739, 788
     .   : milestone, 764,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6036) - mean (191ms)  : 188, 195
     .   : milestone, 191,
    master - mean (190ms)  : 187, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6036) - mean (1,143ms)  : 1119, 1168
     .   : milestone, 1143,
    master - mean (1,194ms)  : 1172, 1217
     .   : milestone, 1194,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6036) - mean (277ms)  : 273, 282
     .   : milestone, 277,
    master - mean (277ms)  : 272, 283
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6036) - mean (930ms)  : 906, 955
     .   : milestone, 930,
    master - mean (969ms)  : 949, 989
     .   : milestone, 969,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6036) - mean (266ms)  : 262, 270
     .   : milestone, 266,
    master - mean (265ms)  : 260, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6036) - mean (909ms)  : 881, 937
     .   : milestone, 909,
    master - mean (946ms)  : 922, 970
     .   : milestone, 946,

andrewlock commented 2 months ago

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6036) (10.786M)   : 0, 10785589
    master (10.867M)   : 0, 10866655
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6036) (7.330M)   : 0, 7329605
    master (7.063M)   : 0, 7062638
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.364M)   : 0, 7364303

    section Manual
    This PR (6036) (9.347M)   : crit ,0, 9347474
    master (10.824M)   : 0, 10823898

    section Manual + Automatic
    This PR (6036) (6.789M)   : 0, 6788996
    master (6.575M)   : 0, 6575042

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6036) (9.638M)   : 0, 9637778
    master (9.746M)   : 0, 9746139
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6036) (6.433M)   : 0, 6432729
    master (6.518M)   : 0, 6518443

    section Trace stats
    master (6.791M)   : 0, 6791013

    section Manual
    This PR (6036) (8.255M)   : crit ,0, 8254990
    master (9.554M)   : 0, 9554347

    section Manual + Automatic
    This PR (6036) (6.232M)   : 0, 6232162
    master (6.054M)   : 0, 6053863

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6036) (9.980M)   : 0, 9980072
    master (10.125M)   : 0, 10125159
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6036) (6.547M)   : 0, 6547186
    master (6.789M)   : 0, 6788744
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.427M)   : 0, 7426998

    section Manual
    This PR (6036) (8.441M)   : crit ,0, 8440662
    master (10.349M)   : 0, 10348694

    section Manual + Automatic
    This PR (6036) (6.187M)   : 0, 6186583
    master (6.321M)   : 0, 6321226

andrewlock commented 2 months ago

Benchmarks Report for tracer :snail:

Benchmarks for #6036 compared to master:

1 benchmarks are faster, with geometric mean 1.118
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`StartStopWithChild`|net6.0|7.78μs|44.5ns|324ns|0.0112| 0.00374|0|5.43 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`StartStopWithChild`|netcoreapp3.1|9.85μs|43.4ns|157ns|0.0143| 0.00476|0|5.62 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`StartStopWithChild`|net472|16.1μs|33ns|123ns|1.03| 0.313|0.102|6.06 KB| |#6036|`StartStopWithChild`|net6.0|7.69μs|43ns|289ns|0.0113| 0.00376|0|5.43 KB| |#6036|`StartStopWithChild`|netcoreapp3.1|9.95μs|54.8ns|334ns|0.0147| 0.00491|0|5.62 KB| |#6036|`StartStopWithChild`|net472|15.8μs|69.9ns|271ns|1.01| 0.292|0.0867|6.07 KB|

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`WriteAndFlushEnrichedTraces`|net6.0|481μs|158ns|549ns|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|625μs|304ns|1.18μs|0| 0|0|2.7 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`WriteAndFlushEnrichedTraces`|net472|844μs|342ns|1.33μs|0.419| 0|0|3.3 KB| |#6036|`WriteAndFlushEnrichedTraces`|net6.0|467μs|260ns|972ns|0| 0|0|2.7 KB| |#6036|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|641μs|331ns|1.28μs|0| 0|0|2.7 KB| |#6036|`WriteAndFlushEnrichedTraces`|net472|837μs|495ns|1.85μs|0.417| 0|0|3.3 KB|

Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`SendRequest`|net6.0|203μs|1.17μs|9.62μs|0.197| 0|0|18.45 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`SendRequest`|netcoreapp3.1|225μs|1.29μs|9.79μs|0.216| 0|0|20.61 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`SendRequest`|net472|0.00235ns|0.000752ns|0.00291ns|0| 0|0|0 b| |#6036|`SendRequest`|net6.0|197μs|1.13μs|9.08μs|0.186| 0|0|18.45 KB| |#6036|`SendRequest`|netcoreapp3.1|218μs|1.25μs|9.79μs|0.225| 0|0|20.61 KB| |#6036|`SendRequest`|net472|0.00127ns|0.000518ns|0.00194ns|0| 0|0|0 b|

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`WriteAndFlushEnrichedTraces`|net6.0|562μs|2.9μs|16.2μs|0.558| 0|0|41.65 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|697μs|3.34μs|13.8μs|0.326| 0|0|41.87 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`WriteAndFlushEnrichedTraces`|net472|862μs|2.83μs|11μs|8.45| 2.53|0.422|53.29 KB| |#6036|`WriteAndFlushEnrichedTraces`|net6.0|568μs|2.65μs|9.92μs|0.546| 0|0|41.51 KB| |#6036|`WriteAndFlushEnrichedTraces`|netcoreapp3.1|677μs|3.47μs|16.6μs|0.332| 0|0|41.68 KB| |#6036|`WriteAndFlushEnrichedTraces`|net472|859μs|2.29μs|8.58μs|8.45| 2.53|0.422|53.26 KB|

Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`ExecuteNonQuery`|net6.0|1.27μs|0.95ns|3.68ns|0.014| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`ExecuteNonQuery`|netcoreapp3.1|1.73μs|1.25ns|4.84ns|0.0131| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`ExecuteNonQuery`|net472|2.04μs|2.14ns|8.31ns|0.156| 0|0|987 B| |#6036|`ExecuteNonQuery`|net6.0|1.27μs|1.26ns|4.87ns|0.0141| 0|0|1.02 KB| |#6036|`ExecuteNonQuery`|netcoreapp3.1|1.74μs|1.01ns|3.77ns|0.0131| 0|0|1.02 KB| |#6036|`ExecuteNonQuery`|net472|2.05μs|2.33ns|9.04ns|0.156| 0|0|987 B|

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`CallElasticsearch`|net6.0|1.23μs|0.454ns|1.7ns|0.0136| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`CallElasticsearch`|netcoreapp3.1|1.56μs|1.79ns|6.7ns|0.0132| 0|0|976 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`CallElasticsearch`|net472|2.61μs|2.1ns|8.13ns|0.158| 0.0013|0|995 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`CallElasticsearchAsync`|net6.0|1.35μs|0.955ns|3.58ns|0.0135| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`CallElasticsearchAsync`|netcoreapp3.1|1.65μs|0.667ns|2.41ns|0.0133| 0|0|1.02 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`CallElasticsearchAsync`|net472|2.64μs|1.14ns|4.11ns|0.166| 0.00133|0|1.05 KB| |#6036|`CallElasticsearch`|net6.0|1.2μs|1.23ns|4.6ns|0.0133| 0|0|976 B| |#6036|`CallElasticsearch`|netcoreapp3.1|1.54μs|1.23ns|4.6ns|0.013| 0|0|976 B| |#6036|`CallElasticsearch`|net472|2.56μs|1.93ns|7.47ns|0.158| 0.00127|0|995 B| |#6036|`CallElasticsearchAsync`|net6.0|1.3μs|3.28ns|12.7ns|0.0136| 0|0|952 B| |#6036|`CallElasticsearchAsync`|netcoreapp3.1|1.58μs|0.544ns|2.04ns|0.0135| 0|0|1.02 KB| |#6036|`CallElasticsearchAsync`|net472|2.54μs|2.26ns|8.46ns|0.166| 0.00126|0|1.05 KB|

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`ExecuteAsync`|net6.0|1.27μs|1.22ns|4.71ns|0.0133| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`ExecuteAsync`|netcoreapp3.1|1.62μs|0.891ns|3.21ns|0.0129| 0|0|952 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`ExecuteAsync`|net472|1.82μs|2.47ns|9.55ns|0.145| 0|0|915 B| |#6036|`ExecuteAsync`|net6.0|1.28μs|1.96ns|7.34ns|0.0136| 0|0|952 B| |#6036|`ExecuteAsync`|netcoreapp3.1|1.65μs|0.824ns|3.19ns|0.0131| 0|0|952 B| |#6036|`ExecuteAsync`|net472|1.84μs|1.15ns|4.44ns|0.145| 0|0|915 B|

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`SendAsync`|net6.0|4.15μs|0.911ns|3.29ns|0.0312| 0|0|2.22 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`SendAsync`|netcoreapp3.1|5.2μs|20.1ns|78ns|0.036| 0|0|2.76 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`SendAsync`|net472|7.84μs|1.8ns|6.98ns|0.496| 0|0|3.15 KB| |#6036|`SendAsync`|net6.0|4.13μs|1.09ns|3.94ns|0.0313| 0|0|2.22 KB| |#6036|`SendAsync`|netcoreapp3.1|5.2μs|2.11ns|7.6ns|0.0366| 0|0|2.76 KB| |#6036|`SendAsync`|net472|7.75μs|7.3ns|28.3ns|0.498| 0|0|3.15 KB|

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`EnrichedLog`|net6.0|1.43μs|0.752ns|2.81ns|0.0229| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`EnrichedLog`|netcoreapp3.1|2.25μs|1.17ns|4.36ns|0.0225| 0|0|1.64 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`EnrichedLog`|net472|2.53μs|0.603ns|2.26ns|0.25| 0|0|1.57 KB| |#6036|`EnrichedLog`|net6.0|1.45μs|0.654ns|2.53ns|0.0229| 0|0|1.64 KB| |#6036|`EnrichedLog`|netcoreapp3.1|2.19μs|0.931ns|3.36ns|0.0219| 0|0|1.64 KB| |#6036|`EnrichedLog`|net472|2.56μs|1.05ns|4.06ns|0.249| 0|0|1.57 KB|

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`EnrichedLog`|net6.0|113μs|165ns|594ns|0.0572| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`EnrichedLog`|netcoreapp3.1|117μs|98.7ns|382ns|0.0589| 0|0|4.28 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`EnrichedLog`|net472|145μs|54.4ns|211ns|0.654| 0.218|0|4.46 KB| |#6036|`EnrichedLog`|net6.0|113μs|95.3ns|330ns|0.0562| 0|0|4.28 KB| |#6036|`EnrichedLog`|netcoreapp3.1|118μs|136ns|528ns|0.0587| 0|0|4.28 KB| |#6036|`EnrichedLog`|net472|145μs|95.7ns|371ns|0.652| 0.217|0|4.46 KB|

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`EnrichedLog`|net6.0|3.04μs|1.35ns|5.05ns|0.0305| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`EnrichedLog`|netcoreapp3.1|4.31μs|1.12ns|4.36ns|0.0302| 0|0|2.2 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`EnrichedLog`|net472|4.89μs|0.944ns|3.66ns|0.32| 0|0|2.02 KB| |#6036|`EnrichedLog`|net6.0|3.04μs|1.95ns|7.54ns|0.0304| 0|0|2.2 KB| |#6036|`EnrichedLog`|netcoreapp3.1|4.15μs|2.08ns|7.78ns|0.0297| 0|0|2.2 KB| |#6036|`EnrichedLog`|net472|4.69μs|0.868ns|3.36ns|0.319| 0|0|2.02 KB|

Benchmarks.Trace.RedisBenchmark - Faster :tada: Same allocations :heavy_check_mark: #### Faster :tada: in #6036 | Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality | |:----------|-----------:|-----------:|--------:|--------:| | Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0 | 1.118 | 1,382.54 | 1,237.17 |

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`SendReceive`|net6.0|1.38μs|0.582ns|2.18ns|0.0159| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`SendReceive`|netcoreapp3.1|1.77μs|0.981ns|3.8ns|0.015| 0|0|1.14 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`SendReceive`|net472|2.07μs|1.26ns|4.86ns|0.183| 0.00103|0|1.16 KB| |#6036|`SendReceive`|net6.0|1.24μs|0.732ns|2.83ns|0.0161| 0|0|1.14 KB| |#6036|`SendReceive`|netcoreapp3.1|1.64μs|0.476ns|1.78ns|0.0149| 0|0|1.14 KB| |#6036|`SendReceive`|net472|2.03μs|0.696ns|2.7ns|0.183| 0|0|1.16 KB|

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`EnrichedLog`|net6.0|2.69μs|10.2ns|39.3ns|0.0225| 0|0|1.6 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`EnrichedLog`|netcoreapp3.1|4.03μs|1.14ns|4.41ns|0.0221| 0|0|1.65 KB| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`EnrichedLog`|net472|4.38μs|3.19ns|12.3ns|0.322| 0|0|2.04 KB| |#6036|`EnrichedLog`|net6.0|2.86μs|0.996ns|3.86ns|0.0215| 0|0|1.6 KB| |#6036|`EnrichedLog`|netcoreapp3.1|3.89μs|1.27ns|4.94ns|0.0215| 0|0|1.65 KB| |#6036|`EnrichedLog`|net472|4.36μs|3.7ns|14.3ns|0.324| 0|0|2.04 KB|

Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`StartFinishSpan`|net6.0|412ns|0.227ns|0.819ns|0.00803| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`StartFinishSpan`|netcoreapp3.1|579ns|0.265ns|0.99ns|0.00795| 0|0|576 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`StartFinishSpan`|net472|679ns|0.578ns|2.24ns|0.0918| 0|0|578 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`StartFinishScope`|net6.0|508ns|0.277ns|1.07ns|0.0097| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`StartFinishScope`|netcoreapp3.1|704ns|0.446ns|1.67ns|0.00933| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`StartFinishScope`|net472|856ns|1.78ns|6.89ns|0.104| 0|0|658 B| |#6036|`StartFinishSpan`|net6.0|441ns|0.237ns|0.917ns|0.008| 0|0|576 B| |#6036|`StartFinishSpan`|netcoreapp3.1|596ns|0.424ns|1.59ns|0.00777| 0|0|576 B| |#6036|`StartFinishSpan`|net472|735ns|0.892ns|3.45ns|0.0918| 0|0|578 B| |#6036|`StartFinishScope`|net6.0|477ns|0.364ns|1.41ns|0.00968| 0|0|696 B| |#6036|`StartFinishScope`|netcoreapp3.1|682ns|0.405ns|1.46ns|0.00962| 0|0|696 B| |#6036|`StartFinishScope`|net472|787ns|0.707ns|2.65ns|0.104| 0|0|658 B|

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

### Raw results | Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------|---------------------------- |-------------- |---------:|---------:|--------:|-------:|------:|------:|----------:| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`RunOnMethodBegin`|net6.0|653ns|0.484ns|1.88ns|0.00979| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`RunOnMethodBegin`|netcoreapp3.1|895ns|4.29ns|17.1ns|0.00925| 0|0|696 B| |[master](https://github.com/DataDog/dd-trace-dotnet/tree/965a822457f8bf38d077de54cad55227e4eb2364)|`RunOnMethodBegin`|net472|1.12μs|1.12ns|4.33ns|0.104| 0|0|658 B| |#6036|`RunOnMethodBegin`|net6.0|647ns|0.531ns|2.06ns|0.00981| 0|0|696 B| |#6036|`RunOnMethodBegin`|netcoreapp3.1|927ns|0.574ns|2.15ns|0.0094| 0|0|696 B| |#6036|`RunOnMethodBegin`|net472|1.06μs|0.809ns|3.13ns|0.104| 0|0|658 B|

DataDog / dd-trace-dotnet

[Version Bump] 2.60.0 #6036

Datadog Report

:x: Failed Tests (2)

New Flaky Tests (2)

:hourglass: Performance Regressions vs Default Branch (15)

Execution-Time Benchmarks Report :stopwatch:

Throughput/Crank Report:zap:

Benchmarks Report for tracer :snail:

Benchmark details