DataDog / dd-trace-dotnet

.NET Client Library for Datadog APM
https://docs.datadoghq.com/tracing/
Apache License 2.0
437 stars 137 forks source link

[backport][serverless] trigger consolidated pipeline on tags (#6052 => v2) #6053

Closed duncanista closed 1 week ago

duncanista commented 1 week ago

Summary of changes

Removes exclusion of pipeline trigger for tags.

Reason for change

Serverless requires a build on a tag in order to have a production ready pipeline to use.

Implementation details

n/a

Test coverage

Other details

datadog-ddstaging[bot] commented 1 week ago

Datadog Report

Branch report: jordan.gonzalez/backport/trigger-pipeline-on-tags Commit report: 2f7f196 Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 352212 Passed, 1821 Skipped, 14h 18m 45.66s Total Time

andrewlock commented 1 week ago

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6053) - mean (73ms)  : 65, 80
     .   : milestone, 73,
    master - mean (70ms)  : 67, 73
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6053) - mean (1,053ms)  : 1025, 1081
     .   : milestone, 1053,
    master - mean (1,106ms)  : 1075, 1137
     .   : milestone, 1106,
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6053) - mean (109ms)  : 105, 112
     .   : milestone, 109,
    master - mean (109ms)  : 105, 113
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6053) - mean (758ms)  : 731, 785
     .   : milestone, 758,
    master - mean (801ms)  : 783, 820
     .   : milestone, 801,
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6053) - mean (92ms)  : 90, 95
     .   : milestone, 92,
    master - mean (92ms)  : 89, 95
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6053) - mean (707ms)  : 688, 727
     .   : milestone, 707,
    master - mean (746ms)  : 724, 768
     .   : milestone, 746,
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6053) - mean (191ms)  : 187, 195
     .   : milestone, 191,
    master - mean (191ms)  : 187, 194
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6053) - mean (1,137ms)  : 1111, 1163
     .   : milestone, 1137,
    master - mean (1,192ms)  : 1167, 1217
     .   : milestone, 1192,
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6053) - mean (277ms)  : 273, 282
     .   : milestone, 277,
    master - mean (278ms)  : 274, 282
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (6053) - mean (921ms)  : 899, 944
     .   : milestone, 921,
    master - mean (963ms)  : 942, 984
     .   : milestone, 963,
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6053) - mean (266ms)  : 263, 269
     .   : milestone, 266,
    master - mean (266ms)  : 262, 270
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6053) - mean (898ms)  : 872, 924
     .   : milestone, 898,
    master - mean (944ms)  : 916, 972
     .   : milestone, 944,