This was identified whilst configuring DORA in DataDog, the spans/traces came in with the incorrect url. the datadog-ci metadata upload appears to be working correctly.
To Reproduce
Steps to reproduce the behavior:
configure sourcelink with your project with APM configured from an ADO repo
inspect traces in datadog and look at git.repository.id or git.repository_url
Example project with the logic isolated showcasing the issue attached
example.zip
Expected behavior
Expected behaviour is parser should correctly parse the url
Screenshots
Runtime environment (please complete the following information):
Instrumentation mode: [e.g. automatic with msi installer or manual with NuGet package]
Tracer version: [e.g. 1.0.0]
OS: [e.g. Windows Server 2012 R2 ]
CLR: [e.g. .NET Framework 4.6.2, .NET Core 2.1]
Additional context
Noticed while configuring DORA CI
Describe the bug It appears that the TryParseSourceLinkUrl method utilised by the AzureDevOpsSourceLinkUrlParser is delivering the incorrect Url
e.g.
this is picked up by sourcelink "https://dev.azure.com/organisation/project/_apis/git/repositories/example.shopping.api/items?api-version=1.0&versionType=commit&version=0e4d29442102e6cef1c271025d513c8b2187bcd6&path=/*"
and should give you
https://dev.azure.com/organisation/project/_git/example.shopping.api
but instead it gives you
https://dev.azure.com/organisation/_git/repositories
This was identified whilst configuring DORA in DataDog, the spans/traces came in with the incorrect url. the datadog-ci metadata upload appears to be working correctly.
To Reproduce Steps to reproduce the behavior:
Example project with the logic isolated showcasing the issue attached example.zip
Expected behavior Expected behaviour is parser should correctly parse the url
Screenshots
Runtime environment (please complete the following information):
Additional context Noticed while configuring DORA CI