Closed ALX99 closed 2 months ago
There are lots of places in the code where globalconfig.AnalyticsRate() is commented out. Should they not inherit from the global configuraton?
globalconfig.AnalyticsRate()
Example:
contrib/confluentinc/confluent-kafka-go/kafka/option.go:41 contrib/confluentinc/confluent-kafka-go/kafka.v2/option.go:41 contrib/bradfitz/gomemcache/memcache/option.go:32 contrib/jinzhu/gorm/option.go:29 contrib/go-redis/redis.v7/option.go:30 contrib/go-redis/redis.v8/option.go:31 contrib/gopkg.in/jinzhu/gorm.v1/option.go:29 contrib/go-redis/redis/option.go:29 contrib/olivere/elastic/option.go:34 contrib/database/sql/option.go:139 contrib/segmentio/kafka.go.v0/option.go:31 contrib/redis/go-redis.v9/option.go:31 contrib/aws/aws-sdk-go/aws/option.go:24 contrib/garyburd/redigo/option.go:29 contrib/tidwall/buntdb/option.go:29 contrib/graph-gophers/graphql-go/option.go:31 contrib/Shopify/sarama/option.go:36 contrib/gocql/gocql/option.go:39 contrib/IBM/sarama.v1/option.go:36 contrib/google.golang.org/api/option.go:30 contrib/go.mongodb.org/mongo-driver/mongo/option.go:29 contrib/gomodule/redigo/option.go:36 contrib/globalsign/mgo/option.go:34 contrib/gorm.io/gorm.v1/option.go:29 contrib/go-pg/pg.v10/option.go:29 contrib/google.golang.org/grpc.v12/option.go:32 contrib/google.golang.org/grpc/option.go:54 contrib/syndtr/goleveldb/leveldb/option.go:30
@ALX99 Thanks for reaching out. This feature is deprecated, and sampling rules should be used instead.
There are lots of places in the code where
globalconfig.AnalyticsRate()
is commented out. Should they not inherit from the global configuraton?Example: