search

DataDog / dd-trace-go

Datadog Go Library including APM tracing, profiling, and security monitoring.
https://docs.datadoghq.com/tracing/
Other
652 stars 436 forks source link

contrib/Shopify/sarama: add support for ConsumerGroups #552

Open catkins opened 4 years ago

catkins commented 4 years ago

Currently dd-trace-go only supports tracing *sarama.Consumer, but not *sarama.ConsumerGroup.

https://godoc.org/gopkg.in/DataDog/dd-trace-go.v1/contrib/Shopify/sarama https://godoc.org/github.com/Shopify/sarama#ConsumerGroup

We've manually implemented tracing for consumer groups in our application, but it'd be awesome if it was supported out of the box.

Thanks! 💖

gbbr commented 4 years ago

SGTM. Would you be interested in contributing? If so, can you explain how you'd do it before starting work?

catkins commented 4 years ago

Thanks @gbbr – I'll try to take a look over the christmas break.

mingrammer commented 4 years ago

Any update?

catkins commented 4 years ago

@mingrammer I haven't had a chance to look at this myself. We had some company-specific stuff that we needed to do, so we ended up wrapping the tracing up in a higher-level bit.

danielbprice commented 1 year ago

Since there is a PR for this, could someone please please please look at it?

I've been trying to get Datadog tracing working for the gocloud.dev/pubsub/kafkapubsub package, which itself uses Sarama. That package is using ConsumerGroup, and it just needs a small patch to allow you to pass in your own ConsumerGroup, but without this PR it's hopeless.

nhunam commented 1 year ago

Is there anything new in this issue ?

miguelb-gk commented 11 months ago

Any updates?