proposal: contrib/twitchtv/twirp: serviceName should be read from global config

DataDog / dd-trace-go

Datadog Go Library including APM tracing, profiling, and security monitoring.

https://docs.datadoghq.com/tracing/

Other

655 stars 438 forks source link

Closed prasad-marne closed 3 years ago

prasad-marne commented 3 years ago

add a check to see if global config ServiceName is not empty before assigning the default serviceName. I can create a PR if the proposal is accepted.

knusbaum commented 3 years ago

This looks correct to me. Server integrations should take the global service name if it's defined.

prasad-marne commented 3 years ago