http4s integration - Githubissues

DataDog / dd-trace-java

Datadog APM client for Java

https://docs.datadoghq.com/tracing/languages/java

Apache License 2.0

593 stars 292 forks source link

http4s integration #1934

Open tyrcho opened 4 years ago

tyrcho commented 4 years ago

As discussed today with @andrewsouthard1 @sallareznov and @cverdier we are going to work soon (days, weeks) on a http4s instrumentation since this is our http framework of choice @colisweb

We'd appreciate if from @Datadog team you could enhance the contributing page to answer a few questions:

[x] how to build a new version of the agent ? how to unit test ? answer
[x] what are the core concepts when designing a new integration ?

From @colisweb side here is the plan for the first steps:

[x] build a POC application with an existing integration for a async framework which is not using threads (play ? akka-http?)
[x] make sure that with this POC we see correlated APM traces between incoming http requests and SQL requests (and maybe outgoing http requests)
[ ] check that we can attach our own spans to the trace created by the instrumentation
[ ] start building the http4s integration
[ ] test it on our POC application

richardstartin commented 4 years ago

Hi @tyrcho - I added some more information about adding an instrumentation in contributing.md. Please let us know if this is enough to get started, we can add more detail if required in certain places along the way.

tyrcho commented 4 years ago

Hi, thanks for the information, I think it will be enough, we might some questions in the future. Do you prefer that we ask general contribution questions here on in dedicated issues ?

@cverdier @sallareznov I noticed an existing play project from which we can start for our POC, we'd just need to add a Doobie dependency.

andrewsouthard1 commented 4 years ago

Hey @tyrcho - please do let us know if you have any questions or need assistance here.

tyrcho commented 4 years ago

Hey, we did not really start yet ... Someone from my team will first check how the existing akka-http integration works with JDBC (probably in the next 10 days or so)

On Tue, Oct 20, 2020 at 1:03 PM Andrew Southard notifications@github.com wrote:

Hey @tyrcho https://github.com/tyrcho - please do let us know if you have any questions or need assistance here.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DataDog/dd-trace-java/issues/1934#issuecomment-712771086, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFK6ZCDI5E3OYZ6W2MSSSLSLVU6RANCNFSM4R7FMGXQ .

tyrcho commented 3 years ago

Hi, we made some progress on the POC and have identified one extra step which we want to check before building the instrumentation :

[ ] check that we can attach our own spans to the trace created by the instrumentation

Any pointers on how this can be done ?

randomanderson commented 3 years ago

@tyrcho You can manually create spans using the OpenTracing api by following the instructions here. On that same page, there are instructions for creating a span with the @Trace annotation, or using dd.trace.methods config

veysiertekin commented 3 years ago

Hi all! Any updates on this?

guizmaii commented 2 years ago

@tyrcho @cverdier @sallareznov Did you guys start something? Can we see? Can we help? 🙂

Edit: Someone started a PR to implement a integration with Blaze: https://github.com/DataDog/dd-trace-java/pull/3131

jhmartin commented 2 years ago

Any updates?

tyrcho commented 2 years ago

We ended up using the Netty backend for http4s which is already supported by datadog, so I don't think we will do this implementation, sorry. Maybe @cverdier you'd like to provide more technical details ?