DataDog / dd-trace-java

Datadog APM client for Java
https://docs.datadoghq.com/tracing/languages/java
Apache License 2.0
555 stars 278 forks source link

Missing @http.status_code in Play #7164

Open mwisnicki opened 1 month ago

mwisnicki commented 1 month ago

I've just updated DD agent from 0.77 to 1.35.0 and am seeing a lot more new information in request level spans from Play framework (2.8.16) however one notable attribute is now gone - the http.status_code which is pretty important.

mwisnicki commented 1 month ago

I found this was originally disabled in https://github.com/DataDog/dd-trace-java/pull/2804

Is there a plan to address underlying issue?

nayeem-kamal commented 1 month ago

We do not currently have plans to address this issue with Play framework however we will track this as an item to look into. For now, you can reenable the functionality by adding -Ddd.trace.play.report-http-status=true to your command line arguments when starting the tracer.

mwisnicki commented 1 month ago

Gotcha. If you have any information about what specific situations can trigger the original issue (wrong status codes - #2804 is pretty light on details), I would be grateful if you could share it.