Closed jpbempel closed 2 months ago
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
ci_job_date | 1725548669 | 1725549048 |
end_time | 2024-09-05T15:05:42 | 2024-09-05T15:12:02 |
git_branch | master | jpbempel/collect-local-vars-uncaught-ex |
git_commit_sha | 123a2c8614 | 0d1e45ca472efbaebd39b32e9fd4c4617ca1e9c2 |
start_time | 2024-09-05T15:04:30 | 2024-09-05T15:10:49 |
Found 0 performance improvements and 3 performance regressions! Performance is the same for 6 metrics, 6 unstable metrics.
scenario | Δ mean agg_http_req_duration_min | Δ mean agg_http_req_duration_p50 | Δ mean agg_http_req_duration_p75 | Δ mean agg_http_req_duration_p99 | Δ mean throughput |
---|---|---|---|---|---|
scenario:basic | worse [+6.012µs; +21.398µs] or [+2.291%; +8.155%] |
worse [+7.154µs; +29.287µs] or [+2.517%; +10.306%] |
worse [+7.328µs; +32.293µs] or [+2.513%; +11.074%] |
unstable [-38.701µs; +50.878µs] or [-6.476%; +8.514%] |
unstable [-298.751op/s; +21.551op/s] or [-11.054%; +0.797%] |
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | jpbempel/collect-local-vars-uncaught-ex |
git_commit_date | 1725545464 | 1725548040 |
git_commit_sha | 123a2c8614 | 0d1e45ca47 |
release_version | 1.40.0-SNAPSHOT~123a2c8614 | 1.39.0-SNAPSHOT~0d1e45ca47 |
Found 1 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 14 unstable metrics.
scenario | Δ mean execution_time | candidate mean execution_time | baseline mean execution_time |
---|---|---|---|
scenario:startup:insecure-bank:iast_HARDCODED_SECRET_DISABLED:AppSec | better [-7.926ms; -5.002ms] or [-14.425%; -9.104%] |
48.478ms | 54.942ms |
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
end_time | 2024-09-05T15:05:41 | 2024-09-05T15:12:31 |
git_branch | master | jpbempel/collect-local-vars-uncaught-ex |
git_commit_date | 1725545464 | 1725548040 |
git_commit_sha | 123a2c8614 | 0d1e45ca47 |
release_version | 1.40.0-SNAPSHOT~123a2c8614 | 1.39.0-SNAPSHOT~0d1e45ca47 |
start_time | 2024-09-05T15:05:28 | 2024-09-05T15:12:17 |
Found 0 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.
scenario | Δ mean http_req_duration | Δ mean throughput | candidate mean http_req_duration | candidate mean throughput | baseline mean http_req_duration | baseline mean throughput |
---|---|---|---|---|---|---|
scenario:load:petclinic:profiling | worse [+31.164µs; +82.622µs] or [+2.086%; +5.532%] |
unstable [-560.727op/s; +560.727op/s] or [-18.224%; +18.224%] |
1.551ms | 3076.923op/s | 1.494ms | 3076.923op/s |
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | jpbempel/collect-local-vars-uncaught-ex |
git_commit_date | 1725545464 | 1725548040 |
git_commit_sha | 123a2c8614 | 0d1e45ca47 |
release_version | 1.40.0-SNAPSHOT~123a2c8614 | 1.39.0-SNAPSHOT~0d1e45ca47 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.
What Does This Do
Collecting local var was disabled for method probe/unhanded exception because all local vars are not accessible/defined. But for Exception Debugging/Replay this is very useful to have. The solution is to hoist local variable at the top level of the method and initialize them to be able to capture them at any point of the method. we are handling also the case of duplicate local var in different scope but with incompatible types
Motivation
Collecting local vars even if uncaught exception
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: DEBUG-2778