Closed manuel-alvarez-alvarez closed 2 months ago
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | malvarez/appsec-reactor-event-tracker |
git_commit_date | 1726490819 | 1726491035 |
git_commit_sha | bb8b0d25a6 | 8a7f01b435 |
release_version | 1.40.0-SNAPSHOT~bb8b0d25a6 | 1.40.0-SNAPSHOT~8a7f01b435 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
end_time | 2024-09-16T13:03:26 | 2024-09-16T13:10:15 |
git_branch | master | malvarez/appsec-reactor-event-tracker |
git_commit_date | 1726490819 | 1726491035 |
git_commit_sha | bb8b0d25a6 | 8a7f01b435 |
release_version | 1.40.0-SNAPSHOT~bb8b0d25a6 | 1.40.0-SNAPSHOT~8a7f01b435 |
start_time | 2024-09-16T13:03:13 | 2024-09-16T13:10:02 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | malvarez/appsec-reactor-event-tracker |
git_commit_date | 1726490819 | 1726491035 |
git_commit_sha | bb8b0d25a6 | 8a7f01b435 |
release_version | 1.40.0-SNAPSHOT~bb8b0d25a6 | 1.40.0-SNAPSHOT~8a7f01b435 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.
What Does This Do
Extracts
datadog.trace.api.EventTracker
logic and moves it into the appsec module, the actual implementation will be injected at runtime by thecom.datadog.appsec.AppSecSystem#start
method during initialization. Since these classes are added to the boostrap classloader by the tracer, customers will always be using the latest version provided by the tracer.Motivation
Moving the logic into the appsec module makes it easier to modify its behavior and make use of other appsec tools like the WAF which is needed for attacker fingerprinting.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]