Closed MattAlp closed 2 months ago
Without this flag specified, the profiling integration will fail silently
Is this even for long running processes? IIRC, the profiler should be started eventually, if the app has been running for a long time.
I don't believe so- the ProfilerInstaller explicitly says that the Profiler is to start first. As far as I know, the run never gets called again, so we never get to the code that sets a delayed startup
Oh, ok. Hm, should we have a warning if a user overrides the flag when running the native image as well?
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | mattalp/scp-479-fix |
git_commit_date | 1725372161 | 1725383113 |
git_commit_sha | 6e276bef3e | a293df12f3 |
release_version | 1.40.0-SNAPSHOT~6e276bef3e | 1.40.0-SNAPSHOT~a293df12f3 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
end_time | 2024-09-03T17:18:31 | 2024-09-03T17:25:20 |
git_branch | master | mattalp/scp-479-fix |
git_commit_date | 1725372161 | 1725383113 |
git_commit_sha | 6e276bef3e | a293df12f3 |
release_version | 1.40.0-SNAPSHOT~6e276bef3e | 1.40.0-SNAPSHOT~a293df12f3 |
start_time | 2024-09-03T17:18:18 | 2024-09-03T17:25:06 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | mattalp/scp-479-fix |
git_commit_date | 1725372161 | 1725383113 |
git_commit_sha | 6e276bef3e | a293df12f3 |
release_version | 1.40.0-SNAPSHOT~6e276bef3e | 1.40.0-SNAPSHOT~a293df12f3 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.
What Does This Do
This turns on the
dd.profiling.start_force_first
config setting silently when the profiler is baked into a Graal native image.Motivation
Without this flag specified, the profiling integration will fail silently. The flag itself is relevant to older, non-Graal JVMs (for historical reasons). Docs do not mention this requirement at the moment.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROF-10457]