Closed amarziali closed 2 months ago
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | andrea.marziali/vertx-sticky |
git_commit_date | 1725455874 | 1725459967 |
git_commit_sha | 86d01e6f14 | 43327605c7 |
release_version | 1.40.0-SNAPSHOT~86d01e6f14 | 1.40.0-SNAPSHOT~43327605c7 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
end_time | 2024-09-04T14:35:03 | 2024-09-04T14:41:54 |
git_branch | master | andrea.marziali/vertx-sticky |
git_commit_date | 1725455874 | 1725459967 |
git_commit_sha | 86d01e6f14 | 43327605c7 |
release_version | 1.40.0-SNAPSHOT~86d01e6f14 | 1.40.0-SNAPSHOT~43327605c7 |
start_time | 2024-09-04T14:34:49 | 2024-09-04T14:41:40 |
Found 0 performance improvements and 1 performance regressions! Performance is the same for 11 metrics, 16 unstable metrics.
scenario | Δ mean http_req_duration | Δ mean throughput | candidate mean http_req_duration | candidate mean throughput | baseline mean http_req_duration | baseline mean throughput |
---|---|---|---|---|---|---|
scenario:load:petclinic:profiling | worse [+39.888µs; +91.796µs] or [+2.667%; +6.137%] |
unstable [-687.055op/s; +459.135op/s] or [-22.329%; +14.922%] |
1.562ms | 2962.963op/s | 1.496ms | 3076.923op/s |
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | andrea.marziali/vertx-sticky |
git_commit_date | 1725455874 | 1725459967 |
git_commit_sha | 86d01e6f14 | 43327605c7 |
release_version | 1.40.0-SNAPSHOT~86d01e6f14 | 1.40.0-SNAPSHOT~43327605c7 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.
What Does This Do
When doing
blockingHandler
vertx create a inner route that we do not wrap. because of this the context is not propagated hence the span generated while executing this handler are attached to the wrong trace/parentThis PR makes sure that all the handlers can activate the right scope by using the one created for the route stored in the routing context
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]