Closed amarziali closed 2 months ago
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | andrea.marziali/pubsub-no-legacy |
git_commit_date | 1725455874 | 1725461168 |
git_commit_sha | 86d01e6f14 | 4cb14e94e8 |
release_version | 1.40.0-SNAPSHOT~86d01e6f14 | 1.40.0-SNAPSHOT~4cb14e94e8 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
end_time | 2024-09-04T14:56:21 | 2024-09-04T15:03:08 |
git_branch | master | andrea.marziali/pubsub-no-legacy |
git_commit_date | 1725455874 | 1725461168 |
git_commit_sha | 86d01e6f14 | 4cb14e94e8 |
release_version | 1.40.0-SNAPSHOT~86d01e6f14 | 1.40.0-SNAPSHOT~4cb14e94e8 |
start_time | 2024-09-04T14:56:08 | 2024-09-04T15:02:55 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 19 unstable metrics.
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | andrea.marziali/pubsub-no-legacy |
git_commit_date | 1725455874 | 1725461168 |
git_commit_sha | 86d01e6f14 | 4cb14e94e8 |
release_version | 1.40.0-SNAPSHOT~86d01e6f14 | 1.40.0-SNAPSHOT~4cb14e94e8 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.
What Does This Do
Google pubsub was lacking of the possibility to turn off the legacy tracing mode. When off, the consumer will use the value of
DD_SERVICE
instead thatgoogle-pubsub
as a service name.The feature can be activated by:
-Ddd.google-pubsub.legacy.tracing.enabled=false
DD_GOOGLE_PUBSUB_LEGACY_TRACING_ENABLED=false
Motivation
see #7209
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]