DataDog / dd-trace-java

Datadog APM client for Java
https://docs.datadoghq.com/tracing/languages/java
Apache License 2.0
588 stars 290 forks source link

Add git commit sha and repostiory url in snapshot #7566

Closed jpbempel closed 2 months ago

jpbempel commented 2 months ago

What Does This Do

add git commit and repository url in snapshot tags

Motivation

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-2491

pr-commenter[bot] commented 2 months ago

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1725536049 1725536443
end_time 2024-09-05T11:35:24 2024-09-05T11:41:56
git_branch master jpbempel/fix-git-info-snapshot
git_commit_sha 7497a93de3 b4c5b2f99792eb806450acbd9b1f7c3061980e58
start_time 2024-09-05T11:34:10 2024-09-05T11:40:44
See matching parameters | |Baseline |Candidate | |----------------------|----------------------------------------------|----------------------------------------------| |ci_job_id |628533953 |628533953 | |ci_pipeline_id |43604928 |43604928 | |cpu_model |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz| |git_commit_date|1725535450 |1725535450 |

Summary

Found 8 performance improvements and 0 performance regressions! Performance is the same for 0 metrics, 7 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:basic better
[-14.595µs; -4.941µs] or [-5.423%; -1.836%]
better
[-23.945µs; -5.434µs] or [-8.051%; -1.827%]
better
[-26.454µs; -3.695µs] or [-8.621%; -1.204%]
unstable
[-76.726µs; +11.833µs] or [-12.419%; +1.915%]
unstable
[-41.710op/s; +318.910op/s] or [-1.627%; +12.437%]
scenario:loop better
[-301.776µs; -290.681µs] or [-2.722%; -2.621%]
better
[-333.710µs; -269.503µs] or [-2.962%; -2.392%]
better
[-381.145µs; -282.575µs] or [-3.359%; -2.490%]
better
[-540.375µs; -121.602µs] or [-4.611%; -1.038%]
better
[+1.283op/s; +3.459op/s] or [+1.463%; +3.943%]
See unchanged results |scenario |Δ mean agg_http_req_duration_min |Δ mean agg_http_req_duration_p50 |Δ mean agg_http_req_duration_p75 |Δ mean agg_http_req_duration_p99 |Δ mean throughput | |----------------|----------------------------------------------------------------|-----------------------------------------------------------------|-----------------------------------------------------------------|------------------------------------------------------------------|--------------------------------------------------------------------| |scenario:noprobe|unstable
[-41.925µs; +22.563µs] or [-15.764%; +8.484%]|unstable
[-61.000µs; +32.650µs] or [-20.043%; +10.728%]|unstable
[-76.086µs; +44.582µs] or [-23.801%; +13.946%]|unstable
[-144.567µs; +83.331µs] or [-21.993%; +12.677%]|unstable
[-75.792op/s; +221.911op/s] or [-2.842%; +8.322%]|
Request duration reports for reports ```mermaid gantt title reports - request duration [CI 0.99] : candidate=None, baseline=None dateFormat X axisFormat %s section baseline noprobe (304.346 µs) : 254, 354 . : milestone, 304, basic (297.433 µs) : 289, 306 . : milestone, 297, loop (11.268 ms) : 11239, 11296 . : milestone, 11268, section candidate noprobe (290.172 µs) : 252, 329 . : milestone, 290, basic (282.744 µs) : 273, 292 . : milestone, 283, loop (10.966 ms) : 10935, 10997 . : milestone, 10966, ``` * **baseline** results |Scenario|Request median duration [CI 0.99]| |---|---| |noprobe|304.346 µs [254.307 µs, 354.386 µs]| |basic|297.433 µs [288.68 µs, 306.187 µs]| |loop|11.268 ms [11.239 ms, 11.296 ms]| * **candidate** results |Scenario|Request median duration [CI 0.99]| |---|---| |noprobe|290.172 µs [251.597 µs, 328.746 µs]| |basic|282.744 µs [273.371 µs, 292.118 µs]| |loop|10.966 ms [10.935 ms, 10.997 ms]|
pr-commenter[bot] commented 2 months ago

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-git-info-snapshot
git_commit_date 1725526572 1725535450
git_commit_sha 7497a93de3 b4c5b2f997
release_version 1.40.0-SNAPSHOT~7497a93de3 1.40.0-SNAPSHOT~b4c5b2f997
See matching parameters | |Baseline |Candidate | |---------------------|----------------------------------------------|----------------------------------------------| |application |insecure-bank |insecure-bank | |ci_job_date |1725537750 |1725537750 | |ci_job_id |628533947 |628533947 | |ci_pipeline_id|43604928 |43604928 | |cpu_model |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz| |module |Agent |Agent | |parent |None |None | |variant |iast |iast |

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 17 unstable metrics.

Startup time reports for insecure-bank ```mermaid gantt title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~b4c5b2f997, baseline=1.40.0-SNAPSHOT~7497a93de3 dateFormat X axisFormat %s section tracing Agent [baseline] (1.055 s) : 0, 1054959 Total [baseline] (8.479 s) : 0, 8479011 Agent [candidate] (1.048 s) : 0, 1047798 Total [candidate] (8.484 s) : 0, 8483746 section iast Agent [baseline] (1.176 s) : 0, 1175798 Total [baseline] (8.98 s) : 0, 8980210 Agent [candidate] (1.175 s) : 0, 1175095 Total [candidate] (8.986 s) : 0, 8986232 section iast_HARDCODED_SECRET_DISABLED Agent [baseline] (1.183 s) : 0, 1182580 Total [baseline] (8.995 s) : 0, 8994888 Agent [candidate] (1.177 s) : 0, 1176920 Total [candidate] (8.975 s) : 0, 8975167 section iast_TELEMETRY_OFF Agent [baseline] (1.171 s) : 0, 1170539 Total [baseline] (8.949 s) : 0, 8949209 Agent [candidate] (1.172 s) : 0, 1172423 Total [candidate] (8.971 s) : 0, 8970985 ``` * **baseline** results |Module|Variant|Duration|Δ tracing| |---|---|---|---| |Agent|tracing|1.055 s |-| |Agent|iast|1.176 s |120.84 ms (11.5%)| |Agent|iast_HARDCODED_SECRET_DISABLED|1.183 s |127.621 ms (12.1%)| |Agent|iast_TELEMETRY_OFF|1.171 s |115.581 ms (11.0%)| |Total|tracing|8.479 s |-| |Total|iast|8.98 s |501.199 ms (5.9%)| |Total|iast_HARDCODED_SECRET_DISABLED|8.995 s |515.877 ms (6.1%)| |Total|iast_TELEMETRY_OFF|8.949 s |470.198 ms (5.5%)| * **candidate** results |Module|Variant|Duration|Δ tracing| |---|---|---|---| |Agent|tracing|1.048 s |-| |Agent|iast|1.175 s |127.297 ms (12.1%)| |Agent|iast_HARDCODED_SECRET_DISABLED|1.177 s |129.122 ms (12.3%)| |Agent|iast_TELEMETRY_OFF|1.172 s |124.625 ms (11.9%)| |Total|tracing|8.484 s |-| |Total|iast|8.986 s |502.487 ms (5.9%)| |Total|iast_HARDCODED_SECRET_DISABLED|8.975 s |491.421 ms (5.8%)| |Total|iast_TELEMETRY_OFF|8.971 s |487.239 ms (5.7%)| ```mermaid gantt title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~b4c5b2f997, baseline=1.40.0-SNAPSHOT~7497a93de3 dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (673.622 ms) : 0, 673622 BytebuddyAgent [candidate] (668.285 ms) : 0, 668285 GlobalTracer [baseline] (307.94 ms) : 0, 307940 GlobalTracer [candidate] (306.366 ms) : 0, 306366 AppSec [baseline] (51.47 ms) : 0, 51470 AppSec [candidate] (51.401 ms) : 0, 51401 Remote Config [baseline] (677.399 µs) : 0, 677 Remote Config [candidate] (661.375 µs) : 0, 661 Telemetry [baseline] (7.604 ms) : 0, 7604 Telemetry [candidate] (7.537 ms) : 0, 7537 section iast BytebuddyAgent [baseline] (782.722 ms) : 0, 782722 BytebuddyAgent [candidate] (781.23 ms) : 0, 781230 GlobalTracer [baseline] (296.226 ms) : 0, 296226 GlobalTracer [candidate] (296.405 ms) : 0, 296405 AppSec [baseline] (52.793 ms) : 0, 52793 AppSec [candidate] (51.624 ms) : 0, 51624 IAST [baseline] (21.082 ms) : 0, 21082 IAST [candidate] (23.569 ms) : 0, 23569 Remote Config [baseline] (593.692 µs) : 0, 594 Remote Config [candidate] (587.932 µs) : 0, 588 Telemetry [baseline] (8.753 ms) : 0, 8753 Telemetry [candidate] (8.03 ms) : 0, 8030 section iast_HARDCODED_SECRET_DISABLED BytebuddyAgent [baseline] (786.585 ms) : 0, 786585 BytebuddyAgent [candidate] (781.987 ms) : 0, 781987 GlobalTracer [baseline] (297.897 ms) : 0, 297897 GlobalTracer [candidate] (298.494 ms) : 0, 298494 AppSec [baseline] (54.27 ms) : 0, 54270 AppSec [candidate] (52.638 ms) : 0, 52638 IAST [baseline] (21.273 ms) : 0, 21273 IAST [candidate] (22.058 ms) : 0, 22058 Remote Config [baseline] (593.254 µs) : 0, 593 Remote Config [candidate] (595.848 µs) : 0, 596 Telemetry [baseline] (8.241 ms) : 0, 8241 Telemetry [candidate] (7.482 ms) : 0, 7482 section iast_TELEMETRY_OFF BytebuddyAgent [baseline] (777.731 ms) : 0, 777731 BytebuddyAgent [candidate] (778.661 ms) : 0, 778661 GlobalTracer [baseline] (295.874 ms) : 0, 295874 GlobalTracer [candidate] (296.745 ms) : 0, 296745 AppSec [baseline] (52.813 ms) : 0, 52813 AppSec [candidate] (50.949 ms) : 0, 50949 IAST [baseline] (21.752 ms) : 0, 21752 IAST [candidate] (24.63 ms) : 0, 24630 Remote Config [baseline] (586.999 µs) : 0, 587 Remote Config [candidate] (593.273 µs) : 0, 593 Telemetry [baseline] (8.161 ms) : 0, 8161 Telemetry [candidate] (7.212 ms) : 0, 7212 ```
Startup time reports for petclinic ```mermaid gantt title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~b4c5b2f997, baseline=1.40.0-SNAPSHOT~7497a93de3 dateFormat X axisFormat %s section tracing Agent [baseline] (1.05 s) : 0, 1050078 Total [baseline] (10.321 s) : 0, 10321056 Agent [candidate] (1.057 s) : 0, 1056549 Total [candidate] (10.318 s) : 0, 10318325 section appsec Agent [baseline] (1.18 s) : 0, 1179942 Total [baseline] (10.551 s) : 0, 10551148 Agent [candidate] (1.189 s) : 0, 1188569 Total [candidate] (10.591 s) : 0, 10590696 section iast Agent [baseline] (1.175 s) : 0, 1175159 Total [baseline] (10.811 s) : 0, 10810665 Agent [candidate] (1.19 s) : 0, 1189860 Total [candidate] (10.836 s) : 0, 10835758 section profiling Agent [baseline] (1.255 s) : 0, 1254674 Total [baseline] (10.579 s) : 0, 10579297 Agent [candidate] (1.246 s) : 0, 1246259 Total [candidate] (10.546 s) : 0, 10546037 ``` * **baseline** results |Module|Variant|Duration|Δ tracing| |---|---|---|---| |Agent|tracing|1.05 s |-| |Agent|appsec|1.18 s |129.865 ms (12.4%)| |Agent|iast|1.175 s |125.082 ms (11.9%)| |Agent|profiling|1.255 s |204.596 ms (19.5%)| |Total|tracing|10.321 s |-| |Total|appsec|10.551 s |230.092 ms (2.2%)| |Total|iast|10.811 s |489.609 ms (4.7%)| |Total|profiling|10.579 s |258.241 ms (2.5%)| * **candidate** results |Module|Variant|Duration|Δ tracing| |---|---|---|---| |Agent|tracing|1.057 s |-| |Agent|appsec|1.189 s |132.02 ms (12.5%)| |Agent|iast|1.19 s |133.311 ms (12.6%)| |Agent|profiling|1.246 s |189.71 ms (18.0%)| |Total|tracing|10.318 s |-| |Total|appsec|10.591 s |272.371 ms (2.6%)| |Total|iast|10.836 s |517.434 ms (5.0%)| |Total|profiling|10.546 s |227.713 ms (2.2%)| ```mermaid gantt title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~b4c5b2f997, baseline=1.40.0-SNAPSHOT~7497a93de3 dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (669.738 ms) : 0, 669738 BytebuddyAgent [candidate] (674.197 ms) : 0, 674197 GlobalTracer [baseline] (307.47 ms) : 0, 307470 GlobalTracer [candidate] (308.445 ms) : 0, 308445 AppSec [baseline] (51.24 ms) : 0, 51240 AppSec [candidate] (51.992 ms) : 0, 51992 Remote Config [baseline] (657.382 µs) : 0, 657 Remote Config [candidate] (671.587 µs) : 0, 672 Telemetry [baseline] (7.387 ms) : 0, 7387 Telemetry [candidate] (7.543 ms) : 0, 7543 section appsec BytebuddyAgent [baseline] (687.889 ms) : 0, 687889 BytebuddyAgent [candidate] (693.198 ms) : 0, 693198 GlobalTracer [baseline] (299.455 ms) : 0, 299455 GlobalTracer [candidate] (302.34 ms) : 0, 302340 AppSec [baseline] (158.396 ms) : 0, 158396 AppSec [candidate] (159.589 ms) : 0, 159589 IAST [baseline] (20.49 ms) : 0, 20490 IAST [candidate] (20.492 ms) : 0, 20492 Remote Config [baseline] (621.417 µs) : 0, 621 Remote Config [candidate] (621.343 µs) : 0, 621 Telemetry [baseline] (9.802 ms) : 0, 9802 Telemetry [candidate] (8.913 ms) : 0, 8913 section iast BytebuddyAgent [baseline] (781.404 ms) : 0, 781404 BytebuddyAgent [candidate] (791.885 ms) : 0, 791885 GlobalTracer [baseline] (296.336 ms) : 0, 296336 GlobalTracer [candidate] (299.633 ms) : 0, 299633 AppSec [baseline] (53.119 ms) : 0, 53119 AppSec [candidate] (52.172 ms) : 0, 52172 IAST [baseline] (22.808 ms) : 0, 22808 IAST [candidate] (22.905 ms) : 0, 22905 Remote Config [baseline] (591.404 µs) : 0, 591 Remote Config [candidate] (606.573 µs) : 0, 607 Telemetry [baseline] (7.288 ms) : 0, 7288 Telemetry [candidate] (8.85 ms) : 0, 8850 section profiling BytebuddyAgent [baseline] (668.917 ms) : 0, 668917 BytebuddyAgent [candidate] (663.874 ms) : 0, 663874 GlobalTracer [baseline] (390.483 ms) : 0, 390483 GlobalTracer [candidate] (388.306 ms) : 0, 388306 AppSec [baseline] (52.451 ms) : 0, 52451 AppSec [candidate] (52.092 ms) : 0, 52092 Remote Config [baseline] (695.921 µs) : 0, 696 Remote Config [candidate] (679.312 µs) : 0, 679 Telemetry [baseline] (7.469 ms) : 0, 7469 Telemetry [candidate] (7.376 ms) : 0, 7376 ProfilingAgent [baseline] (96.572 ms) : 0, 96572 ProfilingAgent [candidate] (96.045 ms) : 0, 96045 Profiling [baseline] (96.596 ms) : 0, 96596 Profiling [candidate] (96.069 ms) : 0, 96069 ```

Load

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-git-info-snapshot
git_commit_date 1725526572 1725535450
git_commit_sha 7497a93de3 b4c5b2f997
release_version 1.40.0-SNAPSHOT~7497a93de3 1.40.0-SNAPSHOT~b4c5b2f997
See matching parameters | |Baseline |Candidate | |---------------------|----------------------------------------------|----------------------------------------------| |application |biojava |biojava | |ci_job_date |1725537377 |1725537377 | |ci_job_id |628533949 |628533949 | |ci_pipeline_id|43604928 |43604928 | |cpu_model |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz| |variant |appsec |appsec |

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava ```mermaid gantt title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~b4c5b2f997, baseline=1.40.0-SNAPSHOT~7497a93de3 dateFormat X axisFormat %s section baseline no_agent (14.87 s) : 14870000, 14870000 . : milestone, 14870000, appsec (15.214 s) : 15214000, 15214000 . : milestone, 15214000, iast (18.973 s) : 18973000, 18973000 . : milestone, 18973000, iast_GLOBAL (17.975 s) : 17975000, 17975000 . : milestone, 17975000, profiling (15.335 s) : 15335000, 15335000 . : milestone, 15335000, tracing (15.452 s) : 15452000, 15452000 . : milestone, 15452000, section candidate no_agent (15.457 s) : 15457000, 15457000 . : milestone, 15457000, appsec (15.501 s) : 15501000, 15501000 . : milestone, 15501000, iast (18.706 s) : 18706000, 18706000 . : milestone, 18706000, iast_GLOBAL (17.948 s) : 17948000, 17948000 . : milestone, 17948000, profiling (15.077 s) : 15077000, 15077000 . : milestone, 15077000, tracing (15.027 s) : 15027000, 15027000 . : milestone, 15027000, ``` * **baseline** results |Variant|Execution Time [CI 0.99]|Δ no_agent| |---|---|---| |no_agent|14.87 s [14.87 s, 14.87 s]|-| |appsec|15.214 s [15.214 s, 15.214 s]|344.0 ms (2.3%)| |iast|18.973 s [18.973 s, 18.973 s]|4.103 s (27.6%)| |iast_GLOBAL|17.975 s [17.975 s, 17.975 s]|3.105 s (20.9%)| |profiling|15.335 s [15.335 s, 15.335 s]|465.0 ms (3.1%)| |tracing|15.452 s [15.452 s, 15.452 s]|582.0 ms (3.9%)| * **candidate** results |Variant|Execution Time [CI 0.99]|Δ no_agent| |---|---|---| |no_agent|15.457 s [15.457 s, 15.457 s]|-| |appsec|15.501 s [15.501 s, 15.501 s]|44.0 ms (0.3%)| |iast|18.706 s [18.706 s, 18.706 s]|3.249 s (21.0%)| |iast_GLOBAL|17.948 s [17.948 s, 17.948 s]|2.491 s (16.1%)| |profiling|15.077 s [15.077 s, 15.077 s]|-380.0 ms (-2.5%)| |tracing|15.027 s [15.027 s, 15.027 s]|-430.0 ms (-2.8%)|
Execution time for tomcat ```mermaid gantt title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~b4c5b2f997, baseline=1.40.0-SNAPSHOT~7497a93de3 dateFormat X axisFormat %s section baseline no_agent (1.466 ms) : 1455, 1478 . : milestone, 1466, appsec (2.25 ms) : 2214, 2286 . : milestone, 2250, iast (2.007 ms) : 1962, 2052 . : milestone, 2007, iast_GLOBAL (2.037 ms) : 1992, 2082 . : milestone, 2037, profiling (2.307 ms) : 2133, 2482 . : milestone, 2307, tracing (1.846 ms) : 1813, 1879 . : milestone, 1846, section candidate no_agent (1.456 ms) : 1445, 1467 . : milestone, 1456, appsec (2.229 ms) : 2194, 2264 . : milestone, 2229, iast (1.996 ms) : 1952, 2040 . : milestone, 1996, iast_GLOBAL (2.031 ms) : 1987, 2075 . : milestone, 2031, profiling (1.873 ms) : 1839, 1907 . : milestone, 1873, tracing (1.854 ms) : 1820, 1887 . : milestone, 1854, ``` * **baseline** results |Variant|Execution Time [CI 0.99]|Δ no_agent| |---|---|---| |no_agent|1.466 ms [1.455 ms, 1.478 ms]|-| |appsec|2.25 ms [2.214 ms, 2.286 ms]|783.781 µs (53.4%)| |iast|2.007 ms [1.962 ms, 2.052 ms]|540.219 µs (36.8%)| |iast_GLOBAL|2.037 ms [1.992 ms, 2.082 ms]|570.555 µs (38.9%)| |profiling|2.307 ms [2.133 ms, 2.482 ms]|840.983 µs (57.3%)| |tracing|1.846 ms [1.813 ms, 1.879 ms]|379.535 µs (25.9%)| * **candidate** results |Variant|Execution Time [CI 0.99]|Δ no_agent| |---|---|---| |no_agent|1.456 ms [1.445 ms, 1.467 ms]|-| |appsec|2.229 ms [2.194 ms, 2.264 ms]|773.025 µs (53.1%)| |iast|1.996 ms [1.952 ms, 2.04 ms]|539.815 µs (37.1%)| |iast_GLOBAL|2.031 ms [1.987 ms, 2.075 ms]|575.127 µs (39.5%)| |profiling|1.873 ms [1.839 ms, 1.907 ms]|416.716 µs (28.6%)| |tracing|1.854 ms [1.82 ms, 1.887 ms]|397.538 µs (27.3%)|