Closed amarziali closed 3 weeks ago
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | andrea.marziali/redisson |
git_commit_date | 1725556786 | 1725608709 |
git_commit_sha | 0a583fed33 | ee3c323b60 |
release_version | 1.40.0-SNAPSHOT~0a583fed33 | 1.40.0-SNAPSHOT~ee3c323b60 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
end_time | 2024-09-06T07:57:26 | 2024-09-06T08:04:13 |
git_branch | master | andrea.marziali/redisson |
git_commit_date | 1725556786 | 1725608709 |
git_commit_sha | 0a583fed33 | ee3c323b60 |
release_version | 1.40.0-SNAPSHOT~0a583fed33 | 1.40.0-SNAPSHOT~ee3c323b60 |
start_time | 2024-09-06T07:57:13 | 2024-09-06T08:04:00 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | andrea.marziali/redisson |
git_commit_date | 1725556786 | 1725608709 |
git_commit_sha | 0a583fed33 | ee3c323b60 |
release_version | 1.40.0-SNAPSHOT~0a583fed33 | 1.40.0-SNAPSHOT~ee3c323b60 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.
What Does This Do
When tracing redisson redis request, we're only tracing the synchronous part (see #7510 )
Now we're instead capturing a continuation and finish when the command actually finishes. The tricky part here is to follow the changes on interfaces and method signature of the redisson codebase. In details:
RPromise
with netty future listenersRFuture
with future listenersCompletionStage
but needs a method handle trick to get the promise since theRPromise
class has been removed somewhere on the 3.x and would have muzzle blocking the instrumentation on recent versions.Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]