Closed jpbempel closed 2 months ago
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
ci_job_date | 1726494356 | 1726494732 |
end_time | 2024-09-16T13:47:12 | 2024-09-16T13:53:26 |
git_branch | master | jpbempel/fix-overlapping-slot |
git_commit_sha | bb8b0d25a6 | 7b3812fb0ce667c1729aa1235e25c278c275b869 |
start_time | 2024-09-16T13:45:57 | 2024-09-16T13:52:13 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 7 unstable metrics.
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | jpbempel/fix-overlapping-slot |
git_commit_date | 1726564137 | 1726569568 |
git_commit_sha | 1429d59b51 | 5fc276336e |
release_version | 1.40.0-SNAPSHOT~1429d59b51 | 1.40.0-SNAPSHOT~5fc276336e |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
end_time | 2024-09-17T10:50:45 | 2024-09-17T10:57:33 |
git_branch | master | jpbempel/fix-overlapping-slot |
git_commit_date | 1726564137 | 1726569568 |
git_commit_sha | 1429d59b51 | 5fc276336e |
release_version | 1.40.0-SNAPSHOT~1429d59b51 | 1.40.0-SNAPSHOT~5fc276336e |
start_time | 2024-09-17T10:50:31 | 2024-09-17T10:57:20 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | jpbempel/fix-overlapping-slot |
git_commit_date | 1726564137 | 1726569568 |
git_commit_sha | 1429d59b51 | 5fc276336e |
release_version | 1.40.0-SNAPSHOT~1429d59b51 | 1.40.0-SNAPSHOT~5fc276336e |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.
What Does This Do
Rewrite the algorithm for hoisting local vars: Go through all local vars defined in the method and determine by name all local var that are hoistable. local vars are hoistable if there is no conflict by slot or by name with another. If conflict by slot and same name we cancel hoisting for this name. if name is different we allocating a new slot for one of the local. If conflict by name and type are not compatible we cancel hoisting for this name. If type compatible, we can add in hoistable list. Then we are considering all hoistable variables by name and if there are multiple occurrence for a name, we are merging those variables in a new slot and rewrite var instructions to use this new slot. if only one variable we just assign a new slot and rewrite the instructions in the range.
Motivation
Fixing issues since #7548
Additional Notes
Tested against exploration tests
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: DEBUG-2841