Closed smola closed 1 week ago
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | smola/enable-telemetry-logs-globally |
git_commit_date | 1726577115 | 1726586026 |
git_commit_sha | 2d2c02962a | b645139a6d |
release_version | 1.40.0-SNAPSHOT~2d2c02962a | 1.40.0-SNAPSHOT~b645139a6d |
Found 1 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 15 unstable metrics.
scenario | Δ mean execution_time | candidate mean execution_time | baseline mean execution_time |
---|---|---|---|
scenario:startup:insecure-bank:iast:Telemetry | better [-540.012µs; -285.570µs] or [-7.237%; -3.827%] |
7.049ms | 7.461ms |
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
end_time | 2024-09-17T15:24:55 | 2024-09-17T15:31:39 |
git_branch | master | smola/enable-telemetry-logs-globally |
git_commit_date | 1726577115 | 1726586026 |
git_commit_sha | 2d2c02962a | b645139a6d |
release_version | 1.40.0-SNAPSHOT~2d2c02962a | 1.40.0-SNAPSHOT~b645139a6d |
start_time | 2024-09-17T15:24:42 | 2024-09-17T15:31:26 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 19 unstable metrics.
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | smola/enable-telemetry-logs-globally |
git_commit_date | 1726577115 | 1726586026 |
git_commit_sha | 2d2c02962a | b645139a6d |
release_version | 1.40.0-SNAPSHOT~2d2c02962a | 1.40.0-SNAPSHOT~b645139a6d |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.
What Does This Do
Enable telemetry logs by default. These were already enabled by default for services using JDK 8, Code Security (IAST), Dynamic Instrumentation, or CI Visibility. They will be enabled for all services from now on.
Users who want to opt out can set
-Ddd.telemetry.log-collection.enabled=false
(system property) orDD_TELEMETRY_LOG_COLLECTION_ENABLED=false
(environment variable).Note that these are not application logs, but internal dd-trace-java logs which we use for troubleshooting. They are heavily redacted by sending only the log formats and not log parameters (e.g. when we do
log.error("An error happened at url: {}", url)
), we will send just"An error happened at url: {}"
, without any placeholder substitution. We also send error stacktraces, including exception type (but not exception message), and any stackframes from dd-trace-java itself or the standard library.Motivation
We use these logs to proactively detect and fix dd-trace-java bugs.
Additional Notes
Previous activation milestones:
Jira: APPSEC-53432
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issue