Closed manuel-alvarez-alvarez closed 1 month ago
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | malvarez/fix-too-many-invocations-stack-overflow |
git_commit_date | 1727466491 | 1727620127 |
git_commit_sha | 201bcbe8ed | 376d6618b0 |
release_version | 1.40.0-SNAPSHOT~201bcbe8ed | 1.40.0-SNAPSHOT~376d6618b0 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
end_time | 2024-09-29T14:39:42 | 2024-09-29T14:46:32 |
git_branch | master | malvarez/fix-too-many-invocations-stack-overflow |
git_commit_date | 1727466491 | 1727620127 |
git_commit_sha | 201bcbe8ed | 376d6618b0 |
release_version | 1.40.0-SNAPSHOT~201bcbe8ed | 1.40.0-SNAPSHOT~376d6618b0 |
start_time | 2024-09-29T14:39:29 | 2024-09-29T14:46:19 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | malvarez/fix-too-many-invocations-stack-overflow |
git_commit_date | 1727466491 | 1727620127 |
git_commit_sha | 201bcbe8ed | 376d6618b0 |
release_version | 1.40.0-SNAPSHOT~201bcbe8ed | 1.40.0-SNAPSHOT~376d6618b0 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.
What Does This Do
Fixes tests failures when a
org.spockframework.mock.TooManyInvocationsError
triggers ajava.lang.StackOverflowError
while composing the failure message.Motivation
When a mocked class captures the assertion error (e.g. TooManyInvocationsError), spock will throw an StackOverflowError while building the accepted invocations failure message, it causes the test to be ignored and won't be reported as a failure. As an example:
Before (warning message and test ignored):
After (test reported as a failure):
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APPSEC-54984