Closed jpbempel closed 4 days ago
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
ci_job_date | 1727195989 | 1727196377 |
end_time | 2024-09-24T16:41:04 | 2024-09-24T16:47:32 |
git_branch | master | jpbempel/fix-widening |
git_commit_sha | 043adb202c | 30a4b6c206c6ab9c74139d73f65de9034b81aff7 |
start_time | 2024-09-24T16:39:50 | 2024-09-24T16:46:18 |
Found 5 performance improvements and 0 performance regressions! Performance is the same for 4 metrics, 6 unstable metrics.
scenario | Δ mean agg_http_req_duration_min | Δ mean agg_http_req_duration_p50 | Δ mean agg_http_req_duration_p75 | Δ mean agg_http_req_duration_p99 | Δ mean throughput |
---|---|---|---|---|---|
scenario:loop | better [-631.181µs; -618.451µs] or [-5.851%; -5.733%] |
better [-670.994µs; -605.462µs] or [-6.120%; -5.522%] |
better [-688.529µs; -577.620µs] or [-6.229%; -5.226%] |
better [-955.778µs; -420.709µs] or [-8.309%; -3.657%] |
better [+4.618op/s; +6.589op/s] or [+5.126%; +7.314%] |
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | jpbempel/fix-widening |
git_commit_date | 1727189655 | 1727195380 |
git_commit_sha | 043adb202c | 30a4b6c206 |
release_version | 1.40.0-SNAPSHOT~043adb202c | 1.40.0-SNAPSHOT~30a4b6c206 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics.
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
end_time | 2024-09-24T16:38:59 | 2024-09-24T16:45:52 |
git_branch | master | jpbempel/fix-widening |
git_commit_date | 1727189655 | 1727195380 |
git_commit_sha | 043adb202c | 30a4b6c206 |
release_version | 1.40.0-SNAPSHOT~043adb202c | 1.40.0-SNAPSHOT~30a4b6c206 |
start_time | 2024-09-24T16:38:46 | 2024-09-24T16:45:38 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | jpbempel/fix-widening |
git_commit_date | 1727189655 | 1727195380 |
git_commit_sha | 043adb202c | 30a4b6c206 |
release_version | 1.40.0-SNAPSHOT~043adb202c | 1.40.0-SNAPSHOT~30a4b6c206 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.
What Does This Do
We are automatically widening numbers from Integer to Long and Float to Double to be able to compare them. But used as key for maps it does not work because the type needs to be exact. For fixing this we are moving to widening then numbers only at comparison time. Otherwise we keep the original typing.
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: DEBUG-2603