Closed ValentinZakharov closed 3 hours ago
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | vzakharov/unclassified_waf_exception |
git_commit_date | 1727627513 | 1727648853 |
git_commit_sha | 59ce38a456 | cc6603d80f |
release_version | 1.40.0-SNAPSHOT~59ce38a456 | 1.40.0-SNAPSHOT~cc6603d80f |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
end_time | 2024-09-29T22:38:46 | 2024-09-29T22:45:37 |
git_branch | master | vzakharov/unclassified_waf_exception |
git_commit_date | 1727627513 | 1727648853 |
git_commit_sha | 59ce38a456 | cc6603d80f |
release_version | 1.40.0-SNAPSHOT~59ce38a456 | 1.40.0-SNAPSHOT~cc6603d80f |
start_time | 2024-09-29T22:38:33 | 2024-09-29T22:45:23 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | vzakharov/unclassified_waf_exception |
git_commit_date | 1727627513 | 1727648853 |
git_commit_sha | 59ce38a456 | cc6603d80f |
release_version | 1.40.0-SNAPSHOT~59ce38a456 | 1.40.0-SNAPSHOT~cc6603d80f |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.
What Does This Do
Added extra checks to prevent occurring exceptions, in case the WAF context was closed earlier during the race condition.
Motivation
Reported exception from customers' service
Additional Notes
Occasional exceptions were observed when the root span and SQL query span executed concurrently. This created a risk of a race condition, where the WAF context could be prematurely closed and finalized before all parallel spans completed. Upon further investigation, the following issues were identified:
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]