Closed nikita-tkachenko-datadog closed 1 month ago
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | nikita-tkachenko/module-name-fix |
git_commit_date | 1729088733 | 1729099885 |
git_commit_sha | 3f89f0321b | 185d67e2c7 |
release_version | 1.41.0-SNAPSHOT~3f89f0321b | 1.41.0-SNAPSHOT~185d67e2c7 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics.
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
end_time | 2024-10-16T17:43:46 | 2024-10-16T17:50:38 |
git_branch | master | nikita-tkachenko/module-name-fix |
git_commit_date | 1729088733 | 1729099885 |
git_commit_sha | 3f89f0321b | 185d67e2c7 |
release_version | 1.41.0-SNAPSHOT~3f89f0321b | 1.41.0-SNAPSHOT~185d67e2c7 |
start_time | 2024-10-16T17:43:33 | 2024-10-16T17:50:25 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | nikita-tkachenko/module-name-fix |
git_commit_date | 1729088733 | 1729099885 |
git_commit_sha | 3f89f0321b | 185d67e2c7 |
release_version | 1.41.0-SNAPSHOT~3f89f0321b | 1.41.0-SNAPSHOT~185d67e2c7 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.
What Does This Do
Fixes module name detection for headless test sessions (i.e. sessions for JVMs that are not part of an instrumented Maven/Gradle build).
When a JVM is a part of an instrumented Maven/Gradle build, the parent process provides module names to the children processes via system properties. For headless sessions the module name is not provided, so there is a fallback that tries to derive module name from current path and repository root (e.g. if repo root is
/my/repo/root
and current path is/my/repo/root/submodule
, then the module name is set tosubmodule
). This fallback logic works incorrectly when repo root is/my/repo/root
and the current path is/my/repo/root/
: in this case module name is empty, which is not allowed.The fix detects these cases, and uses service name as the last fallback if module name cannot be derived from current path.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: SDTEST-1110